WordPress.org

Make WordPress Themes

Opened 16 months ago

Closed 9 months ago

#34029 closed theme (not-approved)

THEME: Keseria – 2.21

Reported by: vivacityinfotech.jaipur Owned by: WPDevHQ
Priority: previously reviewed Keywords: theme-keseria
Cc: vivacityinfotech.jaipur@…

Description

Keseria - 2.20

Keseria is fully Responsive WordPress Theme for all type of business, It is easily customizable with customizer option.It is simply understandable for non coder users.

Theme URL -
Author URL - http://vivacityinfotech.net/

SVN - https://themes.svn.wordpress.org/keseria/2.20
ZIP - https://wordpress.org/themes/download/keseria.2.20.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=keseria/2.19&new_path=keseria/2.20

History:

Ticket Summary Status Resolution Owner
#22636 THEME: Keseria - 1.5 closed not-approved BriniA
#23113 THEME: Keseria - 1.6 closed not-approved optimistic_shekhar
#23708 THEME: Keseria – 1.8 closed not-approved narendrants
#25039 THEME: Keseria – 1.9 closed not-approved markmill2015
#26389 THEME: Keseria – 2.0 closed not-approved Anouska
#28276 THEME: Keseria – 2.19 closed not-approved benlumia007
#34029 THEME: Keseria – 2.21 closed not-approved WPDevHQ

(this ticket)


https://themes.svn.wordpress.org/keseria/2.20/screenshot.png

Attachments (1)

keseria-2.21.zip (2.1 MB) - added by vivacityinfotech.jaipur 10 months ago.

Change History (20)

#1 @lyrathemes
11 months ago

  • Owner set to lyrathemes
  • Status changed from new to reviewing

#2 @djrmom
11 months ago

Hi @lyrathemes, are you still working on this review?

#3 @lyrathemes
11 months ago

Yes @djrmom - I will have an update on this by tomorrow. Sorry for the delay.

#4 @grapplerulrich
11 months ago

@lyrathemes Ping...

#5 @lyrathemes
10 months ago

I am sorry for the delay on this. Here is a review. There are quite a few issues. I am guessing this theme will have to be closed at this time but let me get approval from an admin. In the meanwhile...

  • Escape home_url() in footer.php, header.php
  • What is $custom_header_support in functions.php?
  • Please combine these styles into one file: keresia-style, keresia-styles, keresia-style2
  • I don't think you need this anymore - you have add_theme_support('title-tag');:

add_filter( 'wp_title', 'keseria_wp_title', 10, 2 );

  • I am afraid you will have to redo the slider options in the customize section - content building or pseudo content types through the Customize area are not allowed. You can use existing posts/pages or other content as a basis for your slider.
  • Same for the Services, Call To Social, Call to Action, Clients Logo sections.
  • Try not to use inline styling. index.php:

<h3 style="float:left"><a href="<?php the_permalink();?>"><?php the_title(); ?></a></h3>

template-front.php:

<h2> <span class="wow bounceInLeft animated" data-wow-duration="1.5s" style="font-size:40px;">

  • You should be using esc_url here instead of esc_attr:

<form id="searchform" method="get" action="<?php echo esc_attr( home_url( '/' ) ); ?>">

  • "send" needs to be translatable:

<input type="text" class="send" name="searchsubmit" alt="send" /></div>

  • Even though you cannot use the slider in its current state, these three lines assume that the user has filled out all the three sliders in the Customize section:
<li data-target="#carousel-example-generic" data-slide-to="0" class="active"></li>
    <li data-target="#carousel-example-generic" data-slide-to="1"></li>
    <li data-target="#carousel-example-generic" data-slide-to="2"></li>
  • "READ MORE" should be translatable (template-front.php):

<a class="button" href= "<?php echo the_permalink();?>">READ MORE</a>

  • Please remove this or rewrite it to be translatable - template-front.php:
<h2> <span class="" id="projects">Latest Posts</span></h2>      
      <p class="project_content" >Lorem Ipsum is simply dummy text of the printing and typesetting industry.</p>
  • You have two full width templates (template-no-sidebar.php, template-fullwidth.php) in the theme. Please remove one.
  • Also, please update the style.css tags:
WARNING: The tag white has been deprecated, please remove it from your style.css header.
WARNING: The tag responsive-layout has been deprecated, please remove it from your style.css header.
WARNING: The tag light has been deprecated, please remove it from your style.css header.
WARNING: The tag fixed-layout has been deprecated, please remove it from your style.css header.
WARNING: The tag blue has been deprecated, please remove it from your style.css header.
WARNING: The tag black has been deprecated, please remove it from your style.css header.

This ticket was mentioned in Slack in #themereview by mutantspinach. View the logs.


10 months ago

#7 @grapplerulrich
10 months ago

I don't think you need this anymore - you have add_theme_support('title-tag');

This is fine and the right way to do it.

wp_enqueue_style( 'blue' The handle needs to be prefixed.

#8 @lyrathemes
10 months ago

@grapplerulrich I meant he doesn't need this anymore

add_filter( 'wp_title', 'keseria_wp_title', 10, 2 );

because he has add_theme_support('title-tag');. Sorry for the confusing wording.

#9 @vivacityinfotech.jaipur
10 months ago

Hello @lyrathemes
Greetings!

Thanks a lot for sharing so detailed review. I will review those again and will submit back soon.

Regards
Team Vivacity

#10 @grapplerulrich
10 months ago

@vivacityinfotech.jaipur Please upload the update via the upload page.https://wordpress.org/themes/upload

#11 @themetracbot
10 months ago

  • Summary changed from THEME: Keseria – 2.20 to THEME: Keseria – 2.21

Keseria - 2.21

Keseria is fully Responsive WordPress Theme for all type of business, It is easily customizable with customizer option.It is simply understandable for non coder users.

Theme URL -
Author URL - http://vivacityinfotech.net/

SVN - https://themes.svn.wordpress.org/keseria/2.21
ZIP - https://wordpress.org/themes/download/keseria.2.21.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=keseria/2.20&new_path=keseria/2.21

History:

Ticket Summary Status Resolution Owner
#22636 THEME: Keseria - 1.5 closed not-approved BriniA
#23113 THEME: Keseria - 1.6 closed not-approved optimistic_shekhar
#23708 THEME: Keseria – 1.8 closed not-approved narendrants
#25039 THEME: Keseria – 1.9 closed not-approved markmill2015
#26389 THEME: Keseria – 2.0 closed not-approved Anouska
#28276 THEME: Keseria – 2.19 closed not-approved benlumia007
#34029 THEME: Keseria – 2.21 closed not-approved WPDevHQ

(this ticket)


https://themes.svn.wordpress.org/keseria/2.21/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( "post-thumbnails" )in the functions.php file.
  • RECOMMENDED: Theme URI: is missing from your style.css header.

#12 @grapplerulrich
9 months ago

  • Owner lyrathemes deleted

I am sorry this review is taking so long. Sometimes people are unable to carry on the review, this may have happened this time. As a result, I am going to add this to the new queue again as a priority. This may mean it still takes time, but will prevent this ticket being held for so long by a reviewer that isn't able to carry on. Thanks for your patience.

If you are the reviewer and able to do this review, please carry on and request you get added back in Slack #themereview or you can take on another review when you have time again.

#13 @themetracbot
9 months ago

  • Owner set to masroor101

#14 @jcastaneda
9 months ago

  • Owner masroor101 deleted

I am sorry this review is taking so long. Sometimes people are unable to carry on the review, this may have happened this time. As a result, I am going to add this to the new queue again as a priority. This may mean it still takes time, but will prevent this ticket being held for so long by a reviewer that isn't able to carry on. Thanks for your patience.

If you are the reviewer and able to do this review, please carry on and request you get added back in Slack #themereview or you can take on another review when you have time again.

#15 @WPDevHQ
9 months ago

@jcastaneda - I'll take this review :)

This ticket was mentioned in Slack in #themereview by wpdevhq. View the logs.


9 months ago

#17 @jcastaneda
9 months ago

  • Owner set to WPDevHQ

#18 @WPDevHQ
9 months ago

General Check.

REQUIRED:
Declare license and copyright for all resources used in the theme including those created by you specifically for the theme.

What are the license terms of the products you sell on your site?

Code Check.

Please try and be consistent with your code indentation - for this and more see: WordPress Theme Developer Handbook and follow the guidelines provided!

REQUIRED:

  • header.php - Remove unused code @line 24
  • header.php - Use esc_url( home_url( '/' ) ); instead of esc_attr(home_url());. Same for lines 15 and 19 in footer.php
  • template-aboutus.php is same as template-fullwidth.php and is of no use - please remove it.
  • template-front.php - As this is meant to be used as the site's Front Page then it should follow the prescribed front-page methodology otherwise is of no use.
  • template-front.php - In addition to the above, why do you have almost all of the output for this templated hardcoded? What use is that to the end user if they can not easily change the data?
  • extras.php - Change function new_keseria_stylesheet to function keseria_new_stylesheet
  • extras.php - Use the elseif statement for subsequent checks on theme_mod values.
  • page.php - There's no need for posts_nav_link();
  • functions.php - Remove this add_filter( 'wp_title', 'keseria_wp_title', 10, 2 ); and move the following inside the function keseia_theme_setup(). Please note the mispelling of the prefix!
    add_theme_support( 'title-tag' );
    add_theme_support( 'automatic-feed-links' );
    
  • functions.php - Remove the entire function keseria_wp_title( $title, $sep ) as add_theme_support( 'title-tag' ); will do the same job automatically.
  • functions.php - What is the need for function keseria_get_list_posts()?
  • functions.php - Customizer options and output for the slider: Please aim for reusable user generated content i.e. posts, pages or categories for sliders. With the current method user will loose content upon theme change!
  • functions.php - For Text and image Logo use core functionality i.e. Site title and a logo uploaded via add_theme_support( 'custom-logo', array() );
  • functions.php - You seem to be using a lot of content creation options in the Customizer - we ask that you keep these to a minimum and absolute necessary only. Always remember, all this data will be lost by the user when they switch theme and it is therefore discouraged!
  • functions.php - Remove all real filler prompts like https://www.youtube.com/playlist?list=PLE134D877783367C7 from input fields.
  • functions.php - Use correct sanitization for the appropriate input fields i.e wp_filter_post_kses is not the correct sanitizer for a link input!

RECOMMENDED:

  • functions.php - And finanally, please consider moving the Customizer options into a separate file i.e. customizer.php and reference it correctly. You should also consider breaking other files into appropriate chunks of functionality and reference them correctly.

NOTE: Most of these issues were raised in the previous review which you have failed to rectify before resubmitting the theme. Please take time to go through the link I referenced above and make sure you understand them and that your theme meets all the regulations and requirements!

I'll keep the ticket open for the time being for you to fix these issues and submit a revised version for further consideration. If there is no response within 7 days from the date of this review I'll have no alternative but to close the ticket.
Also note: If the theme is resubmitted without the required fixes, the ticket will be closed with a note to the effect! It is your reposnibility to make sure your theme meets all requirements before uploading it for review.

If you have any questions on this review please feel free to ask.

#19 @WPDevHQ
9 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Closing due to lack of response from author!

Note: See TracTickets for help on using tickets.