WordPress.org

Make WordPress Themes

Opened 17 months ago

Closed 6 months ago

Last modified 6 months ago

#34253 closed theme (not-approved)

THEME: Smerk – 2.5

Reported by: themegenic Owned by: ilovewpcom
Priority: new theme Keywords: theme-smerk
Cc: hello@…, gathered@…

Description

Smerk - 1.0

Smerk is a modernized take on an ever-popular WordPress layout the horizontal masthead with an optional right sidebar that works perfectly for blogs and websites. It has custom color options with beautiful default color schemes, a harmonious fluid grid using a mobile-first approach, and impeccable polish in every detail. Smerk will make your WordPress look beautiful everywhere.

Theme URL - https://themegenic.com/smerk
Author URL - https://themegenic.com

SVN - https://themes.svn.wordpress.org/smerk/1.0
ZIP - https://wordpress.org/themes/download/smerk.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#34253 THEME: Smerk – 2.5 closed not-approved ilovewpcom

(this ticket)

#40215 THEME: SmerkTheme – 1.6 closed not-approved rabmalin


https://themes.svn.wordpress.org/smerk/1.0/screenshot.png

Attachments (2)

smerk-menu-1.png (32.1 KB) - added by ilovewpcom 10 months ago.
smerk-menu-2.png (22.1 KB) - added by ilovewpcom 10 months ago.

Download all attachments as: .zip

Change History (89)

#1 @themegenic
16 months ago

Any update?

#2 @emiluzelac
13 months ago

Please be patient, it takes time.

#3 @kharisblank
12 months ago

  • Owner set to kharisblank
  • Status changed from new to reviewing

#4 @kharisblank
12 months ago

Hello @themegenic,

I am taking a look at your theme. I fund the following issues:

  • Once I activated the theme, I can't see the site title, description, and navigation. Please fix it. https://cloudup.com/cMIcXxSCI5N
  • Fatal error: require_once(): Failed opening required '/Users/kharissulistiyo/Sites/wpdemo/wp-content/themes/smerk/template-parts/.php' (include_path='.:/usr/share/pear') in /Users/kharissulistiyo/Sites/wpdemo/wp-content/themes/smerk/header.php on line 30
  • Missing editor-style tag in the main stylesheet since you included editor-style.css.
  • Please avoid hard coding JS script with smerk_javascript_detection() function. Use wp_enqueue_script instead.
  • Please escape all customizer output. For instance:
<?php echo $navi_back_color; ?>

it should be:

<?php echo esc_attr($navi_back_color); ?>

Please see https://codex.wordpress.org/Data_Validation

Please revise your theme to address those issues. Be sure you communicate with us within next 7 days. Otherwise, this ticked will be closed.

Regards,
Kharis

This ticket was mentioned in Slack in #themereview by kharisulistiyo. View the logs.


12 months ago

#6 @kharisblank
12 months ago

Also please revise that adding menu items into the WP admin toolbar isn't allowed.

#7 @grapplerulrich
12 months ago

@themegenic Please provide an update or the ticket will be closed.

#8 @themegenic
12 months ago

We are looking into this.

Please allow us some time to fix these.

Regards

#9 @themegenic
12 months ago

We have made changes as asked.

We are still in process of testing it.

Please allow us 1-2 days more to test it completely So, we don't end up wasting your time to check it again.

Is that okay?

Regards

#10 @themegenic
12 months ago

Updated theme attached.

#11 @kharisblank
11 months ago

@themegenic,

Please reupload your theme through https://wordpress.org/themes/getting-started/ so we can do the next review process.

Regards,
Kharis

Last edited 11 months ago by kharisblank (previous) (diff)

#12 @themegenic
11 months ago

Thanks @kharisblank

Just wanted to know that you got it. Take your time.

Looking forward to hearing from you.

Regards

#13 @themetracbot
11 months ago

  • Summary changed from THEME: Smerk – 1.0 to THEME: Smerk – 1.1

Smerk - 1.1

Smerk is a modernized take on an ever-popular WordPress layout the horizontal masthead with an optional right sidebar that works perfectly for blogs and websites. It has custom color options with beautiful default color schemes, a harmonious fluid grid using a mobile-first approach, and impeccable polish in every detail. Smerk will make your WordPress look beautiful everywhere.

Theme URL - https://themegenic.com/smerk
Author URL - https://themegenic.com

SVN - https://themes.svn.wordpress.org/smerk/1.1
ZIP - https://wordpress.org/themes/download/smerk.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=smerk/1.0&new_path=smerk/1.1

History:

Ticket Summary Status Resolution Owner
#34253 THEME: Smerk – 2.5 closed not-approved ilovewpcom

(this ticket)

#40215 THEME: SmerkTheme – 1.6 closed not-approved rabmalin


https://themes.svn.wordpress.org/smerk/1.1/screenshot.png

#14 @grapplerulrich
11 months ago

  • Owner kharisblank deleted

I am sorry this review is taking so long. Sometimes people are unable to carry on the review, this may have happened this time. As a result, I am going to add this to the new queue again as a priority. This may mean it still takes time, but will prevent this ticket being held for so long by a reviewer that isn't able to carry on. Thanks for your patience.

If you are the reviewer and able to do this review, please carry on and request you get added back in Slack #themereview or you can take on another review when you have time again.

#15 @themetracbot
11 months ago

  • Owner set to ilovewpcom

#16 @ilovewpcom
11 months ago

Hello @themegenic,

I'll continue the work done before me. It is my first official theme review, so I'll try to make everything right.

Conclusion

Theme has many (required) issues that must be fixed before approval.
Please review your code and remove all the commented out code. Please make sure to inspect all of your files, scripts, styles, etc.
As a reminder, please consider the fact that reviewers are allowed to close a ticket if more than 5 -required- issues are found.

Theme Check

OK.

Required

  1. The screenshot should be no bigger than 1200 x 900px. Currently you have a 1349x1710 image.
  2. Screenshot.png contains a photo, but readme.txt contains no information about it. You have to provide at least 3 things about the image: Source URL, Author and License.
  3. Though you are using only Source Sans Pro, you are loading a total of 8 Google fonts (with all their styles) directly from style.css.

That is the wrong way to do it. Please check how Twentyseventeen or Twentysixteen themes do it correctly via functions.php. Also, you probably don't want to load so much of it (for performance issues).

  1. /assests/css/editor-style.css
  • Doesn't work as it should. When switching to Visual mode, none of your styles are applied due to incorrect CSS selectors.
  • Contains the same fonts issue as in p.3.
  1. /assests/css/responsive.css

.banner {} contains a localhost image path (192.168.1.250), which causes a 404 error in the browser.
.banner_internal references a /images/banner2.jpg that doesn't exist.

  1. /languages/ folder is empty = no .pot file provided.
  2. header.php: font-awesome is hard-coded. You have to enqueue it correctly via functions.php.
  3. header.php: 2 hotlinks to maxcdn scripts. These have to be bundled into the theme per this rule:

"Include all scripts and resources it uses rather than hotlinking. The exception to this is Google Fonts."

  1. Validate and/or sanitize untrusted data before entering into the database. All untrusted data should be escaped before output. (See: Data Validation)
  • header.php: L31.
  • footer.php: L28

And there could be more.

  1. All theme text strings are to be translatable.
  • comments.php: L61, 67, 77
  • content-search.php: L22
  • footer.php: L37
  • index.php: L48
  • sidebar.php: L58, L59

And there could be more.

  1. footer.php: jQuery is included and hard-coded.
  2. Pages look broken and throw a JS error in the console:
    Uncaught TypeError: Cannot read property 'id' of null
    http://localhost/review/wp-content/themes/smerk/assests/js/AnimOnScroll.js?ver=4.7 line 89
    
  3. No minification of scripts or files unless you provide original files.

Masonry script is minified, but original unminified version of the file is not bundled.

  1. You are not allowed to remove sections of the customizer:
  1. readme.txt:

1.1 Smerk WordPress Theme, Copyright 2016 WordPress.org & Automattic.com
I don't think this is right, you probably shouldn't attribute your rights to Automattic :)
1.2 HTML5 Shiv v3.7.0, Copyright 2016 ThemeGenic
I believe this is not right too.

  1. Your Assets folder is called "Assests", you might want to correct the typo (and all the paths to it).
  2. Both menus (in header and in footer) look broken and unstyled. I doubt this is the intended look of them. Please check it.
  3. Post formats are enabled in functions.php, but the theme includes a separate template file just for the Link type.
  4. Customizer contains options and values that are not used in any way, like the Copyright text option.
  5. Multiple functions and lines of code are present in the files but are commented out. Please remove all the unused code, there is no need to keep it there (like in functions.php).
  6. It would be better to not use get_posts() in sidebar.php in favor of new WP_Query.

This ticket was mentioned in Slack in #themereview by ilovewpcom. View the logs.


11 months ago

#18 @ilovewpcom
10 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Closing this ticket for inactivity.

#19 @themegenic
10 months ago

We are already working on this.

I sent you email on Friday as well that we will be submitting it this week.

Earlier reviewer didn't respond for almost a month and now you sent long list and closing it for non activity?

List is long and we are working on it. I have sent you emails on that as well that we are progressing and will be able to finalize this week.

Regards

#20 @emiluzelac
10 months ago

@themegenic Key reviewer here: Unfortunately ticket was closed due to inactivity, you will need to resubmit and wait again.

No reviewers should be contacted via email and all communications should to be handled right here.

For the future reference, if more time is needed, please note that directly in the ticket.

Thanks!

#21 @themegenic
10 months ago

Your first reviewer didn't respond for a month and we didn't respond in the board here and its closed without even looking into the emails?

This is our first theme So, we expect you to be considerate atleast.

We have worked for weeks on this and then waited months to get a review.

This is highly uncalled for and very discouraging.

Can you please open the ticket as we did reply to the email we last received?

We have worked out almost all issues over the weekend and will be ready to resubmit in a couple of days.

http://imgur.com/a/G9HFI

#22 @ilovewpcom
10 months ago

Hi,

That email was obviously not delivered to me, the reviewer.
There were no updates in the ticket here, which is why I closed the ticket after waiting for 9 days.

#23 @themegenic
10 months ago

I sent the email :(

We are new to this So, didn't know if we needed to check and verify if it was actually received by you or not. I may have checked it the next day as well but I sent it on Friday and was unavailable for the weekend.

Can you please open the ticket? We really worked hard on this and were very excited to see our theme live.

Please see if there is something you can do.

Regards

#24 @ilovewpcom
10 months ago

Hi,
As I reviewer I do not even have that option.
You can still upload a theme update, but it will most likely go to the end of the queue, unless I'm able to pick it up sooner.

#25 @emiluzelac
10 months ago

  • Resolution not-approved deleted
  • Status changed from closed to reopened

@themegenic This is not what we usually do, but since there was an issue with your first reviewer, I will make an exception. @ilovewpcom please proceed and thanks!

#26 @themegenic
10 months ago

Thanks, We are working on finalizing the submission and will be submitting soon.

Regards

#27 @themetracbot
10 months ago

  • Summary changed from THEME: Smerk – 1.1 to THEME: Smerk – 1.2

Smerk - 1.2

Smerk is a modernized take on an ever-popular WordPress layout the horizontal masthead with an optional right sidebar that works perfectly for blogs and websites. It has custom color options with beautiful default color schemes, a harmonious fluid grid using a mobile-first approach, and impeccable polish in every detail. Smerk will make your WordPress look beautiful everywhere.

Theme URL - https://themegenic.com/smerk
Author URL - https://themegenic.com

SVN - https://themes.svn.wordpress.org/smerk/1.2
ZIP - https://wordpress.org/themes/download/smerk.1.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=smerk/1.1&new_path=smerk/1.2

History:

Ticket Summary Status Resolution Owner
#34253 THEME: Smerk – 2.5 closed not-approved ilovewpcom

(this ticket)

#40215 THEME: SmerkTheme – 1.6 closed not-approved rabmalin


https://themes.svn.wordpress.org/smerk/1.2/screenshot.png

#28 @ilovewpcom
10 months ago

  • Resolution set to not-approved
  • Status changed from reopened to closed

Hi @themegenic,
I have reviewed version 1.2 of the theme. Here are my findings:

Conclusion

There has been no relevant improvement since my previous review.
You have ignored my findings from the initial review: the same data is left unvalidated, the same strings are left hard-coded, not internationalized for translation.
Due to the fact that the issues have not been addressed in any way, I am forced to close this ticket and mark the theme as not-approved

I encourage you to invest more time into your theme and to test it out properly before submitting it to the official repository.

Required

Multiple issues were found even on a quick scan of the theme, there are more than the ones presented below:

  1. Just activating the theme immediately generates PHP notices on all pages. Please test your theme with debug enabled.
NOTICE: E:\wamp\www\review\wp-content\themes\smerk\inc\custom-header.php:64 - Undefined variable: text_color
NOTICE: E:\wamp\www\review\wp-content\themes\smerk\inc\custom-header.php:67 - Undefined variable: text_color
  1. Readme.txt is still incomplete.

There is no license information for the image visible in the screenshot.
There is no license information for the bundled fonts, scripts, etc.

  1. In style.css you are using the "post formats" tag, which is not actually implemented in the theme.
  1. In header.php you are hard-coding the theme's stylesheet_url. That is the wrong way of doing it. All CSS and JS files are to be enqueued properly via functions.php.
  1. All strings are to be translatable. Even if I provided exact file names and line numbers in my previous review, you haven't fixed it.

footer.php, /page-templates/archive.php and there may be other.

  1. All data output has to be validated. Even if I provided exact file names and line numbers in my previous review, you haven't fixed it.
  1. No need to echo this, the function displays the content.
<?php echo the_excerpt(); ?>
  1. /page-templates/contact.php - hard-coded strings, hard-coded shortcode of third-party plugin, etc.
  1. Pages still look broken. Going to any static page leads to an obviously broken layout.
  1. Google fonts are still loaded incorrectly.
  1. Masonry is still not provided as an unminified version.

This ticket was mentioned in Slack in #themereview by ilovewpcom. View the logs.


10 months ago

#30 @Kenshino
10 months ago

  • Cc gathered@… added

#31 @emiluzelac
10 months ago

  • Resolution not-approved deleted
  • Status changed from closed to reopened

@ilovewpcom we still need to provide more time, please note that 7 days are allowed for author to address the issues :)

#32 @themegenic
10 months ago

We tried fixing all the issues mentioned earlier.

Let me go through your list again and check everything thoroughly. I will add my comments on what we fixed so, there is no miscommunication between us.

We are trying to do everything we can and we are not cutting any corners here.
We may have understood and done something different than you mentioned.

Please be a little bit patient with us as this is our first theme here. So, it can be a learning curve for us as none of team members have done this in past but we hope to do more in future.

Regards

#33 @themetracbot
10 months ago

  • Summary changed from THEME: Smerk – 1.2 to THEME: Smerk – 1.3

Smerk - 1.3

Smerk is a modernized take on an ever-popular WordPress layout the horizontal masthead with an optional right sidebar that works perfectly for blogs and websites. It has custom color options with beautiful default color schemes, a harmonious fluid grid using a mobile-first approach, and impeccable polish in every detail. Smerk will make your WordPress look beautiful everywhere.

Theme URL - https://themegenic.com/smerk
Author URL - https://themegenic.com

SVN - https://themes.svn.wordpress.org/smerk/1.3
ZIP - https://wordpress.org/themes/download/smerk.1.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=smerk/1.2&new_path=smerk/1.3

History:

Ticket Summary Status Resolution Owner
#34253 THEME: Smerk – 2.5 closed not-approved ilovewpcom

(this ticket)

#40215 THEME: SmerkTheme – 1.6 closed not-approved rabmalin


https://themes.svn.wordpress.org/smerk/1.3/screenshot.png

#34 @themegenic
10 months ago

point by point response regarding theme

  1. You have ignored my findings from the initial review: the same data is left unvalidated, the same strings are left hard-coded, not internationalized for translation.

=> We have addressed each and everything here point by point So, there is no miscommunication and we don't think that we have COMPLETED a point but in reality you were talking about something else.

=> Multiple issues were found even on a quick scan of the theme, there are more than the ones presented below: Just activating the theme immediately generates PHP notices on all pages. Please test your theme with debug enabled.
NOTICE: E:\wamp\www\review\wp-content\themes\smerk\inc\custom-header.php:64 - Undefined variable: text_color
NOTICE: E:\wamp\www\review\wp-content\themes\smerk\inc\custom-header.php:67 - Undefined variable: text_color

Ans: resolved

=> Readme.txt is still incomplete.

Ans: Regenerated whole readme.txt

=> There is no license information for the image visible in the screenshot.
=> There is no license information for the bundled fonts, scripts, etc.

Ans: I used the open source third party libraries like "script, font etc". I have added the line for the image as well. I changed the image to one of our camera click and edited it. So, there is no license issue. whatsoever.

=> In style.css you are using the "post formats" tag, which is not actually implemented in the theme.

Ans. Resolved, but still if you have any query or doubt then please let me know

=> All strings are to be translatable.

Ans. resolved by adding e

=> /page-templates/archive.php and there may be other.

Ans. resolved, wordpress already have the archives so I removed that section.

=> No need to echo this, the function displays the content.
<?php echo the_excerpt(); ?>

Ans: resolved

=> /page-templates/contact.php - hard-coded strings, hard-coded shortcode of third-party plugin, etc.

Ans: resolved, actually their is no need for special contact page template so I just remove that, but I will update this with extra features in my next theme version.

=> Pages still look broken. Going to any static page leads to an obviously broken layout.

Ans: Resolved. And sorry about that. Silly mistake on our end.

=> Google fonts are still loaded incorrectly.

Ans. please guide me on this point.

  1. masonry is still not provided as an unminified version

Ans. I placed the masonry.js in same folder

Note: I also installed this plugin "https://wordpress.org/plugins/theme-check/" and checked the theme and check the online "http://themecheck.org/".

please check the screen shots: "http://prntscr.com/dznk2k", "http://prntscr.com/dznuq9", "http://prntscr.com/dznuzv"

if there are still any mistakes then please guide me on the same. Thanks for your support and coordination.

#35 @ilovewpcom
10 months ago

Hi,

You write "solved" for multiple issues, but they haven't been addressed in any way, the code is left untouched. I don't know how you think you fixed something, if absolutely nothing has changed about multiple issues. You have even reintroduced some of the issues from the first review.

Conclusion

Version 1.3 has even more issues that 1.2. It looks like you are simply taking code from random places and trying to see if it passes review or not, without actually checking if the code works or not.
I will wait for the next version, and if these issues are not addressed, I will close the ticket again.
If a key reviewer will not agree with this outcome, I don't mind being removed as the reviewer for this theme.

Required

  1. Theme generates notices, warnings and fatal errors on theme activation. Homepage
Warning: require_once(E:\wamp\www\review/wp-content/themes/smerk/template-parts/.php): failed to open stream: No such file or directory in E:\wamp\www\review\wp-content\themes\smerk\header.php on line 30

Fatal error: require_once(): Failed opening required 'E:\wamp\www\review/wp-content/themes/smerk/template-parts/.php' (include_path='.;C:\php\pear') in E:\wamp\www\review\wp-content\themes\smerk\header.php on line 30
  1. screenshot.png is of the wrong size again.
  1. readme.txt still doesn't contain any license information for the used scripts. Simply putting the file names is not sufficient.

Check here for an example of how to make it right: https://themes.trac.wordpress.org/browser/deadline/2.1.1/readme.txt

  1. post-formats tag is still in style.css
  1. You are back to hard-coding the fonts in style.css
  1. header.php again contains hard-coded CSS, both local and hosted on CDN.
  1. footer.php again contains hard-coded scripts.
  1. All strings have to be internationalized (comments.php and probably more). The "Read More" strings are still left untouched since my first review.
  1. In index.php you are not allowed to modify the amount of posts that are displayed.
  1. You are not allowed to hard-code shortcodes (page-templates/contact.php) (I mentioned this previously, nothing has changed).

There are many other issues that I'm not going to repeat here.

#36 @themegenic
10 months ago

Hello,

You are right. Some issues are not solved in the final plugin submitted due to the local SVN code conflict.

I apologize for waiting your time on this.
We were trying to be quick as you closed the ticket earlier due to not responding quick enough.

We will recheck 10 points you mentioned above and will submit a updated plugin in a few days. I assure you, you will see tremendous progress in that.

Please be a little bit patient with us. This is our first time and with all the ticket closing, reopening we are a little bit on the edge and silly mistakes happen in these situations.

Rest assured, we are not putting random code like you mentioned in your comment. We are working on coding part and I believe relying too much on the theme tester plugins and online verify websites. Rookie mistake I guess.

Thanks again to @ilovewpcom and key reviewer for being patient with us.
@ilovewpcom Please bear with us a little bit longer. I know you are very busy with many tasks and themes in your hands, please be patient and more understanding. We are dedicated to follow all the coing standards and get this theme live.

Regards

#37 @themetracbot
10 months ago

  • Summary changed from THEME: Smerk – 1.3 to THEME: Smerk – 1.4

Smerk - 1.4

Smerk is a modernized take on an ever-popular WordPress layout.

Theme URL - https://themegenic.com/smerk
Author URL - https://themegenic.com

SVN - https://themes.svn.wordpress.org/smerk/1.4
ZIP - https://wordpress.org/themes/download/smerk.1.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=smerk/1.3&new_path=smerk/1.4

History:

Ticket Summary Status Resolution Owner
#34253 THEME: Smerk – 2.5 closed not-approved ilovewpcom

(this ticket)

#40215 THEME: SmerkTheme – 1.6 closed not-approved rabmalin


https://themes.svn.wordpress.org/smerk/1.4/screenshot.jpg

#38 @themegenic
10 months ago

Please check this version.

Most/All of the issues mentioned above should be solved here.

If there is anything pending please let us know.

Waiting for your positive response.

=> Google fonts are still loaded incorrectly.
Ans. If this is not resolved up to your satisfaction, please guide me on this point.

Regards

#39 @ilovewpcom
10 months ago

Conclusion

Theme is not yet ready for approval.

Required

  1. PHP notices on every page:
NOTICE: E:\wamp\www\review\wp-content\themes\smerk\inc\custom-header.php:64 - Undefined variable: text_color
NOTICE: E:\wamp\www\review\wp-content\themes\smerk\inc\custom-header.php:67 - Undefined variable: text_color
  1. Most of the controls in the customizer don't do anything: font sizes, colors, switches, social icons, etc. Please test every single option that you have in the customizer and remove the ones that are not actually in use.
  1. All data must be escaped before output.

header1.php (width, height, etc.)
header2.php (width, height, etc.)
footer.php L28

  1. All theme strings must be internationalized.

content-search.php L22
sidebar.php L68
/inc/custom_customizer_settingscustomizer_footer.php L52
/inc/custom_customizer_settings/customizer_header.php L134-135, L163, L171, L177, L217-218
/inc/custom_customizer_settings/navigation.php L119, L135
/inc/custom_customizer_settings/site.php L156, L177, L199, L220

  1. You still have a hard-coded Google Fonts line:

functions.php, L257

  1. Please explain how to get the menu to look like the one in screenshot.jpg. I will attach below screenshots both for the header and footer menus, is that the intended look?
  1. In readme.txt please provide the correct authors for each script, don't use the file name as the author's name.

#40 @themegenic
10 months ago

Thanks for the review. We have a few questions for you.

PHP notices on every page:

Are you using any tool to check this? I have checked it on my demo server, there is no notice visible there.

All data must be escaped before output.
header1.php (width, height, etc.)
header2.php (width, height, etc.)
footer.php L28

What do you mean by "escaped before output"? We are validating the data we are getting from user as input but not sure about the output.

All theme strings must be internationalized.

You mean by using _e or function?

For ex:

( 'Blog Options', 'my-theme' ); OR _e( 'Blog Options', 'my-theme' );

You still have a hard-coded Google Fonts line:

This really gets us scratching our head. How exactly do you want us to put google fonts there? Any documentation for us?

We are using google fonts and for that we enqueue the google font library url at this point.

#41 @ilovewpcom
10 months ago

  1. Try installing and activating the theme on a new WordPress installation.

I am using the Debug Bar plugin.

  1. All user data must be validated on input (when saving it) and escaped on output (when it is included in the HTML).
  1. Yes, that's what I mean. Internationalizing strings means that you prepare them for easier translation.
  1. You are already loading 3 fonts using the smerk_fonts_url() function which is called in smerk_scripts(), which is the right way.

Additionally you have a hard-coded line (L257) that separately loads the Source Sans Pro font. You need to add the font to the above-mentioned function.

#42 @themetracbot
10 months ago

  • Summary changed from THEME: Smerk – 1.4 to THEME: Smerk – 1.5

Smerk - 1.5

Smerk is a modernized take on an ever-popular WordPress layout.

Theme URL - https://themegenic.com/smerk
Author URL - https://themegenic.com

SVN - https://themes.svn.wordpress.org/smerk/1.5
ZIP - https://wordpress.org/themes/download/smerk.1.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=smerk/1.4&new_path=smerk/1.5

History:

Ticket Summary Status Resolution Owner
#34253 THEME: Smerk – 2.5 closed not-approved ilovewpcom

(this ticket)

#40215 THEME: SmerkTheme – 1.6 closed not-approved rabmalin


https://themes.svn.wordpress.org/smerk/1.5/screenshot.jpg

#43 @themegenic
10 months ago

Hi

Greetings!!!

I worked on following points, please check at your end and let me know if the issues are still their.

Try installing and activating the theme on a new WordPress
installation.
I am using the Debug Bar plugin.
Ans. I'm also using the same and I resolved the notification error.

All user data must be validated on input (when saving it) and escaped
on output (when it is included in the HTML).
Ans. I checked but I am already using the functions like: "esc_url, esc_attr", may you please provide me the tool name that your using for the same or provide me the file name.

Yes, that's what I mean. Internationalizing strings means that you
prepare them for easier translation.
Ans. Now I'm using () function for all the static data, please recheck and let me know if issue is still there.

You are already loading 3 fonts using the smerk_fonts_url() function
which is called in smerk_scripts(), which is the right way.
Additionally you have a hard-coded line (L257) that separately loads the
Source Sans Pro font. You need to add the font to the above-mentioned
function.
Ans. I removed the hard coded "Source Sans Pro" in style.css file

Thanks

#44 @ilovewpcom
10 months ago

Conclusion

Most of the issues were left untouched since last version. Please go back to my previous review and fix the reported issues properly.

Required

  1. In my previous review I have mentioned exact file names with exact line numbers that contained unescaped data, most of which were left untouched (still).
  1. In my previous review I have mentioned exact file names with exact line numbers that contained untranslated strings, most of which were left untouched (still).
  1. In my previous review I have mentioned exact file names with exact line numbers that contained incorrect loading of a Google font. Contrary to what you have written in your notes, it has NOT been removed.
  1. I have provided 2 screen-shots with the broken menus (header and footer), this issue has not been addressed in any way.

#45 @themegenic
10 months ago

We are going through each review line by line in order to make sure we don't miss anything.

Will send you updated theme soon.

Thanks for being patient with us.

Regards

#46 @themegenic
9 months ago

first 3 points are complete. Finalizing 4th point with testing.

Will submit asap. Hopefully will have fixed all possible issues in this update.

Regards

#47 @themegenic
9 months ago

Everything is complete.

We will upload the files tomorrow.

Regards

#48 @themegenic
9 months ago

Hi

Greetings!!!

We have gone through all ticket replies and mentioned all the done points here with comments.
All the line numbers mentioned have been checked and changed accordingly.

If there is anything still pending, please let us know.

Required

  1. The screenshot should be no bigger than 1200 x 900px. Currently you have a 1349x1710 image. -> done
  2. Screenshot.png contains a photo, but readme.txt contains no information about it. You have to provide at least 3 things about the image: Source URL, Author and License.-> done
  3. Though you are using only Source Sans Pro, you are loading a total of 8 Google fonts (with all their styles) directly from style.css. That is the wrong way to do it. Please check how Twentyseventeen or Twentysixteen themes do it correctly via functions.php. Also, you probably don't want to load so much of it (for performance issues).

==> I'm using the following code now

function smerk_fonts_url() {
$fonts_url = ;
$fonts = array();
$subsets = 'latin,latin-ext';
/ translators: If there are characters in your language that are not supported by Merriweather, translate this to 'off'. Do not translate into your own language. /
if ( 'off' !== _x( 'on', 'Merriweather font: on or off', 'smerk' ) ) {
$fonts[] = 'Merriweather:400,700,900,400italic,700italic,900italic';
}
/ translators: If there are characters in your language that are not supported by Montserrat, translate this to 'off'. Do not translate into your own language. /
if ( 'off' !== _x( 'on', 'Montserrat font: on or off', 'smerk' ) ) {
$fonts[] = 'Montserrat:400,700';
}
/ translators: If there are characters in your language that are not supported by Inconsolata, translate this to 'off'. Do not translate into your own language. /
if ( 'off' !== _x( 'on', 'Inconsolata font: on or off', 'smerk' ) ) {
$fonts[] = 'Inconsolata:400';
}
if ( $fonts ) {
$fonts_url = add_query_arg( array(
'family' => urlencode( implode( '|', $fonts ) ),
'subset' => urlencode( $subsets ),
), 'https://fonts.googleapis.com/css' );
}
return $fonts_url;
}
endif;

/assests/css/editor-style.css - Doesn't work as it should. When switching to Visual mode, none of your styles are applied due to incorrect CSS selectors. - Contains the same fonts issue as in p.3.
=> I'm managing the things through main style now text and visual modes working fine please check the screenshots "http://prntscr.com/e3jmug, http://prntscr.com/e3jmyd"

/assests/css/responsive.css .banner {} contains a localhost image path (192.168.1.250), which causes a 404 error in the browser. .banner_internal references a /images/banner2.jpg that doesn't exist.
=> resolved

/languages/ folder is empty = no .pot file provided.
=> now their is no language folder, because my theme is worked on english language but I used printf(()) and _e() functions

header.php: font-awesome is hard-coded. You have to enqueue it correctly via functions.php.
=> Now I'm implemented the font using function.php

header.php: 2 hotlinks to maxcdn scripts. These have to be bundled into the theme per this rule: "Include all scripts and resources it uses rather than hotlinking. The exception to this is Google Fonts."
=> Resolved

Validate and/or sanitize untrusted data before entering into the
database. All untrusted data should be escaped before output. (See: Data Validation)
header.php: L31.
=> resolved ""

footer.php: L28
==> resolved "esc_url(get_theme_mod( 'ft_check' ))"

All theme text strings are to be translatable.
comments.php: L61, 67, 77
=> already changed please have a look "http://prntscr.com/e3jwhf"

content-search.php: L22
=> already chnages please have look "http://prntscr.com/e3jwz2"

footer.php: L37
=> already changed

index.php: L48
=> already changed

sidebar.php: L58, L59
=> already changed

And there could be more.

footer.php: jQuery is included and hard-coded.
=> already changed

Pages look broken and throw a JS error in the console: {{{
Uncaught TypeError: Cannot read property 'id' of null
http://localhost/review/wp-
content/themes/smerk/assests/js/AnimOnScroll.js?ver=4.7 line 89
}}}
=> now the console os cleared please have a look "http://prntscr.com/e3jz48"

No minification of scripts or files unless you provide original files.
Masonry script is minified, but original unminified version of the file is
not bundled.
=> now both versions are their please have a look "http://prntscr.com/e3jzyq"

You are not allowed to remove sections of the customizer:
=> may you please guide me which section I removed

  1. readme.txt: 1.1 Smerk WordPress Theme, Copyright 2016 WordPress.org & Automattic.com I don't think this is right, you probably shouldn't attribute your rights

to Automattic

=> already resolved

1.2 HTML5 Shiv v3.7.0, Copyright 2016 ThemeGenic I believe this is not right too.

=> may you please guide me on this

Your Assets folder is called "Assests", you might want to correct the typo (and all the paths to it).
=> already resolved

Both menus (in header and in footer) look broken and unstyled. I doubt this is the intended look of them. Please check it.
=> resolved

Post formats are enabled in functions.php, but the theme includes a separate template file just for the Link type.
=> Now it's using the default file index.php for posts

Customizer contains options and values that are not used in any way, like the Copyright text option.
=> done, In condition I haven't use the security method but when I print that part then I used "esc_js(get_theme_mod( 'ft_cp_tt'))"

Multiple functions and lines of code are present in the files but are commented out. Please remove all the unused code, there is no need to keep it there (like in functions.php).
=> removed

It would be better to not use get_posts() in sidebar.php in favor of
new WP_Query.
=> already removed

I checked the things step by step. if I missed something then please guide me on the same. Thanks you for your corporation and support.

Thanks

#49 @themetracbot
9 months ago

  • Summary changed from THEME: Smerk – 1.5 to THEME: Smerk – 1.6

Smerk - 1.6

Smerk is a modernized take on an ever-popular WordPress layout.

Theme URL -
Author URL -

Trac Browser - https://themes.trac.wordpress.org/browser/smerk/1.6

SVN - https://themes.svn.wordpress.org/smerk/1.6
ZIP - https://wordpress.org/themes/download/smerk.1.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=smerk/1.5&new_path=smerk/1.6

History:

Ticket Summary Status Resolution Owner
#34253 THEME: Smerk – 2.5 closed not-approved ilovewpcom

(this ticket)

#40215 THEME: SmerkTheme – 1.6 closed not-approved rabmalin


https://themes.svn.wordpress.org/smerk/1.6/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.
  • RECOMMENDED: Author URI: is missing from your style.css header.

#50 @ilovewpcom
9 months ago

I am reviewing version 1.6 only using the Diff with the previous version.

Required

  1. Incorrect function to escape output. Are you expecting here JavaScript code as output?
    <p><?php echo esc_js(get_theme_mod( 'ft_cp_tt')) ; ?></p>
    
  1. Incorrect function to escape output. Are you expecting here an URL as output?
    $hd_type = esc_url(get_theme_mod('hd_type' ));
    
  1. Incorrect code syntax, you cannot use an escaping function on the get_template_part() function.
    esc_attr(get_template_part('template-parts/'. $hd_type));
    

I'll do this one for you, here's the more appropriate code:

get_template_part('template-parts/'. esc_attr($hd_type));
  1. This doesn't need escaping at all:
    esc_attr(get_template_part('template-parts/header2'));
    
  1. readme.txt still contains no copyright information about the photo visible in screenshot.png, nor about the photo in /assets/banner.jpg.

This is all that you have:

=== Screenshot ===
screenshot.jpg
Source url:  
Author: The Themegenic team
License: GNU General Public License v3.0License 

And here's an example of how it is done in Twentyseventeen:

Bundled header image, Copyright Alvin Engler
License: CC0 1.0 Universal (CC0 1.0)
Source: https://unsplash.com/@englr?photo=bIhpiQA009k
  1. /template-parts/header2.php more incorrect usage of validation/sanitization functions.
    <img src="<?php echo esc_url( get_theme_mod( 'hd_lg' ) ); ?> " height="<?php echo esc_url(get_theme_mod( 'hd_lg_he','90px' )) ; ?>" width="<?php echo get_theme_mod( 'hd_lg_wd','224px' ) ; ?>"  alt="<?php bloginfo( 'name' ); ?>"/>					
    

Are you expecting an URL as the parameter for the height attribute?
The width is not escaped.

  1. /template-parts/header2.php
    <h2><a href="<?php echo esc_url( home_url( '/' ) ); ?>"> <?php  echo $blog_title = sanitize_text_field(get_bloginfo( 'name' )); ?> </a></h2>
    

sanitize_text_field() is used to sanitize data before saving it to the database, it is not the correct function to validate content on output.

Replace this line with:

<h2><a href="<?php echo esc_url( home_url( '/' ) ); ?>"> <?php bloginfo( 'name' ); ?> </a></h2>

Why complicate things?

  1. content-search.php L28 contains untranslatable strings:
    <?php comments_number('(0 Comments)', '(1 Comment)', '(% Comments)' );?>
    
  1. /inc/custom_customizer_settings/navigation.php still has the same untranslatable strings that I mentioned after reviewing 1.4. I have provided file name and line numbers to the content, which hasn't been fixed in 1.5 nor in 1.6.
  1. /inc/custom_customizer_settings/customizer_header.php still has untranslatable strings that I mentioned after reviewing 1.4. I have provided file name and line numbers to the content, which hasn't been fixed in 1.5 nor in 1.6.
  1. /inc/custom_customizer_settings/customizer_footer.php still has untranslatable strings that I mentioned after reviewing 1.4. I have provided file name and line numbers to the content, which hasn't been fixed in 1.5 nor in 1.6.
  1. Browser throws a 404 JavaScript error in the console:
    GET http://localhost/review/wp-content/themes/smerk/assets/images/right-arrow.png 404 (Not Found)
    

RECOMMENDED: Theme URI: is missing from your style.css header.
RECOMMENDED: Author URI: is missing from your style.css header.

Last edited 9 months ago by ilovewpcom (previous) (diff)

#51 @themetracbot
9 months ago

  • Summary changed from THEME: Smerk – 1.6 to THEME: Smerk – 1.7

Smerk - 1.7

Smerk is a modernized take on an ever-popular WordPress layout.

Theme URL -
Author URL -

Trac Browser - https://themes.trac.wordpress.org/browser/smerk/1.7

SVN - https://themes.svn.wordpress.org/smerk/1.7
ZIP - https://wordpress.org/themes/download/smerk.1.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=smerk/1.6&new_path=smerk/1.7

History:

Ticket Summary Status Resolution Owner
#34253 THEME: Smerk – 2.5 closed not-approved ilovewpcom

(this ticket)

#40215 THEME: SmerkTheme – 1.6 closed not-approved rabmalin


https://themes.svn.wordpress.org/smerk/1.7/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.
  • RECOMMENDED: Author URI: is missing from your style.css header.

#52 @themetracbot
9 months ago

  • Summary changed from THEME: Smerk – 1.7 to THEME: Smerk – 1.8

Smerk - 1.8

Smerk is a modernized take on an ever-popular WordPress layout.

Theme URL - https://themegenic.com/smerk
Author URL - https://themegenic.com

Trac Browser - https://themes.trac.wordpress.org/browser/smerk/1.8

SVN - https://themes.svn.wordpress.org/smerk/1.8
ZIP - https://wordpress.org/themes/download/smerk.1.8.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=smerk/1.7&new_path=smerk/1.8

History:

Ticket Summary Status Resolution Owner
#34253 THEME: Smerk – 2.5 closed not-approved ilovewpcom

(this ticket)

#40215 THEME: SmerkTheme – 1.6 closed not-approved rabmalin


https://themes.svn.wordpress.org/smerk/1.8/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#53 @themegenic
9 months ago

Hi

Greetings!!!

Thanks for correcting me.

I have done with the following issues please check and provide me your valuable feedback on the same

I am reviewing version 1.6 only using the Diff with the previous version.

Required

  1. Incorrect function to escape output. Are you expecting here JavaScript

code as output?

<p><?php echo esc_js(get_theme_mod( 'ft_cp_tt')) ; ?></p>

Ans: now I used "esc_attr()". please guide me if any other method I can use here.

Incorrect function to escape output. Are you expecting here an URL as
output?

$hd_type = esc_url(get_theme_mod('hd_type' ));

Ans: now I used "esc_attr()". please guide me if any other method I can use here.

Incorrect code syntax, you cannot use an escaping function on the
get_template_part() function.

esc_attr(get_template_part('template-parts/'. $hd_type));

Ans: resolved

I'll do this one for you, here's the more appropriate code: {{{
get_template_part('template-parts/'. esc_attr($hd_type));
}}}
Ans: resolved

This doesn't need escaping at all: {{{
esc_attr(get_template_part('template-parts/header2'));
}}}

Ans: resolved

readme.txt still contains no copyright information about the photo
visible in screenshot.png, nor about the photo in /assets/banner.jpg.

This is all that you have: {{{

Screenshot

screenshot.jpg
Source url: Author: The Themegenic team
License: GNU General Public License v3.0License
}}}

Ans: modified read me file.

And here's an example of how it is done in Twentyseventeen: {{{
Bundled header image, Copyright Alvin Engler
License: CC0 1.0 Universal (CC0 1.0)
Source: https://unsplash.com/@englr?photo=bIhpiQA009k
}}}

/template-parts/header2.php more incorrect usage of
validation/sanitization functions.

<img src="<?php echo esc_url( get_theme_mod( 'hd_lg' ) ); ?> "
height="<?php echo esc_url(get_theme_mod( 'hd_lg_he','90px' )) ; ?>"
width="<?php echo get_theme_mod( 'hd_lg_wd','224px' ) ; ?>" alt="<?php
bloginfo( 'name' ); ?>"/>

Ans: Ans: Now I removed sanitize for get function

Are you expecting an URL as the parameter for the height attribute?
The width is not escaped.

/template-parts/header2.php

<h2><a href="<?php echo esc_url( home_url( '/' ) ); ?>"> <?php echo
$blog_title = sanitize_text_field(get_bloginfo( 'name' )); ?> </a></h2>

Ans: resolved

sanitize_text_field() is used to sanitize data before saving it to the
database, it is not the correct function to validate content on output.

Replace this line with: {{{
<h2><a href="<?php echo esc_url( home_url( '/' ) ); ?>"> <?php bloginfo(
'name' ); ?> </a></h2>
}}}

Ans: Now I removed sanitize for get function

Why complicate things?
content-search.php L28 contains untranslatable strings: {{{
<?php comments_number('(0 Comments)', '(1 Comment)', '(% Comments)' );?>
}}}

Ans: <div class="coments"><?php if ( comments_open()
get_comments_number() ) {

comments_template();
} ?></div>

please let me know if their is any other better way.

/inc/custom_customizer_settings/navigation.php still has the same
untranslatable strings that I mentioned after reviewing 1.4. I have
provided file name and line numbers to the content, which hasn't been
fixed in 1.5 nor in 1.6.
Ans: resolved 'label' => ( 'Font Size','smerk'),'label' => ('Font Family', 'smerk'), I found only these two mistakes, please guide me if I missed something

/inc/custom_customizer_settings/customizer_header.php still has
untranslatable strings that I mentioned after reviewing 1.4. I have
provided file name and line numbers to the content, which hasn't been
fixed in 1.5 nor in 1.6.

Ans: 'header1' => ('Header 1','smerk'),'header2' => ('Header 2','smerk'),'label' => ('Social Icons', 'smerk' ),'label' => ('Width', 'smerk' ),'label' => ('Height', 'smerk' ), I found these 5 mistakes , please guide me if I missed something

/inc/custom_customizer_settings/customizer_footer.php still has
untranslatable strings that I mentioned after reviewing 1.4. I have
provided file name and line numbers to the content, which hasn't been
fixed in 1.5 nor in 1.6.

Ans: Resolved "( 'Copyright Text', 'smerk' )," I found only one mistake, please guide me if I missed something

Browser throws a 404 JavaScript error in the console: GET http://localhost/review/wp-content/themes/smerk/assets/images/right-
arrow.png 404 (Not Found)

Ans: console is clear "http://prntscr.com/e848k0". may you please guide me on this

RECOMMENDED: Theme URI: is missing from your style.css header.
RECOMMENDED: Author URI: is missing from your style.css header.

Ans: it's their may you please guide me on the same "http://prntscr.com/e848z2"

RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
Ans. As you mentioned in very beginning "/assests/css/editor-style.css - Doesn't work as it should. When switching to Visual mode, none of your styles are applied due to incorrect CSS selectors"

So remove the editor-style.css from root and just manage the things through style.css.

please guide me if you found any mistake from me end.

Thanks

#54 @themegenic
9 months ago

waiting for your feedback to get updates on last corrections.

Regards

#55 @ilovewpcom
9 months ago

Hi,

Looking at the diff between the 2 versions there are still things that you haven't fixed, incorrect escaping functions and other things.
Please review my previous notes carefully, you still have unfixed issues.

#56 @themegenic
9 months ago

I have worked on all the line numbers provided in previous messages.

I have mentioned each and everything point by point in my last message.

Can you please provide me screenshot of the errors you are seeing? OR any kind of log thats being created on your end. Any plugin you are using to find these issues.
It would help me find the problem quickly.

Regards

#57 @ilovewpcom
9 months ago

I mentioned this a couple of times and you replied each time that "it is fixed".

<img src="<?php echo esc_url(get_theme_mod('hd_lg')); ?> " height="<?php echo get_theme_mod('hd_lg_he', '90px'); ?>" width="<?php echo get_theme_mod('hd_lg_wd', '224px'); ?>"  alt="<?php bloginfo('name'); ?>"/>	

#58 @themetracbot
9 months ago

  • Summary changed from THEME: Smerk – 1.8 to THEME: Smerk – 1.9

Smerk - 1.9

Smerk is a modernized take on an ever-popular WordPress layout.

Theme URL - https://themegenic.com/smerk
Author URL - https://themegenic.com

Trac Browser - https://themes.trac.wordpress.org/browser/smerk/1.9

SVN - https://themes.svn.wordpress.org/smerk/1.9
ZIP - https://wordpress.org/themes/download/smerk.1.9.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=smerk/1.8&new_path=smerk/1.9

History:

Ticket Summary Status Resolution Owner
#34253 THEME: Smerk – 2.5 closed not-approved ilovewpcom

(this ticket)

#40215 THEME: SmerkTheme – 1.6 closed not-approved rabmalin


https://themes.svn.wordpress.org/smerk/1.9/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#59 @themegenic
9 months ago

changes

smerk\index.php
line: 19

smerk\page-templates\about.php
line: 12

smerk\page-templates\faq.php
line: 11

smerk\template-parts\header1.php
line: 7

smerk\template-parts\header2.php
line: 5

I have done some R&D regarding which escape function will used for get_theme_mod

and found that esc_attr() and I changed accordingly.

if still you found wrong escape functions then please provide me the file name and wrong escape function name.

I reviewed the previous doc and as I replied point to point so I can't able to understand which stuff is unfixed.

Thanks for your support and please guide me on the same.

#60 @ilovewpcom
9 months ago

Hi,

  1. None of your options in Customize are working. I have tried changing the font, size, enabling social icons, changing the header "style" - nothing changes at all.

Please test all options properly and make sure that they work.

  1. Incorrect usage of printf():
<?php printf( __( 'Read More', 'smerk' )); ?>

Please use this instead:

<?php _e( 'Read More', 'smerk' ); ?>
  1. sidebar.php contains unused code, this menu location is not declared:
    <?php
          <?php if ( has_nav_menu( 'social' ) ) : ?>
          <nav id="social-navigation" class="social-navigation" role="navigation">
             <?php
                // Social links navigation menu.
                
                wp_nav_menu( array(
                
                    'theme_location' => 'social',
                
                    'depth'          => 1,
                
                    'link_before'    => '<span class="screen-reader-text">',
                
                    'link_after'     => '</span>',
                
                ) );
                
                ?>
          </nav>
          <!-- .social-navigation -->
          <?php endif; ?>
    
  1. You still have hard-coded text that is not translateable:

sidebar.php

echo 'No posts found';
  1. The automatic code sniffer also reports this for most of your PHP files:
File has mixed line endings; this may cause incorrect results
  1. Additionally you have a lot of blank lines in your files. Even though not a requirement, I suggest that you clean up the files and make the code more readable.

For example in header.php you have a single if..else statement stretched over 28 lines.

#61 @themetracbot
9 months ago

  • Summary changed from THEME: Smerk – 1.9 to THEME: Smerk – 2.0

Smerk - 2.0

Smerk is a modernized take on an ever-popular WordPress layout.

Theme URL - https://themegenic.com/smerk
Author URL - https://themegenic.com

Trac Browser - https://themes.trac.wordpress.org/browser/smerk/2.0

SVN - https://themes.svn.wordpress.org/smerk/2.0
ZIP - https://wordpress.org/themes/download/smerk.2.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=smerk/1.9&new_path=smerk/2.0

History:

Ticket Summary Status Resolution Owner
#34253 THEME: Smerk – 2.5 closed not-approved ilovewpcom

(this ticket)

#40215 THEME: SmerkTheme – 1.6 closed not-approved rabmalin


https://themes.svn.wordpress.org/smerk/2.0/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#62 @themegenic
9 months ago

Hi

Greetings!!!

==> Incorrect usage of printf():

<?php printf( __( 'Read More', 'smerk' )); ?>

Please use this instead: {{{
<?php _e( 'Read More', 'smerk' ); ?>
}}}

Ans: Now I'm using this "_e()", I think on 31-jan-2017 in mentioned this "Now I'm using () function for all the static data, please recheck and let me know if issue is still their."

==> sidebar.php contains unused code, this menu location is not declared: {{{#!php
<?php
<?php if ( has_nav_menu( 'social' ) ) : ?>
<nav id="social-navigation" class="social-navigation"
role="navigation">

<?php
Social links navigation menu.

wp_nav_menu( array(

'theme_location' => 'social',

'depth' => 1,

'link_before' => '<span class="screen-reader-text">',

'link_after' => '</span>',

) );

?>
</nav>
<!-- .social-navigation -->
<?php endif; ?>
}}}

Ans. Removed unwanted code

==> You still have hard-coded text that is not translateable: sidebar.php

echo 'No posts found';

Ans: _e('No posts found','smerk');

==> The automatic code sniffer also reports this for most of your PHP files:

File has mixed line endings; this may cause incorrect results

Additionally you have a lot of blank lines in your files. Even though not a requirement, I suggest that you clean up the files and make the code more readable. For example in header.php you have a single if..else statement stretched over 28 lines.

Ans. As per me understanding I removed the spaces and Now the code is more read able.

==> None of your options in Customize are working. I have tried changing the font, size, enabling social icons, changing the header "style" - nothing changes at all.

Ans. I have done many chnages in that part now things are working fine and I also remove some functionlity I'll implement that in my next version.

Thanks

#63 @ilovewpcom
8 months ago

Hi,

Required

  1. Please remove your custom Logo upload control from the Customizer in favor of the core Logo feature in WordPress.
  1. Please remove your custom Customize > Header > Banner option in favor of the core Header feature in WordPress.
  1. You are not allowed to remove default sections in the Customizer (/inc/customizer.php):
    <?php
            $wp_customize->remove_section( 'colors' );
            $wp_customize->remove_section( 'background_image' );
            $wp_customize->remove_section( 'header_image' );
    
  1. Remove this unused code from header1.php, unless I missed its purpose:
    <?php echo get_theme_mod('site_bg'); ?>
    

#64 @themetracbot
8 months ago

  • Summary changed from THEME: Smerk – 2.0 to THEME: Smerk – 2.1

Smerk - 2.1

Smerk is a modernized take on an ever-popular WordPress layout.

Theme URL - https://themegenic.com/smerk
Author URL - https://themegenic.com

Trac Browser - https://themes.trac.wordpress.org/browser/smerk/2.1

SVN - https://themes.svn.wordpress.org/smerk/2.1
ZIP - https://wordpress.org/themes/download/smerk.2.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=smerk/2.0&new_path=smerk/2.1

History:

Ticket Summary Status Resolution Owner
#34253 THEME: Smerk – 2.5 closed not-approved ilovewpcom

(this ticket)

#40215 THEME: SmerkTheme – 1.6 closed not-approved rabmalin


https://themes.svn.wordpress.org/smerk/2.1/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#65 @themegenic
8 months ago

Hi

Greetings!!!

Required

  1. Please remove your custom Logo upload control from the Customizer in favor of the core Logo feature in WordPress.

Ans. may you please guide me why I have to remove this, if this section is not important then why you haven't this in beginning.

Please remove your custom Customize > Header > Banner option in favor
of the core Header feature in WordPress.
Ans. may you please guide me why I have to remove this, if this section is not important then why you haven't this in beginning.

You are not allowed to remove default sections in the Customizer
(/inc/customizer.php):

<?php

$wp_customize->remove_section( 'colors' );
$wp_customize->remove_section( 'background_image' );
$wp_customize->remove_section( 'header_image' );

Ans. I removed that code.

Remove this unused code from header1.php, unless I missed its purpose: {{{#!php
<?php echo get_theme_mod('site_bg'); ?>
}}}
Ans. removed that code

Thanks

#67 @ilovewpcom
8 months ago

Hi,

Do you have the intention of fixing the 2 issues that were mentioned and ignored during the last update?

#68 @themegenic
8 months ago

We are going through the link you sent and will have a update for you by monday.

#69 @themetracbot
8 months ago

  • Summary changed from THEME: Smerk – 2.1 to THEME: Smerk – 2.2

Smerk - 2.2

Smerk is a modernized take on an ever-popular WordPress layout.

Theme URL - https://themegenic.com/smerk
Author URL - https://themegenic.com

Trac Browser - https://themes.trac.wordpress.org/browser/smerk/2.2

SVN - https://themes.svn.wordpress.org/smerk/2.2
ZIP - https://wordpress.org/themes/download/smerk.2.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=smerk/2.1&new_path=smerk/2.2

History:

Ticket Summary Status Resolution Owner
#34253 THEME: Smerk – 2.5 closed not-approved ilovewpcom

(this ticket)

#40215 THEME: SmerkTheme – 1.6 closed not-approved rabmalin


https://themes.svn.wordpress.org/smerk/2.2/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#70 @themegenic
8 months ago

both points done.

Please check and let me know if there is anything pending still.

Regards

#71 @ilovewpcom
8 months ago

Hi,

  1. Have you tested the Header Image feature?
  2. What's the difference between Header1 and Header2 options in the Customizer? I see absolutely no difference on my set-up, and there is no description for that option.
  3. Why not display the logo with the core the_custom_logo() function? Is it necessary to manually create the anchor and the img tag (in header1 and header2 files)?

#72 @themegenic
8 months ago

we are looking into this.

#73 @themetracbot
8 months ago

  • Summary changed from THEME: Smerk – 2.2 to THEME: Smerk – 2.3

Smerk - 2.3

Smerk is a modernized take on an ever-popular WordPress layout.

Theme URL - https://themegenic.com/smerk
Author URL - https://themegenic.com

Trac Browser - https://themes.trac.wordpress.org/browser/smerk/2.3

SVN - https://themes.svn.wordpress.org/smerk/2.3
ZIP - https://wordpress.org/themes/download/smerk.2.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=smerk/2.2&new_path=smerk/2.3

History:

Ticket Summary Status Resolution Owner
#34253 THEME: Smerk – 2.5 closed not-approved ilovewpcom

(this ticket)

#40215 THEME: SmerkTheme – 1.6 closed not-approved rabmalin


https://themes.svn.wordpress.org/smerk/2.3/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#74 @themegenic
8 months ago

custom header and custom logo code has been removed.

#75 @ilovewpcom
7 months ago

Hi,

  1. header1.php and header2.php files are still included in the theme. If they are not used - please delete unused files.
  1. Pingback URL should be enqueued through functions.php (instead of being hard-coded in header.php).

Please functions.php of Twenty Seventeen for a way to achieve it.

  1. comments.php

Line: 24 ERROR Missing singular placeholder, needed for some languages. See https://codex.wordpress.org/I18n_for_WordPress_Developers#Plurals

Please check Twenty Seventeen for the correct way of displaying the number of comments in this file.

  1. You have misunderstood my previous message about the Custom Header feature, which you implemented in a recent update. Have you tested this feature? Have you tried uploading a large image and use it as the header, have you seen that the theme displays a 200px wide image to fill the whole screen?

#76 @rabmalin
7 months ago

  • Status changed from reopened to reviewing

#77 @themegenic
7 months ago

we are working on the points mentioned above.

#78 @themetracbot
7 months ago

  • Summary changed from THEME: Smerk – 2.3 to THEME: Smerk – 2.4

Smerk - 2.4

Smerk is a modernized take on an ever-popular WordPress layout.

Theme URL - https://themegenic.com/smerk
Author URL - https://themegenic.com

Trac Browser - https://themes.trac.wordpress.org/browser/smerk/2.4

SVN - https://themes.svn.wordpress.org/smerk/2.4
ZIP - https://wordpress.org/themes/download/smerk.2.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=smerk/2.3&new_path=smerk/2.4

History:

Ticket Summary Status Resolution Owner
#34253 THEME: Smerk – 2.5 closed not-approved ilovewpcom

(this ticket)

#40215 THEME: SmerkTheme – 1.6 closed not-approved rabmalin


https://themes.svn.wordpress.org/smerk/2.4/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are smerk, twentyseventeen

#79 @ilovewpcom
7 months ago

Hi,

Please check yourself the results of your theme updates and make sure that everything is according to standards.

Theme Check Results:

Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are smerk, twentyseventeen

Additionally, it looks like there might be something wrong with your development environment, as every patch that you make adds extra white lines to all theme files, which is visible in the DIFF and makes it almost impossible to properly review your updates.

Again, as I said, it is a good idea to check yourself the results of your own updates.
Would you be able to easily review a simple update with a DIFF like this? https://themes.trac.wordpress.org/changeset?old_path=smerk/2.3&new_path=smerk/2.4

#80 @djrmom
7 months ago

@themegenic, you are required to respond within 7 days, please comment or update or this ticket will be closed. Thanks.

#81 @themegenic
7 months ago

working on it.

#82 @themetracbot
6 months ago

  • Summary changed from THEME: Smerk – 2.4 to THEME: Smerk – 2.5

Smerk - 2.5

Smerk is a modernized take on an ever-popular WordPress layout.

Theme URL - https://themegenic.com/smerk
Author URL - https://themegenic.com

Trac Browser - https://themes.trac.wordpress.org/browser/smerk/2.5

SVN - https://themes.svn.wordpress.org/smerk/2.5
ZIP - https://wordpress.org/themes/download/smerk.2.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=smerk/2.4&new_path=smerk/2.5

History:

Ticket Summary Status Resolution Owner
#34253 THEME: Smerk – 2.5 closed not-approved ilovewpcom

(this ticket)

#40215 THEME: SmerkTheme – 1.6 closed not-approved rabmalin


https://themes.svn.wordpress.org/smerk/2.5/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#83 @themegenic
6 months ago

All the issues should be done now.

#84 @ilovewpcom
6 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hi,

I have to report the same issues time and time again, without any real result or quality improvement.

  1. The automatic code sniffer (NS Theme Check) reports 36 errors for all your PHP files:

File has mixed line endings; this may cause incorrect results

  1. archive pages don't show anything, as they reference files that don't even exist.
  1. What is the purpose of the broken /page-templates/faq.php file?
  1. header.php - you don't need to escape or translate the blog name / description.

Conclusion

After 4 months of reviewing this theme, I have to close it.
It is obvious that you aren't even testing your updates, which is unfortunate, considering how much time was wasted on reviewing it.

#85 @emiluzelac
6 months ago

Just wondering, if the author is submitting updates in time, why was this theme closed actually?

#86 @ilovewpcom
6 months ago

@emiluzelac if you feel that 12 patches in 4 months with no end in sight is the right amount of time required for a single theme, then you are very welcome to take over this ticket.

#87 @emiluzelac
6 months ago

@ilovewpcom It's closed already so no point of stepping over and taking the ticket :)

Note: See TracTickets for help on using tickets.