WordPress.org

Make WordPress Themes

Opened 9 months ago

Closed 4 months ago

Last modified 5 weeks ago

#34522 closed theme (not-approved)

THEME: i-amaze – 1.0.1

Reported by: marsian Owned by: greenshady
Priority: new theme Keywords: theme-i-amaze
Cc: marsian.mcs@…

Description

i-amaze - 1.0.1

i-amaze is a beautiful and flexible theme with several premium features including fullscreen slider, portfolio, testimonial, team members, etc. This highly customizable theme is ideal for startup business websites, portfolios, personal websites or blogging. Highly responsive nature of i-amaze makes it suitable for large desktop screens to small mobile screens. Some of the features are unlimited color, boxed/wide layout, custom background, custom css styling, social links, multiple blog layout, etc. i-amaze comes with the plugin “templatesnext toolkit” giving you extra flexibility and functionality which includes, shortcodes to build pages with rows/column, SEO enabled headings, portfolios, testimonials, custom blog pages, custom slider etc. You can create beautiful pages with portfolio/blog carousels, masonry blocks, services, call to act sections etc. Unlike other themes i-amaze does not use theme settings to store content and you can switch theme without losing content. i-amaze is WooCommerce ready.

Theme URL - http://templatesnext.in/i-amaze-landing/
Author URL - http://templatesnext.org/

SVN - https://themes.svn.wordpress.org/i-amaze/1.0.1
ZIP - https://wordpress.org/themes/download/i-amaze.1.0.1.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#34522 THEME: i-amaze – 1.0.1 closed not-approved greenshady

(this ticket)

#40315 THEME: i-amaze – 1.0.3 closed not-approved thinkupthemes


https://themes.svn.wordpress.org/i-amaze/1.0.1/screenshot.png

Change History (9)

#1 @greenshady
4 months ago

  • Owner set to greenshady
  • Status changed from new to reviewing

#2 @greenshady
4 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

This theme needs quite a bit of work to be up to the standards needed to be hosted on the .ORG theme repository. I've maybe reviewed about 1/10 of the theme at this point and have surpassed the minimum number of issues needed to close the ticket.

Please make sure your theme meets all the theme review guidelines. https://make.wordpress.org/themes/handbook/review/

After that, you can resubmit the theme and have it reviewed again.

Pagination

The theme must use core WP functions when available. iamaze_paging_nav() should be replaced with the_posts_pagination().

Use get_template_directory()

When including PHP function-type files, use get_template_directory() instead of dirname( __FILE__ ) when possible.

File-ending ?> + whitespace

It's best not to end your PHP function files with a ?>. Just leave that off. This is not a requirement.

However, when you end with a ?> plus an empty line after that, it creates the "white screen of death" for many users like this at the end of functions.php:

?>

Post meta content creation

Post meta is allowed if it only deals with presentation-related items. Any post meta field that houses content should be left to plugins.

This post meta is clearly content-related:

Other Slider Plugin Shortcode

Enter a 3rd party slider shortcode, ex. meta slider, smart slider 2, wow slider, etc. Only works with TemplatesNext Themes

The logo feature must use the core WordPress logo feature instead of something custom. Additionally, you cannot display placeholder logo by default. Instead, show the user's site title.

Demo content

The theme should not display placeholder/demo content on the front end of the site, such as the demo contact info, fake social media profile links, and slider content.

Meta box plugin

Don't include the meta box plugin with your theme. You can certainly add support for it, but let the user install the plugin if they wish.

Plus, do you really need this for a handful of meta fields? You can build those in probably fewer than 100 lines of code.

Front page

The slider should not appear on the front page when the user has chosen to display blog posts.

Document theme limitations

The theme does not handle a lot of nav menu items. It covers up the page. Make sure to document this in the readme file.

Customizer content creation

The way the slider is handled via the customizer is not allowed because the fields are creating content that locks the user into the theme to keep their content.

Better options are to allow the user to select posts, pages, or media fields. Basically, allow the user to use their existing content. Content should not be tied to the theme options.

Pro/Theme customizer sections

The theme is only allowed one upsell-type section or custom "info" section on the top level. This theme has two: 1) An image logo and 2) A section of info.

I'd say the image logo section needs to be removed anyway since it's not adding any benefit.

The upsell links in the customizer seem to go to a different theme called "ispirit". The way things are worded, it seems that it should be an upsell of a "premium" version of this theme but it leads to an unrelated theme.

Title tag

Themes can only support, at most, 3 versions back of WP. Please remove this from header.php:

	<?php    
    if ( ! function_exists( '_wp_render_title_tag' ) ) :
        function iamaze_render_title() {
    ?>
    <title><?php wp_title( '|', true, 'right' ); ?></title>
    <?php
        }
        add_action( 'wp_head', 'iamaze_render_title' );
    endif;    
    ?> 

Additionally, please don't put functions and actions within template files. Those can go inside of your functions.php.

Archive title

Use the core function the_archive_title() to display archive-type page titles instead of rolling out a custom solution like you have in header.php.

#3 @marsian
4 months ago

Hello Justin,

Hope closed does not mean i have to wait another 3-4 months :) .
Let me go through the guidelines and fix as much as possible and submit in couple of days.

regarding "the_posts_pagination()" and custom archive title (header.php), the framework is "twenty thirteen" and i have kept them the way they were, i guess time to upgrade myself :)

Post meta content creation
Post meta is allowed if it only deals with presentation-related items. Any post meta field that houses content should be left to plugins.
This post meta is clearly content-related:
Other Slider Plugin Shortcode

Enter a 3rd party slider shortcode, ex. meta slider, smart slider 2, wow slider, etc. Only works with TemplatesNext Themes

Nope it does not save any content, it only replaces the theme slider with a 3rd party slider if the user has one. this option actually helps the user to move on to other theme keeping his slider rather then losing the theme slider data and settings.

Last edited 4 months ago by marsian (previous) (diff)

#4 @marsian
3 months ago

@greenshady

hello justin,

The rules say, i can not include any plugin, does that means i have to remove "Kirki"?

if yes, i can add that as recommended plugin but in that case many theme customization options like color, layout, etc will not be available untill the plugin is installed.

can i get the slider content rule relaxed :) since the theme already have a options for slider with custom post type in recommended plugin as well as use of any other slider plugin replacing default theme slider.

rest of the changes are done

Last edited 3 months ago by marsian (previous) (diff)

#5 @greenshady
3 months ago

Nope it does not save any content, it only replaces the theme slider with a 3rd party slider if the user has one. this option actually helps the user to move on to other theme keeping his slider rather then losing the theme slider data and settings.

That should be done via plugin, not your theme. It would be useless if, for example, a user switched to one of my themes.

The rules say, i can not include any plugin, does that means i have to remove "Kirki"?

Kirki is both a plugin and a drop-in library. You can bundle it with your theme.

can i get the slider content rule relaxed :) since the theme already have a options for slider with custom post type in recommended plugin as well as use of any other slider plugin replacing default theme slider.

You can use a custom page template for this or use it on the front page when ! is_home().

#6 @marsian
5 weeks ago

@greenshady

hello justin,

Uploaded the changes, did all the changes, had difficulty finding documentation on partial refhresh/customizer shortcut. It seems to have created another thread here https://themes.trac.wordpress.org/ticket/40315 , hope i do not have to wait another 6 months and make the updates all over again, as i mentioned above i use the core theme "twenty thirteen as base" :)

The "custom header" did not had all the parameters like CSS background image, so i did not use that.

#7 @greenshady
5 weeks ago

If your theme meets all of the requirements and uses standardized coding methods, you shouldn't have to wait 6 months.

The best thing to do in the meantime is to join the theme review team. You'll learn a lot in the process. It'll help you become a much better theme author. https://make.wordpress.org/themes/handbook/get-involved/become-a-reviewer/

#8 follow-up: @marsian
5 weeks ago

@greenshady

Ok thanks! it is already 7 month now, please have a look into it, i tried to update and fix all the issues according to the requirements and recommendations.

Regarding reviewing theme, should i "request a theme for review", i already have the setup almost ready or wait for weekly chat?

#9 in reply to: ↑ 8 @greenshady
5 weeks ago

Ok thanks! it is already 7 month now, please have a look into it, i tried to update and fix all the issues according to the requirements and recommendations.

Another reviewer will pick it up for review. I'm actually taking a break from reviewing right now myself due to work/time constraints.

Regarding reviewing theme, should i "request a theme for review", i already have the setup almost ready or wait for weekly chat?

Yep, go ahead and request a theme for review.

Note: See TracTickets for help on using tickets.