WordPress.org

Make WordPress Themes

Opened 13 months ago

Closed 4 months ago

#34668 closed theme (live)

THEME: Murray – 0.95

Reported by: InkHive Owned by: acalfieri
Priority: new theme Keywords: theme-murray
Cc: support@…

Description

Murray - 0.9

Murray has been designed for Sites Based on Pictures and Videos. But, its so flexible it can adapt to almost any other kind of site as well. It supports and relies on Featured Images. Has a Beautiful Stick Menu Bar, Featured Posts Section, Works with RT Slider and supports Multiple Blog Layouts. For those who need Maximum Social Exposure, we also have a Sticky Social Bar on the left. Sidebar is also configurable. And Yes, its Fully Responsive on all devices from smallets phones to bigger desktops. Demo here: http://demo.inkhive.com/murray/

Theme URL - http://inkhive.com/product/murray
Author URL - http://inkhive.com

SVN - https://themes.svn.wordpress.org/murray/0.9
ZIP - https://wordpress.org/themes/download/murray.0.9.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#34668 THEME: Murray – 0.95 closed live acalfieri

(this ticket)

#42795 THEME: Murray – 1.0 closed live themetracbot
#45338 THEME: Murray – 1.0.1 closed live themetracbot


https://themes.svn.wordpress.org/murray/0.9/screenshot.jpg

Change History (28)

#1 @acalfieri
8 months ago

  • Owner set to acalfieri
  • Status changed from new to reviewing

Hi @InkHive,

I'll review your theme starting from today. You'll get some feedback in the next couple of days.

Cheers!

#2 @acalfieri
8 months ago

Hi @InkHive,

A beautiful theme, indeed. Below are my comments in order to improve some details. It is quite possible that I’ve missed something, but I wanted to give you some feedback today, so you can start working.

Requirements

  1. The .pot file has to be murray.pot.
  1. In functions.php you have to include the non minified .css files.
  1. You are adding theme support for Custom Header but you forgot to include/require the file custom-header.php in functions.php. Besides, some of the things you are doing in the Customizer regarding the custom header image are already handled by core, so look after whether your custom functions are not doing the same.
  1. The custom logo feature could be better implemented following the documentation here https://developer.wordpress.org/themes/functionality/custom-logo/). The height and width arguments in add_theme_support(‘custom-logo’) crop the image to the desired size. There are also other things you can do to improve the implementation:
    • You can rewrite murray_has_logo() in functions.php and replace the condition in header.php by using a function like in the Twenties themes, for instance.
    • The Resize & Adjust Logo control could be just after the Logo image control and not before.
  1. You have registered two navigation menus, but you never use the Top Menu.
  1. You have both home.php and index.php. You only need one of the two, so choose one and delete the other. If you would like to implement a Front Page that is different from the Blog Page, you should include front-page.php instead. More about that here http://www.chipbennett.net/2013/09/14/home-page-and-front-page-and-templates-oh-my/ and here https://make.wordpress.org/themes/2014/06/28/correct-handling-of-static-front-page-and-custom-blog-posts-index-template/
  1. You run three new WP_Query(). It’s good to reset the posts after you run The Loop with wp_reset_postdata(). You have done it well in themes-functions.php but not in recent-posts.php and you have both wp_reset_postdata(); and wp_reset_query(); in home.php
  1. Since WordPress 4.7 Custom CSS in the Customizer is in core, so delete the Custom CSS section in the Customizer.
  1. Your Murray Theme Help & Support and Discover Murray Plus Sections in the Customizer don’t follow the requirements (they are here https://make.wordpress.org/themes/handbook/review/required/explanations-and-examples/#selling-credits-and-links). An example of how it can be done is here https://github.com/justintadlock/trt-customizer-pro
  1. WordPress has many sanitization functions, are you sure you need to write your own ones?
  1. You recommend a plugin for a Slider but when I install that plugin I get a message that it is not compatible with your theme (‘’’Your Theme Does not Support this RT Slider Plugin’’’). You have also files of another slider plugin among your files, but they are never used. I don’t know what you intend to do with the slider plugins, but if you would like to have a slider in your theme, choose between one of the two and implement it properly.

Recommendations

  • (This is not important). At the end of header.php you open two <div>' elements, one with the class mega-container and the other with the id content. You close one in sidebar-footer.php and the other in footer.php`, but the commented names of the closings are switched.

I think you are able to find the details I missed by yourself, so I stop here. You have 7 days to make an update, else the ticket will be closed. If you need more than 7 days, please write a message here so the ticket stays open.

Kindly,

#3 @InkHive
8 months ago

Hello,

We have fixed all the required issues. Please note the following:

  • .pot files are no longer a requirement. I have removed them completely.
  • index.php is also required as its a genric file, even if it doesn't render anything. home.php is just for the blog page. Here is the purpose served by index.php. Also, the user in this theme can use any other page as static page and a different blog page(home.php).
 Index.php is the most generic template file in a WordPress theme
 and one of the two required files for a theme (the other being style.css).
 It is used to display a page when nothing more specific matches a query.
 E.g., it puts together the home page when no home.php file exists.
 Learn more: http://codex.wordpress.org/Template_Hierarchy

#4 @themetracbot
8 months ago

  • Summary changed from THEME: Murray – 0.9 to THEME: Murray – 0.91

Murray - 0.91

Murray has been designed for Sites Based on Pictures and Videos. But, its so flexible it can adapt to almost any other kind of site as well. It supports and relies on Featured Images. Has a Beautiful Stick Menu Bar, Featured Posts Section, Works with RT Slider and supports Multiple Blog Layouts. For those who need Maximum Social Exposure, we also have a Sticky Social Bar on the left. Sidebar is also configurable. And Yes, its Fully Responsive on all devices from smallets phones to bigger desktops. Demo here: http://demo.inkhive.com/murray/

Theme URL - http://inkhive.com/product/murray
Author URL - http://inkhive.com

SVN - https://themes.svn.wordpress.org/murray/0.91
ZIP - https://wordpress.org/themes/download/murray.0.91.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=murray/0.9&new_path=murray/0.91

History:

Ticket Summary Status Resolution Owner
#34668 THEME: Murray – 0.95 closed live acalfieri

(this ticket)

#42795 THEME: Murray – 1.0 closed live themetracbot
#45338 THEME: Murray – 1.0.1 closed live themetracbot


https://themes.svn.wordpress.org/murray/0.91/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are murray,

#5 @acalfieri
8 months ago

Hi again @InkHive!

Sorry the delay, but it's holiday time here and I didn't have the time before. I revised your theme again and I found the following issues.

Code

Requirements

  1. The following piece of code should be wrapped inside a function (murray_content_width, for instance) or inside the murray_setup() function. See how it is done in Twenty Sixteen and Twenty Seventeen.
    if ( ! isset( $content_width ) ) {
    	$content_width = 640; /* pixels */
    }
    
  1. In functions.php, lines 157, 163 and 165 you are still enqueuing the minified .css files. Please, enqueue the non-minified files.
  1. The code in external.js is minified, please unminify it.
  1. You don’t need the murray_has_logo() function in functions.php. In header.php, line 37 you can just check that the custom logo exists with if( has_custom_logo() ).
  1. I’m not sure what your murray_stick_menu() function is doing. Would it not be better to write that code in custom.js instead?
  1. Are you using navigation.js? I don’t think so. If not, delete it.
  1. I don’t understand what you are trying to do with the navigation walkers. If I add descriptions to the Primary Menu, they are not visible. There are some conditions in header.php, lines 58-65 that involve the walkers, but you haven’t defined a setting called murray_disable_nav_desc anywhere, so the conditions always choose the walker Murray_Menu_With_Icon. Even after that, no icons are visible, and while the markup for them has been created, the class of the <i> element is not sufficient to show them. Besides, instead of extending the Walker_Nav_Menu class, a much simpler way of adding descriptions is filtering a bit of it with a function like the following one. A simple filter could also be used for the icons.
    function murray_nav_description( $item_output, $item, $depth, $args ) {
    	if ( $item->description ) {
    		$item_output = str_replace( $args->link_after . '</a>', '<p>' . $item->description . '</p>' . $args->link_after . '</a>', $item_output );
    	}
    
    	return $item_output;
    }
    add_filter( 'walker_nav_menu_start_el', 'murray_nav_description', 10, 4 );
    
  1. In css-mods.php there also are some settings that you haven’t defined anywhere, like murray_disable_active_nav and murray_center_logo. Check if there are more like these two and delete everything that is not used.
  1. Because those settings are undefined (and because you deleted the custom header support), you are not using murray_hex2rgb() and murray_fade(), both in theme-functions.php. Unused functions (unused code, in general) should be deleted. By the way, would it not be better if you merged functions.php and theme-functions.php?
  1. In the same direction, it would also be better if you merged style.css and main.css and deleted the less folder that is not used at all.

Recommendations

  1. I think The Loop in the first part of your home page (the one with the sticky post) should be like in the following piece of code. As it is now, the new WP_Query (lines 16-26 in home.php) does nothing.
    if ( has_posts() ) {
       while ( has_posts() ) {
          the_post();
          <div id="sticky-post">
             /// All the code you have inside this div.
          </div>
       }
    }
    

Functionality

Requirements

  1. The warning "Your Theme Does not Support this RT Slider Plugin" appears everytime a user has another theme activated. I think it should only appear in your own themes.
  1. The plugin has some problems, also. For instance, when I select in Customising -> Main Slider -> Enable/Disable to show 4 slides, I come back to the previous screen and see the settings for 4 slides. I save, I do other things and when I come back again because I would like to change it to 5 slides, I see the settings for all the 10 slides. Moreover, I don't know why, the slider appears in all the pages even if I have disabled all possibilities in the Customizer.
  1. In customizer.php, line 206 you have an inexistent murray_sanitize_text function as sanitize callback. I think that error makes impossible to change the icons of the featured sections in the home page. It works well though if you use sanitize_text_field.
  1. The custom logo still doesn’t work so well. First, I think you would like the height to be 80px and the width to be 300px. Just now, it is the opposite. Second, you haven’t limited the image size in the stylesheet, so if I use a, say, 3000x800 image, the logo covers all the screen.
  1. You have murray_paging_nav() in template-tags.php and murray_pagination() in theme-functions.php. The correct function is the second one, so delete the first one.
  1. You have murray_post_nav() in template-tags.php, but it is impossible to navigate between posts because it is commented out in single.php. Delete this function (both in template-tags.php and single.php) and use the_post_navigation() instead, either in single.php or in content-single.php https://developer.wordpress.org/reference/functions/the_post_navigation/.

File Structure and Organisation

Requirements

  1. I can’t see you’re using featured-posts.php, featured-showcase.php and social-fa.php. Delete those files and check whether there are other unused files.
  1. In comments.php you should change the name of the package to @package Murray. Furthermore, it is not needed to have a callback function in wp_list_comments(), so murray_comment() in template-tags.php can be safely deleted. There are also new functions in core that allow this file to be cleaner and simpler. Again, see the two last default themes for examples.

Recommendations

  1. You could create a folder called template-parts and put inside content-none.php, content-page.php, content-search.php, content-single.php, content.php and the 4 files in framework/layouts. You could also create a content-sticky.php file with the code you wrote for the first post and also save that in the template-parts folder.

Licenses

  1. You need to add this https://github.com/codrops/DirectionAwareHoverEffect in your readme.txt. Look after other external resources in case you have forgotten to declare them.

Finally, it's fine to have index.php between your files as a fallback, but according to the Template Hierarchy https://core.trac.wordpress.org/browser/trunk/src/wp-includes/template-loader.php, if you have home.php, archive.php, search.php, single.php, page.php and 404.php (and you have all of them) it will never be read.

Please, make your changes and submit again.

Kindly,

#6 @InkHive
8 months ago

Hi, I hope you had a great holiday and a happy new year :)

I will get to these issues shortly and update theme in max 2 days.

#7 @InkHive
7 months ago

Working on the issues, will update this ticket soon.

#8 @themetracbot
7 months ago

  • Summary changed from THEME: Murray – 0.91 to THEME: Murray – 0.92

Murray - 0.92

Murray has been designed for Sites Based on Pictures and Videos. But, its so flexible it can adapt to almost any other kind of site as well. It supports and relies on Featured Images. Has a Beautiful Stick Menu Bar, Featured Posts Section, Works with RT Slider and supports Multiple Blog Layouts. For those who need Maximum Social Exposure, we also have a Sticky Social Bar on the left. Sidebar is also configurable. And Yes, its Fully Responsive on all devices from smallets phones to bigger desktops. Demo here: http://demo.inkhive.com/murray/

Theme URL - http://inkhive.com/product/murray
Author URL - http://inkhive.com

SVN - https://themes.svn.wordpress.org/murray/0.92
ZIP - https://wordpress.org/themes/download/murray.0.92.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=murray/0.91&new_path=murray/0.92

History:

Ticket Summary Status Resolution Owner
#34668 THEME: Murray – 0.95 closed live acalfieri

(this ticket)

#42795 THEME: Murray – 1.0 closed live themetracbot
#45338 THEME: Murray – 1.0.1 closed live themetracbot


https://themes.svn.wordpress.org/murray/0.92/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are murray,

#9 @InkHive
7 months ago

Hi,

All issues have been fixed except a few. As they are not required.

  1. Its perfectly within guidelines to enqueue minified files.
  2. Less folder is important to the theme. The .less files compile into .css files.
  3. murray_comment is required. I need it to alter the style of my comments. I am using my own classes here.
  4. I can not control the plugin features after the theme is deactivated. The user has to deactivate the plugin too. Similar situation in WooCommerce. It starts giving incompatibility notice if u switch to an incompatible theme. Secondly, Plugin review is not to under Theme Review. But, thanks for reporting the bugs in the plugin. I will report it to the plugin and get it fixed.

I have confirmed the guidelines regarding above four from slack. Please feel free to ask me any questions you may have.

  1. murray_stick_menu is determining where to stick the menu. If user is logged in, it will be stuck after the admin bar.

I have fixed all the other issues.

Thank you so so much for reviewing Murray!!

#10 @acalfieri
7 months ago

Dear @InkHive

  1. You still have some scripts in external.js that are only provided in minified form.
  1. You haven’t deleted murray_paging_nav() in template-tags.php. See if you have more unused functions.
  1. You don’t need murray_has_logo() in functions.php. In header.php use just has_custom_logo(), which is already a conditional tag and returns true if a logo image is set.
  1. You still don’t have any navigation between single posts. I don’t know if that is because you forgot to add it or on purpose.
  1. Lines 16 - 26 in home.php are still unnecessary if you don’t write the loop properly.

Kindly,

#11 @rohitink
7 months ago

1,2 I will check again.
3 is needed for backwards compatibility.
4 - I don't want navigation between posts.
5 - I will look into it and update the theme tomorrow :)

#12 @InkHive
7 months ago

Hi, I need one more day to fix all these issues.
Sorry for all the delay. Really hoping to get it all done this time around :)

We appreciate your patience with us.

..G. Sriram

Last edited 7 months ago by InkHive (previous) (diff)

#13 @acalfieri
7 months ago

Don't worry! I won't have so much time the next 2 or 3 days, so take your time.

#14 @themetracbot
7 months ago

  • Summary changed from THEME: Murray – 0.92 to THEME: Murray – 0.93

Murray - 0.93

Murray has been designed for Sites Based on Pictures and Videos. But, its so flexible it can adapt to almost any other kind of site as well. It supports and relies on Featured Images. Has a Beautiful Stick Menu Bar, Featured Posts Section, Works with RT Slider and supports Multiple Blog Layouts. For those who need Maximum Social Exposure, we also have a Sticky Social Bar on the left. Sidebar is also configurable. And Yes, its Fully Responsive on all devices from smallets phones to bigger desktops. Demo here: http://demo.inkhive.com/murray/

Theme URL - http://inkhive.com/product/murray
Author URL - http://inkhive.com

SVN - https://themes.svn.wordpress.org/murray/0.93
ZIP - https://wordpress.org/themes/download/murray.0.93.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=murray/0.92&new_path=murray/0.93

History:

Ticket Summary Status Resolution Owner
#34668 THEME: Murray – 0.95 closed live acalfieri

(this ticket)

#42795 THEME: Murray – 1.0 closed live themetracbot
#45338 THEME: Murray – 1.0.1 closed live themetracbot


https://themes.svn.wordpress.org/murray/0.93/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are murray,

#15 @InkHive
7 months ago

Hello,

I have fixed 1 & 2. Added Un-minifed versions in js folder and removed the unused function.

3 & 4, are not required issues for the reasons i explained above.

I do not understand pt 5. I removed the code and I did not get the expected result. That line of code is required for me to the sticky post and display it!

#16 @acalfieri
7 months ago

Hi @InkHive,

  1. I can not find the unminified version of Modernizr.
  1. OK.
  1. I don't understand your point with the use of murray_has_logo(). Why do you need backwards compatibility in a theme that has not yet been released? Even if your theme already has users it will not be a problem to change that.
  1. OK.
  1. I will try to explain it.
  • When you load a template, like index.php, or home.php, or archive.php, the template calls a WP_Query object, the main query. You can check the content of this object with var_dump($wp_query) or, better for reading, echo '<pre>'; print_r($wp_query); echo '</pre>’;. The documentation about this is in https://codex.wordpress.org/Query_Overview.
  • If you print the object you will see that, among other things, you have an array called [posts] that contains all the posts of the query and and object [post] that contains the first post of the query. If there are sticky posts, this first post is the last published sticky post. If not, it is just the last published post.
  • Because the sticky post is in [post], you don’t need to make a custom query for it, so you don't need lines 16-26, you print this post by just printing the code you have in lines 28-42.
  • If you would like to run the custom query you wrote, the right way to do it is as I wrote before. I repeat here the complete piece of code that could replace lines 24-45 in home.php. The main idea is that the code of the sticky template has to be inside the conditions.
    if ( $sticky_query->have_posts() ) :
        while ( $sticky_query->have_posts() ) :
            $sticky_query->the_post(); ?>
    	<div id="sticky-post">
    	    <div <?php post_class("sticky-image col-md-8"); ?>>
    	        <a href="<?php the_permalink(); ?>"><?php the_post_thumbnail('murray-thumb'); ?></a>
    	    </div>
    	    <div class="sticky-details col-md-4">
    	        <div class="sticky-title title-font">
    	            <a href="<?php the_permalink(); ?>"><?php the_title(); ?></a>
    	        </div>
    		<div class="sticky-desc">
    		    <?php the_excerpt(); ?>
    		</div>
    	    </div>
            </div>
    <?php
        endwhile;
        wp_reset_postdata();
    endif ?>
    
  • I just use alternative syntax for the conditions because it's easier for me.
  • I think it would look nicer if the <div id="sticky-post"> with all its content was in a file named content-sticky.php and was called with get_template_part() inside the loop.

Well, I hope it works for you the same way it works for me :-)

I wait until your next update.

Kindly,

#17 @themetracbot
7 months ago

  • Summary changed from THEME: Murray – 0.93 to THEME: Murray – 0.94

Murray - 0.94

Murray has been designed for Sites Based on Pictures and Videos. But, its so flexible it can adapt to almost any other kind of site as well. It supports and relies on Featured Images. Has a Beautiful Stick Menu Bar, Featured Posts Section, Works with RT Slider and supports Multiple Blog Layouts. For those who need Maximum Social Exposure, we also have a Sticky Social Bar on the left. Sidebar is also configurable. And Yes, its Fully Responsive on all devices from smallets phones to bigger desktops. Demo here: http://demo.inkhive.com/murray/

Theme URL - http://inkhive.com/product/murray
Author URL - http://inkhive.com

SVN - https://themes.svn.wordpress.org/murray/0.94
ZIP - https://wordpress.org/themes/download/murray.0.94.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=murray/0.93&new_path=murray/0.94

History:

Ticket Summary Status Resolution Owner
#34668 THEME: Murray – 0.95 closed live acalfieri

(this ticket)

#42795 THEME: Murray – 1.0 closed live themetracbot
#45338 THEME: Murray – 1.0.1 closed live themetracbot


https://themes.svn.wordpress.org/murray/0.94/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are murray,

#18 @InkHive
7 months ago

  1. murray_has_logo indirectly checks if has_custom_logo exists before calling it. has_custom_logo was introduced beyond 4.5 This is because, a majority of users are still not using WP 4.5 and above. if I don't include the check, it would just give them fatal errors. So, I would like to support them as well. https://wordpress.org/about/stats/ I hope there is no harm in supporting people still on WP 4.4 :)
  1. Included unminifed modernizr.
  1. I do appreciate your suggestions regarding the implmentation of sticky posts, but I think i understand why we are having a conflict of opinion here.

To explain you first I would like to explain the structure of the home in algo format.

Featured Stuff

  • Load the first Sticky Post. Only the first, ignore the other sticky posts.
  • Reset Post data.
  • Load Featured Area One. Based on Category defined in customizer. Uses WP_Query.
  • Reset Post data.
  • Load Featured Area Two. Based on Category Defined in customizer. Uses WP_Query.
  • Reset Post data one final time, so that the WP_Query object is restored to the original home.php value.

Now Its Time to process the blog posts

  • Execute the default WP_Query Object, But
  • Ignore only the first sticky post, which has been already featured at the top.

By the implmentation you suggested, all sticky posts will be excuded at once, while i just want the latest one. Also, I will not be able to show featured posts by category in between the first sticky post and regular blog posts.

I hope I was clear. I can understand why you may not appreciate my coding style. But I don't think i am violating any WPORG guidelines with the way i have written the code. I hope the theme passes this review :)

#19 @acalfieri
7 months ago

  • Status changed from reviewing to approved

Dear @InkHive

It's not that I don't appreciate your coding style. On the contrary, I think that, as I said before, you have written a very beautiful theme. Neither is it that I don't understand what you would like to do with the content of your home page (I tried all of the possible configurations). It's just that lines 16-26 in home.php do nothing. If I delete them, everything is the same as you described in pseudocode: the first sticky post, the 2 sections with 3 posts of the selected category and the latest posts without the first sticky post.

And, as I said before, they do nothing because you don't have anything inside the if condition. It's like writing the loop like this, without any markup.

if ( have_posts() ) :
    while ( have_posts() ) : the_post();
    endwhile;
endif;

without get_template_part('content') inside the while loop, nothing will print. What prints the sticky post is the code inside <div id="sticky-post"> for the reasons I said before. But this code is outside the loop.

With the implementation I suggested, only one sticky post (the latest) would be printed at the top of the page, both with and without a custom query.

  • With a custom query, because you have 'posts_per_page' => 1 among your arguments.
  • Without the custom query, because only one post is in $wp_query->post.

But, as you said, it was only a recommendation, I have already said the same thing 3 times and I don't like to repeat myself. My only goal was to make your code better.

Your theme is approved. From now on, it can be found in this queue https://themes.trac.wordpress.org/report/24. Please, don't make any changes until the final review, as this will create a new ticket.

Kindly,

#20 @greenshady
5 months ago

I'm taking on the admin review of this theme.

#21 @greenshady
5 months ago

  • Status changed from approved to reopened

Overall, this is pretty solid theme. There's just a few minor issues I want us to get cleared away before setting the theme live.

Home featured posts

Generally, we don't allow featured areas in the main blog posts list. However, I'd be convinced to allow this feature if you removed the "featured posts" from the main query so that they are not appearing twice on the home/blog page.

You can do this by hooking into pre_get_posts (use the post__not_in argument).

Missing singular placeholder

In comments.php, you're missing the singular placeholder here, so this can't be translated in all languages:

<?php
	printf( _nx( 'One thought on &ldquo;%2$s&rdquo;', '%1$s thoughts on &ldquo;%2$s&rdquo;', get_comments_number(), 'comments title', 'murray' ),
	number_format_i18n( get_comments_number() ), '<span>' . get_the_title() . '</span>' );
?>

Take a look at how this is done in Twenty Seventeen.

Can't translate string

On line 55 of inc/template-tags.php, there's no text to translate:

_x( '%s', 'post date', 'murray' ),

Same thing on line 154:

<?php printf( _x( '%1$s', '1: date', 'murray' ), get_comment_date() ); ?>

Translating footer text

This can't be properly translated in footer.php:

('&copy; '.date('Y').' '.get_bloginfo('name').__('. All Rights Reserved. ','murray'))

Go with something like:

sprintf( __( '&copy; %1$s %2$s. All Rights Reserved.', 'murray' ), date_i18n( 'Y' ), get_bloginfo( 'name' ) )

Escaping

Make sure to escape variables in the following:

Line 143 in framework/theme-functions.php:

<i class="fa <?php echo $icon; ?>"></i><span><?php echo $title; ?></span>

Prefixing

This is minor, but in your framework/widgets/recent-posts.php, you should switch register and murrary in the function name:

function register_murray_widget

#22 @greenshady
5 months ago

  • Status changed from reopened to reviewing

#23 @InkHive
5 months ago

Thank you very much for your suggestions @greenshady
We are working on the issues and will get them fixed in a couple of days.

#24 @InkHive
5 months ago

Hello, I have fixed all the issues.
But I am unable to understand this

You can do this by hooking into pre_get_posts (use the post__not_in argument).

Till Now I have been able to create and store all ids of featured posts in an array global $murray_fpost_ids;
And This is the code i have tried putting at various places in the theme:

Function to Exclude already displayed posts form the Homepage.

<?php
function murray_exclude_single_posts_home($query) {             
global $murray_fpost_ids;
var_dump($murray_fpost_ids); echo "hihi";       
  if ($query->is_home() && $query->is_main_query()) {
    $query->set('post__not_in', $murray_fpost_ids);
  }
}       
add_action('pre_get_posts', 'murray_exclude_single_posts_home');        

I would appreciate your help as I want to do this the right way.
I am aware that I can rewrite the main query for the home.php but that would certainly violate some guidelines.

Thank you very much!

#25 @InkHive
4 months ago

@greenshady Requesting your help :)

Or should I update with whatever I have done till now?

#26 @greenshady
4 months ago

Hooking into pre_get_posts to alter the main query is fine in this situation.

#27 @themetracbot
4 months ago

  • Summary changed from THEME: Murray – 0.94 to THEME: Murray – 0.95

Murray - 0.95

Murray has been designed for Sites Based on Pictures and Videos. But, its so flexible it can adapt to almost any other kind of site as well. It supports and relies on Featured Images. Has a Beautiful Stick Menu Bar, Featured Posts Section, Works with RT Slider and supports Multiple Blog Layouts. For those who need Maximum Social Exposure, we also have a Sticky Social Bar on the left. Sidebar is also configurable. And Yes, its Fully Responsive on all devices from smallets phones to bigger desktops. Demo here: http://demo.inkhive.com/murray/

Theme URL - http://inkhive.com/product/murray
Author URL - http://inkhive.com

Trac Browser - https://themes.trac.wordpress.org/browser/murray/0.95

SVN - https://themes.svn.wordpress.org/murray/0.95
ZIP - https://wordpress.org/themes/download/murray.0.95.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=murray/0.94&new_path=murray/0.95

History:

Ticket Summary Status Resolution Owner
#34668 THEME: Murray – 0.95 closed live acalfieri

(this ticket)

#42795 THEME: Murray – 1.0 closed live themetracbot
#45338 THEME: Murray – 1.0.1 closed live themetracbot


https://themes.svn.wordpress.org/murray/0.95/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are murray,

#28 @greenshady
4 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

I'm going to go ahead and make this theme live.

One thing that I overlooked that must be corrected in your next update is to remove the demo social links in the header. # is not a valid link URL. If the user hasn't explicitly added a social link, don't show it.

Note: See TracTickets for help on using tickets.