WordPress.org

Make WordPress Themes

#34729 closed theme (not-approved)

THEME: PressForward-TurnKey-Theme – 2.1

Reported by: regan008 Owned by: poena
Priority: previously reviewed Keywords: theme-pressforward-turnkey-theme
Cc: aregan2@…

Description

PressForward-TurnKey-Theme - 2.1

The PressForward-TurnKey-Theme is designed to work alongside the PressForward plugin and aid in the creation of a PressForward publication. The theme features an optional homepage template with numerous blocks that allow users to feature a variety of text heavy content based on category. The homepage blocks can be turned on and off and the content can be manipulated to fit a variety of different publication styles. The slider pulls in the featured image from a post and the PressForward author (if the PressForward plugin is active). On individual pages, users can customize the display of the author, comments, and, optionally, display PressForward nomination counts on individual posts. While this theme is designed to compliment the workflow of a PressForward publication it is optimized for use with any site. The theme is designed using the JointsWP, Foundation, Font Awesome, and Kirki libraries and is responsive and accessibility ready.

Theme URL - http://www.github.com/pressforward/pressforward-turnkey-theme
Author URL - http://www.amanda-regan.com

SVN - https://themes.svn.wordpress.org/pressforward-turnkey-theme/2.1
ZIP - https://wordpress.org/themes/download/pressforward-turnkey-theme.2.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=pressforward-turnkey-theme/2.0&new_path=pressforward-turnkey-theme/2.1

History:


https://themes.svn.wordpress.org/pressforward-turnkey-theme/2.1/screenshot.png

Change History (3)

#1 @poena
12 months ago

Hi
Was this theme resubmitted after the first review?
You still need to select a new name, using the word "Theme" in the name is not allowed.

#2 @poena
11 months ago

  • Owner set to poena
  • Status changed from new to reviewing

#3 @poena
11 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hi
Your theme has been partially reviewed against these requirements:
https://make.wordpress.org/themes/handbook/review/required/

As part of the new theme directory guidelines, reviewers may now close tickets if a theme has 5 or more issues.
This is part of our long term goals to improve the theme quality and shorten the queues.
You can read more about this change here: https://make.wordpress.org/themes.

Please do not get discouraged by the ticket being closed. -We want you to resubmit your theme,
but we do ask that you spend more time making sure that your theme meets all the requirements.
https://make.wordpress.org/themes/handbook/review/required/
You can upload your update here: https://wordpress.org/themes/upload/

Because of the large number of themes waiting for review, we might not be able to follow up immediately.
We will review your update when your theme reaches the top of the review queue.

If you have questions you can ask them here or in the #themereview channel on Slack
channel.

Required:
Theme names must not use: WordPress, Theme.

Include all scripts and resources it uses rather than hot-linking. The exception to this is Google Fonts.
-Don't use cdn.
https://themes.svn.wordpress.org/pressforward-turnkey-theme/2.1/assets/functions/enqueue-scripts.php
Reference:
https://make.wordpress.org/themes/handbook/review/required/#stylesheets-and-scripts

Removing and adding dashboard widgets and editing the footer credit is not allowed.
https://themes.svn.wordpress.org/pressforward-turnkey-theme/2.1/assets/functions/admin.php

No removing or modifying non-presentational hooks.
https://themes.svn.wordpress.org/pressforward-turnkey-theme/2.1/assets/functions/cleanup.php
Reference:
https://make.wordpress.org/themes/handbook/review/required/explanations-and-examples/

Changing the login functionality is not allowed.
(You can only style it. Themes are for presentation, don't add functionality that is lost when the user switches themes.)
https://themes.svn.wordpress.org/pressforward-turnkey-theme/2.1/assets/functions/login.php

Provide a unique prefix for everything the Theme defines in the public namespace, including options, functions, global variables, constants, post meta, etc.
These classes needs to be prefixed:
https://themes.svn.wordpress.org/pressforward-turnkey-theme/2.1/assets/functions/menu-walkers.php
function construct_gradient needs to be prefixed:
https://themes.svn.wordpress.org/pressforward-turnkey-theme/2.1/assets/functions/theme-support.php

There are lots of texts in the theme that are missing the translation functions, please check all your files.
See for example https://themes.svn.wordpress.org/pressforward-turnkey-theme/2.1/assets/functions/theme_opts.php
Reference: https://make.wordpress.org/themes/handbook/review/required/#language

Remove all the dummy content such as "Nam pretium magna" as well as the favicons.
The user should not have to clean up the theme to be able to use it.
https://make.wordpress.org/themes/2016/03/31/what-is-demo-content/

Remove jquery from the theme folder. (You need to use the version that is shipped with WordPress.)

Instead of hardcoding <meta charset="utf-8"> please use

<meta charset="<?php bloginfo( 'charset' ); ?>">

You need to escape all your options on output, including color options.


Recommended reading:

https://make.wordpress.org/themes/handbook/review/required/
https://make.wordpress.org/themes/handbook/review/resources/

https://developer.wordpress.org/themes/functionality/internationalization/
https://codex.wordpress.org/Validating_Sanitizing_and_Escaping_User_Data

The coding standards are not required to pass the review, but they can be
helpful when developing your theme.
[https://make.wordpress.org/core/handbook/best-practices/coding-
standards/]

The code reference library is very useful when you want to know more about WordPress functions, classes, hooks and methods.
It can help you determine if a function needs to be escaped or not, or if a function you have planned to write is already available.
https://developer.wordpress.org/reference/

Note: See TracTickets for help on using tickets.