WordPress.org

Make WordPress Themes

Opened 15 months ago

Closed 8 months ago

Last modified 7 months ago

#34842 closed theme (live)

THEME: Education Base – 1.1.3

Reported by: acmethemes Owned by: Diwashc
Priority: new theme Keywords: theme-education-base
Cc: acmethemes@…

Description

Education Base - 0.0.1

Education Base theme is ideal theme for Education sites.

Theme URL - http://www.acmethemes.com/themes/education-base
Author URL - http://www.acmethemes.com/

SVN - https://themes.svn.wordpress.org/education-base/0.0.1
ZIP - https://wordpress.org/themes/download/education-base.0.0.1.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#34842 THEME: Education Base – 1.1.3 closed live Diwashc

(this ticket)

#40927 THEME: Education Base – 1.2.0 closed live themetracbot
#40939 THEME: Education Base – 1.2.1 closed live themetracbot
#40958 THEME: Education Base – 1.2.2 closed live themetracbot
#41048 THEME: Education Base – 1.2.3 closed live themetracbot
#41416 THEME: Education Base – 1.2.4 closed live themetracbot
#41780 THEME: Education Base – 1.2.5 closed live themetracbot
#42049 THEME: Education Base – 1.2.6 closed live themetracbot
#42057 THEME: Education Base – 1.2.7 closed live themetracbot
#42777 THEME: Education Base – 1.2.8 closed live themetracbot
#43227 THEME: Education Base – 1.2.9 closed live themetracbot
#44143 THEME: Education Base – 1.3.0 closed live themetracbot
#45367 THEME: Education Base – 1.4.0 closed live themetracbot


https://themes.svn.wordpress.org/education-base/0.0.1/screenshot.jpg

Change History (21)

#1 @themetracbot
12 months ago

  • Summary changed from THEME: Education Base – 0.0.1 to THEME: Education Base – 1.0.0

Education Base - 1.0.0

Education Base is an attractive, modern, easy to use and responsive WordPress education theme with colorful design and stunning flexibility . This theme is capable of tackling the overall needs of all educational institute websites including universities, colleges, schools and others. Education Base can be also used for business and corporate websites or one page sites. The advanced theme options and available various widgets with drag and drop features will help to customize your site as your need. Some of the available options are awesome slider section, header options, footer options, layout design options, advanced color options, widget options, custom copyright options, integrated social icons, notice bar options and lots of other available options will allow you to create unique website as you want. This theme will help you to create very high quality educational website easily with no time at all. Support Forum: http://www.acmethemes.com/supports/

Theme URL - http://www.acmethemes.com/themes/education-base
Author URL - http://www.acmethemes.com/

SVN - https://themes.svn.wordpress.org/education-base/1.0.0
ZIP - https://wordpress.org/themes/download/education-base.1.0.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=education-base/0.0.1&new_path=education-base/1.0.0

History:

Ticket Summary Status Resolution Owner
#34842 THEME: Education Base – 1.1.3 closed live Diwashc

(this ticket)

#40927 THEME: Education Base – 1.2.0 closed live themetracbot
#40939 THEME: Education Base – 1.2.1 closed live themetracbot
#40958 THEME: Education Base – 1.2.2 closed live themetracbot
#41048 THEME: Education Base – 1.2.3 closed live themetracbot
#41416 THEME: Education Base – 1.2.4 closed live themetracbot
#41780 THEME: Education Base – 1.2.5 closed live themetracbot
#42049 THEME: Education Base – 1.2.6 closed live themetracbot
#42057 THEME: Education Base – 1.2.7 closed live themetracbot
#42777 THEME: Education Base – 1.2.8 closed live themetracbot
#43227 THEME: Education Base – 1.2.9 closed live themetracbot
#44143 THEME: Education Base – 1.3.0 closed live themetracbot
#45367 THEME: Education Base – 1.4.0 closed live themetracbot


https://themes.svn.wordpress.org/education-base/1.0.0/screenshot.jpg

#2 @themetracbot
10 months ago

  • Owner set to Diwashc
  • Status changed from new to reviewing

#3 @themetracbot
10 months ago

  • Summary changed from THEME: Education Base – 1.0.0 to THEME: Education Base – 1.1.0

Education Base - 1.1.0

Education Base is an attractive, modern, easy to use and responsive WordPress education theme with colorful design and stunning flexibility . This theme is capable of tackling the overall needs of all educational institute websites including universities, colleges, schools and others. Education Base can be also used for business and corporate websites or one page sites. The advanced theme options and available various widgets with drag and drop features will help to customize your site as your need. Some of the available options are awesome slider section, header options, footer options, layout design options, advanced color options, widget options, custom copyright options, integrated social icons, notice bar options and lots of other available options will allow you to create unique website as you want. This theme will help you to create very high quality educational website easily with no time at all. Support Forum: http://www.acmethemes.com/supports/

Theme URL - http://www.acmethemes.com/themes/education-base
Author URL - http://www.acmethemes.com/

SVN - https://themes.svn.wordpress.org/education-base/1.1.0
ZIP - https://wordpress.org/themes/download/education-base.1.1.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=education-base/1.0.0&new_path=education-base/1.1.0

History:

Ticket Summary Status Resolution Owner
#34842 THEME: Education Base – 1.1.3 closed live Diwashc

(this ticket)

#40927 THEME: Education Base – 1.2.0 closed live themetracbot
#40939 THEME: Education Base – 1.2.1 closed live themetracbot
#40958 THEME: Education Base – 1.2.2 closed live themetracbot
#41048 THEME: Education Base – 1.2.3 closed live themetracbot
#41416 THEME: Education Base – 1.2.4 closed live themetracbot
#41780 THEME: Education Base – 1.2.5 closed live themetracbot
#42049 THEME: Education Base – 1.2.6 closed live themetracbot
#42057 THEME: Education Base – 1.2.7 closed live themetracbot
#42777 THEME: Education Base – 1.2.8 closed live themetracbot
#43227 THEME: Education Base – 1.2.9 closed live themetracbot
#44143 THEME: Education Base – 1.3.0 closed live themetracbot
#45367 THEME: Education Base – 1.4.0 closed live themetracbot


https://themes.svn.wordpress.org/education-base/1.1.0/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#4 @acmethemes
10 months ago

Hello @Diwashc ,

Thank you for taking our theme for review.
We have updated our theme, please review the latest version 1.1.0 .

Thanks,
Acme Themes

#5 @Diwashc
10 months ago

Hello @acmethemes on fresh install there is js error in the console.
Uncaught Error: Syntax error, unrecognized expression: unsupported pseudo: hover
Please fix the issue.

#6 @themetracbot
10 months ago

  • Summary changed from THEME: Education Base – 1.1.0 to THEME: Education Base – 1.1.1

Education Base - 1.1.1

Education Base is an attractive, modern, easy to use and responsive WordPress education theme with colorful design and stunning flexibility . This theme is capable of tackling the overall needs of all educational institute websites including universities, colleges, schools and others. Education Base can be also used for business and corporate websites or one page sites. The advanced theme options and available various widgets with drag and drop features will help to customize your site as your need. Some of the available options are awesome slider section, header options, footer options, layout design options, advanced color options, widget options, custom copyright options, integrated social icons, notice bar options and lots of other available options will allow you to create unique website as you want. This theme will help you to create very high quality educational website easily with no time at all. Support Forum: http://www.acmethemes.com/supports/

Theme URL - http://www.acmethemes.com/themes/education-base
Author URL - http://www.acmethemes.com/

SVN - https://themes.svn.wordpress.org/education-base/1.1.1
ZIP - https://wordpress.org/themes/download/education-base.1.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=education-base/1.1.0&new_path=education-base/1.1.1

History:

Ticket Summary Status Resolution Owner
#34842 THEME: Education Base – 1.1.3 closed live Diwashc

(this ticket)

#40927 THEME: Education Base – 1.2.0 closed live themetracbot
#40939 THEME: Education Base – 1.2.1 closed live themetracbot
#40958 THEME: Education Base – 1.2.2 closed live themetracbot
#41048 THEME: Education Base – 1.2.3 closed live themetracbot
#41416 THEME: Education Base – 1.2.4 closed live themetracbot
#41780 THEME: Education Base – 1.2.5 closed live themetracbot
#42049 THEME: Education Base – 1.2.6 closed live themetracbot
#42057 THEME: Education Base – 1.2.7 closed live themetracbot
#42777 THEME: Education Base – 1.2.8 closed live themetracbot
#43227 THEME: Education Base – 1.2.9 closed live themetracbot
#44143 THEME: Education Base – 1.3.0 closed live themetracbot
#45367 THEME: Education Base – 1.4.0 closed live themetracbot


https://themes.svn.wordpress.org/education-base/1.1.1/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#7 @acmethemes
10 months ago

Hello @Diwashc ,

We fixed the above mentioned issue and updated the theme, please check :) .

Thanks,
Acme Themes

#8 @Diwashc
10 months ago

@acmethemes
No Image
You have used no-image-400-320.png as a fallback image in slider-section and acme-gallery but the image does not exist.Please add the image or remove the fallback condition in the files you have used this image.

Escaping
Use esc_html instead of esc_attr in content-single,content-recents and content files in line 28,31 and 34.

#9 @themetracbot
10 months ago

  • Summary changed from THEME: Education Base – 1.1.1 to THEME: Education Base – 1.1.2

Education Base - 1.1.2

Education Base is an attractive, modern, easy to use and responsive WordPress education theme with colorful design and stunning flexibility . This theme is capable of tackling the overall needs of all educational institute websites including universities, colleges, schools and others. Education Base can be also used for business and corporate websites or one page sites. The advanced theme options and available various widgets with drag and drop features will help to customize your site as your need. Some of the available options are awesome slider section, header options, footer options, layout design options, advanced color options, widget options, custom copyright options, integrated social icons, notice bar options and lots of other available options will allow you to create unique website as you want. This theme will help you to create very high quality educational website easily with no time at all. Support Forum: http://www.acmethemes.com/supports/

Theme URL - http://www.acmethemes.com/themes/education-base
Author URL - http://www.acmethemes.com/

SVN - https://themes.svn.wordpress.org/education-base/1.1.2
ZIP - https://wordpress.org/themes/download/education-base.1.1.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=education-base/1.1.1&new_path=education-base/1.1.2

History:

Ticket Summary Status Resolution Owner
#34842 THEME: Education Base – 1.1.3 closed live Diwashc

(this ticket)

#40927 THEME: Education Base – 1.2.0 closed live themetracbot
#40939 THEME: Education Base – 1.2.1 closed live themetracbot
#40958 THEME: Education Base – 1.2.2 closed live themetracbot
#41048 THEME: Education Base – 1.2.3 closed live themetracbot
#41416 THEME: Education Base – 1.2.4 closed live themetracbot
#41780 THEME: Education Base – 1.2.5 closed live themetracbot
#42049 THEME: Education Base – 1.2.6 closed live themetracbot
#42057 THEME: Education Base – 1.2.7 closed live themetracbot
#42777 THEME: Education Base – 1.2.8 closed live themetracbot
#43227 THEME: Education Base – 1.2.9 closed live themetracbot
#44143 THEME: Education Base – 1.3.0 closed live themetracbot
#45367 THEME: Education Base – 1.4.0 closed live themetracbot


https://themes.svn.wordpress.org/education-base/1.1.2/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#10 @acmethemes
10 months ago

Hello @Diwashc ,

We fixed the above mentioned issues and updated the theme.

Thanks,
Acme Themes

#11 @Diwashc
10 months ago

  • Status changed from reviewing to approved

#12 @greenshady
8 months ago

I'm taking the admin review of this theme.

#13 @greenshady
8 months ago

  • Status changed from approved to reopened

#14 @greenshady
8 months ago

  • Status changed from reopened to reviewing

The front page issues are the exact same issues that I've covered multiple times in tickets that you've been involved in. I can see this as nothing more than an attempt at working around our front page requirements. Reviewers should not be reporting issues repeatedly with someone who's submitted multiple themes to the directory.

I'm tempted to not approve this ticket on those grounds alone. However, I will continue your review if you correct the following issues.

Slider section

This should not appear on the front page when blog posts are showing.

Hide front page content

This option should not be used to overwrite and hide blog posts when they should appear on the front page.

Home Main Content Area sidebar

This sidebar should not appear when blog posts are to be shown on the front page.

Translatable content

This file has internationalized strings that can't be translated.

  • acmethemes/core/template-tags.php - 18, 24, 30

Missing placeholder for translation

You're missing %1$s in the first (singular) string here:

esc_html( _nx( 'One thought on “%2$s”', '%1$s thoughts on “%2$s”', get_comments_number(), 'comments title', 'education-base' ) ),

Note that One should be replaced with %1$s.

#15 follow-up: @acmethemes
8 months ago

Hello @greenshady ,

Thank you for reviewing our theme. Before updating the theme we have some queries to ask. May be we have some misunderstanding you can solve.

  1. Front Page Setting :

By default WordPress setting is ‘Your latest posts’, at that time the theme shows the latest posts and when user select ‘A static page (select below)’ and choose ‘Front page’, theme shows that selected page content. We think we are doing the same, Please let us know if we are doing anything wrong.

  1. Slider section and Home Main Content Area :

By default theme does not show these areas ( either on latest post or static page ) but later if user want to show these sections they can show or hide by themselves. From this we believe we are giving user some freedom and also respecting rules.

  1. Hide front page content :

By default this option is also unchecked, and theme work according to WordPress core setting. Since this is Education theme and theme also have Widget for blog, user may want to hide front page content( Blog or Static page content). So we added this options. From this we believe we are giving user some freedom and also following rules.

We understood other two points.

About front page and feature section area we were confused and we had asked query in slack too https://wordpress.slack.com/archives/themereview/p1454828533001622 , and we are following the same what we understand from the response. As an author we have disabled every setting by default. We think from the given options the theme will be more useful too, from example : if user want to use theme as blog and want to show slider at top and blog below( many blog theme do ), they can do that, theme may have other possibility too. We just tried to give user more freedom and also following rules by default.

Again thank you for reviewing our theme.

Best Regards,
Acme Themes

#16 in reply to: ↑ 15 @greenshady
8 months ago

  1. Front Page Setting :

That part works OK.

  1. Slider section and Home Main Content Area :

This either needs to be shown when ! is_home() or via a custom page template.

  1. Hide front page content :

Options for hiding the blog posts on the home/posts page is not OK. That breaks the core reading settings. It also breaks plugins that manipulate the query on the home/posts page.

#17 @themetracbot
8 months ago

  • Summary changed from THEME: Education Base – 1.1.2 to THEME: Education Base – 1.1.3

Education Base - 1.1.3

Education Base is an attractive, modern, easy to use and responsive WordPress education theme with colorful design and stunning flexibility . This theme is capable of tackling the overall needs of all educational institute websites including universities, colleges, schools and others. Education Base can be also used for business and corporate websites or one page sites. The advanced theme options and available various widgets with drag and drop features will help to customize your site as your need. Some of the available options are awesome slider section, header options, footer options, layout design options, advanced color options, widget options, custom copyright options, integrated social icons, notice bar options and lots of other available options will allow you to create unique website as you want. This theme will help you to create very high quality educational website easily with no time at all. Support Forum: http://www.acmethemes.com/supports/

Theme URL - http://www.acmethemes.com/themes/education-base
Author URL - http://www.acmethemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/education-base/1.1.3

SVN - https://themes.svn.wordpress.org/education-base/1.1.3
ZIP - https://wordpress.org/themes/download/education-base.1.1.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=education-base/1.1.2&new_path=education-base/1.1.3

History:

Ticket Summary Status Resolution Owner
#34842 THEME: Education Base – 1.1.3 closed live Diwashc

(this ticket)

#40927 THEME: Education Base – 1.2.0 closed live themetracbot
#40939 THEME: Education Base – 1.2.1 closed live themetracbot
#40958 THEME: Education Base – 1.2.2 closed live themetracbot
#41048 THEME: Education Base – 1.2.3 closed live themetracbot
#41416 THEME: Education Base – 1.2.4 closed live themetracbot
#41780 THEME: Education Base – 1.2.5 closed live themetracbot
#42049 THEME: Education Base – 1.2.6 closed live themetracbot
#42057 THEME: Education Base – 1.2.7 closed live themetracbot
#42777 THEME: Education Base – 1.2.8 closed live themetracbot
#43227 THEME: Education Base – 1.2.9 closed live themetracbot
#44143 THEME: Education Base – 1.3.0 closed live themetracbot
#45367 THEME: Education Base – 1.4.0 closed live themetracbot


https://themes.svn.wordpress.org/education-base/1.1.3/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#18 @acmethemes
8 months ago

Hello @greenshady ,

We have updated the theme according to your review. We are waiting for your further review.

Best Regards,
Acme Themes

#19 @greenshady
8 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

The diff looks good.

#20 @acmethemes
7 months ago

@greenshady Thank you for setting our theme live.
@Diwashc Thank you.

This ticket was mentioned in Slack in #themereview by kafleg. View the logs.


7 months ago

Note: See TracTickets for help on using tickets.