WordPress.org

Make WordPress Themes

Opened 8 months ago

Closed 8 days ago

#34978 closed theme (live)

THEME: Delight Spa – 2.3.4

Reported by: themesware Owned by: dragonlit
Priority: new theme Keywords: theme-delight-spa
Cc: magiclines.com@…

Description

Delight Spa - 2.0

Delight theme is responsive Salon and Spa WordPress theme. It is Designed for Corporates, Beauty Industries, eCommerce websites, Medical Industries etc. This theme comes with the great features and easy content management system. This theme is best solution for your websites. This theme is compatible with the latest version of WordPress. This theme is fully responsive working well with all the resolutions. Check demo at: http://themesware.com/demo/delight/

Theme URL - https://themesware.com/product/delight-wordpress-theme/
Author URL - http://themesware.com/

SVN - https://themes.svn.wordpress.org/delight-spa/2.0
ZIP - https://wordpress.org/themes/download/delight-spa.2.0.zip?nostats=1

History:


https://themes.svn.wordpress.org/delight-spa/2.0/screenshot.jpg

Change History (39)

#1 @themetracbot
3 months ago

  • Summary changed from THEME: Delight Spa – 2.0 to THEME: Delight Spa – 2.1

Delight Spa - 2.1

Delight Spa theme is responsive Salon and Spa WordPress theme. It is Designed for Corporates, Beauty Industries, eCommerce websites, Medical Industries etc. This theme comes with the great features and easy content management system. This theme is best solution for your websites. This theme is compatible with the latest version of WordPress. This theme is fully responsive working well with all the resolutions. Check demo at: http://themesware.com/demo/delight-spa/

Theme URL - http://themesware.com/product/delight-spa/
Author URL - http://themesware.com/

SVN - https://themes.svn.wordpress.org/delight-spa/2.1
ZIP - https://wordpress.org/themes/download/delight-spa.2.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=delight-spa/2.0&new_path=delight-spa/2.1

History:


https://themes.svn.wordpress.org/delight-spa/2.1/screenshot.jpg

#2 @themetracbot
3 months ago

  • Owner set to dragonlit
  • Status changed from new to reviewing

#3 @dragonlit
3 months ago

From the theme check:
REQUIRED: This theme text domain does not match the theme's slug. The text domain used: delightThis theme's correct slug and text-domain is delight-spa.
INFO: Only one text-domain is being used in this theme. Make sure it matches the theme's slug correctly so that the theme will be compatible with WordPress.org language packs.
The domain found is delight

#4 @dragonlit
3 months ago

On line 201 of the style.css file, there is a ":" missing for the css rule. Also, line 72 of the functions.php file is an enqueued style file that doesn't appear to be included in the theme.

#5 @dragonlit
3 months ago

The theme's slug and text-domain must be corrected in order for this theme to be approved. It may be a good idea to change the "delight" prefix in the php to "delight-spa" as well. However, per the guidelines, only the text domain must be corrected for the theme to be reviewed. Please update.

#6 @themesware
3 months ago

Hello @dragonlit
Thanks for review. I am doing the chnages and will upload tomorrow.

Thanks.

#7 @themetracbot
3 months ago

  • Summary changed from THEME: Delight Spa – 2.1 to THEME: Delight Spa – 2.2.0

Delight Spa - 2.2.0

Delight Spa theme is responsive Salon and Spa WordPress theme. It is Designed for Corporates, Beauty Industries, eCommerce websites, Medical Industries etc. This theme comes with the great features and easy content management system. This theme is best solution for your websites. This theme is compatible with the latest version of WordPress. This theme is fully responsive working well with all the resolutions. Check demo at: http://themesware.com/demo/delight-spa/

Theme URL - http://themesware.com/product/delight-spa/
Author URL - http://themesware.com/

SVN - https://themes.svn.wordpress.org/delight-spa/2.2.0
ZIP - https://wordpress.org/themes/download/delight-spa.2.2.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=delight-spa/2.1&new_path=delight-spa/2.2.0

History:


https://themes.svn.wordpress.org/delight-spa/2.2.0/screenshot.png

#8 @themesware
3 months ago

Hello @dragonlit

I have done the suggested changes. Please proceed with the review.
Thanks for your precious time.

Thanks.

#9 @dragonlit
3 months ago

Thank you for your submission. I am new to the reviewing myself and am noticing how long it is taking to have a theme make it into the repository. I hope to help review many themes the next year.

The theme check now passes, however, on line 47 of functions.php, the name of the function should be changed to Delight_spa_customize_sec_upsell. I notice you missed the "spa" in the prefix. It breaks the customizer as it can't be called on line 86. Also, there is another css error in /css/customize-controls.min.css. There appears to be an extra "." at the start of the file.

I didn't find any other broken prefixes. After I updated the error on line 47, the theme appeared operational.

Please update to fix the customizer and approve.

#10 @dragonlit
3 months ago

Please, correct line 47 of functions.php to fix the customizer and I can approve this theme. The customizer must be operational in order for the theme to be approved. I will close this ticket on December 30, at 7:30 pm UTC if this correction is not made.
I will make this request each day until close or the update is made.

#11 @themetracbot
3 months ago

  • Summary changed from THEME: Delight Spa – 2.2.0 to THEME: Delight Spa – 2.3.0

Delight Spa - 2.3.0

Delight Spa theme is responsive Salon and Spa WordPress theme. It is Designed for Corporates, Beauty Industries, eCommerce websites, Medical Industries etc. This theme comes with the great features and easy content management system. This theme is best solution for your websites. This theme is compatible with the latest version of WordPress. This theme is fully responsive working well with all the resolutions. Check demo at: http://themesware.com/demo/delight-spa/

Theme URL - http://themesware.com/product/delight-spa/
Author URL - http://themesware.com/

SVN - https://themes.svn.wordpress.org/delight-spa/2.3.0
ZIP - https://wordpress.org/themes/download/delight-spa.2.3.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=delight-spa/2.2.0&new_path=delight-spa/2.3.0

History:


https://themes.svn.wordpress.org/delight-spa/2.3.0/screenshot.png

#12 @themesware
3 months ago

Hello @dragonlit ,

Thanks for taking your precious time for review. I have fixed the errors, please proceed with further review.

Thanks.

#13 @dragonlit
3 months ago

Thank you for the update. The customizer preview is now not working. I'm not sure why, but I get this in the console:

Refused to display 'http://localhost:3000/wordpress/?customize_changeset_uuid=dbcd8738-2a74-41c…9bfb2f7a&customize_theme=delight-spa&customize_messenger_channel=preview-0' in a frame because an ancestor violates the following Content Security Policy directive: "frame-ancestors http://localhost".

However, the controls inside the customizer do work. I will leave this as reviewing until December 30, at 7:30 pm UTC to give you a chance to correct it. If changes are not made, I will still approve the theme, as the requirements don't specifically say that it must be working.

#14 @themesware
3 months ago

Hello @dragonlit ,
I am doing the changes and will submit asap. Please don't close the ticket. Already my two tickets got closed without review. I have waited 5 months for this to come into review.if this get closed I will again have to wait for 5 more months. So one theme approval will take around 10 months. I am doing it asap.

Thank you.

#15 @themesware
3 months ago

Hello @dragonlit ,

I have checked the theme and the theme customizer preview is working fine. Please approve the theme and hope admin will also approve this. Thanks for your precious time.

Thanks.

#16 @dragonlit
3 months ago

  • Status changed from reviewing to approved

Sorry for the wait. I am approving. Congratulations. I sincerely hope I will be able to help the WordPress organization speed up the process in the future.

#17 @greenshady
3 weeks ago

I'm taking the admin review for this theme.

#18 @greenshady
3 weeks ago

  • Status changed from approved to reopened

#19 @greenshady
3 weeks ago

  • Owner changed from dragonlit to themesware
  • Status changed from reopened to reviewing

There's a few items that need to be cleaned up before this theme can go live.

Broken content filter

This filter hook in header.php breaks plugins:

$content = apply_filters('the_content', substr(strip_tags($post->post_content), 0, 160));

For a full explanation: http://themehybrid.com/weblog/how-to-apply-content-filters

The "Buy Pro" link in the customizer just links to #.

"Hide Slider" setting mismatch

I'm sure this is just a mistake, but the "Hide Slider" option is disabled by default in header.php. However, the default in the customizer is for it to be enabled. Basically, the two things don't match, so what you get is the wrong thing by default.

Slider Demo Content

The slider demo content needs to be removed. You can use the user's existing posts/pages if you want to display something or use core WP's starter content.

Missing copyright info

The copyright information for these are missing in readme.txt:

1 - All js that have been used are within folder /js of theme.
- jquery.nivo.slider.js is licensed under MIT.
- html5.js is dual licensed under MIT and GPL2
- bootstrap license under MIT
Link: https://github.com/twbs/bootstrap/blob/master/LICENSE

2 - Allura,DroidSansMono,Damion fonts which all are licensed under the SIL Open Font License(http://scripts.sil.org/OFL)

Make sure to link to each script where it can be found and list the copyright information. Here's a tutorial on how to properly do this: https://make.wordpress.org/themes/2014/07/08/proper-copyrightlicense-attribution-for-themes/

You're missing the copyright and license information for the "upsell section" code in inc/customizer.php. You can grab that info here: https://github.com/justintadlock/trt-customizer-pro#copyright-and-license

You're also missing the copyright and license info for the 4 images under "Our Services" within the screenshot.

Screenshot

In the screenshot, there's a section called "Our Services". However, I can't seem to figure out how to get that section to appear.

#20 @themesware
3 weeks ago

Hello Sir @greenshady ,

Thanks for taking time for review.

I am doing the changes and will update tomorrow.

Thanks.

#21 @themetracbot
2 weeks ago

  • Summary changed from THEME: Delight Spa – 2.3.0 to THEME: Delight Spa – 2.3.1

Delight Spa - 2.3.1

Delight Spa theme is responsive Salon and Spa WordPress theme. It is Designed for Corporates, Beauty Industries, eCommerce websites, Medical Industries etc. This theme comes with the great features and easy content management system. This theme is best solution for your websites. This theme is compatible with the latest version of WordPress. This theme is fully responsive working well with all the resolutions. Check demo at: http://themesware.com/demo/delight-spa/

Theme URL - http://themesware.com/product/delight-spa/
Author URL - http://themesware.com/

Trac Browser - https://themes.trac.wordpress.org/browser/delight-spa/2.3.1

SVN - https://themes.svn.wordpress.org/delight-spa/2.3.1
ZIP - https://wordpress.org/themes/download/delight-spa.2.3.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=delight-spa/2.3.0&new_path=delight-spa/2.3.1

History:


https://themes.svn.wordpress.org/delight-spa/2.3.1/screenshot.jpg

#22 @themesware
2 weeks ago

@greenshady ,

Hello Sir,

I have done the changes, please take a time to review it. Hope this time all is fine.

Thanks.

#23 @greenshady
2 weeks ago

Broken content filter

Why did you comment out this code in header.php instead of just deleting it?

//$content = apply_filters('the_content', substr(strip_tags($post->post_content), 0, 3));

Slider Demo Content

This was not fixed.

Licensing

This license is not correct:

* Upsell section for the customizer
 	Copyright (C) 2016 Justin Tadlock. https://github.com/justintadlock/trt-customizer-pro
 	Licensed under the GNU GENERAL PUBLIC LICENSE

It's GPL 2 or later (GPL 2+). If you'd just link to the appropriate license, it'd be correct. http://www.gnu.org/licenses/old-licenses/gpl-2.0.html

#24 @themetracbot
2 weeks ago

  • Summary changed from THEME: Delight Spa – 2.3.1 to THEME: Delight Spa – 2.3.2

Delight Spa - 2.3.2

Delight Spa theme is responsive Salon and Spa WordPress theme. It is Designed for Corporates, Beauty Industries, eCommerce websites, Medical Industries etc. This theme comes with the great features and easy content management system. This theme is best solution for your websites. This theme is compatible with the latest version of WordPress. This theme is fully responsive working well with all the resolutions. Check demo at: http://themesware.com/demo/delight-spa/

Theme URL - http://themesware.com/product/delight-spa/
Author URL - http://themesware.com/

Trac Browser - https://themes.trac.wordpress.org/browser/delight-spa/2.3.2

SVN - https://themes.svn.wordpress.org/delight-spa/2.3.2
ZIP - https://wordpress.org/themes/download/delight-spa.2.3.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=delight-spa/2.3.1&new_path=delight-spa/2.3.2

History:


https://themes.svn.wordpress.org/delight-spa/2.3.2/screenshot.jpg

#25 @themesware
2 weeks ago

@greenshady
Dear Sir,

I have fixed the changes. Please proceed with the review. Hope all is well this time and this theme is able to be made live.

Thanks.

#26 @themetracbot
2 weeks ago

  • Summary changed from THEME: Delight Spa – 2.3.2 to THEME: Delight Spa – 2.3.3

Delight Spa - 2.3.3

Delight Spa theme is responsive Salon and Spa WordPress theme. It is Designed for Corporates, Beauty Industries, eCommerce websites, Medical Industries etc. This theme comes with the great features and easy content management system. This theme is best solution for your websites. This theme is compatible with the latest version of WordPress. This theme is fully responsive working well with all the resolutions. Check demo at: http://themesware.com/demo/delight-spa/

Theme URL - http://themesware.com/product/delight-spa/
Author URL - http://themesware.com/

Trac Browser - https://themes.trac.wordpress.org/browser/delight-spa/2.3.3

SVN - https://themes.svn.wordpress.org/delight-spa/2.3.3
ZIP - https://wordpress.org/themes/download/delight-spa.2.3.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=delight-spa/2.3.2&new_path=delight-spa/2.3.3

History:


https://themes.svn.wordpress.org/delight-spa/2.3.3/screenshot.jpg

#27 @themesware
2 weeks ago

  • Status changed from reviewing to approved

All things are fixed now.

Thanks.

#28 @themesware
2 weeks ago

Hi @greenshady ,

Please take a look and make theme live.

Thanks.

#29 @themesware
11 days ago

Hello @greenshady ,
Sir, I have to waited long for this theme to be reviewed. I have done the changes you said. Please approve the theme and make it live. Please don't let me wait for another two months. I have waited 5 months for review and more two months for admin review. Please check and approve the theme.

Thanks

#30 @greenshady
11 days ago

  • Status changed from approved to reopened

Why do you have a second copy of the theme within the /delight-spa folder within the theme? See: https://themes.svn.wordpress.org/delight-spa/2.3.3/delight-spa/

Last edited 11 days ago by greenshady (previous) (diff)

#31 @greenshady
11 days ago

  • Owner changed from themesware to dragonlit
  • Status changed from reopened to reviewing

#32 @themesware
11 days ago

Hello @greenshady ,
Ohh sorry that is by mistake.please make it open folder, I mean directly as folder and remove the upper folder. And please review further. I have set all thing correctly now.
Thanks

#33 @greenshady
11 days ago

All that was left was for you to remove the demo content, which it looks like you've done: https://themes.trac.wordpress.org/changeset?old_path=delight-spa/2.3.2&new_path=delight-spa/2.3.3#file81

Other than correcting the theme-within-a-theme mistake, it's ready to go.

#34 @themesware
10 days ago

Thanks @greenshady ,
I will do it submit.

Thanks.

#35 @themetracbot
10 days ago

  • Summary changed from THEME: Delight Spa – 2.3.3 to THEME: Delight Spa – 2.3.4

Delight Spa - 2.3.4

Delight Spa theme is responsive Salon and Spa WordPress theme. It is Designed for Corporates, Beauty Industries, eCommerce websites, Medical Industries etc. This theme comes with the great features and easy content management system. This theme is best solution for your websites. This theme is compatible with the latest version of WordPress. This theme is fully responsive working well with all the resolutions. Check demo at: http://themesware.com/demo/delight-spa/

Theme URL - http://themesware.com/product/delight-spa/
Author URL - http://themesware.com/

Trac Browser - https://themes.trac.wordpress.org/browser/delight-spa/2.3.4

SVN - https://themes.svn.wordpress.org/delight-spa/2.3.4
ZIP - https://wordpress.org/themes/download/delight-spa.2.3.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=delight-spa/2.3.3&new_path=delight-spa/2.3.4

History:


https://themes.svn.wordpress.org/delight-spa/2.3.4/screenshot.jpg

#36 @themesware
10 days ago

Hello @greenshady .
Every thing is done now. As last discussion only folder was there inside the folder. Now all is perfect, please make it live sir.

Thanks.

#37 @themesware
9 days ago

@greenshady ,
Hello Sir,
My theme shows still reviewing. As only one small thing was left which I corrected and this is ready. Please have a look and make it live. Else it will become approved and then again will placed in queue and I have to wait more 2 months again. I have really waited more than 7 months. Please review and approve it sir.

Thanks

This ticket was mentioned in Slack in #themereview by themesware. View the logs.


9 days ago

#39 @greenshady
8 days ago

  • Resolution set to live
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.