WordPress.org

Make WordPress Themes

Opened 8 months ago

Closed 3 weeks ago

#35099 closed theme (live)

THEME: Personal lite – 1.0.10

Reported by: ponvendhan Owned by: mzwillus
Priority: new theme Keywords: theme-personal-lite
Cc: ponvendhan@…

Description

Personal lite - 1.0.0

Personal is a simple light weight, minimal, responsive, elegant theme for personal bloggers. Full width content feature gives a vast place to show content to website reader.

Theme URL - http://www.ammuthemes.com/downloads/personal
Author URL - http://www.ammuthemes.com

SVN - https://themes.svn.wordpress.org/personal-lite/1.0.0
ZIP - https://wordpress.org/themes/download/personal-lite.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#35099 THEME: Personal lite – 1.0.10 closed live mzwillus

(this ticket)

#40892 THEME: Personal lite – 1.0.11 closed live themetracbot
#40997 THEME: Personal lite – 1.0.12 closed live themetracbot


https://themes.svn.wordpress.org/personal-lite/1.0.0/screenshot.png

Change History (27)

#1 @themetracbot
4 months ago

  • Summary changed from THEME: Personal lite – 1.0.0 to THEME: Personal lite – 1.0.1

Personal lite - 1.0.1

Personal is a simple light weight, minimal, responsive, elegant theme for personal bloggers. Full width content feature gives a vast place to show content to website reader.

Theme URL -
Author URL -

SVN - https://themes.svn.wordpress.org/personal-lite/1.0.1
ZIP - https://wordpress.org/themes/download/personal-lite.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=personal-lite/1.0.0&new_path=personal-lite/1.0.1

History:

Ticket Summary Status Resolution Owner
#35099 THEME: Personal lite – 1.0.10 closed live mzwillus

(this ticket)

#40892 THEME: Personal lite – 1.0.11 closed live themetracbot
#40997 THEME: Personal lite – 1.0.12 closed live themetracbot


https://themes.svn.wordpress.org/personal-lite/1.0.1/screenshot.png

#2 @ponvendhan
3 months ago

Working on an update. Will upload within two days.

#3 @themetracbot
3 months ago

  • Summary changed from THEME: Personal lite – 1.0.1 to THEME: Personal lite – 1.0.2

Personal lite - 1.0.2

Personal is a simple light weight, minimal, responsive, elegant theme for personal bloggers. Full width content feature gives a vast place to show content to website reader.

Theme URL -
Author URL -

SVN - https://themes.svn.wordpress.org/personal-lite/1.0.2
ZIP - https://wordpress.org/themes/download/personal-lite.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=personal-lite/1.0.1&new_path=personal-lite/1.0.2

History:

Ticket Summary Status Resolution Owner
#35099 THEME: Personal lite – 1.0.10 closed live mzwillus

(this ticket)

#40892 THEME: Personal lite – 1.0.11 closed live themetracbot
#40997 THEME: Personal lite – 1.0.12 closed live themetracbot


https://themes.svn.wordpress.org/personal-lite/1.0.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: Theme URI: is missing from your style.css header.
  • RECOMMENDED: Author URI: is missing from your style.css header.

#4 @themetracbot
3 months ago

  • Summary changed from THEME: Personal lite – 1.0.2 to THEME: Personal lite – 1.0.3

Personal lite - 1.0.3

Personal is a simple light weight, minimal, responsive, elegant theme for personal bloggers. Full width content feature gives a vast place to show content to website reader.

Theme URL -
Author URL -

SVN - https://themes.svn.wordpress.org/personal-lite/1.0.3
ZIP - https://wordpress.org/themes/download/personal-lite.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=personal-lite/1.0.2&new_path=personal-lite/1.0.3

History:

Ticket Summary Status Resolution Owner
#35099 THEME: Personal lite – 1.0.10 closed live mzwillus

(this ticket)

#40892 THEME: Personal lite – 1.0.11 closed live themetracbot
#40997 THEME: Personal lite – 1.0.12 closed live themetracbot


https://themes.svn.wordpress.org/personal-lite/1.0.3/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: Theme URI: is missing from your style.css header.
  • RECOMMENDED: Author URI: is missing from your style.css header.

#5 @themetracbot
3 months ago

  • Summary changed from THEME: Personal lite – 1.0.3 to THEME: Personal lite – 1.0.4

Personal lite - 1.0.4

Personal is a simple lite weight, minimal, responsive, elegant theme for personal bloggers. Full width content feature gives a vast place to show content to website reader.

Theme URL -
Author URL -

SVN - https://themes.svn.wordpress.org/personal-lite/1.0.4
ZIP - https://wordpress.org/themes/download/personal-lite.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=personal-lite/1.0.3&new_path=personal-lite/1.0.4

History:

Ticket Summary Status Resolution Owner
#35099 THEME: Personal lite – 1.0.10 closed live mzwillus

(this ticket)

#40892 THEME: Personal lite – 1.0.11 closed live themetracbot
#40997 THEME: Personal lite – 1.0.12 closed live themetracbot


https://themes.svn.wordpress.org/personal-lite/1.0.4/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: Theme URI: is missing from your style.css header.
  • RECOMMENDED: Author URI: is missing from your style.css header.

#6 @themetracbot
3 months ago

  • Owner set to mzwillus
  • Status changed from new to reviewing

#7 @mzwillus
3 months ago

Good evening,
please note this is not a full review yet.

WP_DEBUG returned that $custom_css was undefined on line 137 in functions.php

wp_add_inline_style( 'personal-lite-style', $custom_css );

It appeared after installation, but when I changed the background-color from gray to green in the customizer it disappeared. I couldn't get the error back.

Recommendation

Add your Theme URI and Author URI to the style.css comment section.
Put your licensing information into a license.txt instead of your readme.txt.

Kind regards
Malte

#8 @themetracbot
3 months ago

  • Summary changed from THEME: Personal lite – 1.0.4 to THEME: Personal lite – 1.0.5

Personal lite - 1.0.5

Personal is a simple lite weight, minimal, responsive, elegant theme for personal bloggers. Full width content feature gives a vast place to show content to website reader.

Theme URL -
Author URL -

SVN - https://themes.svn.wordpress.org/personal-lite/1.0.5
ZIP - https://wordpress.org/themes/download/personal-lite.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=personal-lite/1.0.4&new_path=personal-lite/1.0.5

History:

Ticket Summary Status Resolution Owner
#35099 THEME: Personal lite – 1.0.10 closed live mzwillus

(this ticket)

#40892 THEME: Personal lite – 1.0.11 closed live themetracbot
#40997 THEME: Personal lite – 1.0.12 closed live themetracbot


https://themes.svn.wordpress.org/personal-lite/1.0.5/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: Theme URI: is missing from your style.css header.
  • RECOMMENDED: Author URI: is missing from your style.css header.

#9 @ponvendhan
3 months ago

@mzwillus Thanks for taking time to review my theme. Please continue your review with latest update.

  1. $custom_css undefined error fixed.

About your recommends

Theme url and author url are left blank because I have no website to link. I will create my website in few months and will point it.

Regarding the License. I think it is not necessary to add a separate license.txt if I add a license url on style.css.

Thank you!

#10 @themetracbot
3 months ago

  • Summary changed from THEME: Personal lite – 1.0.5 to THEME: Personal lite – 1.0.6

Personal lite - 1.0.6

Personal is a simple lite weight, minimal, responsive, elegant theme for personal bloggers. Full width content feature gives a vast place to show content to website reader.

Theme URL -
Author URL -

SVN - https://themes.svn.wordpress.org/personal-lite/1.0.6
ZIP - https://wordpress.org/themes/download/personal-lite.1.0.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=personal-lite/1.0.5&new_path=personal-lite/1.0.6

History:

Ticket Summary Status Resolution Owner
#35099 THEME: Personal lite – 1.0.10 closed live mzwillus

(this ticket)

#40892 THEME: Personal lite – 1.0.11 closed live themetracbot
#40997 THEME: Personal lite – 1.0.12 closed live themetracbot


https://themes.svn.wordpress.org/personal-lite/1.0.6/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: Theme URI: is missing from your style.css header.
  • RECOMMENDED: Author URI: is missing from your style.css header.

#11 @themetracbot
3 months ago

  • Summary changed from THEME: Personal lite – 1.0.6 to THEME: Personal lite – 1.0.7

Personal lite - 1.0.7

Personal is a simple lite weight, minimal, responsive, elegant theme for personal bloggers. Full width content feature gives a vast place to show content to website reader.

Theme URL -
Author URL -

SVN - https://themes.svn.wordpress.org/personal-lite/1.0.7
ZIP - https://wordpress.org/themes/download/personal-lite.1.0.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=personal-lite/1.0.6&new_path=personal-lite/1.0.7

History:

Ticket Summary Status Resolution Owner
#35099 THEME: Personal lite – 1.0.10 closed live mzwillus

(this ticket)

#40892 THEME: Personal lite – 1.0.11 closed live themetracbot
#40997 THEME: Personal lite – 1.0.12 closed live themetracbot


https://themes.svn.wordpress.org/personal-lite/1.0.7/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: Theme URI: is missing from your style.css header.
  • RECOMMENDED: Author URI: is missing from your style.css header.

This ticket was mentioned in Slack in #themereview by mzwillus. View the logs.


3 months ago

#13 @mzwillus
3 months ago

Good afternoon,
correct me if I'm wrong, but you declared your Theme-URI and Author-URI in your readme.txt.

I recommend putting your Theme-URI and Author-URI from readme.txt into style.css.
Also I suggest putting those licensing information into a license.txt:

### Licenses ###
================

=> Font awesome
	Code License: The MIT License (MIT)
	Font License: SIL OFL 1.1
	License url: http://fontawesome.io/license/

=> Twitter Bootstrap framework
	url: http://getbootstrap.com/
	License: The MIT License (MIT)
	License url: https://github.com/twbs/bootstrap/blob/master/LICENSE

=> Slicknav navgation plugin
	License: The MIT License (MIT)
	License url: https://github.com/ComputerWolf/SlickNav/blob/master/MIT-LICENSE.txt

=> Google font - Titillium Web
	License: SIL Open Font License, 1.1
	License url: https://www.google.com/fonts/specimen/Titillium+Web

=> Google font - Sonsie one
	Thanks to : Riccardo De Franceschi
	License: SIL Open Font License, 1.1
	License url: https://www.google.com/fonts/specimen/Sonsie+One	

=> Image used on screenshot taken from Stocksnap	
	Thanks to: Damian Zaleski
	License: CC0 License
	url: https://stocksnap.io/photo/BA9AFFE0BF
	License url: https://stocksnap.io/license

I'll get back to you when I see something that needs changes.

Kind regards
Malte

#14 @mzwillus
3 months ago

Hey,

header.php

I've found following code:

<?php $topmenu = wp_nav_menu (
        array(  'theme_location' => 'pagenav',
                'menu_class' => 'navi',
                'items_wrap' => '<ul id="menu" class="%2$s">%3$s</ul>',
                'echo' => false));
        echo $topmenu;
?>

You didn't use $topmenu anywhere else. Couldn't you run wp_nav_menu() without assigning it to a variable?
I'm thinking about something like that:

<?php echo wp_nav_menu(
        array(
                'theme_location' => 'pagenav',
                'menu_class' => 'navi',
                'items_wrap' => '<ul id="menu" class="%2$s">%3$s</ul>',
                'echo' => false));
?>

I found two files which aren't in use.

/js folder

Those files aren't in use.

js\bootstrap.js
js\jquery.slicknav.js

Please remove them if they aren't required.

Kind regards
Malte

#15 @themetracbot
3 months ago

  • Summary changed from THEME: Personal lite – 1.0.7 to THEME: Personal lite – 1.0.8

Personal lite - 1.0.8

Personal is a simple lite weight, minimal, responsive, elegant theme for personal bloggers. Full width content feature gives a vast place to show content to website reader.

Theme URL -
Author URL -

SVN - https://themes.svn.wordpress.org/personal-lite/1.0.8
ZIP - https://wordpress.org/themes/download/personal-lite.1.0.8.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=personal-lite/1.0.7&new_path=personal-lite/1.0.8

History:

Ticket Summary Status Resolution Owner
#35099 THEME: Personal lite – 1.0.10 closed live mzwillus

(this ticket)

#40892 THEME: Personal lite – 1.0.11 closed live themetracbot
#40997 THEME: Personal lite – 1.0.12 closed live themetracbot


https://themes.svn.wordpress.org/personal-lite/1.0.8/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: Theme URI: is missing from your style.css header.
  • RECOMMENDED: Author URI: is missing from your style.css header.

#16 @ponvendhan
3 months ago

Hi @mzwillus Good afternoon.

  1. Theme-URI and Author-URI are removed from reedme.txt too.
  2. Regarding your suggestion to add a license.txt. I still believe it is not needed to add one. Please refer how lead reviewer @acosmin did in his newest theme businessx. https://themes.svn.wordpress.org/businessx/1.0.5.4/readme.txt
  3. wp_nav_menu on header fixed. That happens when you follow every step from a tutorial :)
  4. About your suggestion about removing unused files, those are non minified versions for enqueue scripts. Please refer this reviewers handbook - point 2 https://make.wordpress.org/themes/handbook/review/required/#stylesheets-and-scripts

Please let me know if you find any issues.
Thank you

#17 @mzwillus
3 months ago

Hi @ponvendhan,

1) Thank you
2) I did not say that it's required.

3) Please check your primary navigation.

You don't echo the wp_nav_menu() which returns in no menu. I also tried to set a primary menu which didn't give me another result.

http://i.imgur.com/zlUv7K1.jpg

I did a little workaround:

<?php echo wp_nav_menu(
        array(
                'theme_location' => 'pagenav',
                'menu_class' => 'navi',
                'items_wrap' => '<ul id="menu" class="%2$s">%3$s</ul>',
                'echo' => false));
?>

Thank you for clarification on issue 4. I didn't know that before :)

Kind regards
Malte

#18 @themetracbot
3 months ago

  • Summary changed from THEME: Personal lite – 1.0.8 to THEME: Personal lite – 1.0.9

Personal lite - 1.0.9

Personal is a simple lite weight, minimal, responsive, elegant theme for personal bloggers. Full width content feature gives a vast place to show content to website reader.

Theme URL -
Author URL -

SVN - https://themes.svn.wordpress.org/personal-lite/1.0.9
ZIP - https://wordpress.org/themes/download/personal-lite.1.0.9.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=personal-lite/1.0.8&new_path=personal-lite/1.0.9

History:

Ticket Summary Status Resolution Owner
#35099 THEME: Personal lite – 1.0.10 closed live mzwillus

(this ticket)

#40892 THEME: Personal lite – 1.0.11 closed live themetracbot
#40997 THEME: Personal lite – 1.0.12 closed live themetracbot


https://themes.svn.wordpress.org/personal-lite/1.0.9/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: Theme URI: is missing from your style.css header.
  • RECOMMENDED: Author URI: is missing from your style.css header.

#19 @ponvendhan
3 months ago

Hey @mzwillus
Navigation menu error fixed. Sorry for confusion,

Regards,
Ponvendhan.

#20 @mzwillus
3 months ago

  • Status changed from reviewing to approved

Ah, yes. This works.

Another suggestion:
You don't need to escape the_permalink() function, since it's already escaped.
https://developer.wordpress.org/reference/functions/the_permalink/

Thank you for your cooperation. I'll put you in another queue, where a key reviewer will review your theme finally.

Kind regards
Malte

#21 @ponvendhan
3 months ago

Ahh, awesome @mzwillus
Thanks for your review. I will remove the escape function in future update.

Regards
Ponvendhan

#22 @greenshady
3 weeks ago

I'm taking the admin review for this theme.

#23 @greenshady
3 weeks ago

  • Status changed from approved to reopened

This theme is pretty much ready to go. Most of the issues are fairly trivial and shouldn't take long to correct.

Theme URI and Author URI

Both of these are giving me 404 errors.

Background

You need to use the core WordPress custom-background feature instead of a custom-coded background feature.

Customizer select callback

I'm a fan of whitelisting for sanitization. However, this function should be broken into two separate functions:

function personal_lite_select_callback($input) {
    $valid = array(
        'lightslategrey' => esc_html__('Grey', 'personal-lite'),
        'seagreen' => esc_html__('Green', 'personal-lite'),
        'enable' => esc_html__('Enable', 'personal-lite'),
        'disable' => esc_html__('Disable', 'personal-lite'),
    );
    if (array_key_exists($input, $valid)) {
        return $input;
    } else {
        return '';
    }
}

Only some settings can have some of those keys. Make sure the setting is valid by using the appropriate whitelist function for that setting.

User-selected date/time

In your templates that display posts, you should use the user-defined date format:

<?php the_time('F j, Y'); ?>

Instead, that should look like:

<?php the_time( get_option( 'date_format' ) ); ?>

the_permalink() outputs the permalink (already escaped). Therefore, wrapping it with esc_url() will not work. The following needs to have esc_url() removed in multiple templates:

<div class="readmore-a"><a href="<?php esc_url(the_permalink ()); ?>"><?php echo __('Read more', 'personal-lite'); ?></a></div>

#24 @greenshady
3 weeks ago

  • Status changed from reopened to reviewing

#25 @themetracbot
3 weeks ago

  • Summary changed from THEME: Personal lite – 1.0.9 to THEME: Personal lite – 1.0.10

Personal lite - 1.0.10

Personal is a simple lite weight, minimal, responsive, elegant theme for personal bloggers. Full width content feature gives a vast place to show content to website reader.

Theme URL -
Author URL -

Trac Browser - https://themes.trac.wordpress.org/browser/personal-lite/1.0.10

SVN - https://themes.svn.wordpress.org/personal-lite/1.0.10
ZIP - https://wordpress.org/themes/download/personal-lite.1.0.10.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=personal-lite/1.0.9&new_path=personal-lite/1.0.10

History:

Ticket Summary Status Resolution Owner
#35099 THEME: Personal lite – 1.0.10 closed live mzwillus

(this ticket)

#40892 THEME: Personal lite – 1.0.11 closed live themetracbot
#40997 THEME: Personal lite – 1.0.12 closed live themetracbot


https://themes.svn.wordpress.org/personal-lite/1.0.10/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: Theme URI: is missing from your style.css header.
  • RECOMMENDED: Author URI: is missing from your style.css header.

#26 @ponvendhan
3 weeks ago

@greenshady Thanks for reviewing my theme. I have fixed the all issues you mentioned.

  1. Theme URL & Author URL are removed as I don't have a website now. It is okey to leave it blank, right?
  2. Own background settings removed and implemented custom-background as you said.
  3. Customizer select callback function fixed.
  4. Date format issue fixed on all template files.
  5. Escape function removed for the_permalink() on template files.

Thankgs,
Ponvendhan

#27 @greenshady
3 weeks ago

  • Resolution set to live
  • Status changed from reviewing to closed

Looks good to me.

Also, for your Author URI, you can use your social profile link, such as Facebook, Twitter, etc.

Note: See TracTickets for help on using tickets.