WordPress.org

Make WordPress Themes

Opened 16 months ago

Closed 11 months ago

Last modified 11 months ago

#35127 closed theme (live)

THEME: Napoli – 1.0.5

Reported by: ThemeZee Owned by: rabmalin
Priority: new theme Keywords: theme-napoli
Cc: contact@…

Description

Napoli - 1.0

Napoli is a beautiful WordPress theme perfectly suited for a food magazine. It features a great featured post slider, smooth typography and a grid-layout for posts. Bon appétit!

Theme URL - https://themezee.com/themes/napoli/
Author URL - https://themezee.com

SVN - https://themes.svn.wordpress.org/napoli/1.0
ZIP - https://wordpress.org/themes/download/napoli.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#35127 THEME: Napoli – 1.0.5 closed live rabmalin

(this ticket)

#39241 THEME: Napoli – 1.0.6 closed live themetracbot
#39874 THEME: Napoli – 1.0.7 closed live themetracbot
#41182 THEME: Napoli – 1.2 closed live themetracbot
#41268 THEME: Napoli – 1.2.1 closed live themetracbot
#41853 THEME: Napoli – 1.2.2 closed live themetracbot
#41988 THEME: Napoli – 1.2.3 closed live themetracbot
#42343 THEME: Napoli – 1.2.4 closed live themetracbot
#42875 THEME: Napoli – 1.2.5 closed live themetracbot
#44511 THEME: Napoli – 1.3 closed live themetracbot
#45537 THEME: Napoli – 1.4 closed live themetracbot
#46143 THEME: Napoli – 1.4.1 closed live themetracbot
#47735 THEME: Napoli – 1.4.2 closed live themetracbot
#48450 THEME: Napoli – 1.4.3 closed live themetracbot


https://themes.svn.wordpress.org/napoli/1.0/screenshot.jpg

Change History (16)

#1 @themetracbot
14 months ago

  • Summary changed from THEME: Napoli – 1.0 to THEME: Napoli – 1.0.1

Napoli - 1.0.1

Napoli is a beautiful WordPress theme perfectly suited for a food magazine. It features a great featured post slider, smooth typography and a grid-layout for posts. Bon appétit!

Theme URL - https://themezee.com/themes/napoli/
Author URL - https://themezee.com

SVN - https://themes.svn.wordpress.org/napoli/1.0.1
ZIP - https://wordpress.org/themes/download/napoli.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=napoli/1.0&new_path=napoli/1.0.1

History:

Ticket Summary Status Resolution Owner
#35127 THEME: Napoli – 1.0.5 closed live rabmalin

(this ticket)

#39241 THEME: Napoli – 1.0.6 closed live themetracbot
#39874 THEME: Napoli – 1.0.7 closed live themetracbot
#41182 THEME: Napoli – 1.2 closed live themetracbot
#41268 THEME: Napoli – 1.2.1 closed live themetracbot
#41853 THEME: Napoli – 1.2.2 closed live themetracbot
#41988 THEME: Napoli – 1.2.3 closed live themetracbot
#42343 THEME: Napoli – 1.2.4 closed live themetracbot
#42875 THEME: Napoli – 1.2.5 closed live themetracbot
#44511 THEME: Napoli – 1.3 closed live themetracbot
#45537 THEME: Napoli – 1.4 closed live themetracbot
#46143 THEME: Napoli – 1.4.1 closed live themetracbot
#47735 THEME: Napoli – 1.4.2 closed live themetracbot
#48450 THEME: Napoli – 1.4.3 closed live themetracbot


https://themes.svn.wordpress.org/napoli/1.0.1/screenshot.jpg

#2 @themetracbot
12 months ago

  • Summary changed from THEME: Napoli – 1.0.1 to THEME: Napoli – 1.0.2

Napoli - 1.0.2

Napoli is a beautiful WordPress theme perfectly suited for a food magazine. It features a great featured post slider, smooth typography and a grid-layout for posts. Bon appétit!

Theme URL - https://themezee.com/themes/napoli/
Author URL - https://themezee.com

SVN - https://themes.svn.wordpress.org/napoli/1.0.2
ZIP - https://wordpress.org/themes/download/napoli.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=napoli/1.0.1&new_path=napoli/1.0.2

History:

Ticket Summary Status Resolution Owner
#35127 THEME: Napoli – 1.0.5 closed live rabmalin

(this ticket)

#39241 THEME: Napoli – 1.0.6 closed live themetracbot
#39874 THEME: Napoli – 1.0.7 closed live themetracbot
#41182 THEME: Napoli – 1.2 closed live themetracbot
#41268 THEME: Napoli – 1.2.1 closed live themetracbot
#41853 THEME: Napoli – 1.2.2 closed live themetracbot
#41988 THEME: Napoli – 1.2.3 closed live themetracbot
#42343 THEME: Napoli – 1.2.4 closed live themetracbot
#42875 THEME: Napoli – 1.2.5 closed live themetracbot
#44511 THEME: Napoli – 1.3 closed live themetracbot
#45537 THEME: Napoli – 1.4 closed live themetracbot
#46143 THEME: Napoli – 1.4.1 closed live themetracbot
#47735 THEME: Napoli – 1.4.2 closed live themetracbot
#48450 THEME: Napoli – 1.4.3 closed live themetracbot


https://themes.svn.wordpress.org/napoli/1.0.2/screenshot.jpg

#3 @themetracbot
11 months ago

  • Summary changed from THEME: Napoli – 1.0.2 to THEME: Napoli – 1.0.3

Napoli - 1.0.3

Napoli is a beautiful WordPress theme perfectly suited for a food magazine. It features a great featured post slider, smooth typography and a grid-layout for posts. Bon appétit!

Theme URL - https://themezee.com/themes/napoli/
Author URL - https://themezee.com

SVN - https://themes.svn.wordpress.org/napoli/1.0.3
ZIP - https://wordpress.org/themes/download/napoli.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=napoli/1.0.2&new_path=napoli/1.0.3

History:

Ticket Summary Status Resolution Owner
#35127 THEME: Napoli – 1.0.5 closed live rabmalin

(this ticket)

#39241 THEME: Napoli – 1.0.6 closed live themetracbot
#39874 THEME: Napoli – 1.0.7 closed live themetracbot
#41182 THEME: Napoli – 1.2 closed live themetracbot
#41268 THEME: Napoli – 1.2.1 closed live themetracbot
#41853 THEME: Napoli – 1.2.2 closed live themetracbot
#41988 THEME: Napoli – 1.2.3 closed live themetracbot
#42343 THEME: Napoli – 1.2.4 closed live themetracbot
#42875 THEME: Napoli – 1.2.5 closed live themetracbot
#44511 THEME: Napoli – 1.3 closed live themetracbot
#45537 THEME: Napoli – 1.4 closed live themetracbot
#46143 THEME: Napoli – 1.4.1 closed live themetracbot
#47735 THEME: Napoli – 1.4.2 closed live themetracbot
#48450 THEME: Napoli – 1.4.3 closed live themetracbot


https://themes.svn.wordpress.org/napoli/1.0.3/screenshot.jpg

#4 @rabmalin
11 months ago

  • Owner set to rabmalin
  • Status changed from new to reviewing

#5 @ThemeZee
11 months ago

Oh wow, didn't expect that Napoli is getting a review in 2016. There were at least 30 themes in the queue before mine a few days ago.

Thanks so much for all your hard work @rabmalin I think this is the third theme in a row you are reviewing from me :)

I have created the missing theme page. Let me know if you find any issues.

#6 follow-up: @rabmalin
11 months ago

Issues

  • REQUIRED: custom-controls.php L122 - Escape admin_url() with esc_url().
  • REQUIRED: Remove comment-form from add_theme_support( 'html5' ). Also, you can use appropriate hooks to customize comment form rather than passing arguments in comment_form().
  • REQUIRED: content-slider.php L21- Value of alt attribute should be translatable and escaped.
  • REQUIRED: excerpt_length hook is used in admin side also. Please make sure it affects front-end only. See Twenty Seventeen for reference.

#7 @ThemeZee
11 months ago

Thanks for the review. I'll try to upload an update to fix these issues as soon as possible.

#8 @themetracbot
11 months ago

  • Summary changed from THEME: Napoli – 1.0.3 to THEME: Napoli – 1.0.4

Napoli - 1.0.4

Napoli is a beautiful WordPress theme perfectly suited for a food magazine. It features a great featured post slider, smooth typography and a grid-layout for posts. Bon appétit!

Theme URL - https://themezee.com/themes/napoli/
Author URL - https://themezee.com

SVN - https://themes.svn.wordpress.org/napoli/1.0.4
ZIP - https://wordpress.org/themes/download/napoli.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=napoli/1.0.3&new_path=napoli/1.0.4

History:

Ticket Summary Status Resolution Owner
#35127 THEME: Napoli – 1.0.5 closed live rabmalin

(this ticket)

#39241 THEME: Napoli – 1.0.6 closed live themetracbot
#39874 THEME: Napoli – 1.0.7 closed live themetracbot
#41182 THEME: Napoli – 1.2 closed live themetracbot
#41268 THEME: Napoli – 1.2.1 closed live themetracbot
#41853 THEME: Napoli – 1.2.2 closed live themetracbot
#41988 THEME: Napoli – 1.2.3 closed live themetracbot
#42343 THEME: Napoli – 1.2.4 closed live themetracbot
#42875 THEME: Napoli – 1.2.5 closed live themetracbot
#44511 THEME: Napoli – 1.3 closed live themetracbot
#45537 THEME: Napoli – 1.4 closed live themetracbot
#46143 THEME: Napoli – 1.4.1 closed live themetracbot
#47735 THEME: Napoli – 1.4.2 closed live themetracbot
#48450 THEME: Napoli – 1.4.3 closed live themetracbot


https://themes.svn.wordpress.org/napoli/1.0.4/screenshot.jpg

#9 in reply to: ↑ 6 @ThemeZee
11 months ago

All issues should be fixed now.

Remove comment-form from add_theme_support( 'html5' ).

Can you explain why this is required?

Napoli uses the default values of Underscores. I have removed the search-form parameter because the theme adds its own searchform.php, but never heard that comment-form should be removed.

I have no problem to remove it, just like to understand the reason for this. Always keep learning :)

#10 @rabmalin
11 months ago

Issues

  • REQUIRED: napoli_excerpt_length() - It should be
        if ( is_admin() ) {
            return $length;
        }
    
  • RECOMMENDED: content-slider.php - It seems you removed alt attribute. For a11y purpose, it is good to add alt attribute. You can keep like this alt="".
  • RECOMMENDED: comment-form HTML5 support - When comment form is customized in the theme, that support should be removed. It seems you removed both support and form customization. If you are not customizing comment form, it is good to add HTML5 support for comment form.
  • RECOMMENDED: addons.php L13 - You may want to change theme name here.

#11 @ThemeZee
11 months ago

Thanks for clarification.

I was creating the Napoli Pro add-on plugin the last days and made several minor changes to the theme since version 1.0.4 to play along with the add-on. I wanted to upload these with an update once the theme is live.

Do you want to review these changes again? Then I upload just v-1.0.5 later, but it will include some more changes.

If not, I can also upload version 1.0.4.1 and only include the issues you have noted. Don't want to cause you any more work.

If you want you can also set the theme live and I fix these issues with the 1.0.5 update when its ready.

Not sure what is best here :)

Best,
Thomas

#12 @rabmalin
11 months ago

I would suggest just fixing above issues and make theme live. Then you can update your theme as per the companion plugin as you like. Since you are already a good coder, I am pretty sure your update will also be following the guideline :-)

#13 @themetracbot
11 months ago

  • Summary changed from THEME: Napoli – 1.0.4 to THEME: Napoli – 1.0.5

Napoli - 1.0.5

Napoli is a beautiful WordPress theme perfectly suited for a food magazine. It features a great featured post slider, smooth typography and a grid-layout for posts. Bon appétit!

Theme URL - https://themezee.com/themes/napoli/
Author URL - https://themezee.com

SVN - https://themes.svn.wordpress.org/napoli/1.0.5
ZIP - https://wordpress.org/themes/download/napoli.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=napoli/1.0.4&new_path=napoli/1.0.5

History:

Ticket Summary Status Resolution Owner
#35127 THEME: Napoli – 1.0.5 closed live rabmalin

(this ticket)

#39241 THEME: Napoli – 1.0.6 closed live themetracbot
#39874 THEME: Napoli – 1.0.7 closed live themetracbot
#41182 THEME: Napoli – 1.2 closed live themetracbot
#41268 THEME: Napoli – 1.2.1 closed live themetracbot
#41853 THEME: Napoli – 1.2.2 closed live themetracbot
#41988 THEME: Napoli – 1.2.3 closed live themetracbot
#42343 THEME: Napoli – 1.2.4 closed live themetracbot
#42875 THEME: Napoli – 1.2.5 closed live themetracbot
#44511 THEME: Napoli – 1.3 closed live themetracbot
#45537 THEME: Napoli – 1.4 closed live themetracbot
#46143 THEME: Napoli – 1.4.1 closed live themetracbot
#47735 THEME: Napoli – 1.4.2 closed live themetracbot
#48450 THEME: Napoli – 1.4.3 closed live themetracbot


https://themes.svn.wordpress.org/napoli/1.0.5/screenshot.jpg

#14 @ThemeZee
11 months ago

Yes, the update will be following the guidelines :)

Thank you! Just wanted to make sure it is no problem to upload an update immediately after the theme is made live.

I have fixed your issues with 1.0.5 now and will upload 1.0.6 once the theme is live.

#15 @rabmalin
11 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Looks good. Approving and setting live. It will take around 1 hour for theme to appear in the directory. Good luck!

#16 @ThemeZee
11 months ago

Thank you so much :)

Note: See TracTickets for help on using tickets.