WordPress.org

Make WordPress Themes

Opened 17 months ago

Closed 11 months ago

Last modified 11 months ago

#35292 closed theme (not-approved)

THEME: Masonry PK – 1.0.2

Reported by: codemovement.pk Owned by: ponvendhan
Priority: previously reviewed Keywords: theme-masonry-pk
Cc: masood.u@…

Description

Masonry PK - 1.0.0

Material Design based on Masonry Cascading grid layout WordPress Theme for Blog.

Theme URL - http://codemovement.pk
Author URL - https://github.com/codemovement

SVN - https://themes.svn.wordpress.org/masonry-pk/1.0.0
ZIP - https://wordpress.org/themes/download/masonry-pk.1.0.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=masonry-pk/0.0.1&new_path=masonry-pk/1.0.0

History:

Ticket Summary Status Resolution Owner
#33371 THEME: Masonry PK – 0.0.1 closed not-approved ThemeZee
#35292 THEME: Masonry PK – 1.0.2 closed not-approved ponvendhan

(this ticket)


https://themes.svn.wordpress.org/masonry-pk/1.0.0/screenshot.png

Change History (11)

#1 @themetracbot
12 months ago

  • Summary changed from THEME: Masonry PK – 1.0.0 to THEME: Masonry PK – 1.0.2

Masonry PK - 1.0.2

Material Design based on Masonry Cascading grid layout WordPress Theme for Blog.

Theme URL - http://codemovement.pk
Author URL - https://github.com/codemovement

SVN - https://themes.svn.wordpress.org/masonry-pk/1.0.2
ZIP - https://wordpress.org/themes/download/masonry-pk.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=masonry-pk/1.0.0&new_path=masonry-pk/1.0.2

History:

Ticket Summary Status Resolution Owner
#33371 THEME: Masonry PK – 0.0.1 closed not-approved ThemeZee
#35292 THEME: Masonry PK – 1.0.2 closed not-approved ponvendhan

(this ticket)


https://themes.svn.wordpress.org/masonry-pk/1.0.2/screenshot.png

#2 @themetracbot
12 months ago

  • Owner set to mldshtn
  • Status changed from new to reviewing

#3 @codemovement.pk
12 months ago

@themetracbot Thanks.

#4 @codemovement.pk
11 months ago

10 days passed without feedback or review, please have a look! @Otto42

#5 @Otto42
11 months ago

  • Owner mldshtn deleted

@mldshtn Please do not accept a theme for review if you do not intend to perform the review.

Adding theme back to queue.

#6 @themetracbot
11 months ago

  • Owner set to ponvendhan

#7 @ponvendhan
11 months ago

Good morning @codemovement.pk
I'm reviewing your theme, Will post my review soon.

#8 @ponvendhan
11 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hi @codemovement.pk
Your theme has been reviewed against these requirements:
https://make.wordpress.org/themes/handbook/review/required/

As part of the new theme directory guidelines, reviewers may now close tickets if a theme has 5 or more issues.
This is part of our long term goals to improve the theme quality and shorten the queues.
You can read more about this change here: https://make.wordpress.org/themes.

Please do not get discouraged by the ticket being closed. -We want you to resubmit your theme,
but we do ask that you spend more time making sure that your theme meets all the requirements.
https://make.wordpress.org/themes/handbook/review/required/

You can upload your update here: https://wordpress.org/themes/upload/

Because of the large number of themes waiting for review, we might not be able to follow up immediately.
We will review your update when your theme reaches the top of the review queue.
If you have questions you can ask them here or in the #themereview channel on Slack
channel.


Required

Remove commented codes
functions.php line 60 to 66
functions.php line 128 to 131

Remove prefixes on third party style & Script enqueues
in function masonry_pk_scripts()

Remove unused files
found so many files with .map extension in /css and /js folder. Remove all
bootstrap-theme, bootstrap-theme.min, material, material.min in /css folder
npm.js in js folder
inc/custom-header.php

All theme text strings are to be translatable.
header.php line 31

Theme URI has no connection with this theme. Provide one if you have or leave blank.

Provide readme and license files in .txt format. Remove md versions.

The constant HEADER_TEXTCOLOR was deprecated in WP 3.4. Remove it

Provide license informations for third party styles, scripts and library's
Provide license informations for images used in screenshot.png

Screenshot.png is too small. 1200 x 900 resolution is required.

WordPress has the_archive_title & the_archive_description functions in core. why do you recreate those functions?
Remove those functions from template-tags.php

After spent 30 minutes to review, I found this is copy of materialwp from Brad williams
http://materialwp.com/
https://github.com/braginteractive/materialwp


Recommend

Found two different copyright statement in license.md.
Please clarify who is owner of this theme. Federico Zivolo or Brad Williams?
Also I suggest to remove license file

footer.php line 19
You have closed <a> tag with </div>. correct it. use </a> instead.

Recommended reading:
https://make.wordpress.org/themes/handbook/review/required/
https://make.wordpress.org/themes/handbook/review/resources/
https://developer.wordpress.org/themes/functionality/internationalization/
https://codex.wordpress.org/Validating_Sanitizing_and_Escaping_User_Data

The coding standards are not required to pass the review, but they can be helpful when developing your theme.
https://make.wordpress.org/core/handbook/best-practices/coding-standards/

The code reference library is very useful when you want to know more about WordPress functions, classes, hooks and methods.
It can help you determine if a function needs to be escaped or not, or if a function you have planned to write is already available.
https://developer.wordpress.org/reference/

This ticket was mentioned in Slack in #themereview by codemovement.pk. View the logs.


11 months ago

#10 @codemovement.pk
11 months ago

Hi @ponvendhan,

Thanks for your detail and quick review and feedback. All required issues aren't required or related to prefixing or security issues but recommended. So please give a chance to the developer to fix it or send recommendation instead of simply adding not-approved tag.

All the issues which you highlighted are recommendation not required.

@Otto42, please help me and give a chance to add the credit for the previous developer(s) and fix these recommendation.

Thanks

#11 @rabmalin
11 months ago

Detailed review for the theme. There are pretty more number of distinct required issues than the limit 5.

Screenshot

  • REQUIRED: Screenshot dimensions are wrong! Ratio of width to height should be 4:3. Screenshot size should be 1200x900, to account for HiDPI displays. Any 4:3 image size is acceptable, but 1200x900 is preferred.

Security (Sanitization/Escaping)

  • REQUIRED: Theme is no proper escaping implemented for value obtained from get_theme_mod().

Deprecated

  • REQUIRED: HEADER_TEXTCOLOR is deprecated. Please use alternative.
  • REQUIRED: Remove masonry_pk_admin_header_style(), masonry_pk_admin_header_image().
  • REQUIRED: Remove masonry_pk_wp_title(). You are already using add_theme_support( 'title-tag' );

Translation

  • REQUIRED: Translation issue - functions.php L31
  • REQUIRED: __( '', 'masonry-pk' ) - This is not correct. Translation string should have translatable content.
  • REQUIRED: comments.php - Value of placeholder should be translatable and escaped.

Credits and license

  • REQUIRED: Update readme file to keep credits and license info of all third party resources. Eg, fonts, images, scripts, etc.

Use WordPress Features first

  • REQUIRED: the_archive_title() is already available in core. It should be removed from theme. Similarly the_archive_description()

Theme Tags

  • REQUIRED: post-formats declared in theme tag but not implemented.
  • REQUIRED: sticky-post declared in theme tag but not implemented.
  • REQUIRED: custom-logo is implemented but theme tag is not kept.

Prefixing

Code

  • REQUIRED: You should remove search-form from add_theme_support( 'html5' ) as you are customizing search form yourself.
  • REQUIRED: You should remove comment-list from add_theme_support( 'html5' ) as you are customizing comment list yourself.
  • REQUIRED: You should remove comment-form from add_theme_support( 'html5' ) as you are customizing comment form yourself.
  • REQUIRED: content.php - wp_link_pages() should be used along with the_content(). It is not needed for the_excerpt().

Funtionality

  • REQUIRED: Site Title in Customizer. When site title is changed, it is neither updated in the preview nor Customizer preview page is refreshing.
Note: See TracTickets for help on using tickets.