WordPress.org

Make WordPress Themes

Opened 8 months ago

Closed 7 weeks ago

Last modified 7 weeks ago

#35504 closed theme (live)

THEME: megaDRIVE – 2017.02.06.1

Reported by: hrant.abelyan Owned by: rinkuyadav999
Priority: previously reviewed Keywords: theme-megadrive
Cc: electronemail777@…

Description

megaDRIVE - 2016.08.14.1

Free wordpress theme by Hrant Abelyan. Make posts sticky and to have featured image to appear in slider.

Theme URL -
Author URL - https://www.facebook.com/hrant.abelyan

SVN - https://themes.svn.wordpress.org/megadrive/2016.08.14.1
ZIP - https://wordpress.org/themes/download/megadrive.2016.08.14.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=megadrive/2015.09.03.1&new_path=megadrive/2016.08.14.1

History:

Ticket Summary Status Resolution Owner
#26036 THEME: megaDRIVE – 2015.07.21.1 closed not-approved nirob.19
#26944 THEME: megaDRIVE – 2015.09.03.1 closed not-approved bgturner
#35504 THEME: megaDRIVE – 2017.02.06.1 closed live rinkuyadav999

(this ticket)

#40096 THEME: megaDRIVE – 2017.02.07.1 closed live themetracbot


https://themes.svn.wordpress.org/megadrive/2016.08.14.1/screenshot.png

Attachments (2)

megadrive.zip (1.2 MB) - added by hrant.abelyan 2 months ago.
megaDrive theme, version 2017.01.14.1
Capture.PNG (29.3 KB) - added by hrant.abelyan 2 months ago.
done with css

Download all attachments as: .zip

Change History (57)

#1 @hrant.abelyan
8 months ago

Hi dear reviewer, thank you for the work that you are doing, if you find something that will not allow this theme to be live, please don't be fast to close this ticket, I will fix issues quick.

Thanks,
Hrant Abelyan

Last edited 7 months ago by hrant.abelyan (previous) (diff)

#2 @rinkuyadav999
3 months ago

  • Owner set to rinkuyadav999
  • Status changed from new to reviewing

#3 @hrant.abelyan
3 months ago

Hi @rinkuyadav999, please don't close ticket, just tell me what needs to be fixed, I will fix it quick. It takes too long to get here.

#4 @rinkuyadav999
3 months ago

Hi @hrant.abelyan

Ok i will not close ticket. i will post issues soon.

Thanks

#5 @hrant.abelyan
3 months ago

Ok, thank you!

I'll be back soon.

#6 @hrant.abelyan
3 months ago

@rinkuyadav999 any news?

#7 follow-ups: @rinkuyadav999
3 months ago

Hi @hrant.abelyan

I have taken a review and found these issues:

WordPress spelling

Please correct WordPress spelling in all files. capitalize W and P, should be WordPress.

Readme.txt file

I did not find license of third party plugins. please take help of twentyseventeen theme and prepare readme.txt file again.

Minify

Please also provide non-minify version of js and css files, if you use minify version.

Escape

Please escape get_permalink function in all files.
searchform.php escape placeholder attribute value.

Translation ready

Make sure all string are translation ready and escaped if used as html attribute. Found: header.php > alt="megaDRIVE" title="megaDrive"

Pagination

Please use WordPress functions and features for pagination. function porc_pagination used for custom pagination and also name of this function is not prefixed properly.

Hard coded script

Please use wp_add_inline_script or wp_enqueue_script to add script. functions.php

Excerpt

You can use excerpt_more filter to add .... after except instead get_excerpt function in functions.php. also it is not allow in this way.

Title

add_theme_support('title-tag'); is enough for title. remove megadrive_wp_title function because it is plugin territory.

Theme Unit Test

Please test your theme with theme unit test > https://codex.wordpress.org/Theme_Unit_Test

Header.php

You can use core WordPress search form or you can use searchform.php template instead own custom search form.
Please use wp_enqueue_script function in functions.php file.

footer.php

You can print current year using php so it will update automatically instead just 2015. if you want to keep it, then make it translation ready.

Please also use wp_link_pages function for page.

You should use wp_enqueue_scripts hook to enqueue css and js files instead init hook.
You can use get_stylesheet_uri function to enqueue main css file instead.
Remove commented codes inside megadrive_register_scripts function.
You do not need to escape get_template_directory_uri function.

I do not see pagination on single post.

Why are you using megadrive_custom_pre_get_posts function?

Thanks

Last edited 3 months ago by rinkuyadav999 (previous) (diff)

#8 @hrant.abelyan
3 months ago

I will start fixing soon

Last edited 3 months ago by hrant.abelyan (previous) (diff)

#9 follow-up: @rinkuyadav999
3 months ago

Hi @hrant.abelyan

Yes, take your time but keep this ticket updated within 7 days.

Thanks

#10 @hrant.abelyan
2 months ago

Ok, much appreciated!

#11 in reply to: ↑ 7 @hrant.abelyan
2 months ago

Replying to rinkuyadav999:

Header.php

You can use core WordPress search form or you can use searchform.php template instead own custom search form.
Please use wp_enqueue_script function in functions.php file.

So, in searchform.php, can I have that magnifier in placeholder of input and call it from header.php?
I want that my search form input be like I created. Please help on that.

Soon will finish all fixes, remaining 'Theme Unit Test', 'Excerpt', 'Header.php' and 1-2 small things.

Also:
Removed -moz-transition-duration properties in style.css
Removed -moz-box-shadow and -o-box-shadow properties in style.css
Converted #000000 to #000, #ffffff to #fff and #xxxxxx to #xxx in style.css
Now hamburger menu starts from 992px instead of 640px

Thanks!

#12 @rinkuyadav999
2 months ago

Hi @hrant.abelyan


I did not tell to update css code:
Removed -moz-box-shadow and -o-box-shadow properties in style.css
Converted #000000 to #000, #ffffff to #fff and #xxxxxx to #xxx in style.css
Now hamburger menu starts from 992px instead of 640px


Yes you can customize search form in searchform.php and use get_search_form function to include in your header file.


Please use wp_enqueue_script function in functions.php file.

if (is_singular() ) wp_enqueue_script( 'comment-reply' );

This line of code will be better in functions.php file.

Thanks

#13 in reply to: ↑ 9 @hrant.abelyan
2 months ago

Replying to rinkuyadav999:

Hi @hrant.abelyan

Yes, take your time but keep this ticket updated within 7 days.

Thanks

Sorry, is writing comments counting as update or I need to upload changes?
Just little bit busy with other project.

Header.php part completed.

#14 @hrant.abelyan
2 months ago

Almost finished my other project, will continue fixing soon.

#15 in reply to: ↑ 7 ; follow-up: @hrant.abelyan
2 months ago

Replying to rinkuyadav999:

Excerpt

You can use excerpt_more filter to add .... after except instead get_excerpt function in functions.php. also it is not allow in this way.

How can I limit excerpt length by characters, so slider excerpt will have 140 chars and posts 90 chars?

And can I use get_the_excerpt filter?

#16 in reply to: ↑ 15 @hrant.abelyan
2 months ago

Replying to hrant.abelyan:

Replying to rinkuyadav999:

How can I limit excerpt length by characters, so slider excerpt will have 140 chars and posts 90 chars?

If it's difficult to solve this, then no problem I will use excerpt_length filter

#17 in reply to: ↑ 7 @hrant.abelyan
2 months ago

Replying to rinkuyadav999:

I do not see pagination on single post.


You mean pagination that is like 'previous post' and 'next post', yes?

#18 @rinkuyadav999
2 months ago

@hrant.abelyan

Yes, next and previous post links on single post.

excerpt length: yes you can use excerpt filters.

Thanks

#19 @hrant.abelyan
2 months ago

So, here is what I have done.

WordPress spelling ✔

Please correct WordPress spelling in all files. capitalize W and P, should be WordPress.
➤ Searched and replaced in all files

Readme.txt file ✔

I did not find license of third party plugins. please take help of twentyseventeen theme and prepare readme.txt file again.
➤ Added license information of third party plugins and fonts.

Minify ✔

Please also provide non-minify version of js and css files, if you use minify version.
➤ Included 'jquery.slicknav.js' in folder 'slicknav', which is non-minified version of 'jquery.slicknav.min.js'

Escape ✔

Please escape get_permalink function in all files.
searchform.php escape placeholder attribute value.
➤ Replaced get_permalink functions with the_permalink functions, the_permalink does escape.
Escaped searchform.php placeholder attribute value with esc_html().

Translation ready ✔

Make sure all string are translation ready and escaped if used as html attribute. Found: header.php > alt="megaDRIVE" title="megaDrive"
➤ Fixed it

Pagination ✔

Please use WordPress functions and features for pagination. function porc_pagination used for custom pagination and also name of this function is not prefixed properly.
➤ Removed porc_pagination, now using megadrive_pagination which works with the_posts_pagination() WordPress function

Hard coded script ✔

Please use wp_add_inline_script or wp_enqueue_script to add script. functions.php
➤ Used wp_add_inline_script script

Excerpt ✔

You can use excerpt_more filter to add .... after except instead get_excerpt function in functions.php. also it is not allow in this way.
➤ Used excerpt_more and excerpt_length script instead of custom function

Title ✔

add_theme_support('title-tag'); is enough for title. remove megadrive_wp_title function because it is plugin territory.
➤ Removed megadrive_wp_title function, and added add_theme_support('title-tag') on after_setup_theme hook

Theme Unit Test ❓

Please test your theme with theme unit test > ​https://codex.wordpress.org/Theme_Unit_Test

Header.php ✔

You can use core WordPress search form or you can use searchform.php template instead own custom search form.
Please use wp_enqueue_script function in functions.php file.
➤ In header.php I used get_search_form() to call searchform.php
Used wp_enqueue_script() to add 'comment-reply' WordPress core script.

footer.php ✔

You can print current year using php so it will update automatically instead just 2015. if you want to keep it, then make it translation ready.
➤ Used php to print year - date('Y')

Please also use wp_link_pages function for page. ✔
You should use wp_enqueue_scripts hook to enqueue css and js files instead init hook. ✔
You can use get_stylesheet_uri function to enqueue main css file instead. ✔
Remove commented codes inside megadrive_register_scripts function. ✔
You do not need to escape get_template_directory_uri function. ✔
I do not see pagination on single post. ✔
Why are you using megadrive_custom_pre_get_posts function? ✔
1) It ignores sticky posts - Because sticky posts are in the slider, and there is no need for higher priority for them to show up on pages.
2) It ignores pages on search results - Users are searching something in posts, not in pages.

I need a little help about 'Theme Unit Test', please tell me which parts are important?

@hrant.abelyan
2 months ago

megaDrive theme, version 2017.01.14.1

#20 @hrant.abelyan
2 months ago

Please help about 'Theme Unit Test', which parts of it are important?

Because I don't know how to be with some parts of it, for example
https://codex.wordpress.org/Theme_Unit_Test#.28no_title.29

no title

  • Lack of post title should not adversely impact layout.
  • Post permalink should be displayed. Making the post date a permalink is a great solution. See Twenty Ten for an example.

My theme need to display dates not as links, but as grey spans.

What you think about that?

Last edited 2 months ago by hrant.abelyan (previous) (diff)

#21 @rinkuyadav999
2 months ago

Hi @hrant.abelyan

Theme unit test is recommended for your theme but not required.

Please upload ( https://wordpress.org/themes/upload/ ) updated version so i can take review again.

Thanks

#22 @hrant.abelyan
2 months ago

Hi @rinkuyadav999

Good, I will do some fixes for gallery images, then will upload new version.

Thanks

#23 @hrant.abelyan
2 months ago

Now posts with empty title will look like this.

@hrant.abelyan
2 months ago

done with css

#24 @hrant.abelyan
2 months ago

Ok I finished fixes, now uploading :)

#25 @themetracbot
2 months ago

  • Summary changed from THEME: megaDRIVE – 2016.08.14.1 to THEME: megaDRIVE – 2017.01.30.1

megaDRIVE - 2017.01.30.1

Free WordPress theme by Hrant Abelyan. Make posts sticky and to have featured image to appear in slider.

Theme URL -
Author URL - https://www.facebook.com/hrant.abelyan

SVN - https://themes.svn.wordpress.org/megadrive/2017.01.30.1
ZIP - https://wordpress.org/themes/download/megadrive.2017.01.30.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=megadrive/2016.08.14.1&new_path=megadrive/2017.01.30.1

History:

Ticket Summary Status Resolution Owner
#26036 THEME: megaDRIVE – 2015.07.21.1 closed not-approved nirob.19
#26944 THEME: megaDRIVE – 2015.09.03.1 closed not-approved bgturner
#35504 THEME: megaDRIVE – 2017.02.06.1 closed live rinkuyadav999

(this ticket)

#40096 THEME: megaDRIVE – 2017.02.07.1 closed live themetracbot


https://themes.svn.wordpress.org/megadrive/2017.01.30.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.

#26 follow-ups: @rinkuyadav999
2 months ago

Hi

I have taken a review:

Template: Sticky - They should show at the very top of the blog index page, even though they could be several posts back chronologically.

Post Format: Video (YouTube): Video do not display properly in container section.

Menu Top Header.php: you can register menu and user wp_nav_menu instead just wp_list_pages. same as main-menu

Logo Header.php: This is not proper way to add custom logo feature. use add_theme_support custom-logo

Escape Header.php: Escape string in attribute Found Line 27 alt, title and also escape home_url function everywhere.

wp_add_inline_script: you can not use core WordPress handler jquery-migrate.

Use the_excerpt instead get_the_excerpt.

use wp_reset_postdata instead wp_reset_query.

Thanks

#27 @hrant.abelyan
2 months ago

Hi @rinkuyadav999

Ok will do

#28 in reply to: ↑ 26 ; follow-up: @hrant.abelyan
2 months ago

Replying to rinkuyadav999:

Escape Header.php: Escape string in attribute Found Line 27 alt, title and also escape home_url function everywhere.

Sorry but there are 2 home_url functions, both are escaped with esc_url, it's enough yes?

#29 @hrant.abelyan
2 months ago

Also in flexslider.php removed toooo weird code on line 12

else {
goto move_on;
}

Now it's

else {
exit();
}
Last edited 2 months ago by hrant.abelyan (previous) (diff)

#30 in reply to: ↑ 28 @rinkuyadav999
2 months ago

Replying to hrant.abelyan:

Replying to rinkuyadav999:

Escape Header.php: Escape string in attribute Found Line 27 alt, title and also escape home_url function everywhere.

Sorry but there are 2 home_url functions, both are escaped with esc_url, it's enough yes?

First one not escaped with esc_url :)

<?php
<ul>
                                <li class="current_page_item">
                                <a href="<?php echo home_url(); ?>/"><?php echo __('Home','megadrive'); ?></a>
                                </li>
                                <?php wp_list_pages('depth=1&sort_column=menu_order&title_li='); ?>
                        </ul>

#31 @hrant.abelyan
8 weeks ago

Hmm ok, maybe I changed it then looked :)
Because now there is a menu with wp_nav_menu.

Last edited 8 weeks ago by hrant.abelyan (previous) (diff)

#32 in reply to: ↑ 26 @hrant.abelyan
8 weeks ago

Replying to rinkuyadav999:

Logo Header.php: This is not proper way to add custom logo feature. use add_theme_support custom-logo

So, I can't put default logo of theme? It must be blog name by default and wrapped in h1?

#33 in reply to: ↑ 26 @hrant.abelyan
8 weeks ago

Replying to rinkuyadav999:

Template: Sticky - They should show at the very top of the blog index page, even though they could be several posts back chronologically.

And this means theme can't "ignore" sticky posts?
It will look little bit odd if sticky posts will be in slider and after that slider.
Some rules don't make sense (

#34 @rinkuyadav999
8 weeks ago

Hi

Sticky post is not an issue in your case.

Yes you should display site title instead default logo.

Please do above changes and upload new version so i can take review again.

Thanks

#35 @hrant.abelyan
8 weeks ago

Ok, I did, will upload it in some minutes.

#36 @themetracbot
8 weeks ago

  • Summary changed from THEME: megaDRIVE – 2017.01.30.1 to THEME: megaDRIVE – 2017.02.01.1

megaDRIVE - 2017.02.01.1

Free WordPress theme by Hrant Abelyan. Make posts sticky and to have featured image to appear in slider. &#8216;Top Menu&#8217; items can&#8217;t contain items, for multilevel menu use &#8216;Main Menu&#8217;.

Theme URL -
Author URL - https://www.facebook.com/hrant.abelyan

SVN - https://themes.svn.wordpress.org/megadrive/2017.02.01.1
ZIP - https://wordpress.org/themes/download/megadrive.2017.02.01.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=megadrive/2017.01.30.1&new_path=megadrive/2017.02.01.1

History:

Ticket Summary Status Resolution Owner
#26036 THEME: megaDRIVE – 2015.07.21.1 closed not-approved nirob.19
#26944 THEME: megaDRIVE – 2015.09.03.1 closed not-approved bgturner
#35504 THEME: megaDRIVE – 2017.02.06.1 closed live rinkuyadav999

(this ticket)

#40096 THEME: megaDRIVE – 2017.02.07.1 closed live themetracbot


https://themes.svn.wordpress.org/megadrive/2017.02.01.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.

#37 @hrant.abelyan
8 weeks ago

✔ Template: Sticky - They should show at the very top of the blog index page, even though they could be several posts back chronologically.
✔ Post Format: Video (YouTube): Video do not display properly in container section.
✔ Menu Top Header.php: you can register menu and user wp_nav_menu instead just wp_list_pages. same as main-menu
✔ Logo Header.php: This is not proper way to add custom logo feature. use add_theme_support custom-logo
✔ Escape Header.php: Escape string in attribute Found Line 27 alt, title and also escape home_url function everywhere.
✔ wp_add_inline_script: you can not use core WordPress handler jquery-migrate.
✔ Use the_excerpt instead get_the_excerpt.
✔ use wp_reset_postdata instead wp_reset_query.

#38 @rinkuyadav999
8 weeks ago

Hi @hrant.abelyan

It is recommended to add fonts using wp_enqueue_style instead @font-face src in style.css

Readme.txt
megaDRIVE WordPress Theme, Copyright 2017 WordPress.org
Seems this is not correct. Please check readme file again.

Images
You can remove unused images like logo.png

Thanks

#39 @rinkuyadav999
8 weeks ago

functions.php line 16: strings Main Menu and Top Menu is not translation ready.

#40 @hrant.abelyan
8 weeks ago

I fixed other stuff, but don't understand font-face part, please help on that.

#41 @rinkuyadav999
8 weeks ago

Hi

Use like:

// Add custom fonts, used in the main stylesheet.
	wp_enqueue_style( 'twentysixteen-fonts', twentysixteen_fonts_url(), array(), null );

instead

@font-face {
	font-family: 'open-sans';
	src: url('fonts/OpenSans-Regular.ttf'); 
	font-weight: 400;
}
@font-face {
	font-family: 'open-sans'; 
	src: url('fonts/OpenSans-Semibold.ttf');
	font-weight: 600;
}

ALSO here you have to fix small issue (comments.php):

<?php
printf( _nx( 'One thought on &ldquo;%2$s&rdquo;', '%1$s thoughts on &ldquo;%2$s&rdquo;', get_comments_number(), 'comments title', 'megadrive' ),
                                        number_format_i18n( get_comments_number() ), get_the_title() );

Like this ( https://github.com/Automattic/_s/pull/1012/files ) :

<?php
$comment_count = get_comments_number();
                                if ( 1 === $comment_count ) {
                                        printf(
                                                /* translators: 1: title. */
                                                esc_html_e( 'One thought on &ldquo;%1$s&rdquo;', '_s' ),
                                                '<span>' . get_the_title() . '</span>'
                                        );
                                } else {
                                        printf( // WPCS: XSS OK.
                                                /* translators: 1: comment count number, 2: title. */
                                                esc_html( _nx( '%1$s thought on &ldquo;%2$s&rdquo;', '%1$s thoughts on &ldquo;%2$s&rdquo;', $comment_count, 'comments title', '_s' ) ),
                                                number_format_i18n( $comment_count ),
                                                '<span>' . get_the_title() . '</span>'
                                        );
                                }

Thanks

#43 @hrant.abelyan
8 weeks ago

Ok, thank you!

And also delete font files from theme, yes?

#44 @themetracbot
8 weeks ago

  • Summary changed from THEME: megaDRIVE – 2017.02.01.1 to THEME: megaDRIVE – 2017.02.03.1

megaDRIVE - 2017.02.03.1

Free WordPress theme by Hrant Abelyan. Make posts sticky and to have featured image to appear in slider. &#8216;Top Menu&#8217; items can&#8217;t contain items, for multilevel menu use &#8216;Main Menu&#8217;.

Theme URL -
Author URL - https://www.facebook.com/hrant.abelyan

SVN - https://themes.svn.wordpress.org/megadrive/2017.02.03.1
ZIP - https://wordpress.org/themes/download/megadrive.2017.02.03.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=megadrive/2017.02.01.1&new_path=megadrive/2017.02.03.1

History:

Ticket Summary Status Resolution Owner
#26036 THEME: megaDRIVE – 2015.07.21.1 closed not-approved nirob.19
#26944 THEME: megaDRIVE – 2015.09.03.1 closed not-approved bgturner
#35504 THEME: megaDRIVE – 2017.02.06.1 closed live rinkuyadav999

(this ticket)

#40096 THEME: megaDRIVE – 2017.02.07.1 closed live themetracbot


https://themes.svn.wordpress.org/megadrive/2017.02.03.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.

#45 @rinkuyadav999
7 weeks ago

Hi @hrant.abelyan

I missed some issues.

Use proper handler of wp_enqueue_script and wp_enqueue_style, you can take help here: https://github.com/grappler/wp-standard-handles

I will recommend to improve design of your theme.

Thanks

#46 @hrant.abelyan
7 weeks ago

Hi @rinkuyadav999

Are design improvements required? I just don't have much time, can do this after theme is published and when will have more time.

Thanks

Last edited 7 weeks ago by hrant.abelyan (previous) (diff)

#47 @rinkuyadav999
7 weeks ago

Hi @hrant.abelyan

No, it is not required but recommended for your theme.

Thanks

#48 @themetracbot
7 weeks ago

  • Summary changed from THEME: megaDRIVE – 2017.02.03.1 to THEME: megaDRIVE – 2017.02.06.1

megaDRIVE - 2017.02.06.1

Free WordPress theme by Hrant Abelyan. Make posts sticky and to have featured image to appear in slider. &#8216;Top Menu&#8217; items can&#8217;t contain items, for multilevel menu use &#8216;Main Menu&#8217;.

Theme URL -
Author URL - https://www.facebook.com/hrant.abelyan

SVN - https://themes.svn.wordpress.org/megadrive/2017.02.06.1
ZIP - https://wordpress.org/themes/download/megadrive.2017.02.06.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=megadrive/2017.02.03.1&new_path=megadrive/2017.02.06.1

History:

Ticket Summary Status Resolution Owner
#26036 THEME: megaDRIVE – 2015.07.21.1 closed not-approved nirob.19
#26944 THEME: megaDRIVE – 2015.09.03.1 closed not-approved bgturner
#35504 THEME: megaDRIVE – 2017.02.06.1 closed live rinkuyadav999

(this ticket)

#40096 THEME: megaDRIVE – 2017.02.07.1 closed live themetracbot


https://themes.svn.wordpress.org/megadrive/2017.02.06.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.

#49 @rinkuyadav999
7 weeks ago

  • Resolution set to live
  • Status changed from reviewing to closed

Hi @hrant.abelyan

Congratulation, your theme will be live today.

Thanks

#50 @hrant.abelyan
7 weeks ago

Hi @rinkuyadav999

Wooohoooooo!

Thank you! I will do updates to it when have time. Do updates require reviewing like this, or a little bit different way?

#51 @rinkuyadav999
7 weeks ago

Hi @hrant.abelyan

No, when you will update theme, it will automatically become live after some automatic checks.

But make sure, you review all new code and your theme follow these rules: https://make.wordpress.org/themes/handbook/review/required/

If you want to review themes of other authors, please follow: https://make.wordpress.org/themes/handbook/get-involved/become-a-reviewer/

Thanks

#52 @rinkuyadav999
7 weeks ago

Hi @hrant.abelyan

File: flexslider.php Line 12 - replace exit(); with return;

Otherwise your theme will exit if a theme does not have sticky posts.

Update it.

Thanks

#53 @hrant.abelyan
7 weeks ago

Hi @rinkuyadav999

Ok, now will do.

#54 @hrant.abelyan
7 weeks ago

Thank you!

#55 @hrant.abelyan
7 weeks ago

Fixed, updated.

Note: See TracTickets for help on using tickets.