WordPress.org

Make WordPress Themes

Opened 14 months ago

Closed 6 months ago

Last modified 6 months ago

#35640 closed theme (live)

THEME: RainbowNews – 1.0.7

Reported by: 99colorthemes Owned by: juhise
Priority: new theme Keywords: theme-rainbownews
Cc: 99colorthemes@…

Attachments (3)

comment_display_2_time.png (72.2 KB) - added by Vala bhavesh 9 months ago.
rss.png (94.2 KB) - added by Vala bhavesh 9 months ago.
theme_checker.png (82.4 KB) - added by Vala bhavesh 9 months ago.

Download all attachments as: .zip

Change History (29)

#1 @themetracbot
9 months ago

  • Summary changed from THEME: RainbowNews – 1.0.0 to THEME: RainbowNews – 1.0.1

RainbowNews - 1.0.1

A WordPress News Theme

Theme URL - http://99colorthemes.com/themes/rainbownews
Author URL - http://99colorthemes.com

SVN - https://themes.svn.wordpress.org/rainbownews/1.0.1
ZIP - https://wordpress.org/themes/download/rainbownews.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=rainbownews/1.0.0&new_path=rainbownews/1.0.1

History:


https://themes.svn.wordpress.org/rainbownews/1.0.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#2 @themetracbot
9 months ago

  • Owner set to Vala bhavesh
  • Status changed from new to reviewing

#3 @Vala bhavesh
9 months ago

Hello @99colorthemes

I will start your theme review and I send design level, development level and some suggestions bug so I hope after you quick updates your theme because more theme is pending.

Thank you

#4 @Vala bhavesh
9 months ago

Hello @99colorthemes

  1. Please update your readme file and add installation steps, currentlly your theme installation steps url not working ( http://99colorthemes.com/theme-instruction/rainbownews/ ) and update version changelog.
  1. RSS display proper now title, date, details are mixing so change design.
  1. Can you please change Recommened like style-editor, theme support in theme check plugin error.
  1. Two time display comments counter on homepage.

Thank you

@Vala bhavesh
9 months ago

#5 @99colorthemes
9 months ago

Hello @Vala bhavesh

Sorry For Late Reply. Thankyou for your quick review.Please give me 2 days & i will update it

#6 @themetracbot
9 months ago

  • Summary changed from THEME: RainbowNews – 1.0.1 to THEME: RainbowNews – 1.0.2

RainbowNews - 1.0.2

A WordPress News Theme

Theme URL -
Author URL -

SVN - https://themes.svn.wordpress.org/rainbownews/1.0.2
ZIP - https://wordpress.org/themes/download/rainbownews.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=rainbownews/1.0.1&new_path=rainbownews/1.0.2

History:


https://themes.svn.wordpress.org/rainbownews/1.0.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: Theme URI: is missing from your style.css header.
  • RECOMMENDED: Author URI: is missing from your style.css header.

#7 @djrmom
9 months ago

  • Owner Vala bhavesh deleted

I am sorry this review is taking so long. Sometimes people are unable to carry on the review, this may have happened this time. As a result, I am going to add this to the new queue again as a priority. This may mean it still takes time, but will prevent this ticket being held for so long by a reviewer that isn't able to carry on. Thanks for your patience.

If you are the reviewer and able to do this review, please carry on and request you get added back in Slack #themereview or you can take on another review when you have time again.

#8 @themetracbot
9 months ago

  • Owner set to Mahesh901122

#9 @Mahesh901122
9 months ago

@99colorthemes Thanks for submitting your theme. I'll complete the review ASAP.

Below is some initial review issues. I'll review other thinks and note down these here.


# style.css


# functions.php

  • /languages/ directory not found which is added in function load_theme_textdomain() @see https://codex.wordpress.org/Function_Reference/load_theme_textdomain
  • No need for post_type_support WordPress core already handles it. add_post_type_support( 'post', 'excerpt' );
  • No need to enqueue another jQuery script from theme. wp_enqueue_script( 'jquery', get_template_directory_uri() . '/js/jquery-2.2.3.js', array( 'jquery' ), '2.2.3', true );
  • Remove unused global variable global $post_type;
  • Register Editor Style in after_setup_theme action except admin_init
  • Add your theme prefix rainbownews ( Which is added for all functions ) for function wpdocs_theme_add_editor_styles()
  • Constant RAINBOWNEWS_MAIN_URL is defined for get_template_directory_uri() so, Use it wherever possible.
  • Remove unused global variable global $post;
  • Use esc_url() for get_category_link() E.g. esc_url( get_category_link( $category->term_id ) )
  • Add prefix for limit_posts_per_page()

# extra.php

  • Why empty value passed in filter body_class E.g. elseif (is_404()) { $rainbownews_classes[] = ''; }
  • Note: Try to manage code indentation / formatting.

# inc/rainbownews-functions.php

  • Escaping: All untrusted data should be escaped properly before displaying. @see https://codex.wordpress.org/Data_Validation
  • Missing wp_reset_postdata(); from function rainbownews_trending_news()
  • Is this valid to return from foreach loop? Is this by mistake? return $layout; Line - 362
  • Missing Translation strings. @see https://codex.wordpress.org/I18n_for_WordPress_Developers/ E.g. echo $before . 'Error 404' . $after;
  • Missing theme slug for function wpb_set_post_views();
  • No removing or modifying non-presentational hooks. remove_action('wp_head', 'adjacent_posts_rel_link_wp_head', 10, 0);

# SUMMERY

You need to follow WordPress coding standards @see https://make.wordpress.org/core/handbook/best-practices/coding-standards/

Don't Extract @see https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#dont-extract
Clever Code @see https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#clever-code
Space Usage @see https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#space-usage
Yoda Conditions @see https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#yoda-conditions

#10 @Mahesh901122
8 months ago

@99colorthemes Lot of issues are related with coding standards @see https://make.wordpress.org/core/handbook/best-practices/coding-standards/


  • Package name "99colorthemes" is not valid;
  • Package name "rainbowNews" is not valid;
  • Remove commented if its no required. E.g. <!-- <div style="text-align: center;"><img src="<?php echo get_template_directory_uri(); ?>/<?php echo get_template_directory_uri() . '/img/style-1.jpg' ?>"></div> -->
  • Code formatting issues:

# functions.php

  • Line 164 - Expected if (...) {\n"; found "if(...) {\n
  • Line 254 - Expected if (...) {\n"; found "if(...) {\n
  • Line 256 - Expected foreach (...) {\n"; foun
  • Line 290 - Expected if (...) {\n"; found "if (...)\n\t{\n

Theme Check Sniffs

Check full PHPCS report for reference - https://www.dropbox.com/sh/aqbrgwgi4sd77iz/AABwMDAFJwvTDYk_CcG4aiRLa?dl=0

Note: Errors need to be fixed and Warnings are things that need to be checked manually.


Also, Try to fix all the possible issues with 7 days and comment here. Otherwise your ticket will be closed. @see https://make.wordpress.org/themes/handbook/review/#timeframes

#12 @99colorthemes
8 months ago

Hello @Mahesh901122

Thankyou for your quick review. You have said no need for post_type_support for add_post_type_support( 'post', 'excerpt' ); in functions.php. But I have added add_post_type_support( 'page', 'excerpt' ); in functions.php . Should i remove this function ? Because post_type page need excerpt field

#13 @Mahesh901122
8 months ago

Hi @99colorthemes,

Thanks for providing update. Below is the short review. I'll review all the files & necessary items to get theme approve ASAP.


Files:

  • index.php - ok
  • archive.php - ok
  • comments.php - ok
  • 404.php
    • Is it right to use <h1> tag for the description text?
  • contact.php
    • This is template file. So, file name expected 'template-contact.php' except 'contact.php'.
  • footer.php
    • Use proper conditions for sidebars. E.g. if ( ! dynamic_sidebar( 'rainbownews_front_page_gallery_area' ) ) : endif; }
    • Action 'rainbownews_footer_copyright' not found. Use do_action('rainbownews_footer_copyright') except rainbownews_footer_copyright_info().
  • functions.php

Notes


  • Found duplicate @packages ( 99colorthemes & Power_Mag ). Your package is 'RainbowNews' so use 'RainbowNews' except 'Rainbownews'
  • Why CSS class prefix 'nnc' used?
  • Indentation & Spacing is more important to understand the code.

#14 @Mahesh901122
8 months ago

@99colorthemes Please check below rest of the review. Fix all the issues.


  • page.php - ok
  • screenshot.png - ok
  • search.php - ok
  • searchform.php - ok
  • single.php - ok
  • template-home.php - ok
  • css/font-awesome.css - ok
  • css/styles.css - ok
  • css/swiper.css - ok
  • inc/custom-header.php - ok
  • inc/customizer.php - ok
  • inc/jetpack.php - ok
  • js/admin/rainbownews-admin.js - ok
  • js/customizer.js - ok
  • inc/template-tags.php - ok
  • js/navigation.js - ok
  • js/newsTicker.js - ok
  • js/skip-link-focus-fix.js - ok
  • js/swiper.js - ok
  • template-parts/content-none.php - ok
  • template-parts/content-search.php - ok
  • template-parts/content.php - ok
  • fonts/NotoSans-*
    • Remove fonts NotoSans which are not used yet.
  • custom-editor-style.css
    • Not engouth CSS for editor. The purpose of editor style is to show the post in TinyMCE editor exact as on front end.
  • header.php
    • Enqueued google font 'Open Sans' hard coded. Use action wp_enqueue_scripts to add google fonts.
    • Use the_custom_logo() except rainbownews_the_custom_logo()
    • echo $description should be esc_html( $description )
    • Could not understand this condition -
      if ( ! dynamic_sidebar( 'rainbownews_advertisement' ) ) :
      endif;
      
    • Remove commented code - Line - 103 - 111
  • readme.txt
    • [Note] You can maintain separate changelog file except adding in readme.txt.
  • rtl.css
    • No any CSS in rtl.css file.
  • sidebar.php
    • Remove package Power_Mag. Use your own.
  • category.php
    • Complicated logic to show categories.
    • Package maybe 'RainbowNews' except 'Rainbownews'
  • style.css
    • Removed unwanted commented CSS code.
  • layouts/content-sidebar.css
    • Unused file. If not required then remove it.
  • layouts/sidebar-content.css
    • Unused file. If not required then remove it.
  • css/admin/rainbownews-admin.css
    • [Note] CSS selector input[type=checkbox]:before affects all the customizer controls.
  • css/responsive.css
    • Remove unused media quries. Add these whenever its required.
  • inc/admin/meta-boxes.php
    • You can remove the extra function call rainbownews_layout_call()
    • Missing prefix for nonce custom_meta_box_nonce.
  • inc/extras.php
    • Why empty value passed in filter body_class. E.g.
      if ( is_home() || is_page_template( 'template-home.php' ) || is_front_page() ) {
       $rainbownews_classes[] = '';
      
  • inc/rainbownews-functions.php
    • Missing Translation strings. Recently, I give you example the example ( E.g. echo $before . 'Error 404' . $after; ). You just change this string. This is okay. But, You need to apply this rule for all strings.
    • Use the_excerpt and its filters instead of rainbownews_excerpt
  • inc/rainbownews-widget.php
    • Package name 'RainbowNews' instead of rainbowNews
  • inc/widgets/rainbownews_advertisement.php
    • Avoid inline CSS E.g. max-width:250px
    • Improve code formatting. E.g. Except below code:
      <div class="<?php if ( $style == 'style2' ) {
      			echo 'nnc-970X250-ads';
      } elseif ( $style == 'style3' ) {
      	echo 'nnc-970X90-ads';
      } else {
      	echo 'nnc-728X90-ads';
      
      } ?>">
      

Use can use:

if ( $style == 'style2' ) {
	$style_class = 'nnc-970X250-ads';
} elseif ( $style == 'style3' ) {
	$style_class = 'nnc-970X90-ads';
} else {
	$style_class = 'nnc-728X90-ads';
}
?>
<div class="<?php esc_attr_e( $style_class ); ?>">
  • inc/widgets/rainbownews_connect_with_us.php
  • inc/widgets/rainbownews_featured_post.php
  • inc/widgets/rainbownews_featured_post_layout1.php
  • inc/widgets/rainbownews_featured_post_layout2.php
  • inc/widgets/rainbownews_featured_post_layout3.php
  • inc/widgets/rainbownews_post_tab.php
  • inc/widgets/rainbownews_slider.php
  • inc/widgets/rainbownews_top_full_width.php
    • [Note: For all the widgets.]
    • Complicated logic to understand.
    • Missing escaping.
  • inc/wp-customize-class.php
    • Why this file has prefix 'wp'? Use your own prefix.
    • Fix the HTML markup <input <?php $this->link(); ?>style = 'display:none'
    • Use your prefix for $name = '_customize-radio-' . $this->id;
  • js/image-uploader.js
    • Use prefix for class custom_media_button
  • js/jquery-2.2.3.js
    • Recently you enqueued the default WordPress jQuery. So, Remove this unwanted file.
  • js/main.js
    • Remove commented code.
    • Improved the coding standard ( Code Indentation & Spacing ).

Notes:

  • Just for reference
  • For left sidebar you added below code:
    ?>
    <?php if ( $layout_meta == 'left-sidebar' ) :
    	?>
    	<aside id="secondary" class="widget-area" role="complementary">
    		<?php dynamic_sidebar( 'rainbownews_left_sidebar' ); ?>
    	 </aside><!-- #secondary -->
    	<?php
    endif;
    ?>
    

Except this you can create the sidebar-left.php and use below code:

?>
<?php if ( $layout_meta == 'left-sidebar' ) :
	get_sidebar( 'left' );
endif;
?>

#16 @Mahesh901122
8 months ago

Hi @99colorthemes,

Please check below final notes. Avoid [@mentor notes] which are for mentor.


Coding Review:

  • index.php - ok
  • archive.php - ok
  • comments.php - ok
  • functions.php - ok
  • page.php - ok
  • screenshot.png - ok
  • search.php - ok
  • searchform.php - ok
  • single.php - ok
  • template-home.php - ok
  • css/font-awesome.css - ok
  • css/swiper.css - ok
  • inc/custom-header.php - ok
  • inc/customizer.php - ok
  • inc/jetpack.php - ok
  • js/admin/rainbownews-admin.js - ok
  • js/customizer.js - ok
  • inc/template-tags.php - ok
  • js/navigation.js - ok
  • js/newsTicker.js - ok
  • js/skip-link-focus-fix.js - ok
  • js/swiper.js - ok
  • template-parts/content-none.php - ok
  • template-parts/content-search.php - ok
  • template-parts/content.php - ok
  • header.php - ok
  • readme.txt - ok
  • sidebar.php - ok
  • category.php - ok
  • style.css - ok
  • css/admin/rainbownews-admin.css - ok
  • css/responsive.css - ok
  • inc/admin/meta-boxes.php - ok
  • inc/extras.php - ok
  • inc/rainbownews-functions.php - ok
  • inc/rainbownews-widget.php - ok
  • inc/widgets/rainbownews_advertisement.php - ok
  • inc/widgets/rainbownews_connect_with_us.php - ok
  • inc/widgets/rainbownews_featured_post.php - ok
  • inc/widgets/rainbownews_featured_post_layout1.php - ok
  • inc/widgets/rainbownews_featured_post_layout2.php - ok
  • inc/widgets/rainbownews_featured_post_layout3.php - ok
  • inc/widgets/rainbownews_post_tab.php - ok
  • inc/widgets/rainbownews_slider.php - ok
  • inc/widgets/rainbownews_top_full_width.php - ok
  • js/main.js - ok
  • template-parts/content-page.php - ok
  • 404.php
    • Is it right to use class page-title for the description text? Class page-title is used for archive, search titles. So, If someone direct use .page-title selector without any specificity and write CSS then it affect on this too.
  • contact.php
    • Thanks for creating template file template-contact.php. [ @mentor notes: template-contact.php & page.php are almost same. Difference is template-contact.php get sidebar depends on theme mod. And page.php get the sidebar depends on page meta. Is there any way to use page.php except template-contact.php with filter? or any other? ]
  • footer.php
    • Please check below snippets. Use code:
         <?php if ( is_active_sidebar( 'rainbownews_front_page_gallery_area' ) ) { ?>
      	<!-- Gallery-start -->
      	<div class="nnc-f-gallery nnc-top-latest">
          	<?php dynamic_sidebar( 'rainbownews_front_page_gallery_area' ); ?>
      	</div><!-- .nnc-f-gallery .nnc-top-latest -->
      	<!-- Gallery-end -->
         <?php } ?>
      
      Instead of
      <!-- Gallery-start -->
      <div class="nnc-f-gallery nnc-top-latest">
          <?php
          if ( is_active_sidebar( 'rainbownews_front_page_gallery_area' ) ) {
              dynamic_sidebar( 'rainbownews_front_page_gallery_area' );
          }
          ?>
      </div>
      <!-- Gallery-end -->
      
    • Do this for all conditions E.g. if ( is_active_sidebar( 'rainbownews_footer1_area' ) || is_active_sidebar( 'rainbownews_footer2_area' ) || is_active_sidebar( 'rainbownews_footer3_area' ) || is_active_sidebar( 'rainbownews_footer4_area' ) ) : too. ( Because, If no one sidebar is active then its unwanted output empty HTML markup. E.g. <div class="nnc-footer"><div class="nnc-container"></div></div> )
    • Line 54 should be <?php if ( is_active_sidebar( 'rainbownews_footer4_area' ) ) { ?> instead of <?php if ( is_active_sidebar( 'rainbownews_footer3_area' ) ) { ?>
  • css/styles.css
    • You already enqueued google font though wp_enqueue_script. So remove @import from style.css.
  • custom-editor-style.css
    • It still not engouth CSS for editor style. The purpose of editor style is to show the post in TinyMCE editor exact as on front end.
  • js/image-uploader.js
    • You can use class rainbownews_media_button instead of custom_media_button.

Design Review:

All page, post, archive, search & 404 page designs NOT looking good.
Is this your final theme design? or something CSS is missing?

If DESIGN REVIEW does not matter then, I'll approve your theme depends ONLY on CODE REVIEW.

https://qsnapnet.com/snaps/kpl9wb9s6qsvpld
https://qsnapnet.com/snaps/nysf2lshp43ac3d
https://qsnapnet.com/snaps/zl15xfpglclyp66
All snaps: https://qsnapnet.com/folders/v0iptwvbw3vdkj4


Please try to fix all the issues before 7 days. To get theme approve ASAP.

#18 @Mahesh901122
8 months ago

  • Status changed from reviewing to approved

Hi @99colorthemes,

Congratulations. Approving RainbowNews theme.


[NOTE: I reviewed all the possible things and approve the theme. Now, Theme goes to the final review. Where Team reviewer will review and live your theme.]


Thanks for Contributing.

#19 @juhise
6 months ago

  • Status changed from approved to reopened

Hey @99colorthemes,

I am doing the final review, please fix below issues:

REQUIRED

Escaping

  • Escape L244 rainbownews-functions.php
  • Escape as late as possible L376 $homelink, $home rainbownews-functions.php
  • Escape get_the_time L393,394,395 rainbownews-functions.php

Please look at other places, there are many other places where escaping is missing.

Translation

  • Translation missing for Search results for in rainbownews-functions.php L388
  • Translation missing for No Comments L196 rainbows_-featured_post_layout1.php
  • Strings should have translatable content L315 inc/customizer.php
  • Strings should have translatable content L54 inc/template-tags.php
  • Strings should have translatable content L538 inc/rainbownews-functions.php

Code

  • Found usage of constant "HEADER_TEXTCOLOR". Use add_theme_support( 'custom-header' ) instead.
  • Escape and Store it $_POST['rainbownews_custom_meta_box_nonce'] in a variable and then use further.

@Mahesh901122
Could you please continue the review?

Best Regards,
Juhi

#20 @juhise
6 months ago

  • Owner changed from Mahesh901122 to juhise
  • Status changed from reopened to reviewing

#21 @juhise
6 months ago

Hey @99colorthemes,

Please fix below issues too:

Customizer Settings

  • When Header Logo Only is selected it’s showing Header Text too
  • Activate search box has wrong text Activate Breadcrumb
  • Header image not appearing

#22 @99colorthemes
6 months ago

Hello @juhise

Thankyou for your quick review. We will update theme within 3 days. I don't understand about escape get_the_time function . Could you plz tell me about the escape get_the_time function ?

#24 @juhise
6 months ago

@99colorthemes

Some issues are not fixed, please fix:

  • Escape as late as possible L376 $homelink, $home rainbownews-functions.php - You need to escape when using it. It should be escaped as late as possible. Like this <a href="' .esc_url( $homeLink)
  • Strings should have translatable content L315 inc/customizer.php- Not Fixed
  • Strings should have translatable content L54 inc/template-tags.php- Not Fixed
  • Strings should have translatable content L538 inc/rainbownews-functions.php- Not Fixed
  • Escape rainbownews_footer_count in footer.php

Best Regards,
Juhi

#26 @juhise
6 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Hey @99colorthemes

I am making your theme live.

Good luck!

Best Regards,
Juhi

Last edited 6 months ago by juhise (previous) (diff)
Note: See TracTickets for help on using tickets.