WordPress.org

Make WordPress Themes

Change History (3)

comment:1 emiluzelac3 years ago

  • Owner set to karmatosed
  • Status changed from new to assigned

@karmatosed since you reviewed the previous version I am assigning the newest one as well. And hope that you are all right with that.

comment:2 karmatosed3 years ago

Thank you for your theme submission, here are my findings on running the theme review.


Theme review results:


Theme check test results : PASSED

1. Required: None

2. Recommended:

RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
RECOMMENDED: No reference to add_custom_image_header was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
RECOMMENDED: No reference to add_custom_background() was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.

3. Information:

INFO: At least one hard coded date was found in the file left-meta.php. Consider get_option( 'date_format' )

Debugger results: PASSED


Test data results: PASSED


Visual issues / functionality / browser checks: PASSED


Validation: 19 Errors, 40 warning(s): FAILED (considering it's use of html some are acceptable) - too many to list strongly advise theme author reviews these

Unable to Determine Parse Mode!
eneral entity X not defined and no default entity 

Line 14, column 68: general entity "raquo" not defined and no default entity
…lication/rss+xml" title="theme test » Feed" href="http://localhost/them
Line 59, column 130: general entity "bull" not defined and no default entity
…estwp/tag/tag1/" rel="tag">tag1</a> &bull; <a href="http://localhost/themetes
Line 59, column 279: general entity "nbsp" not defined and no default entity
…testwp/tag/tag3/" rel="tag">tag3</a>&nbsp;

cannot generate system identifier for general entity X

Line 14, column 68: cannot generate system identifier for general entity "raquo"
…lication/rss+xml" title="theme test &raquo; Feed" href="http://localhost/them
Line 59, column 130: cannot generate system identifier for general entity "bull"
…estwp/tag/tag1/" rel="tag">tag1</a> &bull; <a href="http://localhost/themetes
Line 59, column 279: cannot generate system identifier for general entity "nbsp"
…testwp/tag/tag3/" rel="tag">tag3</a>&nbsp;

reference to entity X for which no system identifier could be generated 

Line 14, column 73: reference to entity "raquo" for which no system identifier could be generated
…ion/rss+xml" title="theme test &raquo; Feed" href="http://localhost/themetest
Line 15, column 73: reference to entity "raquo" for which no system identifier could be generated
…ion/rss+xml" title="theme test &raquo; Comments Feed" href="http://localhost/
Line 59, column 134: reference to entity "bull" for which no system identifier could be generated
…p/tag/tag1/" rel="tag">tag1</a> &bull; <a href="http://localhost/themetestwp/
Line 59, column 209: reference to entity "bull" for which no system identifier could be generated
…p/tag/tag2/" rel="tag">tag2</a> &bull; <a href="http://localhost/themetestwp/
Line 59, column 283: reference to entity "nbsp" for which no system identifier could be generated
…wp/tag/tag3/" rel="tag">tag3</a>&nbsp;
Line 95, column 53: reference to entity "nbsp" for which no system identifier could be generated
                                                &nbsp;
Line 132, column 142: reference to entity "bull" for which no system identifier could be generated
…attels/" rel="tag">chattels</a> &bull; <a href="http://localhost/themetestwp/
Line 132, column 226: reference to entity "nbsp" for which no system identifier could be generated
…vation/" rel="tag">privation</a>&nbsp;
Line 176, column 53: reference to entity "nbsp" for which no system identifier could be generated
                                                &nbsp;
Line 264, column 149: reference to entity "nbsp" for which no system identifier could be generated
…ats/" rel="tag">Post Formats</a>&nbsp;
Line 300, column 149: reference to entity "nbsp" for which no system identifier could be generated
…ats/" rel="tag">Post Formats</a>&nbsp;
Line 338, column 149: reference to entity "nbsp" for which no system identifier could be generated
…ats/" rel="tag">Post Formats</a>&nbsp;
Line 374, column 149: reference to entity "nbsp" for which no system identifier could be generated
…ats/" rel="tag">Post Formats</a>&nbsp;
Line 410, column 149: reference to entity "nbsp" for which no system identifier could be generated
…ats/" rel="tag">Post Formats</a>&nbsp;
Line 446, column 149: reference to entity "nbsp" for which no system identifier could be generated
…ats/" rel="tag">Post Formats</a>&nbsp;
 NET-enabling start-tag requires SHORTTAG YES

Line 4, column 22: NET-enabling start-tag requires SHORTTAG YES
<meta charset="UTF-8" />
Line 5, column 50: NET-enabling start-tag requires SHORTTAG YES
<link rel="profile" href="http://gmpg.org/xfn/11" />
Line 6, column 61: NET-enabling start-tag requires SHORTTAG YES
… rel="theme author" href="ZHAO Xudong,zxdong@gmail.com" />
Line 8, column 56: NET-enabling start-tag requires SHORTTAG YES
<meta name="robots" content="index,follow,noodp,noydir" />
Line 9, column 63: NET-enabling start-tag requires SHORTTAG YES
…e="description" content="Just another WordPress site" />
Line 10, column 53: NET-enabling start-tag requires SHORTTAG YES
<meta name="keywords" content="wordpress,theme test" />
Line 11, column 124: NET-enabling start-tag requires SHORTTAG YES
…p-content/themes/cssfever/style.css" />
Line 12, column 68: NET-enabling start-tag requires SHORTTAG YES
…" href="http://localhost/themetestwp/xmlrpc.php" />
Line 13, column 47: NET-enabling start-tag requires SHORTTAG YES
<meta name='robots' content='noindex,nofollow' />
Line 14, column 123: NET-enabling start-tag requires SHORTTAG YES
…"http://localhost/themetestwp/feed/" />
Line 15, column 141: NET-enabling start-tag requires SHORTTAG YES
…ocalhost/themetestwp/comments/feed/" />
Line 17, column 110: NET-enabling start-tag requires SHORTTAG YES
…ocalhost/themetestwp/xmlrpc.php?rsd" />
Line 18, column 123: NET-enabling start-tag requires SHORTTAG YES
…etestwp/wp-includes/wlwmanifest.xml" /> 
Line 19, column 74: NET-enabling start-tag requires SHORTTAG YES
…test' href='http://localhost/themetestwp/' />
Line 20, column 49: NET-enabling start-tag requires SHORTTAG YES
<meta name="generator" content="WordPress 3.1.1" />
Line 28, column 75: NET-enabling start-tag requires SHORTTAG YES
…="s" id="s" placeholder="search something"/> 
Line 29, column 55: NET-enabling start-tag requires SHORTTAG YES
	<input type="submit" id="searchsubmit" value="SEARCH" /> 
Line 168, column 264: NET-enabling start-tag requires SHORTTAG YES
…"aligncenter size-full wp-image-535" /> ALorem ipsum dolor sit amet, consecte
Line 170, column 260: NET-enabling start-tag requires SHORTTAG YES
…s="alignleft size-full wp-image-535" /> Lorem ipsum dolor sit amet, consectet
Line 172, column 262: NET-enabling start-tag requires SHORTTAG YES
…="alignright size-full wp-image-535" /> Lorem ipsum dolor sit amet, consectet
Line 174, column 260: NET-enabling start-tag requires SHORTTAG YES
…s="alignnone size-full wp-image-535" /> Lorem ipsum dolor sit amet, consectet
Line 231, column 271: NET-enabling start-tag requires SHORTTAG YES
…mbnail" alt="canola" title="canola2" /></a>
Line 234, column 356: NET-enabling start-tag requires SHORTTAG YES
…husk" title="dsc20040724_152504_532" /></a>
Line 240, column 347: NET-enabling start-tag requires SHORTTAG YES
…_132" title="dsc20050315_145007_132" /></a>
Line 241, column 37: NET-enabling start-tag requires SHORTTAG YES
			</dt></dl><br style="clear: both" /><dl class='gallery-item'>
Line 243, column 352: NET-enabling start-tag requires SHORTTAG YES
…421" title="dsc20050604_133440_3421" /></a>
Line 246, column 347: NET-enabling start-tag requires SHORTTAG YES
…_222" title="dsc20050727_091048_222" /></a>
Line 249, column 342: NET-enabling start-tag requires SHORTTAG YES
…56_52" title="dsc20050813_115856_52" /></a>
Line 250, column 37: NET-enabling start-tag requires SHORTTAG YES
			</dt></dl><br style="clear: both" /><dl class='gallery-item'>
Line 252, column 347: NET-enabling start-tag requires SHORTTAG YES
…_332" title="dsc20050831_165238_332" /></a>
Line 255, column 352: NET-enabling start-tag requires SHORTTAG YES
…vale" title="dsc20050901_105100_212" /></a>
Line 260, column 28: NET-enabling start-tag requires SHORTTAG YES
			<br style='clear: both;' />
Line 334, column 56: NET-enabling start-tag requires SHORTTAG YES
                                        <p>John: foo<br />
Line 335, column 13: NET-enabling start-tag requires SHORTTAG YES
Mary: bar<br />
Line 408, column 399: NET-enabling start-tag requires SHORTTAG YES
…"288" class="size-full wp-image-675" /></a><p class="wp-caption-text">A pictu
Line 444, column 429: NET-enabling start-tag requires SHORTTAG YES
…"480" class="size-full wp-image-612" /></a><p class="wp-caption-text">Chunk o


Other notes - None

There is no archive.php


Conclusion: Recommend PASS


Additional

You can use the following tools to recreate the issues raised above if any have been:

Theme Check Plugin:http://wordpress.org/extend/plugins/theme-check/
Theme Unit Test:http://codex.wordpress.org/Theme_Unit_Test
Log Deprecated Notices: http://wordpress.org/extend/plugins/log-deprecated-notices/
Themes should be reviewed using define('WP_DEBUG', true); in wp-config.php

You can also view the Theme Review page.

comment:3 emiluzelac3 years ago

  • Resolution set to approved
  • Status changed from assigned to closed

As there are no other issues here and going by @karmatosed recommendations this Theme is now approved.

Note: See TracTickets for help on using tickets.