WordPress.org

Make WordPress Themes

#35865 closed theme (not-approved)

THEME: Dloober. – 1.0.0

Reported by: GeroNikolov Owned by: poena
Priority: new theme Keywords: theme-dloober
Cc: vtm.sunrise@…

Description

Dloober. - 1.0.0

Dloober. is simple design which is nice for every eye and it is compatible with every business. It is responsive & smooth, crafted for the biggest & for the smallest screens.

Theme URL - http://underscores.me/
Author URL - http://blogy.co?GeroNikolov

SVN - https://themes.svn.wordpress.org/dloober/1.0.0
ZIP - https://wordpress.org/themes/download/dloober.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#35865 THEME: Dloober. – 1.0.0 closed not-approved poena

(this ticket)


https://themes.svn.wordpress.org/dloober/1.0.0/screenshot.png

Change History (3)

#1 @Otto42
14 months ago

This is not a full review:

  • The screenshot is unacceptable by the theme review guidelines. The screenshot should be of the actual theme as it appears with reasonable default options, not a logo or mockup.

#2 @poena
12 months ago

  • Owner set to poena
  • Status changed from new to reviewing

#3 @poena
12 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hi
Your theme has been partially reviewed against these requirements:
https://make.wordpress.org/themes/handbook/review/required/

As part of the new theme directory guidelines, reviewers may now close tickets if a theme has 5 or more issues.
This is part of our long term goals to improve the theme quality and shorten the queues.
You can read more about this change here: https://make.wordpress.org/themes.

Please do not get discouraged by the ticket being closed. -We want you to resubmit your theme,
but we do ask that you spend more time making sure that your theme meets all the requirements.
https://make.wordpress.org/themes/handbook/review/required/
You can upload your update here: https://wordpress.org/themes/upload/

Because of the large number of themes waiting for review, we might not be able to follow up immediately.
We will review your update when your theme reaches the top of the review queue.

If you have questions you can ask them here or in the #themereview channel on Slack
channel.

Required:

As was mentioned, the screenshot needs to be replaced. It needs to be an image of the theme.

When I activate the theme I get the following php notices:

Notice: Use of undefined constant is_archive - assumed 'is_archive' \dloober\header.php on line 43
Notice: Trying to get property of non-object in dloober\header.php on line 45
Notice: Undefined property: WP_Error::$taxonomy in \dloober\header.php on line 48
Notice: Undefined property: WP_Error::$taxonomy in \dloober\header.php on line 49

And the following js errors:

(index):29 Uncaught SyntaxError: Invalid or unexpected token
(index):44 Uncaught SyntaxError: Unexpected token <

The Theme URI is incorrect. This link is optional, you can leave it empty until your page is ready.

Provide a unique prefix for everything the Theme defines in the public namespace, including options, functions, global variables, constants, post meta, etc.
There is a large ammount of functions in functions.php that are not prefixed.
Themes are for design, not functionality. You need to remove the send_order function.

Include all scripts and resources it uses rather than hotlinking. The exception to this is Google Fonts.
For example the image linked from your site and font awesome needs to be included in the theme folder.
No hard coding of script and style files. You need to remove the scripts and styles from header.php and enqueue them.
https://developer.wordpress.org/reference/functions/wp_enqueue_script/

There is text in your theme that are missing translation functions. Please check all your files.
See footer.php where the year is hard coded to 2016. It is soon 2017, use a date function instead.

The readme files are referring to underscores and needs to be updated.
Include a copyright statement for the theme itself, this is required to use GPL.
See https://make.wordpress.org/themes/2014/07/08/proper-copyrightlicense-attribution-for-themes/

The theme tags in style.css and description must match what the theme actually does in respect to functionality and design.
See https://make.wordpress.org/themes/handbook/review/required/theme-tags/

Please remove any and all code, files or folders that are not used.


Recommended reading:

https://make.wordpress.org/themes/handbook/review/required/
https://make.wordpress.org/themes/handbook/review/resources/

https://developer.wordpress.org/themes/functionality/internationalization/
https://codex.wordpress.org/Validating_Sanitizing_and_Escaping_User_Data

The coding standards are not required to pass the review, but they can be
helpful when developing your theme.
[https://make.wordpress.org/core/handbook/best-practices/coding-
standards/]

The code reference library is very useful when you want to know more about WordPress functions, classes, hooks and methods.
It can help you determine if a function needs to be escaped or not, or if a function you have planned to write is already available.
https://developer.wordpress.org/reference/

Note: See TracTickets for help on using tickets.