WordPress.org

Make WordPress Themes

#35906 closed theme (closed-newer-version-uploaded)

THEME: Zerif Lite – 1.8.4.7

Reported by: themeisle Owned by: grapplerulrich
Priority: theme update Keywords: theme-zerif-lite 2nd-opinion
Cc: ionut+worg@…

Description

Zerif Lite - 1.8.4.7

Zerif LITE is a free one page Wordpress theme. It’s perfect for web agency business,corporate business,personal and parallax business portfolio, photography sites and freelancer.Is built on BootStrap with parallax support, is responsive, clean, modern, flat and minimal. Zerif Lite is ecommerce (WooCommerce) Compatible, WPML, RTL, Retina-Ready, SEO Friendly and with parallax, full screen image is one of the best business themes.

Theme URL - http://themeisle.com/themes/zerif-lite/
Author URL - http://themeisle.com

SVN - https://themes.svn.wordpress.org/zerif-lite/1.8.4.7
ZIP - https://wordpress.org/themes/download/zerif-lite.1.8.4.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=zerif-lite/1.8.4.6&new_path=zerif-lite/1.8.4.7

History:

Ticket Summary Status Resolution Owner
#20384 THEME: Zerif Lite - 1.0.5 closed live karmatosed
#21317 THEME: Zerif Lite - 1.3 closed live catchthemes
#21451 THEME: Zerif Lite - 1.3.1 closed live emiluzelac
#21597 THEME: Zerif Lite - 1.3.9 closed live jcastaneda
#22197 THEME: Zerif Lite - 1.4.0 closed live karmatosed
#22433 THEME: Zerif Lite - 1.4.1 closed live karmatosed
#22574 THEME: Zerif Lite - 1.4.3 closed live jcastaneda
#22756 THEME: Zerif Lite - 1.4.4 closed live nishasingh
#22951 THEME: Zerif Lite - 1.4.5 closed live Milmor
#23105 THEME: Zerif Lite - 1.4.6 closed live grapplerulrich
#23191 THEME: Zerif Lite - 1.4.7 closed live emiluzelac
#23364 THEME: Zerif Lite – 1.5.2 closed live jcastaneda
#23596 THEME: Zerif Lite – 1.5.4 closed live hardeepasrani
#23775 THEME: Zerif Lite – 1.6.0 closed live jcastaneda
#24098 THEME: Zerif Lite – 1.7.1 closed live poena
#24296 THEME: Zerif Lite – 1.7.2 closed live jcastaneda
#24323 THEME: Zerif Lite – 1.7.3 closed live jacenty3590
#24568 THEME: Zerif Lite – 1.7.6 closed live karmatosed
#24907 THEME: Zerif Lite – 1.8.2.1 closed live chipbennett
#25711 THEME: Zerif Lite – 1.8.2.2 closed live jcastaneda
#26096 THEME: Zerif Lite – 1.8.2.3 closed live chipbennett
#26505 THEME: Zerif Lite2015 – 1.8.2.3 closed not-approved alex27
#26918 THEME: Zerif Lite Nicole – 2.0.1.1 closed not-approved jcastaneda
#26955 THEME: Zerif litez – 2.0.1.2 closed not-approved jcastaneda
#27715 THEME: Zerif Lite mine – 1.8.2.5 closed not-approved jcastaneda
#27836 THEME: Zerif Lite – 1.8.2.4 closed live karmatosed
#27977 THEME: Zerif Lite – 1.8.2.5 closed live jcastaneda
#28112 THEME: Zerif Lite – 1.8.2.6 closed live karmatosed
#28449 THEME: Zerif Lite – 1.8.2.7 closed live karmatosed
#28454 THEME: Zerif Lite – 1.8.2.8 closed live karmatosed
#28637 THEME: Zerif Lite – 1.8.2.9 closed live karmatosed
#28818 THEME: Zerif Lite – 1.8.3.0 closed live karmatosed
#29196 THEME: Zerif Lite – 1.8.3.1 closed live Otto42
#29720 THEME: Zerif Lite – 1.8.3.2 closed live greenshady
#29824 THEME: Zerif Lite – 1.8.3.3 closed live Otto42
#30045 THEME: Zerif Lite – 1.8.3.5 closed live joedolson
#31136 THEME: Zerif Lite – 1.8.3.6 closed live themetracbot
#31326 THEME: Zerif Lite – 1.8.3.7 closed live themetracbot
#31338 THEME: Zerif Lite – 1.8.3.8 closed live themetracbot
#31672 THEME: Zerif Lite – 1.8.4.0 closed live themetracbot
#32649 THEME: Zerif Lite – 1.8.4.1 closed live themetracbot
#33432 THEME: Zerif Lite – 1.8.4.3 closed live themetracbot
#33435 THEME: Zerif Lite – 1.8.4.4 closed live themetracbot
#34821 THEME: Zerif Lite – 1.8.4.5 closed live themetracbot
#35904 THEME: Zerif Lite – 1.8.4.6 closed live themetracbot
#35906 THEME: Zerif Lite – 1.8.4.7 closed closed-newer-version-uploaded grapplerulrich

(this ticket)

#35981 THEME: Zerif Lite – 1.8.4.8 closed live themetracbot
#36004 THEME: Zerif Lite – 1.8.4.9 closed live themetracbot
#38196 THEME: Zerif Lite – 1.8.5.5 closed closed-newer-version-uploaded grapplerulrich
#38491 THEME: Zerif Lite – 1.8.5.8 closed live grapplerulrich
#40574 THEME: Zerif Lite – 1.8.5.9 closed live themetracbot
#40631 THEME: Zerif Lite – 1.8.5.10 closed live themetracbot
#40693 THEME: Zerif Lite – 1.8.5.11 closed live themetracbot
#40754 THEME: Zerif Lite – 1.8.5.12 closed live themetracbot
#40959 THEME: Zerif Lite – 1.8.5.13 closed live themetracbot
#40969 THEME: Zerif Lite – 1.8.5.14 closed live themetracbot
#40986 THEME: Zerif Lite – 1.8.5.15 closed live themetracbot
#41931 THEME: Zerif Lite – 1.8.5.16 closed live themetracbot
#42398 THEME: Zerif Lite – 1.8.5.17 closed live themetracbot
#42453 THEME: Zerif Lite – 1.8.5.18 closed live themetracbot
#42609 THEME: Zerif Lite – 1.8.5.19 closed live themetracbot
#42726 THEME: Zerif Lite – 1.8.5.20 closed live themetracbot
#42812 THEME: Zerif Lite – 1.8.5.21 closed live themetracbot
#42914 THEME: Zerif Lite – 1.8.5.22 closed live themetracbot
#42936 THEME: Zerif Lite – 1.8.5.23 closed live themetracbot
#43874 THEME: Zerif Lite – 1.8.5.24 closed live themetracbot
#44274 THEME: Zerif Lite – 1.8.5.25 closed live themetracbot
#45942 THEME: Zerif Lite – 1.8.5.26 closed live themetracbot
#45946 THEME: Zerif Lite – 1.8.5.27 closed live themetracbot
#45953 THEME: Zerif Lite – 1.8.5.28 closed live themetracbot
#46180 THEME: Zerif Lite – 1.8.5.29 closed live themetracbot
#47696 THEME: Zerif Lite – 1.8.5.30 closed live themetracbot
#47965 THEME: Zerif Lite – 1.8.5.31 closed live themetracbot
#48058 THEME: Zerif Lite – 1.8.5.32 closed live themetracbot


https://themes.svn.wordpress.org/zerif-lite/1.8.4.7/screenshot.png

Change History (40)

#1 @themetracbot
15 months ago

  • Owner set to themetracbot
  • Status changed from new to reviewing

Theme Update for existing Live theme - automatically reviewed

#2 @themetracbot
15 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Theme Update for existing Live theme - automatically approved

#3 follow-up: @timjared
15 months ago

Hi! I would like to point out that this theme and many others in top 100 are mentioned as examples in reviews because they are allowed to:

Use demo content
Create content using pseudo custom post types.
Use contact forms (plugin territory) enabled by default.

I know this is an old theme with 100k+ users, but this doesn’t mean you can’t do a few changes that will get this theme on the same page as new themes (which are required to follow the guidelines).

Things that must be changed:

Functions.php:

  • zerif_register_default_widgets() - this functions adds widgets and demo content into the database. Your current users have already saved this info, changed it. It shouldn’t be a problem to remove it.
  • zerif_ourfocus, zerif_testimonial_widget, zerif_clients_widget, zerif_team_widget are pseudo custom post types. This should also be removed, if you are still worried about backwards compatibility, you can try and check for theme version and for new installs make sure it follows the rules.
  • Contact form: you were asked by a few admins to remove it some time ago when you didn’t have so many users. Since then, you’ve managed to add recaptcha (which is plugin territory) instead of recommending a plugin.

../sections/ folder and all its files.

  • Instead of using sane defaults you are using demo content just to make your theme look pretty in the .org previewer. Also, they are used in case there are no widgets in the so called “sections”. Here is a simple issue, please try and remove the widgets (mentioned above) from those sections and you will see that this demo content will take their place. The user doesn’t have a say in this, to leave a section empty of content. Please remove any demo content and replace with sane defaults.
  • Things like “ONE OF THE TOP 10 MOST POPULAR THEMES ON WORDPRESS.ORG”, “GO PRO FOR MORE FEATURES”, “lorem ipsums” don’t have a place in themes based on current rules. If removed they do not affect your current users.

Customizer:

  • You have three sections locked (“Sections order and Colors”, “Google maps section”, “Pricing section” and displaying message like “Go Pro” in them. Also, there are similar closed sections in “Big title section”, “Our focus section”, “About us section” These must be removed because they don’t bring any value to users.
  • One upsell link at the top is enough and respects the current rules. Also make sure it doesn’t display when you click on sections, it is causing issues with the section title.

When you click on “Change” theme the top part of the list is hidden. This is mostly caused because some of your upsell links mess up with Customizer’s JS templating functions (margins and padding)

  • “Star this theme on WordPress.org!” at the bottom isn’t allowed and must be added on your theme promo page.

Zerif lite is most of the time given as an example in ticket reviews because it does all the above things. New developers take this theme as an example before they start creating themes. When they get their themes reviewed and “semi-rejected” they get frustrated and start pointing to this theme and many others, causing delays in reviews. Take for example this ticket 29713, it caused a 4 weeks delay.

Things need to change! Just because this theme is old, with many users, doesn’t mean it shouldn’t respect the guidelines like newer themes do.

@greenshady @grapplerulrich @djrmom

#4 @greenshady
15 months ago

Some of these issues were brought up 15 months ago and should've been addressed by now. https://themes.trac.wordpress.org/ticket/24907#comment:5 There has been ample time to migrate users forward.

As far as I can tell, none of the things that have been brought up have been addressed. Even something as simple as documenting a limitation in your readme ("Note in the readme that custom background only applies to the blog posts index") was not done. I even gave you a step-by-step guide on migrating the blog page template issue: https://themes.trac.wordpress.org/ticket/24907#comment:29

These are just simple things that could've been done right away without messing with existing users. Not doing them, to me, shows a total lack of respect for the TRT and the job that we perform. We've been extremely lenient and fair with this theme, moreso than we've ever been with any theme in the history of the TRT as far as I'm aware. But, at a certain point, we've got to make sure that Zerif Lite is following all the same rules that other themes have to follow. We've come to that point now.

#5 @themeisle
15 months ago

Hey Justin,

Thanks for jumping in! First of all this isn't about ignoring or not respecting TRT work, we have quite few newer themes which respect all those things and we are ourself members of TRT, we aren't trying to be shady or not comply with stuff.

Blog Templates

For me the blog template issue is related to the reading setting issue which is something that I have extensively written about that we can't change while maintaining a good UX.

Custom Background

The custom background notice honestly I just missed it, is a trivial thing to do ( that we just did now ), however in all the mess and comments everywhere at that time we have simply missed that line, it wasn't on purpose.

Overall Comments

The message mentioning that we aren't taking any step forward in fixing/migrating some of the stuff, especially the contact form, is completely false, since a while we created a generic plugin http://themeisle.com/plugins/pirate-forms// which when activated it automatically replace built-in contact form, however we weren't confident in removing the existing code since we still see users who doen't want/know how to activate a plugin and are using the theme functionality. Looking at the nr of active install of PirateForms you can figure out the we successfully managed to migrate quite a lot of users to this.

We have improved the upsell things by removing empty sections, again a thing that wasn't reported, we knew for newer themes is not ok but we just missed it, there are lots of themes and free users to maintain so sometime we can miss or delay things for a very long time.

#6 @greenshady
15 months ago

Let's just focus on one thing at a time. What steps have you taken to correct the reading settings issues?

Let's get that fixed here in the next version. That doesn't seem like an unreasonable request. You've had over a year to come up with a solution or reach out to the team for help.

I'm cool if you can show that you're taking the steps, from one version to the next, to correct the big issues that were laid out.

For example, the contact form should've been easy. You currently have "This theme recommends the following plugin: Pirate Forms.". Instead of that basic message, you could do something like "In version X.X.X, the theme will no longer have a contact form built in. We recommend installing the the Pirate Forms plugin."


What gets frustrating for the admins is that every time we turn around there's another theme author pointing out that Zerif Lite isn't following the rules. And, we have to say that you're in the process of making the necessary changes. However, it's been 15 months. That story that we tell everyone doesn't really work if the changes aren't actually happening in a timely manner.

And, I don't like to beat around the bush too much. At a certain point, the admins may simply make the decision to suspend the theme until it gets brought up to standards. I'm not saying we're at that point yet, but the reality is that the issues that we asked to be fixed have not been fixed.

#7 in reply to: ↑ 3 @emiluzelac
15 months ago

Replying to timjared:

Hi! I would like to point out that this theme and many others in top 100 are mentioned as examples in reviews because they are allowed to:

Use demo content
Create content using pseudo custom post types.
Use contact forms (plugin territory) enabled by default.

I know this is an old theme with 100k+ users, but this doesn’t mean you can’t do a few changes that will get this theme on the same page as new themes (which are required to follow the guidelines).

Things that must be changed:

Functions.php:

  • zerif_register_default_widgets() - this functions adds widgets and demo content into the database. Your current users have already saved this info, changed it. It shouldn’t be a problem to remove it.
  • zerif_ourfocus, zerif_testimonial_widget, zerif_clients_widget, zerif_team_widget are pseudo custom post types. This should also be removed, if you are still worried about backwards compatibility, you can try and check for theme version and for new installs make sure it follows the rules.
  • Contact form: you were asked by a few admins to remove it some time ago when you didn’t have so many users. Since then, you’ve managed to add recaptcha (which is plugin territory) instead of recommending a plugin.

../sections/ folder and all its files.

  • Instead of using sane defaults you are using demo content just to make your theme look pretty in the .org previewer. Also, they are used in case there are no widgets in the so called “sections”. Here is a simple issue, please try and remove the widgets (mentioned above) from those sections and you will see that this demo content will take their place. The user doesn’t have a say in this, to leave a section empty of content. Please remove any demo content and replace with sane defaults.
  • Things like “ONE OF THE TOP 10 MOST POPULAR THEMES ON WORDPRESS.ORG”, “GO PRO FOR MORE FEATURES”, “lorem ipsums” don’t have a place in themes based on current rules. If removed they do not affect your current users.

Customizer:

  • You have three sections locked (“Sections order and Colors”, “Google maps section”, “Pricing section” and displaying message like “Go Pro” in them. Also, there are similar closed sections in “Big title section”, “Our focus section”, “About us section” These must be removed because they don’t bring any value to users.
  • One upsell link at the top is enough and respects the current rules. Also make sure it doesn’t display when you click on sections, it is causing issues with the section title.

When you click on “Change” theme the top part of the list is hidden. This is mostly caused because some of your upsell links mess up with Customizer’s JS templating functions (margins and padding)

  • “Star this theme on WordPress.org!” at the bottom isn’t allowed and must be added on your theme promo page.

Zerif lite is most of the time given as an example in ticket reviews because it does all the above things. New developers take this theme as an example before they start creating themes. When they get their themes reviewed and “semi-rejected” they get frustrated and start pointing to this theme and many others, causing delays in reviews. Take for example this ticket 29713, it caused a 4 weeks delay.

Things need to change! Just because this theme is old, with many users, doesn’t mean it shouldn’t respect the guidelines like newer themes do.

@greenshady @grapplerulrich @djrmom

@timjared Don't create an account just to do this, if you want to bring something to our attention, please get in touch with us on Slack! This, not only that's uncool, but it's not allowed either.

#8 @greenshady
15 months ago

After some discussion in the key reviewer chat today, we decided that this is an issue that needs to be corrected. We're giving you 2 weeks to make the appropriate changes to the theme. If the changes are not made in that time, the theme will be suspended.


What I will do is personally go over the theme shortly and make a list of items that need to change. You already know most of them. However, this way, there's a clear set of goals to achieve.

What I'd like to get from you is a commitment that you'll make these changes to the theme.


A big reason for this is that it's an issue that we're having to deal with on an ongoing basis. And, the problems outlined should've been corrected at this point.

We understand that Zerif Lite is one of the top themes on WordPress.org. That means that it's in the spotlight and will come under even greater scrutiny than some other themes. That just goes with the territory. That's also part of the reason we've been extremely lenient for so long.

We have to draw a line in the sand so that the guidelines are being applied fairly to everyone. This is that line.

#9 @greenshady
15 months ago

The following is a list of items that must be corrected. These are primarily the "big" items. There may be smaller issues that we need to address in the future. However, the important thing right now is to correct these bigger issues.

The theme must use the core WordPress custom-logo feature. It also cannot display a default logo. Instead, show the user's site title.

Front Page

The front page must work according to the user-selected settings defined via Settings > Reading in the admin. If the user has chosen to display posts, the theme must display the blog posts index.

If the user has chosen to display a page, the theme may output a custom design.

The best route is to create a custom page template that the user can choose to use on any page of their site, including the front page.

Demo Content

The theme is not allowed to display demo content. It should either display the user's existing content or nothing at all until a user has explicitly chosen to display something.

Demo content includes but may not be limited to:

  • The fake content used on the front page.
  • Footer: Contact info.
  • Footer: Social links.

Contact Form

Contact forms are plugin territory and not allowed in themes. This includes the reCaptcha functionality.

Themes are allowed one top-level link in the customizer. This link should be done using the customizer API and not injected into the DOM via JavaScript.

Locked Customizer Sections

A single locked section, such as "More info" or "Go pro" is OK. However, multiple sections that are locked and provide no usable options are not allowed.

Background Image

Make a note in the readme file that the theme limits this to the custom front page (or anywhere else it's used). Themes are required to document these types of limitations.

Blog Templates

Themes are required to work with the core WordPress template hierarchy. This means that the custom blog page templates in the theme are not correct. The core hierarchy uses the home.php template when is_home() (i.e., blog posts index).

What you can do is create a customizer option to allow the user to select different layouts for different blog designs.

Plugin Territory: Widgets

The following widgets are what we consider pseudo custom post types and are not allowed.

  • Our Focus Widget
  • Clients Widget
  • Team Member Widget
  • Testimonial Widget

The problem is that the content for these widgets is lost when the user switches to a different theme. You can integrate with existing plugins or even use the core text widget for some of these items.

Archive Title and Description

The archive title and description must be output using the_archive_title() and the_archive_description() core functions.

Default Background Image

This image is broken when using a child theme. From functions.php:

'default-image' => get_stylesheet_directory_uri() . "/images/bg.jpg",

Either check that file exists first or use get_template_directory_uri().

wp_title() back-compat

You can remove this code from functions.php since we only allow back-compatibility up to 3 versions:

if ( ! function_exists( '_wp_render_title_tag' ) ) {
	function zerif_old_render_title() {
?>
<title><?php wp_title( '|', true, 'right' ); ?></title>
<?php
	}
	add_action( 'wp_head', 'zerif_old_render_title' );
}

This ticket was mentioned in Slack in #themereview by ionutn. View the logs.


15 months ago

#11 @themeisle
15 months ago

Hey @greenshady,

Thanks for the detailed review. We already fixed the title, bg image, title and logo. Now, regarding the other mentions, the answer is longer.

It is strange to be in this position, time and time again, whenever someone creates a new/annonymous account just to spread their frustration and hate towards our theme. Also, you are saying that Zerif Lite was kind of protected compared with other themes, which is false and we never asked for preferential treatment.

Front Page + Blog Templates

  1. Migration of the setting

As I wrote before, without being allowed to force the change of the settings or using forceful notifications, the experience for the users will be awful. They will be forced to take more steps to get their website fixed (in case they will notice it and won't be automatically updated).

  1. How settings->reading core setting works

The current workflow of setting a frontpage in WordPress, especially when we are talking about one-page sites, is in my opinion completely broken. 99% of our users want the one-page layout, as they see in the screenshot/demo. However, in order to do that, they are all required to take 3 steps that not all of them know how to do: create an empty page, set page template, set the page as the frontpage - and not all of them can be even done in the same place. We have tried for a while to get involved and solve this, however with no luck: https://core.trac.wordpress.org/ticket/19627#comment:74>.

  1. How preview works

This setting enabled us, as many other authors too, to kind of bypass the awful experience that we have with previewing themes in the wordpress.org repo. We are not solving the core problem (improving the previewer). However, personally, I still don't understand how we can get noticed and involved in the core/meta development, every time we have tried, we got no answers or no relevant ones.

Contact Form + faux CPT/widgets

I fully agree that this is plugin territory. However, this along with the other things that we consider plugin territory (like: faux CPT, custom css, analytics or child theme creation), are things that users need. We can do a survey and see what beginners think about having to install 10 plugins in order to get a 'simple' one-page site to work.

The current experience of recommending/installing and configuring plugins is bad. The main reason is because WordPress lacks some standardized advanced installer (like jetpack start) and because themes AREN'T ALLOWED to use installers like, for example, WooCommerce is doing - in order to configure the theme or automatically install some plugins, see https://www.youtube.com/watch?v=vMey1BrKP_A .

Matt Mullenweg said this better on slack as well : "we have a lot of hard and strict rules designed to "protect" users, like around CPTs et al, but someone could make an informed decision to trade off future potential portability for current form or functionality. it would be a perfectly rational decision to make"

Just like 1.5 years ago, I still believe today that trading user experience for getting accepted in the directory is not something that we are willing to do, and not because we don't want to comply with the rules, we are in this market to create the best themes for people.

We love our inclusion in the WordPress.org theme directory, and would love to be able to fully comply with the rules that benefit users. We have made decisions over the years, that in our opinion help the user experience, and at various times were approved by the theme team.

If removing some of those features is forced on us, and we cannot remove them without disrupting the existing user experience, then we would rather be suspended from the repo. But we hope it doesn't come to that. We would love to continue a constructive conversation about how we can offer an improved onboarding and user experience while fully cooperating within the bounds of the theme team's guidelines.

Possible solutions

First, I guess we should all agree that things aren't perfect currently regarding the theme process. I guess we should all look at previously reported issues, and think if those changes really benefit the users, or just make our lives as theme reviewers easier by not having people showing Zerif Lite as example. A rule that's set at the user's expense isn't a good rule.

I know we are working towards automation, and I believe that accepting every secure theme + having a better search algorithm (what plugin repo is doing) is both the easiest and the best thing we can do. This will give more freedom and will enable us - as theme authors - to explore things like on-boarding ( https://www.youtube.com/watch?v=vMey1BrKP_A ), for example, which could help us to offer a great 'look like the demo' experience while doing what is good for users (like no plugin territory things).

LE : For people reading this might be a valuable discussion as well : https://wordpress.slack.com/archives/themereview/p1432860396003236 ( you need to be in the WP slack channel ).

Best regards,
Ionut

Last edited 15 months ago by themeisle (previous) (diff)

#12 @greenshady
15 months ago

These are problems that you've had a lot of time to address. You've had a lot of time to come to us for help. At this point, it just needs to be done. That's where we're at.

Not sure what you want us to say here.

You don't get a pass on the same guidelines that every other theme has to follow. As I've said before in discussions about things you've mentioned, I'd like to see a better front page process, a better previewer, and a dependency management system. However, until those things are done, we have the system that we have. We have to work within that system.

What I outlined earlier is what needs to happen for the theme to continue being in the directory.

#13 @themeisle
15 months ago

Hey Justin,

The problem isn't time, is the lack of solutions, nothing proposed in the previous discussion from 15 months ago will work, have you ever tried to put a note in readme that your frontpage will be changed in the next update and saw if people are reading it ?

Unless we can run a migration script (which we were explicitly said that we cannot) which for example will automatically activate PirateForms on update or it will automatically create a new page and set it as FrontPage all other options will imply a broken site and steps that users will need to take.

Even for a simple thing like ContactForm, we already did an year ago what you have mentioned : https://github.com/Codeinwp/zerif-lite/blob/production/functions.php#L109, we are saying to our users clearly the functionality will be removed in the next update and surprisingly we still find people everyday using the default theme functionality, I am also sure that we'll both see them in the support forums after update.

Also few questions that will help me taking the best decision :

  • If we will do the changes and users get unhappy, can we 'rollback' in next hours and get the theme suspended ?
  • Can this be done just for new users ? ( last time I checked it was not a solution, thought it worth asking )
  • Can we run an update routine ?
  • Any idea about what % of the users update themes? Including child themes we roughly have 200k active users.

It will probably take us a while to think this through and to address the required changes in case we decide to do so, in order to be fair with everybody feel free to suspend it after 2 weeks if you consider this is the best route for the repo.

This ticket was mentioned in Slack in #themereview by ionutn. View the logs.


15 months ago

#15 @greenshady
15 months ago

If we will do the changes and users get unhappy, can we 'rollback' in next hours and get the theme suspended ?

Either make the changes or don't. Of course if you do that, the theme will be suspended. I'm not sure what purpose rolling back the changes will serve.

Can this be done just for new users ? ( last time I checked it was not a solution, thought it worth asking )

No.

Can we run an update routine ?

Like auto-activating a plugin? No.

Like a temporary script for migrating existing (anyone on version 1.8.4.7 or below) users' front page to use a page instead of posts? Sure. No problem with that.

Any idea about what % of the users update themes? Including child themes we roughly have 200k active users.

No idea. It'd be interesting data to see.

Last edited 15 months ago by greenshady (previous) (diff)

#16 @ionutn
15 months ago

Hey Justin,

Thanks for clarification, is great to hear that there is an option to have a temporary migrate script for the frontpage setting, this can get one big repo guideline issue solved and we will think about that.

Now we still have 1 really big guideline issue : faux CPT, for which I can't see a seamless migration if we aren't allowed to auto-activate a 'companion' plugin while informing the user ( part of the migration script ). I am right ?

Off-topic :

The previous message as some explanations below were not made to get listed in the repo without doing what everybody else is doing, the purpose is to explain why we took those decisions ( which were accepted by TRT at that point) and why we think we did the right thing. I think both the goal of us as theme developers and you as key reviewer is to make sure the user gets the best experience.

Let's look at the faux custom post types rule, where you said that we should remove because that content is locked in the theme.

Our Focus Widget
Clients Widget
Team Member Widget
Testimonial Widget

First of all that content was designed to be used just on the front-page, is a one-page theme and users want to be that way, creating 4 custom post types for a content that is still minimal, I don't think it brings a lot of value, just way more complexity.

The accepted and most widely used solution by themes with the same focus is to create a 'companion'/'extensions' plugin and throw all of those plugin-teritorry things there, how is this better ? Isn't the content still locked in the db ? Or now is fine because is not a theme problem but a plugin problem ? While this approach follow the repo rules, I consider it to be worse, you are asking users to install a plugin to enjoy the theme, while continue to 'lock' that content.

The other recommended solution is to use generic plugins, like recommending a team plugin, testimonials plugin, client plugin, contact form plugin and so on, plugins which are indeed more flexible and users can enjoy using them with other themes as well, but the thing here is that you trade-off the initial setup UX ( requiring and configuring 5 plugins to setup a simple one page theme isn't the easiest thing for a user ) because you assume that users will need that in the future or you assume that there are other themes out there who can incorporate those 5 plugins as the current one is doing.

In an ideal world I agree that 2nd solution is a good one, but isn't the case in the current eco-system because isn't mature enough, plugins will break theme functionality and the theme will break the plugin one ( even big plugins like WooCoomerce aren't doing a great job in maintaining backward-compatibility ), while without being allowed to use an installer in the theme the whole installation/activation and configuration of those 5 plugins will be a nightmare.

We are talking with a lot of users on a daily basis, we have themes build in the all 3 scenarios and by far people would prefer to go with the option 1, like we are doing in Zerif for one-page themes. If we are talking about a portfolio theme or about a review theme where 1 standalone plugin is required ( not companion-like ), of course is clear that the best thing you can do is to recommend that plugin so users can easily switch themes while maintaining their review ratings, tables and so on.

#17 @greenshady
14 months ago

Yesterday was the final day of the two-week deadline the TRT admins gave for correcting the issues. Because the corrections were not made, the admins have decided to suspend the theme.

If you decide to make the appropriate changes in the future, please get in touch with someone on the team so that we can reopen your ticket. The theme will undergo a full review and be expected to meet all the current standards.

#18 @ionutn
14 months ago

Thanks for letting us know Justin!

As I said before I believe having the theme suspended is a less disservice that we did to our users than having it 'fixed', the theme will be available on our website and we will do our best to make sure is still the #1.

In the meantime please suspend also all zerif-lite childs in the repository since they can't be installed anymore neither.

Last edited 14 months ago by ionutn (previous) (diff)

#19 @greenshady
14 months ago

At the moment, we're not suspending any child themes from third-party developers. However, if you have any that you're the author of and want removed, please let us know the names of them.

This ticket was mentioned in Slack in #forums by yui. View the logs.


14 months ago

#21 @ionutn
13 months ago

Hey Justin/other key reviewers,

Unfortunately due to some personal stuff I didn't get a chance to move faster with this, but lately we managed to do some brainstorming around possible solutions that we can apply, without affecting existing users, while continue to support them .

As I asked before, if you see other solution that we might have missed, is still welcome, not sure if you didn't had one or just missed the question from 1 month ago

" Now we still have 1 really big guideline issue : faux CPT, for which I can't see a seamless migration if we aren't allowed to auto-activate a 'companion' plugin while informing the user ( part of the migration script ). I am right ? "

Here is what we can do :

  1. Like Stephen Cronin suggested to me we can do this on update : create a new frontpage, have all faux-content in it ( the_content() ), set it as frontpage, recommend a companion plugin, after the plugin is activated, clear the_content and show the options in customizers as now. We also need to identify the current page using blog_template and set it in settings-reading for blog while removing the blog template.

The difference compared with what I have proposed before or you proposed is that until the user activate the new plugin, while he won't be able to edit the frontpage, his site will still work due to the content that there is embedded in the page .

  1. Do not do automatic stuff, but force-redirect users on update to a 'installer' where they will be kinda forced to chose some options ( create new frontpage, set it, set blog page, activate contact form plugin ). However during the migration process his frontpage should still work, so we will need either to have all content displayed somehow, or keep the code in the theme as fallback .
  1. Do this in 1 steps to minimise the risk towards the end users while ensuring that we have no unfair advantage compared to other people :

a ) Auto-fix the setting reading on update, so we will get same demo as other authors in the repo along with things that won't break anything like : demo content, upsells, contact form removal etc + recommend a companion plugin

b ) 1 month later, remove the code from the theme. So during 1st month users will still have the fallback in place ( some faux content ), which will mean that just very few % of users will fall into this and might need further help.

If anyone have other solutions that imply 0 seconds of broken things for the users, we will be happy to work towards implementing them.

As a note, until now we managed to update probably around 2k of the existing user-base .

This ticket was mentioned in Slack in #themereview by ionutn. View the logs.


13 months ago

#23 @Kenshino
13 months ago

  • Keywords 2nd-opinion added

IMO - do not remove the code. People won't understand or switch to your changes in just a month. That's the sad truth of most web users. They probably won't even see this update and maybe update a few versions later to have everything break.

Leave the code in the following manner.

They cannot make use of the faux cpt function (e.g. they cannot key in the faux cpt without the companion plugin), but if you detect the old meta data, continue to display whatever it is you last did.

This ensures that new users do not use the faux cpt while old users don't get screwed over. Track this behaviour over many versions and finally retire the faux cpt after enough users have switched over.

#24 @djrmom
13 months ago

Hi @ionutn and @themeisle,

I have written up some notes that I think cover the major points in earlier discussions. I haven't done a full review of zerif lite to check for additional issues or more minor points, however, I expect we would want to do a fuller review before re-publishing your theme.

I have shared this with the other key reviewers, however, these should not be considered a final list of requirements that must be met there is still the possibility that we might consider something to be required that I haven't covered or make additional exceptions on some points.

I think the key thing is that new users will not have the option of using the incorrect front page settings, blog templates, content creation, or plugin territory features.

Note: Faux CPTs - I think we should stop using this term, it is confusing the issue, it is only a term we use to describe what makes certain types of options/widgets content creation and not a requirement that certain type of content can only be handled by cpts.

  1. The contact form and recaptcha needs to be removed at this point. Looks to me like pirate forms has been recommended for over a year now. This is more than just a content creation issue, it is plugin territory functionality and hotlinking to google recaptcha.
  1. Demo content needs to be removed from the front end
  1. Deprecate the blog templates by removing the Template Name from the header as previously suggested https://themes.trac.wordpress.org/ticket/24907#comment:29
  1. Automatically creating and saving widgets needs to be removed zerif_register_default_widgets
  1. we have 2 types of possible content creation:
    • widgets
      • as noted in https://themes.trac.wordpress.org/ticket/24907#comment:31 widgets can be pasted as is into a plugin with checks to keep from causing fatal errors from having in both the theme and plugin at the same time and make sure the plugin version runs first
      • if there is a way for new users to only use the plugin version that would be a plus, maybe check the option for existing widgets and not load the theme version if none have been created which would force new users to install plugin to create the widgets
      • Since even existing users of widgets in the theme would be able to install the widget plugin to get their widgets back, I am okay with keeping widgets in the theme while working on getting users transitioned to the plugin
      • consider making the plugin have more options and improved features to encourage existing users to opt in
    • theme mods
      • some of the theme mods can also be considered content creation, see point 7 below, I believe if this is a workable solution, we can further discuss whether some of your existing home page settings need to be changed or removed for the new version of the static home page
  1. I don't think you need to do any auto migration of front page settings to continue to display already saved content
    • new users should have only correct front page settings
    • existing users will need to migrate to the new front page setup in order to add/edit their site if/when they choose to do so
    • existing users who don't do anything can continue to have backwards compatibility until they are ready to migrate
  1. This is my suggestion for handling transitioning front page settings
    • change the name of existing front page settings in the customizer, you can simply append _2 to theme mod names if you want
      • this leaves the existing settings as a fallback that can be output as they are now, users can't change them but they will still be available in the database to read and display as they are now, while it is not ideal to have the extra content above the blog index, I think it is okay as a way to keep content from breaking on existing sites
    • new users would have nothing to display when is_home leaving only the blog index as it should be, the blog index needs to be handled correctly with the default loop instead of a custom query
    • output the home page settings with new names on a properly configured static front page
      • old settings can be read to use as defaults for the new settings so that users don't have to recreate anything when they opt into the static home page

I hope that this can be worked out in a way that can satisfy the guidelines as well as serve as a positive example to all theme authors.

Thanks,
Jenny

#25 @ionutn
13 months ago

Hey Jenny & @Kenshino ,

Thanks a lot for your input on this, we are working on fixing those things, however due to some internal issues it will probably take a bit of time.

#26 @ionutn
13 months ago

Hey,

Wanted to let you know that we have started working on those, hope to have the new version ready in a week or so.

#27 @themeisle
13 months ago

Hey @djrmom,

We have fixed all reported issues, however we cannot upload the update, it says that we cannot upload it because the theme is suspended. http://prntscr.com/d31pc8

Here is the latest code : https://github.com/codeinwp/zerif-lite/tree/zerif-lite-2

#28 @djrmom
13 months ago

Thanks @themeisle, I will try to take a look at it in the next few days.

#29 @themeisle
12 months ago

Hey @djrmom,

No hurry, just wanted to send a reminder here in case you forgot about this :D

Thanks!

#30 @themeisle
12 months ago

Hey,

It would be great if we can get some feedback here before going for #wcus, from @djrmom or other key reviewer.

Thanks!

#31 @acosmin
12 months ago

I wrote a review to speed things up. I did test the theme without the companion plugin installed/activated.

@djrmom @greenshady


  1. Theme check - ok
  1. On the 'Welcome screen' please change the wording from Actions required to Recommended action.
    • themes should not require.
  1. Customizer
    • Support and migration for custom logo is in place.
    • The panels for sections that display those widgets/custom content should use a callback function and appear only when template-frontpage.php is used, at least for new users it should be this way (I don't think this is required).
  1. Front Page
    • front-page.php - ok Displays a page if one is selected or latest posts if no page is selected
    • home.php and index.php display as they should, only using a simple posts loop.
  1. Demo Content
    • These were removed:
      • The fake content used on the front page.
      • Footer: Contact info.
      • Footer: Social links.
  1. Contact Form
    • Isn't used anymore.
    • The reCaptcha functionality is still in the theme, but doesn't work for new users, just for backwards compatibility.
  1. Customizer Links
    • remove advertising links in most of the panels, View PRO version.... You already have a panel for ads Theme Info, you can style that one if you like (change colors).
    • Everything else looks ok.
  1. Locked Customizer Sections - fixed
  1. Blog Templates - fixed
    • at least template-blog.php & template-blog-large.php don't work for new users.
  1. Plugin Territory: Widgets
    • These functions shouldn't be available for new theme installs, only when the companion plugin is installed/activated:
      • widgets zerif_ourfocus zerif_testimonial_widget zerif_clients_widget zerif_team_widget
      • the same goes for the sidebars: about, our focus, testimonials, our team.
        • You can check that they still appear in Appearance > Widgets.
          • The above might be optional depending on what the admins think. Since even existing users of widgets in the theme would be able to install the widget plugin to get their widgets back, I am okay with keeping widgets in the theme while working on getting users transitioned to the plugin
  1. Archive Title and Description - fixed
  1. Default Background Image - fixed
    • at least from how the code looks :) this one I didn't test.
  1. Should remove:
    • zerif_wp_title()

The above were mostly for greenshady's review.


  1. Provide a unique prefix for everything the Theme defines in the public namespace, including options, functions, global variables, constants, post meta, etc.
    • functions.php - l30-33
  1. Escaping/Sanitization
    • functions.php:l205 - get_the_permalink(), get_the_title(), also replace ... with &hellip;
    • admin_url() should be escaped in multiple places
    • content-single.php:78 - get_the_permalink()
    • content-page.php:12 - get_author_posts_url()
  1. functions.php
    • l297, that needs to be urlencode like you did in zerif_slug_fonts_url()
  1. footer.php
    • http://wordpress.org/ should be translatable and escaped for locals - example
  1. readme.txt
    • declare license for smoothscroll.js
    • declare license for respond.min.js
    • declare license for parallax.js
    • declare license for html5.js
  1. No minification of scripts or files unless provide original files.
    • respond.min.js
    • bootstrap.min.js
  1. Optional, don't know if these should be kept for backwards compatibility:
    • header.php:l25, wp_add_inline_script() could be used



Anyway, if this helps and can be taken into consideration, I hope everything can be resolved.

#32 @themeisle
12 months ago

Thanks for the detailed review @acosmin, we are looking into this tomorrow and we'll fix the minor reported things.

For the widgets, we though based on @djrmom comment that we can keep it at least for the 1st update and in 2 weeks remove them, just to make sure there aren't that many changes at once, which means more ways to break things :)

#33 @djrmom
12 months ago

Thanks @acosmin,

For the widgets, unless other key reviewers feel otherwise, I think as long as the widget plugin is available and encouraged for new users, it is okay to have backwards compatibility in the theme for a period.

Also, the View Pro Version links inside sections are okay, as long as it is not the only thing in the section - "One top-level link in the customizer (other unobtrusive links in sections allowed)." - https://make.wordpress.org/themes/2016/05/03/may-3rd-meeting-notes/

This looks good so far as far as what a new install, I haven't gone through everything but here are a few issues I noted:

  • the actions required link in customizer results in a broken link in live preview (when the theme is not active)
  • front-page-post-form in tags is not applicable
  • spell WordPress correctly with capital W and P - readme.txt, style.css
  • be sure to include source link for resources in readme.txt
  • front-page.php - the query should not be custom starting ln 175, the "main" query and loop needs to use the default query for the blog index
  • update TGMPA
  • Recommended: avoid wp_is_mobile on frontend, server side checking of user agent is sometimes not compatible with caching
  • text in zerif_customizer.js is not translation ready
  • no removing core panels/sections/controls - $wp_customize->remove_section('colors');
  • why Zerif_Customize_Textarea_Control? core has support for textareas

I will try to look over some more this week and weekend.

Thanks,
Jenny

#34 @themeisle
12 months ago

Hi @acosmin and @djrmom ,

Thank you both for the reviews. We updated the code with the changes mentioned by you. You can find the latest version here https://github.com/Codeinwp/zerif-lite/tree/zerif-lite-2 .

Thank you

#35 @ionutn
12 months ago

Hey Jenny,

Let me know if you got a chance to look at this and if is still something that we need to work on.

Thanks!

This ticket was mentioned in Slack in #themereview by ionutn. View the logs.


12 months ago

#37 @grapplerulrich
12 months ago

  • Resolution live deleted
  • Status changed from closed to reopened

I have suspended the theme, you should be upload updates now. The theme is still offline.

#38 @grapplerulrich
12 months ago

  • Owner changed from themetracbot to grapplerulrich
  • Status changed from reopened to reviewing

#39 @themeisle
12 months ago

Hi @grapplerulrich ,

Thank you so much! We uploaded the theme now.

#40 @grapplerulrich
12 months ago

  • Resolution set to closed-newer-version-uploaded
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.