WordPress.org

Make WordPress Themes

Opened 11 months ago

Closed 9 months ago

#36400 closed theme (live)

THEME: xMag – 1.1.7

Reported by: fabiorubioglio Owned by: acalfieri
Priority: previously reviewed Keywords: theme-xmag
Cc: designlabthemes@…

Description

xMag - 1.1.3

xMag is a free Magazine WordPress Theme. It features a simple and elegant design. This theme comes with great features for magazine, blog and news websites.

Theme URL - http://www.designlabthemes.com/xmag-wordpress-theme/
Author URL - http://www.designlabthemes.com/

SVN - https://themes.svn.wordpress.org/xmag/1.1.3
ZIP - https://wordpress.org/themes/download/xmag.1.1.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=xmag/1.1.2&new_path=xmag/1.1.3

History:

Ticket Summary Status Resolution Owner
#30572 THEME: xMag – 1.0.9 closed not-approved acalfieri
#36248 THEME: xMag – 1.1.2 closed not-approved kevinhaig
#36400 THEME: xMag – 1.1.7 closed live acalfieri

(this ticket)

#38834 THEME: xMag – 1.1.8 closed live themetracbot
#39331 THEME: xMag – 1.1.9 closed live themetracbot
#40270 THEME: xMag – 1.2.0 closed live themetracbot
#41962 THEME: xMag – 1.2.1 closed live themetracbot
#41999 THEME: xMag – 1.2.2 closed live themetracbot
#43628 THEME: xMag – 1.2.3 closed live themetracbot


https://themes.svn.wordpress.org/xmag/1.1.3/screenshot.png

Change History (25)

#1 @fabiorubioglio
11 months ago

i asked @jcastaneda to close ticket #35491 (Theme Brilliant),
in order to allow xMag theme in the queue.

best regards

Last edited 11 months ago by fabiorubioglio (previous) (diff)

This ticket was mentioned in Slack in #themereview by fabiorubioglio. View the logs.


11 months ago

This ticket was mentioned in Slack in #themereview by fabiorubioglio. View the logs.


11 months ago

This ticket was mentioned in Slack in #themereview by acalfieri. View the logs.


11 months ago

#5 @emiluzelac
11 months ago

  • Owner set to acalfieri
  • Status changed from new to reviewing

#6 @acalfieri
11 months ago

Thanks @emiluzelac!

Hi again, @fabiorubioglio!

I made a small list with some issues to start working:

The customiser

  • The option to change the background color in the boxed layout doesn’t work. That can be easily solved if you delete body.site-boxed { background-color: #f2f2f2; } from style.css and let the styles you wrote in customizer.php handle the body background color. A better way, however, would be to add theme support for custom background, and maybe move the default control to where you now have the body background for boxed layout control and delete this one.
  • Changing the background color of the header background changes the color of the social icons in the social icons menu. I think it depends on the contrast and the brightness, but I didn't delve into the functions.
  • The top navigation menu could have more space or be more flexible, so it doesn’t run in two lines when it has many elements.
  • Theme Settings in customizer.php line 64 needs to be translatable.

Code

  • You could add theme support for the other post formats (audio, chat and aside). At least post format audio would be fine.
  • You don’t need line 15 (global $post) in single.php and line 20 in page.php. WordPress already knows that you are handling a post object when it loads single.php and page.php

I wait for the next update as usual.

Saluti!

#7 @themetracbot
11 months ago

  • Summary changed from THEME: xMag – 1.1.3 to THEME: xMag – 1.1.4

xMag - 1.1.4

xMag is a free Magazine WordPress Theme. It features a simple and elegant design. This theme comes with great features for magazine, blog and news websites.

Theme URL - http://www.designlabthemes.com/xmag-wordpress-theme/
Author URL - http://www.designlabthemes.com/

SVN - https://themes.svn.wordpress.org/xmag/1.1.4
ZIP - https://wordpress.org/themes/download/xmag.1.1.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=xmag/1.1.3&new_path=xmag/1.1.4

History:

Ticket Summary Status Resolution Owner
#30572 THEME: xMag – 1.0.9 closed not-approved acalfieri
#36248 THEME: xMag – 1.1.2 closed not-approved kevinhaig
#36400 THEME: xMag – 1.1.7 closed live acalfieri

(this ticket)

#38834 THEME: xMag – 1.1.8 closed live themetracbot
#39331 THEME: xMag – 1.1.9 closed live themetracbot
#40270 THEME: xMag – 1.2.0 closed live themetracbot
#41962 THEME: xMag – 1.2.1 closed live themetracbot
#41999 THEME: xMag – 1.2.2 closed live themetracbot
#43628 THEME: xMag – 1.2.3 closed live themetracbot


https://themes.svn.wordpress.org/xmag/1.1.4/screenshot.png

#8 @fabiorubioglio
11 months ago

i uploaded a new version with the last issues.
thank you @acalfieri for your work and your patience.

#9 @acalfieri
10 months ago

Hi @fabiorubioglio,

Two small things:

  • In customizer.php, line 44 would be better like this: echo '<p><a target="_blank" href="' . esc_url( $important_link['link'] ). '" >' . esc_html($important_link['text']) . ' </a></p>’;
  • In author-bio.php you have a call to some social links that don’t exist anymore in customizer.php.

#10 @themetracbot
10 months ago

  • Summary changed from THEME: xMag – 1.1.4 to THEME: xMag – 1.1.5

xMag - 1.1.5

xMag is a free Magazine WordPress Theme. It features a simple and elegant design. This theme comes with great features for magazine, blog and news websites.

Theme URL - http://www.designlabthemes.com/xmag-wordpress-theme/
Author URL - http://www.designlabthemes.com/

SVN - https://themes.svn.wordpress.org/xmag/1.1.5
ZIP - https://wordpress.org/themes/download/xmag.1.1.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=xmag/1.1.4&new_path=xmag/1.1.5

History:

Ticket Summary Status Resolution Owner
#30572 THEME: xMag – 1.0.9 closed not-approved acalfieri
#36248 THEME: xMag – 1.1.2 closed not-approved kevinhaig
#36400 THEME: xMag – 1.1.7 closed live acalfieri

(this ticket)

#38834 THEME: xMag – 1.1.8 closed live themetracbot
#39331 THEME: xMag – 1.1.9 closed live themetracbot
#40270 THEME: xMag – 1.2.0 closed live themetracbot
#41962 THEME: xMag – 1.2.1 closed live themetracbot
#41999 THEME: xMag – 1.2.2 closed live themetracbot
#43628 THEME: xMag – 1.2.3 closed live themetracbot


https://themes.svn.wordpress.org/xmag/1.1.5/screenshot.png

#11 @acalfieri
10 months ago

  • Status changed from reviewing to approved

I think everything is fine now, so I approve the theme. From now on it will be in this queue https://themes.trac.wordpress.org/report/24.

#12 @poena
9 months ago

  • Status changed from approved to reopened

#13 @poena
9 months ago

Hi!
Your theme is almost ready to go live.
You need to escape all your options on output, including the color options in xmag_custom_style().

You need to specify the correct license and copyright information for the images in the screenshot.
Note that GPL is not commonly used for images. A quick image search for the image with the woman holding the camera shows that the image is not licensed as GPL but CC0.
https://unsplash.com/@b3njamin?photo=hiAdjnXZxl8

#14 @poena
9 months ago

Oops I was a bit rushed there.
The upsell that you are adding to the customizer interface with the javascript, xmag_plus_customize_js, needs to be replaced.
Please see this ticket for more information and background: https://core.trac.wordpress.org/ticket/37335,
and this example button that you can build from instead:
https://github.com/justintadlock/trt-customizer-pro

I strongly recommend you to remove xmag_custom_css_section,
since you will be required to do this after the grace period when 4.7 is released.
(There is a new custom css setting added to WordPress core)

#15 @fabiorubioglio
9 months ago

hi,
thanks for the review.
this weekend i'll fix the last issues.

#16 @fabiorubioglio
9 months ago

hi @poena,
how could i escape color options?
i'm sorry but I never heard anything about it.
i found only references about sanitizing it.

#17 @poena
9 months ago

Hi
I suggest esc_attr().
All unsafe data needs to be escaped. Even when the option is sanitized before saving, it can be manipulated.

You might be interested in this guide:
https://make.wordpress.org/themes/2015/05/19/a-guide-to-writing-secure-themes-part-1-introduction/

#18 @themetracbot
9 months ago

  • Summary changed from THEME: xMag – 1.1.5 to THEME: xMag – 1.1.6

xMag - 1.1.6

xMag is a free Magazine WordPress Theme. It features a simple and elegant design. This theme comes with great features for magazine, blog and news websites.

Theme URL - http://www.designlabthemes.com/xmag-wordpress-theme/
Author URL - http://www.designlabthemes.com/

SVN - https://themes.svn.wordpress.org/xmag/1.1.6
ZIP - https://wordpress.org/themes/download/xmag.1.1.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=xmag/1.1.5&new_path=xmag/1.1.6

History:

Ticket Summary Status Resolution Owner
#30572 THEME: xMag – 1.0.9 closed not-approved acalfieri
#36248 THEME: xMag – 1.1.2 closed not-approved kevinhaig
#36400 THEME: xMag – 1.1.7 closed live acalfieri

(this ticket)

#38834 THEME: xMag – 1.1.8 closed live themetracbot
#39331 THEME: xMag – 1.1.9 closed live themetracbot
#40270 THEME: xMag – 1.2.0 closed live themetracbot
#41962 THEME: xMag – 1.2.1 closed live themetracbot
#41999 THEME: xMag – 1.2.2 closed live themetracbot
#43628 THEME: xMag – 1.2.3 closed live themetracbot


https://themes.svn.wordpress.org/xmag/1.1.6/screenshot.png

#19 @fabiorubioglio
9 months ago

thanks @poena for the review and the help.

#20 @acalfieri
9 months ago

Do I continue this review @poena?

@fabiorubioglio, WordPress 4.7 is almost ready and the background image settings and controls have changed a bit. Therefore line 69 in customizer.php throws an error. If you still haven't, try to install 4.7 (you can download the release candidate version from this link https://wordpress.org/news/2016/11/wordpress-4-7-release-candidate/) and check how it works now.

I'm not sure whether the xMag Links section in the Customizer is allowed. What do you say, @poena?

If not, lines 19-49 and 319-333 in customizer.php should be deleted.

#21 @poena
9 months ago

Hi
I did not have the time to look at the code earlier, you can continue if you have the time :)
The theme should be ready to go live when the php error has been fixed (I'm seeing the error too now).

Warning: Creating default object from empty value in \xmag\inc\customizer.php on line 69

Please also remove

function xmag_sanitize_textarea( $text ) { 
return esc_textarea( $text );
}

It does not seem to be used?
esc_textarea is used to escape content that is being output inside actual text areas,
not for sanitizing.

The section in the customizer is the current recommended way to add an upsell link, until there is a core solution.

#22 @fabiorubioglio
9 months ago

thanks @acalfieri and @poena,
i'll fix the warning in customizer.php

#23 @themetracbot
9 months ago

  • Summary changed from THEME: xMag – 1.1.6 to THEME: xMag – 1.1.7

xMag - 1.1.7

xMag is a free Magazine WordPress Theme. It features a simple and elegant design. This theme comes with great features for magazine, blog and news websites.

Theme URL - http://www.designlabthemes.com/xmag-wordpress-theme/
Author URL - http://www.designlabthemes.com/

SVN - https://themes.svn.wordpress.org/xmag/1.1.7
ZIP - https://wordpress.org/themes/download/xmag.1.1.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=xmag/1.1.6&new_path=xmag/1.1.7

History:

Ticket Summary Status Resolution Owner
#30572 THEME: xMag – 1.0.9 closed not-approved acalfieri
#36248 THEME: xMag – 1.1.2 closed not-approved kevinhaig
#36400 THEME: xMag – 1.1.7 closed live acalfieri

(this ticket)

#38834 THEME: xMag – 1.1.8 closed live themetracbot
#39331 THEME: xMag – 1.1.9 closed live themetracbot
#40270 THEME: xMag – 1.2.0 closed live themetracbot
#41962 THEME: xMag – 1.2.1 closed live themetracbot
#41999 THEME: xMag – 1.2.2 closed live themetracbot
#43628 THEME: xMag – 1.2.3 closed live themetracbot


https://themes.svn.wordpress.org/xmag/1.1.7/screenshot.png

#24 @acalfieri
9 months ago

  • Status changed from reopened to approved

#25 @acalfieri
9 months ago

  • Resolution set to live
  • Status changed from approved to closed

Finally!

Note: See TracTickets for help on using tickets.