WordPress.org

Make WordPress Themes

Opened 6 months ago

Closed 8 days ago

#36640 closed theme (not-approved)

THEME: No Man's Land – 1.5.4

Reported by: freelancermartin Owned by: Litonice13
Priority: new theme Keywords: theme-no-mans-land
Cc: developerforwebsites@…

Description

No-Man's Land - 1.5.1

No Mans Land is a modernized One Page Demo Theme — what demostrates endless development power with wordpress and other framework. It works perfectly for blogs and websites. It has custom color options with beautiful default color schemes, a harmonious fluid grid using a mobile-first approach, and impeccable polish in every detail. no_mans_land will make your WordPress look beautiful everywhere.

Theme URL - http://no-mans.developerforwebsites.com/
Author URL - https://developerforwebsites.com

SVN - https://themes.svn.wordpress.org/no-mans-land/1.5.1
ZIP - https://wordpress.org/themes/download/no-mans-land.1.5.1.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#36640 THEME: No Man's Land – 1.5.4 closed not-approved Litonice13

(this ticket)


https://themes.svn.wordpress.org/no-mans-land/1.5.1/screenshot.png

Change History (29)

#1 @freelancermartin
6 months ago

Hello There

I made changes as you requested, i hope this time it is like must be. Cheers Martin

#2 @acalfieri
7 weeks ago

  • Owner set to acalfieri
  • Status changed from new to reviewing

#3 @acalfieri
7 weeks ago

Dear @freelancermartin

Your theme has many problems, so it can not be approved as it is. Please do the following changes and submit again.

Requirements

  1. Delete this function no_mans_land_theme_style() in functions.php because is throwing an error.
    function no_mans_land_theme_style() {
    	wp_enqueue_style('theme-style', get_template_directory_uri() . "/style.css", '', '', 'all');
    }
    add_action( 'after_setup_theme', 'no_mans_land_theme_style', 0 );
    
    The correct way of enqueuing the stylesheet is like you do in line 261.
  1. I assume your theme name is "No-Man's Land", so
    1. The text domain should be no-mans-land and not no_mans_land. Change it in all translation functions and change also line 11 in style.css.
    2. The @package tag should be "No_Mans_Land", for instance, and not "WordPress", that is reserved to WordPress default themes. Change that in all files. You don't need a @subpackage tag.
    3. The prefix of your functions and classes could be no_mans_land or something similar. It should be unique, anyway.
  1. You have a problem understanding the Template Hierarchy and the use of index.php, home.php and front-page.php. Please read the following documentation and update your theme according to that.
  1. The styles are quite a disaster. The main menu is hidden and the styles are modifying the admin menus in a very undesirable way. You have a profusion of stylesheets and though your theme is very similar to Twenty Sixteen.
  1. Organise your files better according to the guidelines here. https://developer.wordpress.org/themes/basics/organizing-theme-files/.

All in all, this theme is really not working. It should display a WordPress theme normal behaviour without any plugin, but it doesn't work either when I activate the recommended plugin. The front page shows a blank page with a menu and the admin bar is hidden, which is not allowed. In other pages, I can see the admin bar, but the main menu is hidden. Please, read the following documentation very carefully, look at well crafted WordPress themes like the default themes, especially the three last ones, learn how to use the Customizer API, correct all the errors and resubmit again. And, specially, try to understand the basics before complicating things too much.

This is not a complete review, but we continue after your next submission. You have 7 days to make your changes, else the ticket will be closed. If you can not manage it in 7 days, just post a message here so the ticket stays open. When you are ready to submit the new version, please do it from this link https://wordpress.org/themes/upload/

Kindly,

#4 @freelancermartin
6 weeks ago

Hello There

Yes quite old one this theme, i accept it is not done right, i need little bit more time to make bigger corrections, i am trying to develop the theme by documentation guidelines and follow your tips, because i have now more experiece

Cheers Martin

#5 @acalfieri
6 weeks ago

Hi @freelancermartin

Do I close the ticket or keep it open a bit longer so you can make your changes?

#6 @freelancermartin
6 weeks ago

Yes keep it open a bit longer , than i can make changes

#7 @themetracbot
6 weeks ago

  • Summary changed from THEME: No-Man's Land – 1.5.1 to THEME: No Man's Land – 1.5.2

No Man's Land - 1.5.2

No Mans Land is a modernized One Page Demo Theme — what demostrates endless development power with wordpress and other framework. It works perfectly for blogs and websites. It has custom color options with beautiful default color schemes, a harmonious fluid grid using a mobile-first approach, and impeccable polish in every detail. no-mans-land will make your WordPress look beautiful everywhere.

Theme URL - http://themes.developerforwebsites.com/no-mans-land
Author URL - https://developerforwebsites.com

Trac Browser - https://themes.trac.wordpress.org/browser/no-mans-land/1.5.2

SVN - https://themes.svn.wordpress.org/no-mans-land/1.5.2
ZIP - https://wordpress.org/themes/download/no-mans-land.1.5.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=no-mans-land/1.5.1&new_path=no-mans-land/1.5.2

History:

Ticket Summary Status Resolution Owner
#36640 THEME: No Man's Land – 1.5.4 closed not-approved Litonice13

(this ticket)


https://themes.svn.wordpress.org/no-mans-land/1.5.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are no-mans-land,

#8 @freelancermartin
6 weeks ago

So i did some mayor changes, i hope this one is better

#9 @themetracbot
6 weeks ago

  • Summary changed from THEME: No Man's Land – 1.5.2 to THEME: No Man's Land – 1.5.3

No Man's Land - 1.5.3

No Mans Land is a modernized One Page Demo Theme — what demostrates endless development power with wordpress and other framework. It works perfectly for blogs and websites. It has custom color options with beautiful default color schemes, a harmonious fluid grid using a mobile-first approach, and impeccable polish in every detail. no-mans-land will make your WordPress look beautiful everywhere.

Theme URL - http://themes.developerforwebsites.com/no-mans-land
Author URL - https://developerforwebsites.com

Trac Browser - https://themes.trac.wordpress.org/browser/no-mans-land/1.5.3

SVN - https://themes.svn.wordpress.org/no-mans-land/1.5.3
ZIP - https://wordpress.org/themes/download/no-mans-land.1.5.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=no-mans-land/1.5.2&new_path=no-mans-land/1.5.3

History:

Ticket Summary Status Resolution Owner
#36640 THEME: No Man's Land – 1.5.4 closed not-approved Litonice13

(this ticket)


https://themes.svn.wordpress.org/no-mans-land/1.5.3/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are no-mans-land,

#10 @freelancermartin
6 weeks ago

founds some bugs

#11 @acalfieri
5 weeks ago

Dear @freelancermartin,

Your theme still has many errors. There are a lot of undefined variables and many non-working options.

I would recommend developing a theme without the help of any framework until you understand how to build a theme. Besides, not using a framework would make my work much easier.

Kindly,

#12 @freelancermartin
5 weeks ago

Dear @acalfieri

Like i understand you found some undefined variables from WP_DEBUG what i forget to fix or there are something what i dont know ? Please could you be more specific with non-working options ? Sorry about making your job hard, but i haven't seen anything in wordpress theme documentation what states that you can't use frameworks in theme. All framework are up to date with last versions and should work correctly. Please can you bring any example as well about frameworks

Kindly

#13 @acalfieri
5 weeks ago

Dear @freelancermartin,

As I said before, your theme is not working very well and it has so many errors that this ticket could be closed as not approved without any more consideration. Nevertheless, I will give you one more opportunity to make the changes. If you are not willing to make it work, just tell me, so we stop wasting our time. Working without a framework it's only a recommendation as it would make things easier both for you as a theme author and for me as a theme reviewer.

Below there is an incomplete list of the things I found:

  1. Undefined variables and constants.
    Notice: Undefined variable: socio_list in /Applications/MAMP/htdocs/wordpressaca/wp-content/themes/no-mans-land/inc/custom-functions.php on line 79
    
    Notice: Use of undefined constant show_titles - assumed 'show_titles' in /Applications/MAMP/htdocs/wordpressaca/wp-content/themes/no-mans-land/header.php on line 117
    
    Notice: Use of undefined constant left - assumed 'left' in /Applications/MAMP/htdocs/wordpressaca/wp-content/themes/no-mans-land/header.php on line 123
    
    Notice: Use of undefined constant show_titles - assumed 'show_titles' in /Applications/MAMP/htdocs/wordpressaca/wp-content/themes/no-mans-land/content-single.php on line 16
    
    Notice: Use of undefined constant left - assumed 'left' in /Applications/MAMP/htdocs/wordpressaca/wp-content/themes/no-mans-land/page.php on line 18
    
  1. Many functions are prefixed with twentysixteen instead of no_mans_land (see functions in template-tags.php and back-compat.php).
  1. Functions in custom-functions.php are not prefixed at all.
  1. There are two files named page.php. One of them is obviously unused.
  1. File organisation is quite chaotic.
  1. There is not any understanding of the template hierarchy.
  1. The logic of content.php is totally incomprehensible. Because of that, the index page is repeating itself more than 10 times.
  1. Archive pages are not working. It's impossible to click on a category, a tag or an author and find the articles under that term.
  1. There are 12 registered widget areas, but only the footer widget areas work as expected.
  1. There is custom content creation in the three section templates, which is not allowed.
  1. Files should be included using require get_template_directory() . 'path to file'; and not include_once( dirname( __FILE__ ) . 'path to file' );
  1. Declare licenses of any resources included such as fonts, images or third party scripts. See how it's done in the default themes.

All in all, your theme needs to be rewritten following the documentation and guidelines. Correct all errors and submit again. And please, no framework.

Cheers!

#14 @freelancermartin
5 weeks ago

Dear @acalfieri

Sorry it took so long to get back to you. Yes off course i am willing to make it work, because thats the directions where i would like to go and get new experience. I very appreciate that you gave me new change, sorry i just was little confused that moment. But thanks anyway for giving me another change and you putting effort to make it work. So i make corrections and troubleshoot it to find and fix bugs

Cheers

#15 @freelancermartin
5 weeks ago

So everything else is fixed, have question about about point 9 and ten, other sidebar should be working, there are settings created for that, if you create new page under text editor you have choose which sidebar and where is position, left or right of the sidebar. About number 10. Is the content like "lore ipsum " not allowed or the sections with picture content are not allowed ?

Cheers Martin

This ticket was mentioned in Slack in #themereview by acalfieri. View the logs.


4 weeks ago

#17 @acalfieri
4 weeks ago

Hi @freelancermartin

Unfortunately, I won't be able to continue reviewing this ticket. I've asked to be removed from it and you will get another reviewer as soon as possible.

#18 @grapplerulrich
4 weeks ago

  • Owner acalfieri deleted

#19 @themetracbot
4 weeks ago

  • Owner set to Litonice13

#20 @Litonice13
4 weeks ago

Hi @freelancermartin,
I will review your Theme. Will take 2-3 days and I will be back if there any issues.
Thanks

#21 @djrmom
3 weeks ago

@Litonice13, are you still reviewing this theme? It has been 6 days.

#22 @Litonice13
3 weeks ago

Hello @djrmom,
Yes, I'm on it. I was very busy. Will review by today.
Thanks

#23 @Litonice13
3 weeks ago

Hello @freelancermartin ,
I've checked your Theme. Found some major issues are given below:

  • Notice: wp_enqueue_style was called incorrectly. Scripts and styles should not be registered or enqueued until the wp_enqueue_scripts, admin_enqueue_scripts, or login_enqueue_scripts hooks. Please see Debugging in WordPress for more information.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs.
  • WARNING: Found a translation function that is missing a text-domain. Function esc_html_e, with the arguments
  • WARNING: Found a translation function that is missing a text-domain. Function esc_html_e, with the arguments 'no_mans_land'
  • WARNING: Found a translation function that is missing a text-domain. Function esc_html_e, with the arguments 'no-mans-land'
  • WARNING: Found a translation function that is missing a text-domain. Function esc_attr_e, with the arguments 'no_mans_land'
  • REQUIRED: This theme text domain does not match the theme's slug. The text domain used: no_mans_land, This theme's correct slug and text-domain is no-mans-land.

At first fix those issues. Then I will go forward.
Thanks

#24 @freelancermartin
3 weeks ago

Hello Litonice13

Yes like acalfieri showed i had many bugs inside. There was many text-domein errors. Now i have fixed those but i havent't upload it yet. What you were reviewing was old version , i upload the fixed version now, please could you review this one and give me a feedback
and i have question about custom content creation what i have in my theme, what exactly in not allowed, the theme content with pictures or lore ipsum text

Best Regards

Last edited 3 weeks ago by freelancermartin (previous) (diff)

#25 @themetracbot
3 weeks ago

  • Summary changed from THEME: No Man's Land – 1.5.3 to THEME: No Man's Land – 1.5.4

No Man's Land - 1.5.4

No Mans Land is a modernized One Page Demo Theme — what demostrates endless development power with wordpress and other framework. It works perfectly for blogs and websites. It has custom color options with beautiful default color schemes, a harmonious fluid grid using a mobile-first approach, and impeccable polish in every detail. no-mans-land will make your WordPress look beautiful everywhere.

Theme URL - http://themes.developerforwebsites.com/no-mans-land
Author URL - https://developerforwebsites.com

Trac Browser - https://themes.trac.wordpress.org/browser/no-mans-land/1.5.4

SVN - https://themes.svn.wordpress.org/no-mans-land/1.5.4
ZIP - https://wordpress.org/themes/download/no-mans-land.1.5.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=no-mans-land/1.5.3&new_path=no-mans-land/1.5.4

History:

Ticket Summary Status Resolution Owner
#36640 THEME: No Man's Land – 1.5.4 closed not-approved Litonice13

(this ticket)


https://themes.svn.wordpress.org/no-mans-land/1.5.4/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are no-mans-land,

#26 @Litonice13
3 weeks ago

Hello @freelancermartin,
This isn't the way you're telling. You've fixed and not uploaded updated version and I've reviewed your older version. That's why I've got those errors !!!
Generally it should be. Please be familiar with wp.org repo Theme Guidelines and submit your theme.
Now, when I will get time within 2-3 days I will review again. I've to check existing themes from pipeline.
Thanks

#27 @freelancermartin
2 weeks ago

Hello @Litonice13
Pardon my amateurness, i will keep that in mind and thanks for the feedback
Thanks

#28 @freelancermartin
11 days ago

Hello @Litonice13
Just was wondering to ask how is it going with checking existing themes

Thanks

#29 @Litonice13
8 days ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hello @freelancermartin,

  1. Screenshot isn't clear on Dashboard. Needs clear picture of your Theme resolution: 1200x900.
  2. g: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs.The domains found are no-mans-land,
  3. No hard coded links allowed. It'll needs validation and sanitization
    $links[] = '<a href='https://metabox.io/docs/'>' . __( 'Documentation', 'no-mans-land' ) . '</a>
    
  4. Theme is broken and not working. http://prnt.sc/embhw6

Please take deeper look and read guidelines. Don't waste too much time for reviewers also yours.

Thanks

Note: See TracTickets for help on using tickets.