WordPress.org

Make WordPress Themes

Opened 13 months ago

Closed 13 months ago

Last modified 5 months ago

#37025 closed theme (live)

THEME: Primer – 1.3.0

Reported by: Godaddy Owned by: Otto42
Priority: previously reviewed Keywords: theme-primer
Cc: plugins@…

Description

Primer - 1.3.0

Primer is a powerful theme that brings clarity to your content in a fresh design.

Theme URL - https://github.com/godaddy/wp-primer-theme
Author URL - https://www.godaddy.com/

SVN - https://themes.svn.wordpress.org/primer/1.3.0
ZIP - https://wordpress.org/themes/download/primer.1.3.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=primer/1.2&new_path=primer/1.3.0

History:

Ticket Summary Status Resolution Owner
#37025 THEME: Primer – 1.3.0 closed live Otto42

(this ticket)

#40495 THEME: Primer – 1.5.0 closed live themetracbot
#40500 THEME: Primer – 1.5.1 closed live themetracbot
#40701 THEME: Primer – 1.6.0 closed live themetracbot
#41734 THEME: Primer – 1.7.0 closed live themetracbot
#44763 THEME: Primer – 1.8.0 closed live themetracbot


https://themes.svn.wordpress.org/primer/1.3.0/screenshot.png

Change History (17)

#1 @Otto42
13 months ago

  • Owner set to Otto42
  • Status changed from new to reviewing

#2 @Otto42
13 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Pre-reviewed before upload by @emiluzelac. Marking as live.

This ticket was mentioned in Slack in #themereview by acosmin. View the logs.


13 months ago

#4 @emiluzelac
13 months ago

FYI: https://wordpress.slack.com/archives/themereview/p1474473537003064 just in case if anyone was wondering what the pre-review was, this was asked in the channel and I helped, that is all.

#5 @rabmalin
13 months ago

@emiluzelac Thanks for the info. I guess pre-review is not the major disagreement here. Major issue in hand is skipping 5 months review queue and 2 months admin queue I believe.

#6 @WPDevHQ
13 months ago

I strongly raise objection to this process!

All themes should be treated equally regardless of pre-review or what not. Skipping, circumvention and/or fastracking is totally against the TRT own rules. This practisce should not and can not be allowed to be practiced within the TRT by any member, admin or otherwise!

The ticket should be re-openned and placed back in the que in the order it was submitted to await its turn!

#7 @Otto42
13 months ago

Okay, let's just clarify a few things here.

First, this was a special case. I manually had to make this name available to GoDaddy for this purpose. Changing the name of the theme was problematic for other reasons, and they could not have submitted it with this name at all without administrative intervention.

When they came to me for that, I naturally had the theme reviewed first. I asked for a volunteer, they reviewed it for me, some changes to the theme were made. This took about 3 weeks.

When the theme was finished, I was able to transfer it to their name and upload it here properly. Since the theme had already been reviewed, and it's a parent theme, and it's already released, and child themes that depend on it need it live for them to be uploaded, then I made it live.

There will always be special cases. There will always be things that we have to do to adjust the system as needed.

The queue does not exist simply to make everybody wait some arbitrary amount of time. It's there because there's not enough reviewers and too many themes to review and too many themes that need additional review because they don't pass the guidelines on the first few reviews and so on. Not enough man power, too much work.

But if there is an administrative need to adjust things on WordPress.org, in order to help out any number of users, then we will take such actions as we deem necessary to do that. If that means we do things like this, put themes in the directory by hand, and make them live immediately, then that is going to occur. Special cases, like this one, will get special treatment.

The special case here is that they needed to reuse an old name for assorted practical reasons, and it had to be live to allow the already created child themes to be added to the directory. Not that they're GoDaddy.

#8 @WPDevHQ
13 months ago

I'm sorry, but until you explained it that is not the way it looks to the "open" community.

This should have been communicated publicly and the case made for it before it all happend - would have save a lot of bad press (on top of bad feelings from other theme developers) the TRT is going to get now!

This ticket was mentioned in Slack in #themereview by otto42. View the logs.


13 months ago

#10 @Otto42
13 months ago

For the historical record, here is a copy of the review on the initial version of the theme. These issues were corrected before the theme was uploaded:


Primer Review:

  1. wp_enqueue_script('jquery'); should not be added directly, jQuery dependency needs to be called via array, which theme already does.

https://github.com/WordPress/twentysixteen/blob/master/functions.php#L281

  1. wpcom.php is entirely wordpress.com related and it should be removed for wordpress.org hosted themes.
  1. The code that loads the customizer code is a potential security concern, themes shouldn’t be autoloading files and especially not with a wildcard. Load only what files you know actually should exist.
		/**
		 * Autoload all customizer components.
		 *
		 * @since 1.0.0
		 */
		foreach( glob( dirname( __FILE__ ) . '/customizer/*.php' ) as $filename ) {

			if ( is_readable( $filename ) ) {

				require_once $filename;

			}

		}

In addition to that themes should be using core path such as:

  • get_template_directory - Filter the current theme directory path.
  • get_template_directory_uri - Filter the current theme directory URI.
  • get_stylesheet_directory - Filter the stylesheet directory path for current theme.
  • get_stylesheet_directory_uri - Filter the stylesheet directory URI.
  1. Search for all home_url() and include a slash like this home_url(‘/‘)

https://developer.wordpress.org/reference/functions/home_url/#comment-428
https://core.trac.wordpress.org/changeset/14443 (example only).

  1. When you select any page to your front page, page title doesn’t show.
  1. Post titles display twice.

---

#11 @WPDevHQ
13 months ago

  • Theme has two footer links which is not allowed - only use one link which should be equivalent to either the Theme or Author url
  • Use WordPress core functions first where avaialble - Theme uses custom functions of primer_pagin_nav() and primer_post_nav()

To be addressed in the next update.

#12 @jonathanbardo
13 months ago

@WPDevHQ Thank you for your feedback. I will remove one of the links in the footer, that's totally my bad on not seeing that rule. I will create an issue to fix the second point.

#13 @greenshady
13 months ago

Just a quick note where I was checking credit.php file (someone had pointed out the two-link issue).

_x(), or in this case, esc_html_x() is not the appropriate function. The _x() functions are for context. You're using them to leave translator notes.

For example, this:

esc_html_x( 'Copyright %1$s %2$d %3$s', '1. copyright symbol, 2. year, 3. site title', 'primer' ),

Should be:

// Translators: 1. copyright symbol, 2. year, 3. site title
esc_html__( 'Copyright %1$s %2$d %3$s', 'primer' ),

If you properly create a POT file using the WordPress i18n tool, it'll automatically pick up translator notes. The system here on .ORG will too.

Using the context function such as _x() and esc_html_x() is to offer context when there's a text string that might need to be translated differently based on context. For example, take the word "post" in English. It's both a noun and a verb, depending on the usage, so you'd code it like so:

_x( 'Post', 'noun', 'primer' );

_x( 'Post', 'verb', 'primer' );

#14 @jonathanbardo
13 months ago

@greenshady Thank you for your input. I'll review this with our internal translation team.

Last edited 13 months ago by jonathanbardo (previous) (diff)

#15 @emiluzelac
13 months ago

Thanks for the extras guys!

#16 @Shaped Pixels
13 months ago

This is going to tick off (putting it mildly) a lot of theme authors who have been waiting up to 6 and even more months. There really is no excuse for "special" cases whatsoever. I can perhaps understand theme authors who got lost in the queue and ended up with many more months in waiting, but this, no way!

Last edited 13 months ago by Shaped Pixels (previous) (diff)

This ticket was mentioned in Slack in #themereview by acosmin. View the logs.


5 months ago

Note: See TracTickets for help on using tickets.