WordPress.org

Make WordPress Themes

#37074 closed theme (closed-newer-version-uploaded)

THEME: Activation – 0.9.2

Reported by: Godaddy Owned by: meissudeep
Priority: new theme Keywords: theme-activation child-theme parent-primer
Cc: plugins@…

Description

Activation - 0.9.0

Activation is a Primer child theme with a colorful, fitness-focused design.

Theme URL - https://github.com/godaddy/wp-activation-theme
Author URL - https://www.godaddy.com/

SVN - https://themes.svn.wordpress.org/activation/0.9.0
ZIP - https://wordpress.org/themes/download/activation.0.9.0.zip?nostats=1
Parent Theme: https://wordpress.org/themes/primer

History:

Ticket Summary Status Resolution Owner
#37074 THEME: Activation – 0.9.2 closed closed-newer-version-uploaded meissudeep

(this ticket)

#40498 THEME: Activation – 1.1.0 closed closed-newer-version-uploaded meissudeep
#40805 THEME: Activation – 1.1.2 closed live meissudeep


https://themes.svn.wordpress.org/activation/0.9.0/screenshot.png

Attachments (2)

37074.patch (23.0 KB) - added by fjarrett 10 months ago.
screenshot.png (282.6 KB) - added by fjarrett 10 months ago.

Download all attachments as: .zip

Change History (35)

This ticket was mentioned in Slack in #themereview by otto42. View the logs.


14 months ago

#2 @WPDevHQ
10 months ago

  • Keywords changed from theme-activation, child-theme, parent-primer to theme-activation child-theme parent-primer

Author url should be: https://www.godaddy.com/wordpress-themes
The current url is not associated with WordPress development but hosting in general and therefore not appropriate!

#3 @fjarrett
10 months ago

Thanks @WPDevHQ!

The URL you're suggesting was actually created just a few weeks ago and is not yet available in every locale.

We'd like to stick with https://www.godaddy.com as the Author URI for a few reasons:

  1. It's guaranteed to never change.
  2. It's available in all locales / regions.
  3. Being our primary URL, it's semantically accurate when users ask: "What is the URL of the Author?"
  4. It accurately reflects that the theme was built and is officially maintained by the company.

#4 @themetracbot
10 months ago

  • Owner set to arvindsinghu
  • Status changed from new to reviewing

#5 in reply to: ↑ description @arvindsinghu
10 months ago

  • Status changed from reviewing to approved

Replying to Godaddy:

Activation - 0.9.0

Activation is a Primer child theme with a colorful, fitness-focused design.

Theme URL - https://github.com/godaddy/wp-activation-theme
Author URL - https://www.godaddy.com/

SVN - https://themes.svn.wordpress.org/activation/0.9.0
ZIP - https://wordpress.org/themes/download/activation.0.9.0.zip?nostats=1
Parent Theme: https://wordpress.org/themes/primer

History:

Ticket Summary Status Resolution Owner
#37074 THEME: Activation – 0.9.2 closed closed-newer-version-uploaded meissudeep

(this ticket)

#40498 THEME: Activation – 1.1.0 closed closed-newer-version-uploaded meissudeep
#40805 THEME: Activation – 1.1.2 closed live meissudeep


https://themes.svn.wordpress.org/activation/0.9.0/screenshot.png

Hi there,

i Have Checked Your Theme and I did't Found any Problem . Congratulations

#6 @WPDevHQ
10 months ago

  • Status changed from approved to reopened

General Check.

REQUIRED:

Code Check.

REQUIRED:

  • searchform.php - @ L10 use esc_url as the escape method and not esc_attr

#7 @WPDevHQ
10 months ago

@arvindsinghu - please follow up on the theme update and approve when the aforementioned issues are resolved!

#8 @arvindsinghu
10 months ago

@WPDevHQ Thank you Sir for your valuable reply , i have not noticed it yet :)

i will remember it in future :)

#9 @grapplerulrich
10 months ago

  • Owner arvindsinghu deleted
  • Status changed from reopened to reviewing

As @arvindsinghu has another theme open to review I will put this back in the queue for someone else to review.

#10 @meissudeep
10 months ago

@grapplerulrich

Assign this to me I will continue a review.

#11 @grapplerulrich
10 months ago

  • Owner set to meissudeep

@meissudeep done

#12 @meissudeep
10 months ago

Hello @Godaddy, @fjarrett

Have review your theme fix all the issue mentioned by @WPDevHQ and Also,

  • You need to give license and source detail for all the image used in screenshots as well.
  • On customizer Customizing ▸ Colors ▸ Header > Site Title Text I am unable to get any changes.

I am unable to get my site as like your screenshots so do please check that too eg: search section shown on screenshots for more see here:https://make.wordpress.org/themes/handbook/review/required/#screenshot

All other things looks fine.

#13 @meissudeep
10 months ago

hello @fjarrett @Godaddy

It has been 8 days, I will give you next 24 hour. Please update your theme or I will mark this as not-approved

@fjarrett
10 months ago

@fjarrett
10 months ago

#14 @fjarrett
10 months ago

Thanks @meissudeep, sorry for the delay.

#15 @meissudeep
10 months ago

Heloo @fjarrett

Please upload your theme from here https://wordpress.org/themes/upload

and fix all the mention issue and don't forget to change the version

Thanks

#16 @fjarrett
10 months ago

Oh thanks @meissudeep, will upload there first thing in the AM as it's getting quite late where I am.

#17 @themetracbot
10 months ago

  • Summary changed from THEME: Activation – 0.9.0 to THEME: Activation – 0.9.1

Activation - 0.9.1

Activation is a Primer child theme with a colorful, fitness-focused design.

Theme URL - https://wordpress.org/themes/activation/
Author URL - https://www.godaddy.com/

Trac Browser - https://themes.trac.wordpress.org/browser/activation/0.9.1

SVN - https://themes.svn.wordpress.org/activation/0.9.1
ZIP - https://wordpress.org/themes/download/activation.0.9.1.zip?nostats=1
Parent Theme: https://wordpress.org/themes/primer

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=activation/0.9.0&new_path=activation/0.9.1

History:

Ticket Summary Status Resolution Owner
#37074 THEME: Activation – 0.9.2 closed closed-newer-version-uploaded meissudeep

(this ticket)

#40498 THEME: Activation – 1.1.0 closed closed-newer-version-uploaded meissudeep
#40805 THEME: Activation – 1.1.2 closed live meissudeep


https://themes.svn.wordpress.org/activation/0.9.1/screenshot.png
Theme Check Results:

  • REQUIRED: Could not find wp_footer. See: wp_footer
     <?php wp_footer(); ?>
    
  • REQUIRED: Could not find wp_head. See: wp_head
     <?php wp_head(); ?>
    
  • REQUIRED: Could not find language_attributes. See: language_attributes
    <html <?php language_attributes(); ?>
    
  • REQUIRED: Could not find charset. There must be a charset defined in the Content-Type or the meta charset tag in the head.
  • REQUIRED: Could not find add_theme_support( 'automatic-feed-links' ). See: add_theme_support
     <?php add_theme_support( $feature ); ?>
    
  • REQUIRED: Could not find comments_template. See: comments_template
     <?php comments_template( $file, $separate_comments ); ?>
    
  • REQUIRED: Could not find wp_list_comments. See: wp_list_comments
     <?php wp_list_comments( $args ); ?>
    
  • REQUIRED: Could not find comment_form. See: comment_form
     <?php comment_form(); ?>
    
  • REQUIRED: Could not find body_class call in body tag. See: body_class
     <?php body_class( $class ); ?>
    
  • REQUIRED: Could not find wp_link_pages. See: wp_link_pages
     <?php wp_link_pages( $args ); ?>
    
  • REQUIRED: Could not find post_class. See: post_class
     <div id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
    
  • REQUIRED: The theme doesn't have comment pagination code in it. Use paginate_comments_links() or the_comments_navigation or the_comments_pagination or next_comments_link() and previous_comments_link() to add comment pagination.
  • REQUIRED: No content width has been defined. Example:
    if ( ! isset( $content_width ) ) $content_width = 900;
    
  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • WARNING: Could not find the file index.php in the theme.
  • REQUIRED: This theme doesn't seem to support the standard avatar functions. Use get_avatar or wp_list_comments to add this support.
  • RECOMMENDED: No reference to nav_menu's was found in the theme. Note that if your theme has a menu bar, it is required to use the WordPress nav_menu functionality for it.
  • REQUIRED: The theme doesn't have post pagination code in it. Use posts_nav_link() or paginate_links() or the_posts_pagination() or the_posts_navigation() or next_posts_link() and previous_posts_link() to add post pagination.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
  • RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( "post-thumbnails" )in the functions.php file.
  • REQUIRED: This theme doesn't seem to display tags. Modify it to display tags in appropriate locations.
  • REQUIRED: No reference to add_theme_support( "title-tag" ) was found in the theme.
  • REQUIRED: The theme must not used the <title> tags.
  • REQUIRED: The theme must not call to wp_title().
  • RECOMMENDED: This theme contains no sidebars/widget areas. See Widgets API
  • WARNING: "Activation" currently has 4,000+ active installations. Please check for name collisions outside of WordPress.org before approval.

#18 @fjarrett
10 months ago

All of the above errors for "missing" things this theme actually inherits from its parent theme. Should we be concerned?

WARNING: "Activation" currently has 4,000+ active installations. Please check for name collisions outside of WordPress.org before approval.

This is expected as we have been allowing our customers to use this theme on our hosting platform for quite some time.

#19 @meissudeep
10 months ago

@fjarrett

Other all things looks fine but please give the full URL of the image used on your theme.

Thanks

#20 @rabmalin
10 months ago

Some more issues I found in quick scan.

  • REQUIRED: Using a WordPress.org Theme URI is reserved for official themes. Please change it.
  • REQUIRED: readme - Keep credit and copyright info of parent theme.

#21 @meissudeep
10 months ago

Thanks @rabmalin
I have trust author. . .. I miss that as on previous one, he have placed the github URL on Theme URI so have only checked the mention issue.

#22 @fjarrett
10 months ago

@meissudeep and @rabmalin

please give the full URL of the image used on your theme.

No problem.

REQUIRED: Using a WordPress.org Theme URI is reserved for official themes. Please change it.

Oh sorry, I am used to being able to do with Plugin URI headers. No problem!

REQUIRED: readme - Keep credit and copyright info of parent theme.

Where should I put this? I've looked at several other child themes in the repo and can't find an example to model from. Any advice would be appreciated.

Thank you!

Last edited 10 months ago by fjarrett (previous) (diff)

#23 @fjarrett
10 months ago

@rabmalin Something like this?

Activation is a child theme of Primer:

Primer, Copyright 2017 GoDaddy Operating Company, LLC.
License: GPL-2.0
Source: https://github.com/godaddy/wp-primer-theme

#24 @rabmalin
10 months ago

You can add it in readme file. You can use following format.

Ginger WordPress Theme is child theme of Fred WordPress Theme, Copyright 2012 Joe Smith
Fred WordPress Theme is distributed under the terms of the GNU GPL    

#25 @themetracbot
10 months ago

  • Summary changed from THEME: Activation – 0.9.1 to THEME: Activation – 0.9.2

Activation - 0.9.2

Activation is a Primer child theme with a colorful, fitness-focused design.

Theme URL - https://github.com/godaddy/wp-activation-theme
Author URL - https://www.godaddy.com/

Trac Browser - https://themes.trac.wordpress.org/browser/activation/0.9.2

SVN - https://themes.svn.wordpress.org/activation/0.9.2
ZIP - https://wordpress.org/themes/download/activation.0.9.2.zip?nostats=1
Parent Theme: https://wordpress.org/themes/primer

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=activation/0.9.1&new_path=activation/0.9.2

History:

Ticket Summary Status Resolution Owner
#37074 THEME: Activation – 0.9.2 closed closed-newer-version-uploaded meissudeep

(this ticket)

#40498 THEME: Activation – 1.1.0 closed closed-newer-version-uploaded meissudeep
#40805 THEME: Activation – 1.1.2 closed live meissudeep


https://themes.svn.wordpress.org/activation/0.9.2/screenshot.png
Theme Check Results:

  • REQUIRED: Could not find wp_footer. See: wp_footer
     <?php wp_footer(); ?>
    
  • REQUIRED: Could not find wp_head. See: wp_head
     <?php wp_head(); ?>
    
  • REQUIRED: Could not find language_attributes. See: language_attributes
    <html <?php language_attributes(); ?>
    
  • REQUIRED: Could not find charset. There must be a charset defined in the Content-Type or the meta charset tag in the head.
  • REQUIRED: Could not find add_theme_support( 'automatic-feed-links' ). See: add_theme_support
     <?php add_theme_support( $feature ); ?>
    
  • REQUIRED: Could not find comments_template. See: comments_template
     <?php comments_template( $file, $separate_comments ); ?>
    
  • REQUIRED: Could not find wp_list_comments. See: wp_list_comments
     <?php wp_list_comments( $args ); ?>
    
  • REQUIRED: Could not find comment_form. See: comment_form
     <?php comment_form(); ?>
    
  • REQUIRED: Could not find body_class call in body tag. See: body_class
     <?php body_class( $class ); ?>
    
  • REQUIRED: Could not find wp_link_pages. See: wp_link_pages
     <?php wp_link_pages( $args ); ?>
    
  • REQUIRED: Could not find post_class. See: post_class
     <div id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
    
  • REQUIRED: The theme doesn't have comment pagination code in it. Use paginate_comments_links() or the_comments_navigation or the_comments_pagination or next_comments_link() and previous_comments_link() to add comment pagination.
  • REQUIRED: No content width has been defined. Example:
    if ( ! isset( $content_width ) ) $content_width = 900;
    
  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • WARNING: Could not find the file index.php in the theme.
  • REQUIRED: This theme doesn't seem to support the standard avatar functions. Use get_avatar or wp_list_comments to add this support.
  • RECOMMENDED: No reference to nav_menu's was found in the theme. Note that if your theme has a menu bar, it is required to use the WordPress nav_menu functionality for it.
  • REQUIRED: The theme doesn't have post pagination code in it. Use posts_nav_link() or paginate_links() or the_posts_pagination() or the_posts_navigation() or next_posts_link() and previous_posts_link() to add post pagination.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
  • RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( "post-thumbnails" )in the functions.php file.
  • REQUIRED: This theme doesn't seem to display tags. Modify it to display tags in appropriate locations.
  • REQUIRED: No reference to add_theme_support( "title-tag" ) was found in the theme.
  • REQUIRED: The theme must not used the <title> tags.
  • REQUIRED: The theme must not call to wp_title().
  • RECOMMENDED: This theme contains no sidebars/widget areas. See Widgets API
  • WARNING: "Activation" currently has 4,000+ active installations. Please check for name collisions outside of WordPress.org before approval.

#26 @meissudeep
10 months ago

  • Status changed from reviewing to approved

Hello @fjarrett

Now its all good.
I am marking this theme as approve.

#27 @WPDevHQ
10 months ago

Since we have the author's attention can we make sure that the 2 footer links from the parent theme is resolved before this theme goes live!

@fjarrett Please update Primer to remove the second footer link - this was advised in the notes above but not addressed!

#28 @WPDevHQ
10 months ago

@fjarrett - Please revisit this ticket: https://themes.trac.wordpress.org/ticket/37025.

Some of the issues raised there were never resolved including but not limited to the footer links!

Ref: https://github.com/godaddy/wp-primer-theme/issues/127 for WordPress core functionality issue - couldn't find an issue open or closed (I may have missed it) for the footer link as was promissed by @jonathanbardo in the original ticket above.

#29 @fjarrett
10 months ago

@WPDevHQ Alright, going back to drawing board then to submit an update for Primer 1.5.0. Will spend the day working on that.

#30 @fjarrett
10 months ago

@WPDevHQ @meissudeep

Alright I've got Primer updated to 1.5.0 now, which includes the footer links fix you requested.

The Activation theme is now also updated to 1.1.0 to be compatible with the Primer 1.5.0 version.

#31 @meissudeep
10 months ago

@grapplerulrich

Can you close this ticket and assign https://themes.trac.wordpress.org/ticket/40498 ticket to me for review

#32 @grapplerulrich
10 months ago

  • Status changed from approved to reopened

#33 @grapplerulrich
10 months ago

  • Resolution set to closed-newer-version-uploaded
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.