WordPress.org

Make WordPress Themes

Opened 7 months ago

Closed 4 weeks ago

Last modified 4 weeks ago

#37110 closed theme (live)

THEME: Clarina – 0.5.9

Reported by: madalinm Owned by: greenshady
Priority: new theme Keywords: theme-clarina child-theme parent-llorix-one-lite
Cc: mileamadalin@…

Description

Change History (39)

#1 @themetracbot
6 months ago

  • Summary changed from THEME: Clarina – 0.1 to THEME: Clarina – 0.2

#2 @themetracbot
5 months ago

  • Summary changed from THEME: Clarina – 0.2 to THEME: Clarina – 0.3

Clarina - 0.3

Clarina is a free and beautiful one page business WordPress theme, with a flat and clean bootstrap based design and an elegant parallax effect. It provides a simple, minimal and modern look that can be used for any kind of personal businesses or startup mobile app. Keeping simplicity in mind, Clarina’s customizer is perfectly designed in such a way, that it is easy for anyone to use and modify the content of the website. You can use it for your business / startup shop, agency, corporate website, or photography portfolio. The theme provides a responsive blog section, is eCommerce ready (WooCommerce store compatible), WPML, bbPress, Photo Gallery Grid, Contact Form 7, Meta Slider, SiteOrigin Page Builder, is JetPack compatible and is SEO friendly.

Theme URL -
Author URL -

SVN - https://themes.svn.wordpress.org/clarina/0.3
ZIP - https://wordpress.org/themes/download/clarina.0.3.zip?nostats=1
Parent Theme: https://wordpress.org/themes/llorix-one-lite

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=clarina/0.2&new_path=clarina/0.3

History:

Ticket Summary Status Resolution Owner
#37110 THEME: Clarina – 0.5.9 closed live greenshady

(this ticket)


https://themes.svn.wordpress.org/clarina/0.3/screenshot.png
Theme Check Results:

  • REQUIRED: Could not find wp_footer. See: wp_footer
     <?php wp_footer(); ?>
    
  • REQUIRED: Could not find add_theme_support( 'automatic-feed-links' ). See: add_theme_support
     <?php add_theme_support( $feature ); ?>
    
  • REQUIRED: Could not find comments_template. See: comments_template
     <?php comments_template( $file, $separate_comments ); ?>
    
  • REQUIRED: Could not find wp_list_comments. See: wp_list_comments
     <?php wp_list_comments( $args ); ?>
    
  • REQUIRED: Could not find comment_form. See: comment_form
     <?php comment_form(); ?>
    
  • REQUIRED: The theme doesn't have comment pagination code in it. Use paginate_comments_links() or the_comments_navigation or the_comments_pagination or next_comments_link() and previous_comments_link() to add comment pagination.
  • REQUIRED: No content width has been defined. Example:
    if ( ! isset( $content_width ) ) $content_width = 900;
    
  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • WARNING: Could not find the file index.php in the theme.
  • RECOMMENDED: Could not find the file readme.txt in the theme. Please see Theme_Documentation for more information.
  • REQUIRED: The theme doesn't have post pagination code in it. Use posts_nav_link() or paginate_links() or the_posts_pagination() or the_posts_navigation() or next_posts_link() and previous_posts_link() to add post pagination.
  • RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( "post-thumbnails" )in the functions.php file.
  • <span class='tc-lead tc-required'>REQUIRED</span>: .bypostauthor css class is needed in your theme css.
  • <span class='tc-lead tc-required'>REQUIRED</span>: .alignleft css class is needed in your theme css.
  • <span class='tc-lead tc-required'>REQUIRED</span>: .alignright css class is needed in your theme css.
  • <span class='tc-lead tc-required'>REQUIRED</span>: .aligncenter css class is needed in your theme css.
  • <span class='tc-lead tc-required'>REQUIRED</span>: .wp-caption css class is needed in your theme css.
  • <span class='tc-lead tc-required'>REQUIRED</span>: .wp-caption-text css class is needed in your theme css.
  • <span class='tc-lead tc-required'>REQUIRED</span>: .gallery-caption css class is needed in your theme css.
  • <span class='tc-lead tc-required'>REQUIRED</span>: .screen-reader-text css class is needed in your theme css. See See: the Codex for an example implementation.
  • RECOMMENDED: Author URI: is missing from your style.css header.
  • <span class='tc-lead tc-required'>REQUIRED</span>: This theme doesn't seem to display tags. Modify it to display tags in appropriate locations.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs.<br>The domains found are llorix-one-lite, clarina
  • REQUIRED: No reference to add_theme_support( "title-tag" ) was found in the theme.
  • REQUIRED: The theme must not used the &lt;title&gt; tags.
  • REQUIRED: The theme must not call to wp_title().
  • <span class='tc-lead tc-recommended'>RECOMMENDED</span>: This theme contains no sidebars/widget areas. See Widgets API

#3 @themetracbot
5 months ago

  • Summary changed from THEME: Clarina – 0.3 to THEME: Clarina – 0.4

Clarina - 0.4

Clarina is a free and beautiful one page business WordPress theme, with a flat and clean bootstrap based design and an elegant parallax effect. It provides a simple, minimal and modern look that can be used for any kind of personal businesses or startup mobile app. Keeping simplicity in mind, Clarina&#8217;s customizer is perfectly designed in such a way, that it is easy for anyone to use and modify the content of the website. You can use it for your business / startup shop, agency, corporate website, or photography portfolio. The theme provides a responsive blog section, is eCommerce ready (WooCommerce store compatible), WPML, bbPress, Photo Gallery Grid, Contact Form 7, Meta Slider, SiteOrigin Page Builder, is JetPack compatible and is SEO friendly.

Theme URL -
Author URL -

SVN - https://themes.svn.wordpress.org/clarina/0.4
ZIP - https://wordpress.org/themes/download/clarina.0.4.zip?nostats=1
Parent Theme: https://wordpress.org/themes/llorix-one-lite

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=clarina/0.3&new_path=clarina/0.4

History:

Ticket Summary Status Resolution Owner
#37110 THEME: Clarina – 0.5.9 closed live greenshady

(this ticket)


https://themes.svn.wordpress.org/clarina/0.4/screenshot.png
Theme Check Results:

  • REQUIRED: Could not find wp_footer. See: wp_footer
     &lt;?php wp_footer(); ?&gt;
    
  • REQUIRED: Could not find add_theme_support( 'automatic-feed-links' ). See: add_theme_support
     &lt;?php add_theme_support( $feature ); ?&gt;
    
  • REQUIRED: Could not find comments_template. See: comments_template
     &lt;?php comments_template( $file, $separate_comments ); ?&gt;
    
  • REQUIRED: Could not find wp_list_comments. See: wp_list_comments
     &lt;?php wp_list_comments( $args ); ?&gt;
    
  • REQUIRED: Could not find comment_form. See: comment_form
     &lt;?php comment_form(); ?&gt;
    
  • REQUIRED: The theme doesn't have comment pagination code in it. Use paginate_comments_links() or the_comments_navigation or the_comments_pagination or next_comments_link() and previous_comments_link() to add comment pagination.
  • REQUIRED: No content width has been defined. Example:
    if ( ! isset( $content_width ) ) $content_width = 900;
    
  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • WARNING: Could not find the file index.php in the theme.
  • RECOMMENDED: Could not find the file readme.txt in the theme. Please see Theme_Documentation for more information.
  • REQUIRED: The theme doesn't have post pagination code in it. Use posts_nav_link() or paginate_links() or the_posts_pagination() or the_posts_navigation() or next_posts_link() and previous_posts_link() to add post pagination.
  • RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( "post-thumbnails" )in the functions.php file.
  • <span class='tc-lead tc-required'>REQUIRED</span>: .bypostauthor css class is needed in your theme css.
  • <span class='tc-lead tc-required'>REQUIRED</span>: .alignleft css class is needed in your theme css.
  • <span class='tc-lead tc-required'>REQUIRED</span>: .alignright css class is needed in your theme css.
  • <span class='tc-lead tc-required'>REQUIRED</span>: .aligncenter css class is needed in your theme css.
  • <span class='tc-lead tc-required'>REQUIRED</span>: .wp-caption css class is needed in your theme css.
  • <span class='tc-lead tc-required'>REQUIRED</span>: .wp-caption-text css class is needed in your theme css.
  • <span class='tc-lead tc-required'>REQUIRED</span>: .gallery-caption css class is needed in your theme css.
  • <span class='tc-lead tc-required'>REQUIRED</span>: .screen-reader-text css class is needed in your theme css. See See: the Codex for an example implementation.
  • RECOMMENDED: Author URI: is missing from your style.css header.
  • <span class='tc-lead tc-required'>REQUIRED</span>: This theme doesn't seem to display tags. Modify it to display tags in appropriate locations.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs.<br>The domains found are llorix-one-lite, clarina
  • REQUIRED: No reference to add_theme_support( "title-tag" ) was found in the theme.
  • REQUIRED: The theme must not used the &lt;title&gt; tags.
  • REQUIRED: The theme must not call to wp_title().
  • <span class='tc-lead tc-recommended'>RECOMMENDED</span>: This theme contains no sidebars/widget areas. See Widgets API

#4 @themeisle
4 months ago

Note for reviewer :

While Madalin is working with us at ThemeIsle and Clarina development was initially started in the team, after the 1-theme limit rule per account we have decided to giveaway the theme/maintenance to Madalin, rather than throwing it away.

This is not an attempt to go around the w.org rules, the theme is not and won't be transferred to themeisle.

#5 @themetracbot
3 months ago

  • Summary changed from THEME: Clarina – 0.4 to THEME: Clarina – 0.5.4

Clarina - 0.5.4

Clarina is a free and beautiful one page WordPress theme build for Travel Blogs, Agencies and Hotels

Theme URL - https://www.themeisle.com/themes/clarina/
Author URL - http://themeisle.com/

SVN - https://themes.svn.wordpress.org/clarina/0.5.4
ZIP - https://wordpress.org/themes/download/clarina.0.5.4.zip?nostats=1
Parent Theme: https://wordpress.org/themes/llorix-one-lite

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=clarina/0.4&new_path=clarina/0.5.4

History:

Ticket Summary Status Resolution Owner
#37110 THEME: Clarina – 0.5.9 closed live greenshady

(this ticket)


https://themes.svn.wordpress.org/clarina/0.5.4/screenshot.png
Theme Check Results:

  • REQUIRED: Could not find wp_footer. See: wp_footer
     &lt;?php wp_footer(); ?&gt;
    
  • REQUIRED: Could not find wp_head. See: wp_head
     &lt;?php wp_head(); ?&gt;
    
  • REQUIRED: Could not find language_attributes. See: language_attributes
    &lt;html &lt;?php language_attributes(); ?&gt;
    
  • REQUIRED: Could not find charset. There must be a charset defined in the Content-Type or the meta charset tag in the head.
  • REQUIRED: Could not find add_theme_support( 'automatic-feed-links' ). See: add_theme_support
     &lt;?php add_theme_support( $feature ); ?&gt;
    
  • REQUIRED: Could not find comments_template. See: comments_template
     &lt;?php comments_template( $file, $separate_comments ); ?&gt;
    
  • REQUIRED: Could not find wp_list_comments. See: wp_list_comments
     &lt;?php wp_list_comments( $args ); ?&gt;
    
  • REQUIRED: Could not find comment_form. See: comment_form
     &lt;?php comment_form(); ?&gt;
    
  • REQUIRED: Could not find body_class call in body tag. See: body_class
     &lt;?php body_class( $class ); ?&gt;
    
  • REQUIRED: Could not find wp_link_pages. See: wp_link_pages
     &lt;?php wp_link_pages( $args ); ?&gt;
    
  • REQUIRED: Could not find post_class. See: post_class
     &lt;div id="post-&lt;?php the_ID(); ?&gt;" &lt;?php post_class(); ?&gt;&gt;
    
  • REQUIRED: The theme doesn't have comment pagination code in it. Use paginate_comments_links() or the_comments_navigation or the_comments_pagination or next_comments_link() and previous_comments_link() to add comment pagination.
  • REQUIRED: No content width has been defined. Example:
    if ( ! isset( $content_width ) ) $content_width = 900;
    
  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • WARNING: Could not find the file index.php in the theme.
  • RECOMMENDED: Could not find the file readme.txt in the theme. Please see Theme_Documentation for more information.
  • REQUIRED: This theme doesn't seem to support the standard avatar functions. Use get_avatar or wp_list_comments to add this support.
  • RECOMMENDED: No reference to nav_menu's was found in the theme. Note that if your theme has a menu bar, it is required to use the WordPress nav_menu functionality for it.
  • REQUIRED: The theme doesn't have post pagination code in it. Use posts_nav_link() or paginate_links() or the_posts_pagination() or the_posts_navigation() or next_posts_link() and previous_posts_link() to add post pagination.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
  • RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( "post-thumbnails" )in the functions.php file.
  • REQUIRED: .bypostauthor css class is needed in your theme css.
  • REQUIRED: .alignleft css class is needed in your theme css.
  • REQUIRED: .alignright css class is needed in your theme css.
  • REQUIRED: .aligncenter css class is needed in your theme css.
  • REQUIRED: .wp-caption css class is needed in your theme css.
  • REQUIRED: .wp-caption-text css class is needed in your theme css.
  • REQUIRED: .gallery-caption css class is needed in your theme css.
  • REQUIRED: .screen-reader-text css class is needed in your theme css. See See: the Codex for an example implementation.
  • REQUIRED: This theme doesn't seem to display tags. Modify it to display tags in appropriate locations.
  • REQUIRED: No reference to add_theme_support( "title-tag" ) was found in the theme.
  • REQUIRED: The theme must not used the &lt;title&gt; tags.
  • REQUIRED: The theme must not call to wp_title().
  • RECOMMENDED: This theme contains no sidebars/widget areas. See Widgets API

#6 @themetracbot
3 months ago

  • Summary changed from THEME: Clarina – 0.5.4 to THEME: Clarina – 0.5.5

Clarina - 0.5.5

Clarina is a free and beautiful one page business WordPress theme, with a flat and clean bootstrap based design and an elegant parallax effect. It provides a simple, minimal and modern look that can be used for any kind of personal businesses or startup mobile app. Keeping simplicity in mind, Clarina&#8217;s customizer is perfectly designed in such a way, that it is easy for anyone to use and modify the content of the website. You can use it for your business / startup shop, agency, corporate website, or photography portfolio. The theme provides a responsive blog section, is eCommerce ready (WooCommerce store compatible), WPML, bbPress, Photo Gallery Grid, Contact Form 7, Meta Slider, SiteOrigin Page Builder, is JetPack compatible and is SEO friendly.

Theme URL - https://justfreethemes.com/clarina/
Author URL - http://madalinm.com

SVN - https://themes.svn.wordpress.org/clarina/0.5.5
ZIP - https://wordpress.org/themes/download/clarina.0.5.5.zip?nostats=1
Parent Theme: https://wordpress.org/themes/llorix-one-lite

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=clarina/0.5.4&new_path=clarina/0.5.5

History:

Ticket Summary Status Resolution Owner
#37110 THEME: Clarina – 0.5.9 closed live greenshady

(this ticket)


https://themes.svn.wordpress.org/clarina/0.5.5/screenshot.png
Theme Check Results:

  • REQUIRED: Could not find wp_footer. See: wp_footer
     &lt;?php wp_footer(); ?&gt;
    
  • REQUIRED: Could not find wp_head. See: wp_head
     &lt;?php wp_head(); ?&gt;
    
  • REQUIRED: Could not find language_attributes. See: language_attributes
    &lt;html &lt;?php language_attributes(); ?&gt;
    
  • REQUIRED: Could not find charset. There must be a charset defined in the Content-Type or the meta charset tag in the head.
  • REQUIRED: Could not find add_theme_support( 'automatic-feed-links' ). See: add_theme_support
     &lt;?php add_theme_support( $feature ); ?&gt;
    
  • REQUIRED: Could not find comments_template. See: comments_template
     &lt;?php comments_template( $file, $separate_comments ); ?&gt;
    
  • REQUIRED: Could not find wp_list_comments. See: wp_list_comments
     &lt;?php wp_list_comments( $args ); ?&gt;
    
  • REQUIRED: Could not find comment_form. See: comment_form
     &lt;?php comment_form(); ?&gt;
    
  • REQUIRED: Could not find body_class call in body tag. See: body_class
     &lt;?php body_class( $class ); ?&gt;
    
  • REQUIRED: Could not find wp_link_pages. See: wp_link_pages
     &lt;?php wp_link_pages( $args ); ?&gt;
    
  • REQUIRED: Could not find post_class. See: post_class
     &lt;div id="post-&lt;?php the_ID(); ?&gt;" &lt;?php post_class(); ?&gt;&gt;
    
  • REQUIRED: The theme doesn't have comment pagination code in it. Use paginate_comments_links() or the_comments_navigation or the_comments_pagination or next_comments_link() and previous_comments_link() to add comment pagination.
  • REQUIRED: No content width has been defined. Example:
    if ( ! isset( $content_width ) ) $content_width = 900;
    
  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • WARNING: Could not find the file index.php in the theme.
  • RECOMMENDED: Could not find the file readme.txt in the theme. Please see Theme_Documentation for more information.
  • REQUIRED: This theme doesn't seem to support the standard avatar functions. Use get_avatar or wp_list_comments to add this support.
  • RECOMMENDED: No reference to nav_menu's was found in the theme. Note that if your theme has a menu bar, it is required to use the WordPress nav_menu functionality for it.
  • REQUIRED: The theme doesn't have post pagination code in it. Use posts_nav_link() or paginate_links() or the_posts_pagination() or the_posts_navigation() or next_posts_link() and previous_posts_link() to add post pagination.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
  • RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( "post-thumbnails" )in the functions.php file.
  • REQUIRED: .bypostauthor css class is needed in your theme css.
  • REQUIRED: .alignleft css class is needed in your theme css.
  • REQUIRED: .alignright css class is needed in your theme css.
  • REQUIRED: .aligncenter css class is needed in your theme css.
  • REQUIRED: .wp-caption css class is needed in your theme css.
  • REQUIRED: .wp-caption-text css class is needed in your theme css.
  • REQUIRED: .gallery-caption css class is needed in your theme css.
  • REQUIRED: .screen-reader-text css class is needed in your theme css. See See: the Codex for an example implementation.
  • REQUIRED: This theme doesn't seem to display tags. Modify it to display tags in appropriate locations.
  • REQUIRED: No reference to add_theme_support( "title-tag" ) was found in the theme.
  • REQUIRED: The theme must not used the &lt;title&gt; tags.
  • REQUIRED: The theme must not call to wp_title().
  • RECOMMENDED: This theme contains no sidebars/widget areas. See Widgets API

#7 @themetracbot
3 months ago

  • Owner set to arvindsinghu
  • Status changed from new to reviewing

#8 @arvindsinghu
3 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

hi , i found some following error please fix them first

RECOMMENDED: Screenshot size should be 1200x900, to account for HiDPI displays. Any 4:3 image size is acceptable, but 1200x900 is preferred.
RECOMMENDED: Possible variable $input found in translation function in inc/extras.php. Translation function calls must NOT contain PHP variables.
Line 84: return pll( $input );
RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
INFO: Themes that use the tag accessibility-ready will need to undergo an accessibility review. See https://make.wordpress.org/themes/handbook/review/accessibility/
INFO: Possible hard-coded links were found in the file inc/customizer.php.
Line 38: 'llorix_one_lite_message' =>
( 'Check out the <a href='http://themeisle.com/plugins/llorix-one-plus/'>PRO version</a> for full con
Line 153: 'llorix_one_lite_message' => ( 'Check out the <a href='http://themeisle.com/plugins/llorix-one-plus/'>PRO version</a> for full con
Line 38: 'llorix_one_lite_message' =>
( 'Check out the <a href='http://themeisle.com/plugins/llorix-one-plus/'>PRO version</a> for full con
Line 153: 'llorix_one_lite_message' => ( 'Check out the <a href='http://themeisle.com/plugins/llorix-one-plus/'>PRO version</a> for full con
INFO: Possible hard-coded links were found in the file inc/customize-pro/class-llorix-one-lite-customize-upsell.php.
Line 78: 'upsell_text' =>
( 'Check out the <a href='http://themeisle.com/plugins/llorix-one-plus/'>PRO version</a> for full con
Line 87: 'upsell_text' => ( 'To customize the Frontpage sections please create a page and select the template 'Frontpage' for that page. After that, go to Appearance -> Customize -> Static Front Page and under 'Static Front Page' select 'A static page'. Finally, for 'Front page' choose the page you previously created.','llorix-one-lite' ) . '<br><br>' . ( 'Need further informations? Check this','llorix-one-lite' ) . ' <a href='http://docs.themeisle.com/article/236-how-to-set-up-the-home-page-for-llori
INFO: Possible hard-coded links were found in the file inc/admin/welcome-screen/sections/support.php.
Line 16: <a href='http://docs.themeisle.com/article/186-llorix-one-documentation' class='butt
INFO: Possible hard-coded links were found in the file inc/admin/welcome-screen/sections/github.php.
Line 22: <a href='https://github.com/Codeinwp/llorix-one-lite/' class='github-button button b
INFO: Possible hard-coded links were found in the file inc/admin/welcome-screen/sections/getting-started.php.
Line 46: <p><a href='http://docs.themeisle.com/article/14-how-to-create-a-child-theme/' class='b
Line 52: <p><a href='http://docs.themeisle.com/article/80-how-to-translate-zerif' class='button'
Line 58: <p><a href='http://docs.themeisle.com/article/219-how-to-build-a-landing-page-with-a-dr
Line 66: <p><a href='http://docs.themeisle.com/article/63-speed-up-your-wordpress-site/' class='
Line 72: <p><a href='http://docs.themeisle.com/article/59-how-to-link-menu-to-sections-in-parall
Line 78: <p><a href='http://docs.themeisle.com/article/72-parallax-one-how-to-change-section-anc
Line 90: <p><a href='http://themeisle.com/documentation-llorix-one/' class='button button-primar
INFO: Possible hard-coded links were found in the file inc/admin/welcome-screen/sections/child-themes.php.
Line 35: <a href='http://themeisle.com/themes/naturelle' class='button button-primary install
INFO: Possible hard-coded links were found in the file footer.php.
Line 109: <?php echo apply_filters( 'llorix_one_plus_footer_text_filter','<div class='powered-by'><a href='http://themeisle.com/themes/llorix-one/' rel='nofollow'>Llorix One Lite </a
INFO: Only one text-domain is being used in this theme. Make sure it matches the theme's slug correctly so that the theme will be compatible with WordPress.org language packs.
The domain found is llorix-one-lite
INFO: inc/customizer.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
Line 15: require_once( 'class/llorix-one-lite-general-control.php' );
Line 16: require_once( 'class/llorix-one-lite-text-control.php' );
Line 17: require_once( 'class/llorix-one-lite-alpha-control.php' );
INFO: inc/customize-pro/class-llorix-one-lite-customize-upsell.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
Line 71: require_once( trailingslashit( get_template_directory() ) . 'inc/customize-
INFO: inc/admin/welcome-screen/welcome-screen.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
Line 165: require_once( ABSPATH . 'wp-load.php' );
Line 166: require_once( ABSPATH . 'wp-admin/admin.php' );
Line 167: require_once( ABSPATH . 'wp-admin/admin-header.php' );
Line 201: require_once( get_template_directory() . '/inc/admin/welcome-screen/section
Line 207: require_once( get_template_directory() . '/inc/admin/welcome-screen/section
Line 213: require_once( get_template_directory() . '/inc/admin/welcome-screen/section
Line 221: require_once( get_template_directory() . '/inc/admin/welcome-screen/section
Line 227: require_once( get_template_directory() . '/inc/admin/welcome-screen/section
Line 233: require_once( get_template_directory() . '/inc/admin/welcome-screen/section

thank you :)

This ticket was mentioned in Slack in #themereview by madalinm. View the logs.


3 months ago

#10 @hardeepasrani
3 months ago

  • Keywords changed from theme-clarina, child-theme, parent-llorix-one-lite to theme-clarina child-theme parent-llorix-one-lite
  • Resolution not-approved deleted
  • Status changed from closed to reopened

@arvindsinghu All of these are recommended so you shouldn't close the ticket. Please keep reviewing. :)

#11 @grapplerulrich
3 months ago

  • Status changed from reopened to reviewing

#12 @arvindsinghu
3 months ago

hi , i found some following error please fix them first

RECOMMENDED: Screenshot size should be 1200x900, to account for HiDPI displays. Any 4:3 image size is acceptable, but 1200x900 is preferred.
RECOMMENDED: Possible variable $input found in translation function in inc/extras.php. Translation function calls must NOT contain PHP variables.
Line 84: return pll( $input );
RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
INFO: Themes that use the tag accessibility-ready will need to undergo an accessibility review. See https://make.wordpress.org/themes/handbook/review/accessibility/
INFO: Possible hard-coded links were found in the file inc/customizer.php.
Line 38: 'llorix_one_lite_message' =>
( 'Check out the <a href='http://themeisle.com/plugins/llorix-one-plus/'>PRO version</a> for full con
Line 153: 'llorix_one_lite_message' => ( 'Check out the <a href='http://themeisle.com/plugins/llorix-one-plus/'>PRO version</a> for full con
Line 38: 'llorix_one_lite_message' =>
( 'Check out the <a href='http://themeisle.com/plugins/llorix-one-plus/'>PRO version</a> for full con
Line 153: 'llorix_one_lite_message' => ( 'Check out the <a href='http://themeisle.com/plugins/llorix-one-plus/'>PRO version</a> for full con
INFO: Possible hard-coded links were found in the file inc/customize-pro/class-llorix-one-lite-customize-upsell.php.
Line 78: 'upsell_text' =>
( 'Check out the <a href='http://themeisle.com/plugins/llorix-one-plus/'>PRO version</a> for full con
Line 87: 'upsell_text' => ( 'To customize the Frontpage sections please create a page and select the template 'Frontpage' for that page. After that, go to Appearance -> Customize -> Static Front Page and under 'Static Front Page' select 'A static page'. Finally, for 'Front page' choose the page you previously created.','llorix-one-lite' ) . '<br><br>' . ( 'Need further informations? Check this','llorix-one-lite' ) . ' <a href='http://docs.themeisle.com/article/236-how-to-set-up-the-home-page-for-llori
INFO: Possible hard-coded links were found in the file inc/admin/welcome-screen/sections/support.php.
Line 16: <a href='http://docs.themeisle.com/article/186-llorix-one-documentation' class='butt
INFO: Possible hard-coded links were found in the file inc/admin/welcome-screen/sections/github.php.
Line 22: <a href='https://github.com/Codeinwp/llorix-one-lite/' class='github-button button b
INFO: Possible hard-coded links were found in the file inc/admin/welcome-screen/sections/getting-started.php.
Line 46: <p><a href='http://docs.themeisle.com/article/14-how-to-create-a-child-theme/' class='b
Line 52: <p><a href='http://docs.themeisle.com/article/80-how-to-translate-zerif' class='button'
Line 58: <p><a href='http://docs.themeisle.com/article/219-how-to-build-a-landing-page-with-a-dr
Line 66: <p><a href='http://docs.themeisle.com/article/63-speed-up-your-wordpress-site/' class='
Line 72: <p><a href='http://docs.themeisle.com/article/59-how-to-link-menu-to-sections-in-parall
Line 78: <p><a href='http://docs.themeisle.com/article/72-parallax-one-how-to-change-section-anc
Line 90: <p><a href='http://themeisle.com/documentation-llorix-one/' class='button button-primar
INFO: Possible hard-coded links were found in the file inc/admin/welcome-screen/sections/child-themes.php.
Line 35: <a href='http://themeisle.com/themes/naturelle' class='button button-primary install
INFO: Possible hard-coded links were found in the file footer.php.
Line 109: <?php echo apply_filters( 'llorix_one_plus_footer_text_filter','<div class='powered-by'><a href='http://themeisle.com/themes/llorix-one/' rel='nofollow'>Llorix One Lite </a
INFO: Only one text-domain is being used in this theme. Make sure it matches the theme's slug correctly so that the theme will be compatible with WordPress.org language packs.
The domain found is llorix-one-lite
INFO: inc/customizer.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
Line 15: require_once( 'class/llorix-one-lite-general-control.php' );
Line 16: require_once( 'class/llorix-one-lite-text-control.php' );
Line 17: require_once( 'class/llorix-one-lite-alpha-control.php' );
INFO: inc/customize-pro/class-llorix-one-lite-customize-upsell.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
Line 71: require_once( trailingslashit( get_template_directory() ) . 'inc/customize-
INFO: inc/admin/welcome-screen/welcome-screen.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
Line 165: require_once( ABSPATH . 'wp-load.php' );
Line 166: require_once( ABSPATH . 'wp-admin/admin.php' );
Line 167: require_once( ABSPATH . 'wp-admin/admin-header.php' );
Line 201: require_once( get_template_directory() . '/inc/admin/welcome-screen/section
Line 207: require_once( get_template_directory() . '/inc/admin/welcome-screen/section
Line 213: require_once( get_template_directory() . '/inc/admin/welcome-screen/section
Line 221: require_once( get_template_directory() . '/inc/admin/welcome-screen/section
Line 227: require_once( get_template_directory() . '/inc/admin/welcome-screen/section
Line 233: require_once( get_template_directory() . '/inc/admin/welcome-screen/section

thank you :)

#13 @WPDevHQ
2 months ago

@arvindsinghu - These are non issues and at worst they are just recommendation.

Your review process should be to open up the theme's files and check the code manually fo items like security - only report issues that are required to be fixed in line with the guidelines.

@madalinm

Please state the theme's copyright in the readme file.

The footer link needs to point to either the theme or author url - it currently points to the parent theme!

Looking at both your theme and the parent theme I can not see much difference between the two in terms of the home/frontpage layout, looks and feel. Child theme's are required to be distinctively unique in design.

You may want to explore adding more functionality, switching out the layout's look and feel - perhaps call different sections on the page and add in something else that's unique to the child theme.

Other than this there are not many issues that would hold the theme back from being approved.

#14 @themetracbot
2 months ago

  • Summary changed from THEME: Clarina – 0.5.5 to THEME: Clarina – 0.5.6

Clarina - 0.5.6

Clarina is a free and beautiful one page business WordPress theme, with a flat and clean bootstrap based design and an elegant parallax effect. It provides a simple, minimal and modern look that can be used for any kind of personal businesses or startup mobile app. Keeping simplicity in mind, Clarina customizer is perfectly designed in such a way, that it is easy for anyone to use and modify the content of the website. You can use it for your business / startup shop, agency, corporate website, or photography portfolio. The theme provides a responsive blog section, is eCommerce ready (WooCommerce store compatible), WPML, bbPress, Photo Gallery Grid, Contact Form 7, Meta Slider, SiteOrigin Page Builder, is JetPack compatible and is SEO friendly.

Theme URL - https://justfreethemes.com/clarina/
Author URL - http://madalinm.com

SVN - https://themes.svn.wordpress.org/clarina/0.5.6
ZIP - https://wordpress.org/themes/download/clarina.0.5.6.zip?nostats=1
Parent Theme: https://wordpress.org/themes/llorix-one-lite

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=clarina/0.5.5&new_path=clarina/0.5.6

History:

Ticket Summary Status Resolution Owner
#37110 THEME: Clarina – 0.5.9 closed live greenshady

(this ticket)


https://themes.svn.wordpress.org/clarina/0.5.6/screenshot.png
Theme Check Results:

  • REQUIRED: Could not find wp_footer. See: wp_footer
     &lt;?php wp_footer(); ?&gt;
    
  • REQUIRED: Could not find wp_head. See: wp_head
     &lt;?php wp_head(); ?&gt;
    
  • REQUIRED: Could not find language_attributes. See: language_attributes
    &lt;html &lt;?php language_attributes(); ?&gt;
    
  • REQUIRED: Could not find charset. There must be a charset defined in the Content-Type or the meta charset tag in the head.
  • REQUIRED: Could not find add_theme_support( 'automatic-feed-links' ). See: add_theme_support
     &lt;?php add_theme_support( $feature ); ?&gt;
    
  • REQUIRED: Could not find comments_template. See: comments_template
     &lt;?php comments_template( $file, $separate_comments ); ?&gt;
    
  • REQUIRED: Could not find wp_list_comments. See: wp_list_comments
     &lt;?php wp_list_comments( $args ); ?&gt;
    
  • REQUIRED: Could not find comment_form. See: comment_form
     &lt;?php comment_form(); ?&gt;
    
  • REQUIRED: Could not find body_class call in body tag. See: body_class
     &lt;?php body_class( $class ); ?&gt;
    
  • REQUIRED: Could not find wp_link_pages. See: wp_link_pages
     &lt;?php wp_link_pages( $args ); ?&gt;
    
  • REQUIRED: Could not find post_class. See: post_class
     &lt;div id="post-&lt;?php the_ID(); ?&gt;" &lt;?php post_class(); ?&gt;&gt;
    
  • REQUIRED: The theme doesn't have comment pagination code in it. Use paginate_comments_links() or the_comments_navigation or the_comments_pagination or next_comments_link() and previous_comments_link() to add comment pagination.
  • REQUIRED: No content width has been defined. Example:
    if ( ! isset( $content_width ) ) $content_width = 900;
    
  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • WARNING: Could not find the file index.php in the theme.
  • RECOMMENDED: Could not find the file readme.txt in the theme. Please see Theme_Documentation for more information.
  • REQUIRED: This theme doesn't seem to support the standard avatar functions. Use get_avatar or wp_list_comments to add this support.
  • RECOMMENDED: No reference to nav_menu's was found in the theme. Note that if your theme has a menu bar, it is required to use the WordPress nav_menu functionality for it.
  • REQUIRED: The theme doesn't have post pagination code in it. Use posts_nav_link() or paginate_links() or the_posts_pagination() or the_posts_navigation() or next_posts_link() and previous_posts_link() to add post pagination.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
  • RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( "post-thumbnails" )in the functions.php file.
  • REQUIRED: .bypostauthor css class is needed in your theme css.
  • REQUIRED: .alignleft css class is needed in your theme css.
  • REQUIRED: .alignright css class is needed in your theme css.
  • REQUIRED: .aligncenter css class is needed in your theme css.
  • REQUIRED: .wp-caption css class is needed in your theme css.
  • REQUIRED: .wp-caption-text css class is needed in your theme css.
  • REQUIRED: .gallery-caption css class is needed in your theme css.
  • REQUIRED: .screen-reader-text css class is needed in your theme css. See See: the Codex for an example implementation.
  • REQUIRED: This theme doesn't seem to display tags. Modify it to display tags in appropriate locations.
  • REQUIRED: No reference to add_theme_support( "title-tag" ) was found in the theme.
  • REQUIRED: The theme must not used the &lt;title&gt; tags.
  • REQUIRED: The theme must not call to wp_title().
  • RECOMMENDED: This theme contains no sidebars/widget areas. See Widgets API

#15 @madalinm
2 months ago

Hi @WPDevHQ ,

Thank you. I added the copyright in the readme file and changed the footer link as you mentioned. Regarding the thing you mentioned about the difference between the child theme and the parent, I already added different options in the child theme. If you check the functions.php file, you will see the clarina_customize_register function where I register different options like titles, subtitles or images to different existing sections. I hope this is ok.

Thank you,
Madalin

Last edited 2 months ago by madalinm (previous) (diff)

This ticket was mentioned in Slack in #themereview by madalinm. View the logs.


2 months ago

#17 @madalinm
2 months ago

Hey there,

Can someone have a look here please?

This ticket was mentioned in Slack in #themereview by madalinm. View the logs.


2 months ago

#19 @djrmom
2 months ago

  • Owner arvindsinghu deleted

I'll put this back in the queue for a new reviewer to be assigned. @WPDevHQ, do you want to take over the review.

#20 @WPDevHQ
2 months ago

Sure @djrmom - please assign it to me :)

#21 @djrmom
2 months ago

  • Owner set to WPDevHQ

Thanks @WPDevHQ

#22 @WPDevHQ
2 months ago

Code Check.
REQUIRED:

  • functions.php - Please remove the default "Lorem ipsum" text - use something meanignfull like how to instructions or leave it blank!

Post Installation.

REQUIRED:

  • Please remove the reference to "Themeisle" as footer copyright - by default this should be the site's title and not a 3rd party entity!
  • Please remove the "View PRO Version" as this refers to the parent theme
  • Change the "Documentation" link to point to domumentation relevant to Clarina and not the parent theme or remove it comepletely.
  • Not happy with the amount of PRO links in the customizer - these need at the very least toned down or be completely removed. My opinion is that they shold be removed as they are not related to the theme itself but the parent theme!

RECOMMENDATION:

  • Customizer >> Footer Options under "Add new social icon" every option reads "Llorix One" which can be somewhat confusing to the end user. Perhaps explore changing this to a meaningful term to indicate what the option is for?

I'm going to halt the review at this point and suggest that you and @themeisle have a long and hard discussion on how things are done by the parent theme and how you can go about removing them from your theme!

The declaration above by @themeisle is that this theme has been donated to @madalinm yet everything seems to point back to ThemesIsles - can we have some clarity here please!

As it stands, the theme would not qualify for approval unless the above issues are addressed satisfacotry - I'm inclined to keep the ticket open in order to facilitate discussion amongst all of us for a satisfactory resolution.

#23 @themeisle
2 months ago

Hey,

Thank you for the review! We'll coordinate with @madalinm to make sure that parent theme will allow him to do the required changes (remove upsells and missed references).

Regarding the clarifications, most of the links point to themeisle, because of the parent theme, it is the case with other child themes for our themes (developed by us or by other developers), since the child theme is just a different style for the parent theme, usually the documentation and all the stuff are similar, however I agree is pretty confusing for the user, so would be great if Madalin can create a new (even if quite similar) documentation.

#24 @madalinm
8 weeks ago

Hi @WPDevHQ

Thank you for the review. I'm sorry about the confusion and I will fix them soon.

#25 @madalinm
8 weeks ago

Hey there,

I still working to fix this issues. I need more time.

Thank you!

#26 @WPDevHQ
8 weeks ago

Sure, just keep us posted on progress

#27 @themetracbot
7 weeks ago

  • Summary changed from THEME: Clarina – 0.5.6 to THEME: Clarina – 0.5.7

Clarina - 0.5.7

Clarina is a free and beautiful one page business WordPress theme, with a flat and clean bootstrap based design and an elegant parallax effect. It provides a simple, minimal and modern look that can be used for any kind of personal businesses or startup mobile app. Keeping simplicity in mind, Clarina customizer is perfectly designed in such a way, that it is easy for anyone to use and modify the content of the website. You can use it for your business / startup shop, agency, corporate website, or photography portfolio. The theme provides a responsive blog section, is eCommerce ready (WooCommerce store compatible), WPML, bbPress, Photo Gallery Grid, Contact Form 7, Meta Slider, SiteOrigin Page Builder, is JetPack compatible and is SEO friendly.

Theme URL - https://justfreethemes.com/clarina/
Author URL - http://madalinm.com

Trac Browser - https://themes.trac.wordpress.org/browser/clarina/0.5.7

SVN - https://themes.svn.wordpress.org/clarina/0.5.7
ZIP - https://wordpress.org/themes/download/clarina.0.5.7.zip?nostats=1
Parent Theme: https://wordpress.org/themes/llorix-one-lite

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=clarina/0.5.6&new_path=clarina/0.5.7

History:

Ticket Summary Status Resolution Owner
#37110 THEME: Clarina – 0.5.9 closed live greenshady

(this ticket)


https://themes.svn.wordpress.org/clarina/0.5.7/screenshot.png
Theme Check Results:

  • REQUIRED: Could not find wp_footer. See: wp_footer
     &lt;?php wp_footer(); ?&gt;
    
  • REQUIRED: Could not find wp_head. See: wp_head
     &lt;?php wp_head(); ?&gt;
    
  • REQUIRED: Could not find language_attributes. See: language_attributes
    &lt;html &lt;?php language_attributes(); ?&gt;
    
  • REQUIRED: Could not find charset. There must be a charset defined in the Content-Type or the meta charset tag in the head.
  • REQUIRED: Could not find add_theme_support( 'automatic-feed-links' ). See: add_theme_support
     &lt;?php add_theme_support( $feature ); ?&gt;
    
  • REQUIRED: Could not find comments_template. See: comments_template
     &lt;?php comments_template( $file, $separate_comments ); ?&gt;
    
  • REQUIRED: Could not find wp_list_comments. See: wp_list_comments
     &lt;?php wp_list_comments( $args ); ?&gt;
    
  • REQUIRED: Could not find comment_form. See: comment_form
     &lt;?php comment_form(); ?&gt;
    
  • REQUIRED: Could not find body_class call in body tag. See: body_class
     &lt;?php body_class( $class ); ?&gt;
    
  • REQUIRED: Could not find wp_link_pages. See: wp_link_pages
     &lt;?php wp_link_pages( $args ); ?&gt;
    
  • REQUIRED: Could not find post_class. See: post_class
     &lt;div id="post-&lt;?php the_ID(); ?&gt;" &lt;?php post_class(); ?&gt;&gt;
    
  • REQUIRED: The theme doesn't have comment pagination code in it. Use paginate_comments_links() or the_comments_navigation or the_comments_pagination or next_comments_link() and previous_comments_link() to add comment pagination.
  • REQUIRED: No content width has been defined. Example:
    if ( ! isset( $content_width ) ) $content_width = 900;
    
  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • WARNING: Could not find the file index.php in the theme.
  • RECOMMENDED: Could not find the file readme.txt in the theme. Please see Theme_Documentation for more information.
  • REQUIRED: This theme doesn't seem to support the standard avatar functions. Use get_avatar or wp_list_comments to add this support.
  • RECOMMENDED: No reference to nav_menu's was found in the theme. Note that if your theme has a menu bar, it is required to use the WordPress nav_menu functionality for it.
  • REQUIRED: The theme doesn't have post pagination code in it. Use posts_nav_link() or paginate_links() or the_posts_pagination() or the_posts_navigation() or next_posts_link() and previous_posts_link() to add post pagination.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
  • RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( "post-thumbnails" )in the functions.php file.
  • REQUIRED: .bypostauthor css class is needed in your theme css.
  • REQUIRED: .alignleft css class is needed in your theme css.
  • REQUIRED: .alignright css class is needed in your theme css.
  • REQUIRED: .aligncenter css class is needed in your theme css.
  • REQUIRED: .wp-caption css class is needed in your theme css.
  • REQUIRED: .wp-caption-text css class is needed in your theme css.
  • REQUIRED: .gallery-caption css class is needed in your theme css.
  • REQUIRED: .screen-reader-text css class is needed in your theme css. See See: the Codex for an example implementation.
  • REQUIRED: This theme doesn't seem to display tags. Modify it to display tags in appropriate locations.
  • REQUIRED: No reference to add_theme_support( "title-tag" ) was found in the theme.
  • REQUIRED: The theme must not used the &lt;title&gt; tags.
  • REQUIRED: The theme must not call to wp_title().
  • RECOMMENDED: This theme contains no sidebars/widget areas. See Widgets API

#28 @madalinm
7 weeks ago

Hi @WPDevHQ ,

Thank you for your patience. Please let me know if everything is okay now.

#29 @WPDevHQ
6 weeks ago

Sorry for the delay - will take a look at the updates for you in the 24 hours.

#30 @madalinm
5 weeks ago

Hi @WPDevHQ ,

Do you have any new here? Or if you don't have time maybe someone else can pick this ticket.

This ticket was mentioned in Slack in #themereview by madalinm. View the logs.


5 weeks ago

This ticket was mentioned in Slack in #themereview by madalinm. View the logs.


5 weeks ago

#33 @greenshady
5 weeks ago

@WPDevHQ - Do you have time to finish this review today? If not, I can get someone to take it over.

Last edited 5 weeks ago by greenshady (previous) (diff)

#34 @greenshady
4 weeks ago

  • Owner changed from WPDevHQ to greenshady

I'm taking over the review.

#35 @greenshady
4 weeks ago

The following issues must be corrected before the theme can be approved and set live.

Front Page Message

Messages such as this should not be shown on the front end of a user's site:

This Theme Supports a Custom FrontPage

If you want to put something like "Blog" or "Archive", that's fine. But, marketing text is not.

The social links in the footer should not appear unless they are legit social links. Demo # URLs don't work. They're just broken links.

Correct stylesheet / Only load once

First, you're loading your theme's style.css twice using these two lines of code in functions.php:

wp_enqueue_style( 'child-style', get_stylesheet_directory_uri() . '/style.css', array( 'clarina-parent-style' ) );

wp_enqueue_style( 'clarina-inline-style', get_stylesheet_uri(), array(), '1.0.0' );

One of the above needs to be removed. Also, be sure to use get_stylesheet_uri() as you've done in the second line.

Escape CSS theme mods

The theme mods used in the clarina_php_style() must be escaped so that they're OK to use as CSS.

Use core return false

The clarina_filters_return_false() function and its use in the theme should be replaced with the core WP __return_false() function.

See: https://developer.wordpress.org/reference/functions/__return_false/

Translating footer text

The text in clarina_change_poweredby() cannot be properly translated because you have the string broken up into separate parts.

return '<div class="powered-by"><a href="https://justfreethemes.com/clarina/" rel="nofollow">Clarina</a>' . ' ' . esc_html__( 'powered by','clarina' ) . ' ' . '<a href="http://wordpress.org/" rel="nofollow">' . esc_html__( 'WordPress','clarina' ) . '</a></div>';

Instead, you should do something like this:

$text = sprint( 
	__( '%1$s powered by %2$s', 'clarina' ),
	'<a href="https://justfreethemes.com/clarina/" rel="nofollow">Clarina</a>',
	'<a href="http://wordpress.org/" rel="nofollow">' . esc_html__( 'WordPress','clarina' ) . '</a>'
);
		
return sprintf( '<div class="powered-by">%s</div>', $text );

Use core return empty string

The clarina_change_copyright() function should be replaced by the core WP __return_empty_string() function.

See: https://developer.wordpress.org/reference/functions/__return_empty_string/

#36 @themetracbot
4 weeks ago

  • Summary changed from THEME: Clarina – 0.5.7 to THEME: Clarina – 0.5.9

Clarina - 0.5.9

Clarina is a free and beautiful one page business WordPress theme, with a flat and clean bootstrap based design and an elegant parallax effect. It provides a simple, minimal and modern look that can be used for any kind of personal businesses or startup mobile app. Keeping simplicity in mind, Clarina customizer is perfectly designed in such a way, that it is easy for anyone to use and modify the content of the website. You can use it for your business / startup shop, agency, corporate website, or photography portfolio. The theme provides a responsive blog section, is eCommerce ready (WooCommerce store compatible), WPML, bbPress, Photo Gallery Grid, Contact Form 7, Meta Slider, SiteOrigin Page Builder, is JetPack compatible and is SEO friendly.

Theme URL - https://justfreethemes.com/clarina/
Author URL - http://madalinm.com

Trac Browser - https://themes.trac.wordpress.org/browser/clarina/0.5.9

SVN - https://themes.svn.wordpress.org/clarina/0.5.9
ZIP - https://wordpress.org/themes/download/clarina.0.5.9.zip?nostats=1
Parent Theme: https://wordpress.org/themes/llorix-one-lite

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=clarina/0.5.7&new_path=clarina/0.5.9

History:

Ticket Summary Status Resolution Owner
#37110 THEME: Clarina – 0.5.9 closed live greenshady

(this ticket)


https://themes.svn.wordpress.org/clarina/0.5.9/screenshot.png
Theme Check Results:

  • REQUIRED: Could not find wp_footer. See: wp_footer
     &lt;?php wp_footer(); ?&gt;
    
  • REQUIRED: Could not find wp_head. See: wp_head
     &lt;?php wp_head(); ?&gt;
    
  • REQUIRED: Could not find language_attributes. See: language_attributes
    &lt;html &lt;?php language_attributes(); ?&gt;
    
  • REQUIRED: Could not find charset. There must be a charset defined in the Content-Type or the meta charset tag in the head.
  • REQUIRED: Could not find add_theme_support( 'automatic-feed-links' ). See: add_theme_support
     &lt;?php add_theme_support( $feature ); ?&gt;
    
  • REQUIRED: Could not find comments_template. See: comments_template
     &lt;?php comments_template( $file, $separate_comments ); ?&gt;
    
  • REQUIRED: Could not find wp_list_comments. See: wp_list_comments
     &lt;?php wp_list_comments( $args ); ?&gt;
    
  • REQUIRED: Could not find comment_form. See: comment_form
     &lt;?php comment_form(); ?&gt;
    
  • REQUIRED: Could not find body_class call in body tag. See: body_class
     &lt;?php body_class( $class ); ?&gt;
    
  • REQUIRED: Could not find wp_link_pages. See: wp_link_pages
     &lt;?php wp_link_pages( $args ); ?&gt;
    
  • REQUIRED: Could not find post_class. See: post_class
     &lt;div id="post-&lt;?php the_ID(); ?&gt;" &lt;?php post_class(); ?&gt;&gt;
    
  • REQUIRED: The theme doesn't have comment pagination code in it. Use paginate_comments_links() or the_comments_navigation or the_comments_pagination or next_comments_link() and previous_comments_link() to add comment pagination.
  • REQUIRED: No content width has been defined. Example:
    if ( ! isset( $content_width ) ) $content_width = 900;
    
  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • WARNING: Could not find the file index.php in the theme.
  • RECOMMENDED: Could not find the file readme.txt in the theme. Please see Theme_Documentation for more information.
  • REQUIRED: This theme doesn't seem to support the standard avatar functions. Use get_avatar or wp_list_comments to add this support.
  • RECOMMENDED: No reference to nav_menu's was found in the theme. Note that if your theme has a menu bar, it is required to use the WordPress nav_menu functionality for it.
  • REQUIRED: The theme doesn't have post pagination code in it. Use posts_nav_link() or paginate_links() or the_posts_pagination() or the_posts_navigation() or next_posts_link() and previous_posts_link() to add post pagination.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
  • RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( "post-thumbnails" )in the functions.php file.
  • REQUIRED: .bypostauthor css class is needed in your theme css.
  • REQUIRED: .alignleft css class is needed in your theme css.
  • REQUIRED: .alignright css class is needed in your theme css.
  • REQUIRED: .aligncenter css class is needed in your theme css.
  • REQUIRED: .wp-caption css class is needed in your theme css.
  • REQUIRED: .wp-caption-text css class is needed in your theme css.
  • REQUIRED: .gallery-caption css class is needed in your theme css.
  • REQUIRED: .screen-reader-text css class is needed in your theme css. See See: the Codex for an example implementation.
  • REQUIRED: This theme doesn't seem to display tags. Modify it to display tags in appropriate locations.
  • REQUIRED: No reference to add_theme_support( "title-tag" ) was found in the theme.
  • REQUIRED: The theme must not used the &lt;title&gt; tags.
  • REQUIRED: The theme must not call to wp_title().
  • RECOMMENDED: This theme contains no sidebars/widget areas. See Widgets API

#37 @madalinm
4 weeks ago

Hi @greenshady ,

Please let me know if now everything is okay.

Best regards,
Madalin

#38 @greenshady
4 weeks ago

  • Resolution set to live
  • Status changed from reviewing to closed

I'm going to go ahead and mark this theme live. In your next update, please address the "Front page message" and "Social demo links" notes I left above. These should be corrected.

#39 @Madalin_ThemeIsle
4 weeks ago

@greenshady Thank you! I would make these changes.

Note: See TracTickets for help on using tickets.