WordPress.org

Make WordPress Themes

Opened 15 months ago

Closed 10 months ago

Last modified 10 months ago

#37258 closed theme (live)

THEME: Speculor – 1.1.5

Reported by: Prelc Owned by: rabmalin
Priority: new theme Keywords: theme-speculor
Cc: mareprelc@…

Description

Speculor - 1.0.0

Speculor is fast, clean and powerful WordPress theme.

Theme URL -
Author URL - http://www.prelc.si

SVN - https://themes.svn.wordpress.org/speculor/1.0.0
ZIP - https://wordpress.org/themes/download/speculor.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#37258 THEME: Speculor – 1.1.5 closed live rabmalin

(this ticket)

#41365 THEME: Speculor – 1.2.0 closed live themetracbot


https://themes.svn.wordpress.org/speculor/1.0.0/screenshot.jpg

Change History (23)

#1 @themetracbot
15 months ago

  • Summary changed from THEME: Speculor – 1.0.0 to THEME: Speculor – 1.0.1

Speculor - 1.0.1

Speculor is fast, clean and powerful WordPress theme.

Theme URL -
Author URL - http://www.prelc.si

SVN - https://themes.svn.wordpress.org/speculor/1.0.1
ZIP - https://wordpress.org/themes/download/speculor.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=speculor/1.0.0&new_path=speculor/1.0.1

History:

Ticket Summary Status Resolution Owner
#37258 THEME: Speculor – 1.1.5 closed live rabmalin

(this ticket)

#41365 THEME: Speculor – 1.2.0 closed live themetracbot


https://themes.svn.wordpress.org/speculor/1.0.1/screenshot.jpg

#2 @themetracbot
15 months ago

  • Summary changed from THEME: Speculor – 1.0.1 to THEME: Speculor – 1.1.0

Speculor - 1.1.0

Speculor is fast, clean and powerful WordPress theme.

Theme URL -
Author URL - http://www.prelc.si

SVN - https://themes.svn.wordpress.org/speculor/1.1.0
ZIP - https://wordpress.org/themes/download/speculor.1.1.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=speculor/1.0.1&new_path=speculor/1.1.0

History:

Ticket Summary Status Resolution Owner
#37258 THEME: Speculor – 1.1.5 closed live rabmalin

(this ticket)

#41365 THEME: Speculor – 1.2.0 closed live themetracbot


https://themes.svn.wordpress.org/speculor/1.1.0/screenshot.jpg

#3 @rabmalin
11 months ago

  • Owner set to rabmalin
  • Status changed from new to reviewing

#4 @rabmalin
11 months ago

Issues

  • REQUIRED: Remove search-form from add_theme_support( 'html5' ) as you are customizing search form yourself.
  • REQUIRED: Remove add_post_type_support( 'page', 'excerpt' );. [Plugin Territory]
  • REQUIRED: Please remove development files as those are not needed in production version.
  • REQUIRED: get_search_query() missing in searchform.php.
  • REQUIRED: readme - Add credit for Color library.
  • REQUIRED: Use esc_url_raw for sanitization rather than esc_url.
  • REQUIRED: Escaping missing in several places. Eg, check customizer_colors(). Check other places also.

Please respond within 7 days. If there is no response for 7 days, ticket will be closed as not-approved.

#5 @Prelc
11 months ago

Hi @rabmalin. Thanks for the review. I will do my best to fix everything this week.

#6 @themetracbot
11 months ago

  • Summary changed from THEME: Speculor – 1.1.0 to THEME: Speculor – 1.1.1

Speculor - 1.1.1

Speculor is fast, clean and powerful WordPress theme.

Theme URL -
Author URL - http://www.prelc.si

Trac Browser - https://themes.trac.wordpress.org/browser/speculor/1.1.1

SVN - https://themes.svn.wordpress.org/speculor/1.1.1
ZIP - https://wordpress.org/themes/download/speculor.1.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=speculor/1.1.0&new_path=speculor/1.1.1

History:

Ticket Summary Status Resolution Owner
#37258 THEME: Speculor – 1.1.5 closed live rabmalin

(this ticket)

#41365 THEME: Speculor – 1.2.0 closed live themetracbot


https://themes.svn.wordpress.org/speculor/1.1.1/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.

#7 @Prelc
11 months ago

Hi @rabmalin. Thanks again for the review. I fixed everything except this:

REQUIRED: Escaping missing in several places. Eg, check customizer_colors(). Check other places also.

I checked everything and everything is escaped. It was also made in the same way as my Purus theme (https://wordpress.org/themes/purus) which is already published.

Please let me know what exactly did you have in mind here.

#8 @rabmalin
11 months ago

Issues

  • REQUIRED: Have you implemented post formats? See https://make.wordpress.org/themes/handbook/review/required/theme-tags/ Support a post formats with clear visual distinction,
  • REQUIRED: Max 3 subject theme tags allowed.
  • REQUIRED: Four images used in screenshot but one URL is kep in readme.
  • REQUIRED: template-front-page-hero-image.php - Custom query should be reset.

#9 @rabmalin
11 months ago

Please respond within 7 days. If there is no response for 7 days, ticket will be closed as not-approved. Today is day 5.

#10 @Prelc
11 months ago

Hi. I am doing my best to finish everything. If I don't upload the new version in 2 days, please give more time - to the Monday.

#11 @themetracbot
11 months ago

  • Summary changed from THEME: Speculor – 1.1.1 to THEME: Speculor – 1.1.2

Speculor - 1.1.2

Speculor is fast, clean and powerful WordPress theme.

Theme URL -
Author URL - http://www.prelc.si

Trac Browser - https://themes.trac.wordpress.org/browser/speculor/1.1.2

SVN - https://themes.svn.wordpress.org/speculor/1.1.2
ZIP - https://wordpress.org/themes/download/speculor.1.1.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=speculor/1.1.1&new_path=speculor/1.1.2

History:

Ticket Summary Status Resolution Owner
#37258 THEME: Speculor – 1.1.5 closed live rabmalin

(this ticket)

#41365 THEME: Speculor – 1.2.0 closed live themetracbot


https://themes.svn.wordpress.org/speculor/1.1.2/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.

#12 @Prelc
11 months ago

Hi @rabmalin,

I fixed everything.

REQUIRED: Have you implemented post formats? See https://make.wordpress.org/themes/handbook/review/required/theme-tags/ Support a post formats with clear visual distinction,

I don't have support for post formats and I didn't put the tag post-formats in my theme. I also didn't find anywhere that post formats are required for the submit.

REQUIRED: template-front-page-hero-image.php - Custom query should be reset.

I found that this reset https://codex.wordpress.org/Function_Reference/wp_reset_query is not suitable for WP_query so I reset with this function https://codex.wordpress.org/wp_reset_postdata.

Have a nice day!

#13 @themetracbot
11 months ago

  • Summary changed from THEME: Speculor – 1.1.2 to THEME: Speculor – 1.1.3

Speculor - 1.1.3

Speculor is fast, clean and powerful WordPress theme.

Theme URL -
Author URL - http://www.prelc.si

Trac Browser - https://themes.trac.wordpress.org/browser/speculor/1.1.3

SVN - https://themes.svn.wordpress.org/speculor/1.1.3
ZIP - https://wordpress.org/themes/download/speculor.1.1.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=speculor/1.1.2&new_path=speculor/1.1.3

History:

Ticket Summary Status Resolution Owner
#37258 THEME: Speculor – 1.1.5 closed live rabmalin

(this ticket)

#41365 THEME: Speculor – 1.2.0 closed live themetracbot


https://themes.svn.wordpress.org/speculor/1.1.3/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.

#14 @Prelc
11 months ago

Hi @rabmalin,

I forgot to remove sass files in v1.1.2. Only change in v1.1.3 is that I removed this files.

Take care!

#15 @rabmalin
11 months ago

Other looks good. Please check following few issues.

Issues

  • REQUIRED: content-search.php - the_excerpt() does not take any parameters. https://developer.wordpress.org/reference/functions/the_excerpt/
  • REQUIRED: template-front-page-hero-image.php L14 - Escape value of height and width.
  • REQUIRED: get_post_format() function call as theme does not support Post Format. [Yes, it is not required to post format.]

Theme Check Sniff Issues

Note: Errors need to be fixed and Warnings are things that need to be checked manually.

FILE: /var/www/review.dev/public_html/wp-content/themes/speculor/footer.php
--------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------
 16 | ERROR | [x] Multiple placeholders should be ordered. Expected '%1$s, %2$s', but got %s, %s.
--------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------
FILE: /var/www/review.dev/public_html/wp-content/themes/speculor/inc/theme-customizer.php
---------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------
 299 | ERROR | [x] Multiple placeholders should be ordered. Expected '%1$s, %2$s', but got %s, %s.
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------
FILE: /var/www/review.dev/public_html/wp-content/themes/speculor/single.php
--------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
 51 | ERROR | Missing singular placeholder, needed for some languages. See
    |       | https://codex.wordpress.org/I18n_for_WordPress_Developers#Plurals
--------------------------------------------------------------------------------------------------------------
FILE: /var/www/review.dev/public_html/wp-content/themes/speculor/page.php
--------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
 36 | ERROR | Missing singular placeholder, needed for some languages. See
    |       | https://codex.wordpress.org/I18n_for_WordPress_Developers#Plurals
--------------------------------------------------------------------------------------------------------------

#16 @Prelc
11 months ago

Hi @rabmalin. I would like to ask again for a little bit more time. At least to the Monday.

#17 @themetracbot
11 months ago

  • Summary changed from THEME: Speculor – 1.1.3 to THEME: Speculor – 1.1.4

Speculor - 1.1.4

Speculor is fast, clean and powerful WordPress theme.

Theme URL -
Author URL - http://www.prelc.si

Trac Browser - https://themes.trac.wordpress.org/browser/speculor/1.1.4

SVN - https://themes.svn.wordpress.org/speculor/1.1.4
ZIP - https://wordpress.org/themes/download/speculor.1.1.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=speculor/1.1.3&new_path=speculor/1.1.4

History:

Ticket Summary Status Resolution Owner
#37258 THEME: Speculor – 1.1.5 closed live rabmalin

(this ticket)

#41365 THEME: Speculor – 1.2.0 closed live themetracbot


https://themes.svn.wordpress.org/speculor/1.1.4/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.
  • WARNING: Found a translation function that is missing a text-domain. Function esc_attr_e, with the arguments '

#18 @rabmalin
10 months ago

Issues

  • REQUIRED: Found a translation function that is missing a text-domain. Function esc_attr_e, with the arguments. Check template-front-page-hero-image.php. Why are you using translating function here? Use escaping function.

#19 @rabmalin
10 months ago

@Prelc Please fix above issue and re-upload your theme. Ticket will be closed if no response for 7 days. Today is day 4.

#20 @themetracbot
10 months ago

  • Summary changed from THEME: Speculor – 1.1.4 to THEME: Speculor – 1.1.5

Speculor - 1.1.5

Speculor is fast, clean and powerful WordPress theme.

Theme URL -
Author URL - http://www.prelc.si

Trac Browser - https://themes.trac.wordpress.org/browser/speculor/1.1.5

SVN - https://themes.svn.wordpress.org/speculor/1.1.5
ZIP - https://wordpress.org/themes/download/speculor.1.1.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=speculor/1.1.4&new_path=speculor/1.1.5

History:

Ticket Summary Status Resolution Owner
#37258 THEME: Speculor – 1.1.5 closed live rabmalin

(this ticket)

#41365 THEME: Speculor – 1.2.0 closed live themetracbot


https://themes.svn.wordpress.org/speculor/1.1.5/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.

#21 @rabmalin
10 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Looks good. Approving and setting live. It will take around 1 hour for theme to appear in the directory. Good luck!

#22 @rabmalin
10 months ago

Hello @Prelc

Sorry for not catching this issue earlier (Someone just DMed me about the issue). In footer, one credit is allowed, but it should be either Theme URL or Author URL. Please keep same URL you kept in style.css. Please fix this issue and re-upload your theme.

Thanks

#23 @Prelc
10 months ago

Hi @rabmalin,

Don't worry. I will fix that issue in the next update. I didn't catch that rule before.

Thanks again for all the reviews you did on my theme.

Have a nice day!

Note: See TracTickets for help on using tickets.