WordPress.org

Make WordPress Themes

#37354 closed theme (not-approved)

THEME: Storefront Child Theme – 1.0.0

Reported by: 1sarthak2 Owned by: poena
Priority: new theme Keywords: theme-storefront-child-theme child-theme parent-storefront accessibility-ready
Cc: 1sarthak2@…

Change History (2)

#1 @poena
11 months ago

  • Keywords changed from theme-storefront-child-theme, child-theme, parent-storefront, accessibility-ready to theme-storefront-child-theme child-theme parent-storefront accessibility-ready
  • Owner set to poena
  • Status changed from new to reviewing

#2 @poena
11 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hi!
You need to rename your theme, since using the word "theme" in the name is not allowed.

Before uploading the theme with the new name, make sure that it follows the guidelines:
https://make.wordpress.org/themes/handbook/review/required/

This is not a complete review, -your new theme will be fully reviewed when it reaches the top of the review queue, but here are some things that you will need to fix:

The theme won't load because there are php errors in your code.

Parse error: syntax error, unexpected '/' in themes\storefront-child-theme\functions.php on line 68

function 'storefront_header_cart' not found or invalid function name.

You must test your theme carefully.
The theme must work without plugins installed, and you can't require plugins, only recommend them.
(Before using plugin functions, you need to check if the plugin is actually activated. You can do this by checking if the plugin class or function exists.)

License and attribution
You need to update the author info and links,
Add attribution to the theme that you have used as your base.
In addition to attributing the original theme author, you need to include copyright information for the theme itself, and copyright and license information for all assets. This includes images used in screenshots.

Language
Child themes should use their own text domain, so you need to replace it where you are using the 'storefront' text-domain. One extra text domain is allowed when frameworks are used, but you have two:
woocommerce and wcvendors -you will need to replace one.

Provide a unique prefix for everything the Theme defines in the public namespace, including options, functions, global variables, constants, post meta, etc.
For example "custom_storefront_credit" is not prefixed. I recommend that you use your new theme slug as a prefix.

Themes are not allowed to change the admin footer text, so you need to remove the "my_footer_text" and filter in functions.php.

You also need to update your theme tags:
WARNING: The tag white has been deprecated, please remove it from your style.css header.
WARNING: The tag responsive-layout has been deprecated, please remove it from your style.css header.
WARNING: The tag light has been deprecated, please remove it from your style.css header.
WARNING: The tag black has been deprecated, please remove it from your style.css header.

Note: See TracTickets for help on using tickets.