WordPress.org

Make WordPress Themes

Opened 13 months ago

Closed 13 months ago

Last modified 13 months ago

#37481 closed theme (live)

THEME: Lana – 1.0.6

Reported by: jerryscg Owned by: kevinhaig
Priority: previously reviewed Keywords: theme-lana
Cc: kdonet@…

Description

Lana - 1.0.5

Multi-Purpose, Responsive WordPress theme.

Theme URL - http://www.theme-vision.com/lana/
Author URL - http://www.theme-vision.com

SVN - https://themes.svn.wordpress.org/lana/1.0.5
ZIP - https://wordpress.org/themes/download/lana.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=lana/1.0.4&new_path=lana/1.0.5

History:

Ticket Summary Status Resolution Owner
#29899 THEME: Lana – 1.0.0 closed closed-newer-version-uploaded clarionwpdeveloper
#34358 THEME: Lana – 1.0.3 closed not-approved joedolson
#37247 THEME: Lana – 1.0.4 closed closed-newer-version-uploaded kevinhaig
#37481 THEME: Lana – 1.0.6 closed live kevinhaig

(this ticket)

#37528 THEME: Lana – 1.0.7 closed live themetracbot
#38124 THEME: Lana Blog – 1.0.0 closed not-approved poena
#38219 THEME: Lana Blog – 1.0.5 closed live acosmin
#39080 THEME: Lana – 1.0.8 closed live themetracbot
#39983 THEME: Lana – 1.0.9 closed live themetracbot
#41397 THEME: Lana Blog – 1.0.6 closed live themetracbot
#42035 THEME: Lana Blog – 1.0.7 closed live themetracbot
#42039 THEME: Lana Blog – 1.0.8 closed live themetracbot
#42153 THEME: Lana Site – 1.0.9 closed live shrimp2t
#42709 THEME: Lana Blog – 1.0.9 closed live themetracbot
#44316 THEME: Lana Blog – 1.1.0 closed live themetracbot
#46257 THEME: Lana Blog – 1.1.1 closed live themetracbot
#46258 THEME: Lana Site – 1.1.0 closed live themetracbot
#47016 THEME: Lana Blog – 1.1.2 closed live themetracbot


https://themes.svn.wordpress.org/lana/1.0.5/screenshot.png

Change History (9)

#1 @kevinhaig
13 months ago

  • Owner set to kevinhaig
  • Status changed from new to reviewing

#2 @kevinhaig
13 months ago

Theme Review - Lana Version 1.0.5

  • Below is the review of the latest update of your theme.

Responding to the Review

  • Please respond with update or request an extension within 7 days, or theme may be closed.

Required Items

Code

All untrusted data should be escaped before output.
  • Check and fix escaping problem. , file: lana\framework\lana-functions.php, line: 259
    • use WordPress functions for escaping if there is one. In this case use esc_html().
  • Check and fix escaping problem. , file: lana\framework\lana-post-slider.php, line: 11
  • Translations in attributes must be properly escaped. Use esc_attr() or esc_attr_e() , file: lana\framework\lana-post-slider.php, line: 31
Provide a unique prefix for everything the Theme defines in the public namespace, including options, functions, global variables, constants, post meta, etc.
  • This function name should be prefixed. Please use lana. , file: lana\framework\lana-woocommerce.php, line: 65

Core Functionality and Features

The theme tags in style.css and description must match the what the theme actually does in respect to functionality and design.
  • No subject tags were found. Please select no more then 3 subject tags that reflect your theme. , file: lana\style.css, line: 10

Stylesheets and Scripts

  • you are enqueue'ing bootstrap styles twice

#3 @themetracbot
13 months ago

  • Summary changed from THEME: Lana – 1.0.5 to THEME: Lana – 1.0.6

Lana - 1.0.6

Multi-Purpose, Responsive WordPress theme.

Theme URL - http://www.theme-vision.com/lana/
Author URL - http://www.theme-vision.com

SVN - https://themes.svn.wordpress.org/lana/1.0.6
ZIP - https://wordpress.org/themes/download/lana.1.0.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=lana/1.0.5&new_path=lana/1.0.6

History:

Ticket Summary Status Resolution Owner
#29899 THEME: Lana – 1.0.0 closed closed-newer-version-uploaded clarionwpdeveloper
#34358 THEME: Lana – 1.0.3 closed not-approved joedolson
#37247 THEME: Lana – 1.0.4 closed closed-newer-version-uploaded kevinhaig
#37481 THEME: Lana – 1.0.6 closed live kevinhaig

(this ticket)

#37528 THEME: Lana – 1.0.7 closed live themetracbot
#38124 THEME: Lana Blog – 1.0.0 closed not-approved poena
#38219 THEME: Lana Blog – 1.0.5 closed live acosmin
#39080 THEME: Lana – 1.0.8 closed live themetracbot
#39983 THEME: Lana – 1.0.9 closed live themetracbot
#41397 THEME: Lana Blog – 1.0.6 closed live themetracbot
#42035 THEME: Lana Blog – 1.0.7 closed live themetracbot
#42039 THEME: Lana Blog – 1.0.8 closed live themetracbot
#42153 THEME: Lana Site – 1.0.9 closed live shrimp2t
#42709 THEME: Lana Blog – 1.0.9 closed live themetracbot
#44316 THEME: Lana Blog – 1.1.0 closed live themetracbot
#46257 THEME: Lana Blog – 1.1.1 closed live themetracbot
#46258 THEME: Lana Site – 1.1.0 closed live themetracbot
#47016 THEME: Lana Blog – 1.1.2 closed live themetracbot


https://themes.svn.wordpress.org/lana/1.0.6/screenshot.png

#4 @jerryscg
13 months ago

Anyone ?

#5 @kevinhaig
13 months ago

anyone what?

#6 @kevinhaig
13 months ago

There are 800 themes in the queue, yours is just one of them.

#7 @jerryscg
13 months ago

Well this theme is almost approved, basically you need to confirm i did fixes you requested and now you will leave me to wait another month... well after being 10 months in queue i guess i'm on the end from those 800 you stated.

Last edited 13 months ago by jerryscg (previous) (diff)

#8 @kevinhaig
13 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

@jerryscg

We are all volunteers here. Yesterday I was busy reviewing an additional two themes, and I did not want to stop.

I would also note that the initial review could have been closed as there were way more than the 5 distinct issues. But because you have waited so long I chose not to do that.

I spend much of my time trying to help here and I don't feel your impatience and snide comments are deserved.

Turn your negative attitude into something positive, and help review themes. You will become a better themer and will help reduce the queue that you so nicely commented on.

Approved and set live.

#9 @jerryscg
13 months ago

Thanks @kevinhaig,

Sorry for my negative attitude.

I will definitely take in consideration your suggestion about helping reviewing themes.

Regards

Note: See TracTickets for help on using tickets.