WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

#3777 closed theme (not-approved)

THEME: warm-home - 1.0

Reported by: wpart Owned by: pseudoxiah
Priority: Keywords: theme-warm-home
Cc: nyw@…

Description

warm-home - 1.0

The Wordpress templates "Warm Home",with the tone of light and breezy ,elegant and full of life.It is divided into three columns:

Theme URL - http://www.wpart.org/wordpress-themes-warm-home-4/
Author URL - http://www.wpart.org

SVN - http://themes.svn.wordpress.org/warm-home/1.0
ZIP - http://wordpress.org/extend/themes/download/warm-home.1.0.zip?nostats=1

All previous tickets for this theme: http://themes.trac.wordpress.org/query?keywords=~theme-warm-home

https://themes.svn.wordpress.org/warm-home/1.0/screenshot.png

Change History (2)

comment:1 pseudoxiah3 years ago

  • Owner set to pseudoxiah
  • Status changed from new to accepted

comment:2 pseudoxiah3 years ago

  • Resolution set to not-approved
  • Status changed from accepted to closed

Theme Review:

  • Themes should be reviewed using "define('WP_DEBUG', true);" in wp-config.php
  • Themes should be reviewed using the test data from the Theme Checklists (TC)

Theme Check

  • REQUIRED: The theme uses include to display the sidebar. Use get_sidebar(); instead.

single.php

Line 53: <?php include ('sidebar.php'); ?>

search.php

Line 62: <?php include ('sidebar.php'); ?>

page.php

Line 34: <?php include ('sidebar.php'); ?>

index.php

Line 61: <?php include ('sidebar.php'); ?>

archive.php

Line 63: <?php include ('sidebar.php'); ?>

404.php

Line 32: <?php include ('sidebar.php'); ?>
  • REQUIRED: bloginfo(template_url) was found in the file sidebar.php. Use get_template_directory_uri() instead.
  • REQUIRED: bloginfo(template_url) was found in the file functions.php. Use get_template_directory_uri() instead.
  • REQUIRED: Non-printable characters were found in the functions.php file. You may want to check this file for errors.
    Line 139: User-Defined Picture Address 01: <input name='image1'  type='text'   value='<?php echo get_option('image
    
Line 141: User-Defined Picture Address 02: <input name='image2'  type='text'   value='<?php echo get_option('image
  • RECOMMENDED: Text domain problems in single.php. You have not included a text domain!
    Line 13: <?php _e('Filed under&#58');?>
    
  • RECOMMENDED: Text domain problems in sidebar.php. You have not included a text domain!
    Line 10: <?php _e('categories');?>
    
  • RECOMMENDED: Text domain problems in search.php. You have not included a text domain!
    Line 23: <?php _e('Posted in&#58');?>
    
  • RECOMMENDED: Text domain problems in page.php. You have not included a text domain!
    Line 24: <?php _e('Not Found');?>
    
  • RECOMMENDED: Text domain problems in index.php. You have not included a text domain!
    Line 23: <?php _e('Posted in&#58');?>
    
  • RECOMMENDED: Text domain problems in header.php. You have not included a text domain!
    Line 36: <?php _e('home');?>
    
  • RECOMMENDED: Text domain problems in archive.php. You have not included a text domain!
    Line 23: <?php _e('Posted in&#58');?>
    
  • RECOMMENDED: Screenshot is wrong size! Detected: 300x250px. Maximum allowed size is 320x240px.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
  • RECOMMENDED: No reference to add_custom_image_header was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

Debogger
-- Debug: Undefined variable: wordscut on line 168 of /wp-content/themes/warm-home/functions.php
-- Debug: Undefined variable: j on line 169 of /wp-content/themes/warm-home/functions.php
-- Debug: Undefined variable: wordscut on line 168 of /wp-content/themes/warm-home/functions.php
-- Debug: Undefined variable: j on line 169 of /wp-content/themes/warm-home/functions.php
-- Debug: Undefined variable: wordscut on line 168 of /wp-content/themes/warm-home/functions.php
-- Debug: Undefined variable: j on line 169 of /wp-content/themes/warm-home/functions.php
-- Debug: Undefined variable: wordscut on line 168 of /wp-content/themes/warm-home/functions.php
-- Debug: Undefined variable: j on line 169 of /wp-content/themes/warm-home/functions.php
-- Debug: Undefined variable: wordscut on line 168 of /wp-content/themes/warm-home/functions.php
-- Debug: Undefined variable: j on line 169 of /wp-content/themes/warm-home/functions.php
-- Debug: Undefined variable: wordscut on line 168 of /wp-content/themes/warm-home/functions.php
-- Debug: Undefined variable: j on line 169 of /wp-content/themes/warm-home/functions.php
-- Debug: Undefined variable: wordscut on line 168 of /wp-content/themes/warm-home/functions.php
-- Debug: Undefined variable: j on line 169 of /wp-content/themes/warm-home/functions.php
-- Debug: Undefined variable: wordscut on line 168 of /wp-content/themes/warm-home/functions.php
-- Debug: Undefined variable: j on line 169 of /wp-content/themes/warm-home/functions.php
-- Debug: Undefined variable: wordscut on line 168 of /wp-content/themes/warm-home/functions.php
-- Debug: Undefined variable: j on line 169 of /wp-content/themes/warm-home/functions.php
-- Debug: Undefined variable: wordscut on line 168 of /wp-content/themes/warm-home/functions.php
-- Debug: Undefined variable: j on line 169 of /wp-content/themes/warm-home/functions.php


Test Data
=> Sticky posts are not styled
=> The theme strips out spaces from the content on the home page. Is this intentional?
=> Image alignment is not set. Please set the following styles:

.aligncenter {
	display:block;
	margin:15px auto;
}

.alignleft {
	float:left;
	margin:15px;
	margin-left:0;
}

.alignright {
	float:right;
	margin:15px;
	margin-right:0;
}

Just examples, they can of course be adapted.
=> Image with caption is not styled
=> Wide image overlaps with sidebar
=> Embedded videos overlap sidebar. Please set the content_width variable
=> Page with comments does not show comments
-> Comments appear not to be styled.


General Observations:
=> The theme registers some custom functionality in the function warmHome_setup() however this function in not hooked so the functionality is not available. Recommend hooking the theme to the after_setup_theme hook.
=> Several declared functions are not properly hooked and some are never called. Please declare and hook all functionality in functions.php as other locations may be inappropiate


Overall: not-approved

  • Additional review may be required once the above issues are resolved.


Again, this is not a complete review. The Theme may have other issues that do
not meet the Theme Review Guidelines.
This theme failed a large amount of criteria. Please make sure you thoroughly read the documentation below on how to improve the theme's quality and functionality:


Once the points above have been addressed appropriately using the available
information found at the links above; please thoroughly review your theme and
re-submit it using the uploader tool: http://wordpress.org/extend/themes/upload/
... this will generate a new Trac ticket.

NB: Re-submitted Themes are given review priority over new Themes that have not
been reviewed yet.

Also note, to preserve your queue position if you upload a new revision to the
theme before the current Trac ticket has been resolved:

  1. Note the "new" ticket number of the revision.
  2. Go to the oldest *open* ticket for your theme.
  3. Add a comment to the *open* ticket with a link to the "new" ticket.
  4. The next review should take this into consideration.


Feel free to make use of the contact details below if you have any questions,
comments, or feedback:

  • Leave a comment on this ticket
  • Send an email to the Theme Review email list
  • Use the #wordpress-themes IRC channel on Freenode

Test Environment:
WordPress Theme Reviews by pross

  • WordPress Version: 3.1.2
  • PHP version: 5.2.13
  • Multisite Enabled: No
  • Current User Role: administrator
Note: See TracTickets for help on using tickets.