WordPress.org

Make WordPress Themes

Opened 13 months ago

Closed 10 months ago

Last modified 10 months ago

#37982 closed theme (live)

THEME: Pinfolio – 1.0.5

Reported by: desirepress Owned by: bplv
Priority: previously reviewed Keywords: theme-pinfolio
Cc: desirepress.com@…

Description

Pinfolio - 1.0.1

Pinfolio theme offers a functional framework for people, groups or entities who would like to show off their artwork, photography, portfolio or anything visual that they want to display or promote online.

Theme URL - http://preview.desirepress.com/wp/pinfolio
Author URL - http://desirepress.com

SVN - https://themes.svn.wordpress.org/pinfolio/1.0.1
ZIP - https://wordpress.org/themes/download/pinfolio.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=pinfolio/1.0.0&new_path=pinfolio/1.0.1

History:

Ticket Summary Status Resolution Owner
#34068 THEME: Pinfolio – 1.0.0 closed closed-newer-version-uploaded bplv
#37982 THEME: Pinfolio – 1.0.5 closed live bplv

(this ticket)


https://themes.svn.wordpress.org/pinfolio/1.0.1/screenshot.png

Attachments (1)

pinfolio.zip (776.5 KB) - added by desirepress 10 months ago.
Pinfolio 1.0.2

Download all attachments as: .zip

Change History (34)

#1 @poena
11 months ago

  • Owner set to bplv
  • Status changed from new to reviewing

#2 @desirepress
10 months ago

Hello,

We would like to know is there any update on this ticket's review.

Please let us know.

Thanks,
DesirePress

#3 @bplv
10 months ago

Hello @desirepress ,

Currently I am reviewing your theme, I will be posting potential issues today or tomorrow ( if any ) before the theme is approved from my side.

Sit tight. :)

Regards.

#4 @bplv
10 months ago

Please check following issues.

Issues

  • REQUIRED: Several strings are not translatable. Use https://wordpress.org/plugins-wp/piglatin/ this plugin to check.
  • REQUIRED: Provide a unique prefix for everything the Theme defines in the public namespace, including options, functions, global variables, constants, post meta, image sizes, etc. http://themereview.co/prefix-all-the-things/
  • REQUIRED: home_url() should be escaped with esc_url() function.
  • REQUIRED: Escaping missing header.php line 30. Check other also. All untrusted data should be escaped properly before displaying. https://codex.wordpress.org/Data_Validation
  • REQUIRED: Use the_archive_title() to display archive title. Please check all archive templates.
  • REQUIRED: Static value of HTML attributes like alt, placeholder, etc should be translatable and escaped. If value comes dynamically, only escaping is needed. Check all your files.
  • REQUIRED: Unminified versions of files also needed in minified is used. Please keep both version files in the theme.
  • REQUIRED: Remove core settings like this is not allowed. $wp_customize->remove_control( 'header_textcolor' );
  • REQUIRED: Use Custom Logo for logo. https://make.wordpress.org/core/2016/03/10/custom-logo/
  • REQUIRED: Remove WP_Customize_Textarea_Control custom control from theme. Textarea is already available in WordPress.
  • RECOMMENDED: Do not prefix third party script and style handle. Follow this https://make.wordpress.org/themes/2016/10/04/october-4th-team-meeting-notes/
  • REQUIRED: Remove add_filter('widget_text', 'do_shortcode');. This is plugin territory.

Please repond within 7 days to avoid closing of ticket.

#5 @desirepress
10 months ago

Hello @bplv,

Thanks for your reviews.

I have added new updated theme file 1.0.2 in attachment, please take a look and us know.

Thanks,
DesirePress

Last edited 10 months ago by desirepress (previous) (diff)

@desirepress
10 months ago

Pinfolio 1.0.2

#6 @bplv
10 months ago

Hello @desirepress ,

Please upload your theme like you did at first but change the version number in style.css

Attachment will not be reviewed.
Regards.

#7 @themetracbot
10 months ago

  • Summary changed from THEME: Pinfolio – 1.0.1 to THEME: Pinfolio – 1.0.2

Pinfolio - 1.0.2

Pinfolio theme offers a functional framework for people, groups or entities who would like to show off their artwork, photography, portfolio or anything visual that they want to display or promote online.

Theme URL - http://preview.desirepress.com/wp/pinfolio
Author URL - http://desirepress.com

SVN - https://themes.svn.wordpress.org/pinfolio/1.0.2
ZIP - https://wordpress.org/themes/download/pinfolio.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=pinfolio/1.0.1&new_path=pinfolio/1.0.2

History:

Ticket Summary Status Resolution Owner
#34068 THEME: Pinfolio – 1.0.0 closed closed-newer-version-uploaded bplv
#37982 THEME: Pinfolio – 1.0.5 closed live bplv

(this ticket)


https://themes.svn.wordpress.org/pinfolio/1.0.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

#8 @desirepress
10 months ago

Hello @bplv,

Thanks for letting us know.

We have uploaded theme updated version 1.0.2.

Please take a look and let us know.

Thanks,
DesirePress

#9 @bplv
10 months ago

Hello @desirepress ,

There are some more issues that needs to be fixed, please fix them and upload an updated version.

  • Core-functions.php usage of global $options; found. Have you saved any option named "blog_excerpt_length" through your theme? If you have you must prefix it. Recommend: You can use customizer api and save it on theme_mod insetad of saving the value on options table.
  • if ( 'page' == get_option( 'show_on_front' ) && ( '' != get_option( 'page_for_posts' ) ) && is_front_page() ) this can be simple re-written as if ( is_front_page() && !is_home() )
  • You do not need to enqueue jquery, just pass it on the dependency parameter.
  • You do not need to prefix third party css and js.
  • Enqueue dependency should be passed in an array. eg: array('jQuery').
  • You are not allowed to remove default controls eg: $wp_customize->remove_control( 'header_image' );
  • Escaping missing on content.php line 16,
  • Translation functions used but no translatable content found. Check other files too. Most of the files have this issue
    • content.php line 26, 27 28,29
    • customizer.php Line: 11, Line: 132, Line: 149, Line: 166, Line: 183, Line: 200, Line: 217, Line: 234, Line: 251, Line: 282, Line: 301


  • Font awesome has two license, please include both.
  • You do not need to provide the license of the fonts that are not bundled with the theme.
  • License declaration missing for hoverIntent
  • There are two images being used on the screenshot. There is one on the background too. But no license has been provided for that image.
  • get_theme_mod() has second param as "" please either use a boolen as the second param or just use get_theme_mod('fbicon')
  • Escaping missing on header.php line 98 on title attribute.
  • Prefixing missing on add_image_size() function's handler.
  • Custom logo used but tag not found on style.css

#10 @desirepress
10 months ago

Hello @bplv,

Thanks for your valuable review.

Can you please let us know more about last point.. as we are not getting it properly.

Custom logo used but tag not found on style.css

Thanks,
DesirePress

#11 @bplv
10 months ago

Hello @desirepress ,

If you theme supports custom-logo add it on your style.css ( tags section ).

https://make.wordpress.org/themes/handbook/review/required/theme-tags/

Hope you understood.

Regards.

#12 @themetracbot
10 months ago

  • Summary changed from THEME: Pinfolio – 1.0.2 to THEME: Pinfolio – 1.0.3

Pinfolio - 1.0.3

Pinfolio theme offers a functional framework for people, groups or entities who would like to show off their artwork, photography, portfolio or anything visual that they want to display or promote online.

Theme URL - http://preview.desirepress.com/wp/pinfolio
Author URL - http://desirepress.com

Trac Browser - https://themes.trac.wordpress.org/browser/pinfolio/1.0.3

SVN - https://themes.svn.wordpress.org/pinfolio/1.0.3
ZIP - https://wordpress.org/themes/download/pinfolio.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=pinfolio/1.0.2&new_path=pinfolio/1.0.3

History:

Ticket Summary Status Resolution Owner
#34068 THEME: Pinfolio – 1.0.0 closed closed-newer-version-uploaded bplv
#37982 THEME: Pinfolio – 1.0.5 closed live bplv

(this ticket)


https://themes.svn.wordpress.org/pinfolio/1.0.3/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

#13 @desirepress
10 months ago

Hello @bplv,

Thanks for your help.

We have fixed all issues and uploaded new version.

Please take a look and let us know.

Thanks,
DesirePress

#14 @bplv
10 months ago

Hello,
Please fix the following issues also

  • REQUIRED: add_editor_style(); is called but there is no admin CSS file. See https://developer.wordpress.org/reference/functions/add_editor_style/
  • REQUIRED: single.php line 40 - Use user's date set in the system rather than custom date format. Eg the_time( get_option( 'date_format' ) ). Check content.php also.
  • REQUIRED: Theme URI is invalid. https://make.wordpress.org/themes/handbook/review/recommended/selling-themes-and-links/
  • REQUIRED: Author URI is pointing to site which shows Coming Soon. Either fix URL or remove it.
  • REQUIRED: It seems admin folder is not is use. Remove those if not needed.
  • REQUIRED: init.php - Use get_template_directory() for path.
  • REQUIRED: Google font style handle should be prefixed.
  • REQUIRED: Remove images folder if not needed.
  • REQUIRED: Remove languages folder if not needed.
  • REQUIRED: customizer.php - Use esc_url_raw to sanitize URL.
  • REQUIRED: pinfolio_sanitize_text() - For simple text field, use sanitize_text_field for sanitization.
  • REQUIRED: content.php - Change alt="<?php the_title(); ?>" to alt="<?php the_title_attribute(); ?>". Similar for title attribute also. When you want to echo in normal context the_title() is used but in attribute context the_title_attribute() should be used.

#15 @themetracbot
10 months ago

  • Summary changed from THEME: Pinfolio – 1.0.3 to THEME: Pinfolio – 1.0.4

Pinfolio - 1.0.4

Pinfolio theme offers a functional framework for people, groups or entities who would like to show off their artwork, photography, portfolio or anything visual that they want to display or promote online.

Theme URL - http://desirepress.com/themes/pinfolio
Author URL - http://desirepress.com

Trac Browser - https://themes.trac.wordpress.org/browser/pinfolio/1.0.4

SVN - https://themes.svn.wordpress.org/pinfolio/1.0.4
ZIP - https://wordpress.org/themes/download/pinfolio.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=pinfolio/1.0.3&new_path=pinfolio/1.0.4

History:

Ticket Summary Status Resolution Owner
#34068 THEME: Pinfolio – 1.0.0 closed closed-newer-version-uploaded bplv
#37982 THEME: Pinfolio – 1.0.5 closed live bplv

(this ticket)


https://themes.svn.wordpress.org/pinfolio/1.0.4/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

#16 @desirepress
10 months ago

Hello @bplv,

Thanks for your review.

We have fixed all issues and uploaded new version 1.0.4.

Please take a look and let us know.

Thanks,
DesirePress

#17 @bplv
10 months ago

  • Status changed from reviewing to approved

Hello @desirepress ,

It looks good. Thank your for your patience.

@poena I am approving the theme, please let me know if there is anything else.

Regards.

#18 @desirepress
10 months ago

Hello @bplv,

Thanks a lot :)

Regards,
DesirePress

#19 @desirepress
10 months ago

Hello @poena,

Can you please provide us your review on this approved theme.

Please let us know.

Thanks,
DesirePress

#20 @rabmalin
10 months ago

@desirepress After ticket is approved by reviewer, it goes to admin queue. Only after admin approval theme goes live. Check this admin queue. https://themes.trac.wordpress.org/report/24

#21 @poena
10 months ago

@rabmalin it's OK, I asked them to ping me. The theme was first approved without a complete review and has already waited 5 weeks in this queue.

Actually it was more like 3 months o.O not 5 weeks...

Last edited 10 months ago by poena (previous) (diff)

#22 @desirepress
10 months ago

Hello @poena,

Thank you.

Can you please let us know how much time it will take to go our theme under admin approval review (Actually, we have submitted our theme around 8 months ago and still we are waiting).

Thanks,
DesirePress

Last edited 10 months ago by desirepress (previous) (diff)

#23 @poena
10 months ago

Hi
I'm sick with the flu so I need more time.

#24 @desirepress
10 months ago

Hello @poena,

I'm really sorry..

I hope you feel better soon... :)

Thanks,
DesirePress

#25 @poena
10 months ago

  • Status changed from approved to reopened

#26 @poena
10 months ago

  • Owner changed from bplv to poena
  • Status changed from reopened to reviewing

Just reassigning it to me so that I don't forget :)

#27 @desirepress
10 months ago

Hello @poena

Okay Thanks :)

Regards,
DesirePress

#28 @poena
10 months ago

Hi
Yes, when I said that theme had waited in the queue for 3 months I meant the "Theme Admin: Approved Themes Not Yet Live" queue :)

The theme is almost ready to go live, there are some problems that needs to be fixed first:

Required
When the menu is opened it covers the WordPress admin bar when I am logged in.
At about 780 pixels width, the menu icon also overlaps the WordPress admin bar. If I reduce the windows size even further, the admin bar is pushed down from the top of the browser window.

The license information for the images in the screenshot is still missing.

The theme needs to respect the users settings.
In content.php -Don't add an alt text for featured images:
-You are overwriting the users setting, whether the original alt text is empty or not.
-The post title might not describe the image.
https://www.w3.org/QA/Tips/altAttribute

Notes:
Notes are not required to pass the review
In wp-enqueue.php, if (!is_admin()) is not necesarry, neither of these loads files in the admin area.


Please reply within 7 days or the ticket may be closed for inactivity.


@bplv great review, thank you.

#29 @themetracbot
10 months ago

  • Summary changed from THEME: Pinfolio – 1.0.4 to THEME: Pinfolio – 1.0.5

Pinfolio - 1.0.5

Pinfolio theme offers a functional framework for people, groups or entities who would like to show off their artwork, photography, portfolio or anything visual that they want to display or promote online.

Theme URL - http://desirepress.com/themes/pinfolio
Author URL - http://desirepress.com

Trac Browser - https://themes.trac.wordpress.org/browser/pinfolio/1.0.5

SVN - https://themes.svn.wordpress.org/pinfolio/1.0.5
ZIP - https://wordpress.org/themes/download/pinfolio.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=pinfolio/1.0.4&new_path=pinfolio/1.0.5

History:

Ticket Summary Status Resolution Owner
#34068 THEME: Pinfolio – 1.0.0 closed closed-newer-version-uploaded bplv
#37982 THEME: Pinfolio – 1.0.5 closed live bplv

(this ticket)


https://themes.svn.wordpress.org/pinfolio/1.0.5/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

#30 @desirepress
10 months ago

Hello @poena,

Thanks for your review.

We have fixed all issues and uploaded new version 1.0.5.

For theme screenshot image, we have used only one image "Flower Pot" and we have added license information regarding this in readme.txt file.

Please take a look and let us know.

Thanks,
DesirePress

#31 @poena
10 months ago

  • Owner changed from poena to bplv

#32 @poena
10 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Hi
Thank you for fixing these problems, your theme should be live shortly.

#33 @desirepress
10 months ago

Hello @poena,

Thanks a lot :)

Regards,
DesirePress

Note: See TracTickets for help on using tickets.