WordPress.org

Make WordPress Themes

Opened 11 months ago

Closed 5 months ago

#37985 closed theme (not-approved)

THEME: Riemann – 1.0.3

Reported by: NomNom99 Owned by: nikeo
Priority: previously reviewed Keywords: theme-riemann
Cc: Sidmetal98@…

Description

Attachments (2)

37985.diff (1.5 KB) - added by NomNom99 8 months ago.
Fix for issue 1 pointed out by @nikeo
riemann.zip (146.7 KB) - added by NomNom99 8 months ago.
Removed the irrelevant Readme.md file

Download all attachments as: .zip

Change History (22)

#1 @themetracbot
8 months ago

  • Owner set to aries_larry
  • Status changed from new to reviewing

#2 @djrmom
8 months ago

  • Owner aries_larry deleted

I am sorry this review is taking so long. Sometimes people are unable to carry on the review, this may have happened this time. As a result, I am going to add this to the new queue again as a priority. This may mean it still takes time, but will prevent this ticket being held for so long by a reviewer that isn't able to carry on. Thanks for your patience.

If you are the reviewer and able to do this review, please carry on and request you get added back in Slack #themereview or you can take on another review when you have time again.

#3 @themetracbot
8 months ago

  • Owner set to nikeo

#4 @nikeo
8 months ago

Hello @NomNom99,

Everything looks overall good to me.
No php or js error. All customizer options work fine. Options are handled properly and safely with core functions.
Posts, pages and taxonomies are handled properly and accessible where to should be.

Can you please fix the following problems :

  1. Sub menu items disappear behind the main content on home (and may be other pages ? )

http://screencast-o-matic.com/watch/cbenot6TwD

  1. Hierarchical menu items are not visible because one on another
  2. It is hard to navigate in the submenu items

http://screencast-o-matic.com/watch/cbenox6TwB

Version 0, edited 8 months ago by nikeo (next)

#5 @nikeo
8 months ago

Hello @NomNom99,

don't forget to provide a feedback within the 7 days following my last reply. Otherwise the ticket might be closed and it will be back again at the end of the queue, which would really not be good.

=> the current queue is several monthes long, and we, the theme review team, had unfortunately to put in place some rules like this to make sure we can reduce the waiting queue for everyone's benefit.

Thanks for your understanding and I look forward to reading from you.

Cheers,

Last edited 8 months ago by nikeo (previous) (diff)

#6 @nikeo
8 months ago

Hello @NomNom99,

Just a reminder : please provide some activity signs before next Thursday, March 9th.

Cheers :)

#7 @NomNom99
8 months ago

Hi @nikeo Sorry I apologize for not replying sooner!
I'll fix the issue 1, and regarding issues 2 and 3, this theme was supposed to support only 1 level of submenu.

@NomNom99
8 months ago

Fix for issue 1 pointed out by @nikeo

#8 @nikeo
8 months ago

OK.
Last minor thing, your current readme.md file is not really relevant since it is a copy of the underscores one.
Let me know when you'll have uploaded the next version.
thanks

@NomNom99
8 months ago

Removed the irrelevant Readme.md file

#9 @NomNom99
8 months ago

I've uploaded the whole zip file of the theme without the README.md file. Please let me know if this is the correct way to upload changes, I've forgotten the process after such a long gap.

#10 follow-up: @djrmom
8 months ago

@NomNom99, you have to upload from https://wordpress.org/themes/upload/

#11 @themetracbot
8 months ago

  • Summary changed from THEME: Riemann – 1.0.1 to THEME: Riemann – 1.0.3

Riemann - 1.0.3

A theme for bloggers built on Underscores starter theme.

Theme URL - http://underscores.me/
Author URL - https://www.inkmyweb.com

Trac Browser - https://themes.trac.wordpress.org/browser/riemann/1.0.3

SVN - https://themes.svn.wordpress.org/riemann/1.0.3
ZIP - https://wordpress.org/themes/download/riemann.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=riemann/1.0.1&new_path=riemann/1.0.3

History:

Ticket Summary Status Resolution Owner
#37968 THEME: Riemann – 1.0.0 closed not-approved rabmalin
#37985 THEME: Riemann – 1.0.3 closed not-approved nikeo

(this ticket)


https://themes.svn.wordpress.org/riemann/1.0.3/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#12 in reply to: ↑ 10 @NomNom99
8 months ago

Thank you, I've uploaded it as advised!
Replying to djrmom:

@NomNom99, you have to upload from https://wordpress.org/themes/upload/

#13 follow-up: @nikeo
8 months ago

  • Status changed from reviewing to approved

@NomNom99 the menu looks all good now.
Approved for me. Congratulations!

Your theme will now be reviewed by a key reviewer for the final approval.
( process here : https://make.wordpress.org/themes/handbook/review/ )

#14 in reply to: ↑ 13 @NomNom99
8 months ago

Thank you! :D

Replying to nikeo:

@NomNom99 the menu looks all good now.
Approved for me. Congratulations!

Your theme will now be reviewed by a key reviewer for the final approval.
( process here : https://make.wordpress.org/themes/handbook/review/ )

#15 @rabmalin
6 months ago

  • Cc rabmalin added
  • Status changed from approved to reopened

Doing final review.

#16 @rabmalin
6 months ago

  • Status changed from reopened to reviewing

#17 follow-ups: @rabmalin
6 months ago

Hello @NomNom99

Please fix following issues and re-upload your theme.

Please respond within 7 days. If there is no response for 7 days, ticket will be closed as not-approved.

#18 in reply to: ↑ 17 @NomNom99
6 months ago

Hi @rabmalin,
Can I start working on the theme after 3 days from now? I'm kind of stuck with work!

Replying to rabmalin:

Hello @NomNom99

Please fix following issues and re-upload your theme.

Please respond within 7 days. If there is no response for 7 days, ticket will be closed as not-approved.

#19 in reply to: ↑ 17 @NomNom99
6 months ago

@rabmalin I have started working on this

#20 @rabmalin
5 months ago

  • Cc rabmalin removed
  • Resolution set to not-approved
  • Status changed from reviewing to closed

Closing due to no response for 7 days.

Note: See TracTickets for help on using tickets.