WordPress.org

Make WordPress Themes

Opened 11 months ago

Closed 8 months ago

Last modified 8 months ago

#37987 closed theme (not-approved)

THEME: Reduxbiz – 1.0.2

Reported by: pritamhans Owned by: pratikshrestha
Priority: new theme Keywords: theme-reduxbiz
Cc: pritam.hans@…

Description

Reduxbiz - 1.0.0

Reduxbiz is an elegant and responsive theme perfect for your business’s online presence. Choose a custom color, add header logo & menu for your website easily. For business home page, activate the desired sections and customize each section with your own background image & text color scheme to create stunning website home page. Add your contact info, telephone & email links on home page easily. Add testimonials, team member & services details easily. With all the features for business websites, the theme also looks great as a personal blog.

Theme URL - http://reduxthemes.com/themes/reduxbiz/
Author URL - http://reduxthemes.com/

SVN - https://themes.svn.wordpress.org/reduxbiz/1.0.0
ZIP - https://wordpress.org/themes/download/reduxbiz.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#37987 THEME: Reduxbiz – 1.0.2 closed not-approved pratikshrestha

(this ticket)

#40649 THEME: Reduxbiz – 1.0.5 closed not-approved benlumia007


https://themes.svn.wordpress.org/reduxbiz/1.0.0/screenshot.jpg

Change History (9)

#1 @themetracbot
11 months ago

  • Summary changed from THEME: Reduxbiz – 1.0.0 to THEME: Reduxbiz – 1.0.1

Reduxbiz - 1.0.1

Reduxbiz is an elegant and responsive theme perfect for your business’s online presence. Choose a custom color, add header logo & menu for your website easily. For business home page, activate the desired sections and customize each section with your own background image & text color scheme to create stunning website home page. Add your contact info, telephone & email links on home page easily. Add testimonials, team member & services details easily. With all the features for business websites, the theme also looks great as a personal blog.

Theme URL - http://reduxthemes.com/themes/reduxbiz/
Author URL - http://reduxthemes.com/

SVN - https://themes.svn.wordpress.org/reduxbiz/1.0.1
ZIP - https://wordpress.org/themes/download/reduxbiz.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=reduxbiz/1.0.0&new_path=reduxbiz/1.0.1

History:

Ticket Summary Status Resolution Owner
#37987 THEME: Reduxbiz – 1.0.2 closed not-approved pratikshrestha

(this ticket)

#40649 THEME: Reduxbiz – 1.0.5 closed not-approved benlumia007


https://themes.svn.wordpress.org/reduxbiz/1.0.1/screenshot.jpg

#2 follow-up: @poena
10 months ago

Hi
This is not a complete review

You need to reduce the amount of content creation, specifically the sections with text areas and images etc should be using existing content like post or pages.

There is already a custom css option in WordPress 4.7, so you need to remove yours.

Featured images are only displayed in the navigation, I don't know if this is intentional.

#3 @themetracbot
10 months ago

  • Summary changed from THEME: Reduxbiz – 1.0.1 to THEME: Reduxbiz – 1.0.2

Reduxbiz - 1.0.2

Reduxbiz is an elegant and responsive theme perfect for your business’s online presence. Choose a custom color, add header logo & menu for your website easily. For business home page, activate the desired sections and customize each section with your own background image & text color scheme to create stunning website home page. Add your contact info, telephone & email links on home page easily. Add testimonials, team member & services details easily. With all the features for business websites, the theme also looks great as a personal blog.

Theme URL - http://reduxthemes.com/themes/reduxbiz/
Author URL - http://reduxthemes.com/

SVN - https://themes.svn.wordpress.org/reduxbiz/1.0.2
ZIP - https://wordpress.org/themes/download/reduxbiz.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=reduxbiz/1.0.1&new_path=reduxbiz/1.0.2

History:

Ticket Summary Status Resolution Owner
#37987 THEME: Reduxbiz – 1.0.2 closed not-approved pratikshrestha

(this ticket)

#40649 THEME: Reduxbiz – 1.0.5 closed not-approved benlumia007


https://themes.svn.wordpress.org/reduxbiz/1.0.2/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.

#4 in reply to: ↑ 2 @pritamhans
10 months ago

Hi @poena Thank you for your review. As suggested, I am removing the Custom CSS option. Featured images are being displayed in blog index and also on posts, apart from being shown in previous-next post navigation. As for the content part, the idea is to have a flexible content section, allowing to add external links, etc, independent of posts or pages. So I request you to allow the same. A quick demo available at http://demo.reduxthemes.com/preview/?theme=reduxbiz

Replying to poena:

Hi
This is not a complete review

You need to reduce the amount of content creation, specifically the sections with text areas and images etc should be using existing content like post or pages.

There is already a custom css option in WordPress 4.7, so you need to remove yours.

Featured images are only displayed in the navigation, I don't know if this is intentional.

#5 follow-up: @poena
10 months ago

Featured images are being displayed in blog index and also on posts
But they are not showing on my install -all I see is a blue background.

You will need to replace the sections, only minor content creation is allowed.
"Flexible content" as you call it is actually not flexible since it is lost as soon as the user switches themes.

#6 in reply to: ↑ 5 @pritamhans
9 months ago

Replying to poena:

Featured images are being displayed in blog index and also on posts
But they are not showing on my install -all I see is a blue background.

You will need to replace the sections, only minor content creation is allowed.
"Flexible content" as you call it is actually not flexible since it is lost as soon as the user switches themes.

Featured image: The featured image issue that you mention is most probably a local issue at your end caused by a missing image, which is still set as the featured image for the posts.

Content: The homepage template content is merely excerpts and is designed to be used as pointers/links. No actual content is created for the homepage, which means all your posts, pages remain intact even when you switch the theme. If user wants, she can avoid the custom home page template and use any other page template for the front page or only use the blog index page as the front page.

#7 @pratikshrestha
8 months ago

  • Owner set to pratikshrestha
  • Status changed from new to reviewing

#8 @pratikshrestha
8 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hello @pritamhans,

Thanks for uploading theme. This theme has quite a few security issues and few other issues so it is being closed. Do not get discouraged. A closed ticket is not the end. We want you to resubmit your theme. We do ask that you spend a bit more time making sure that your theme meets all the requirements before we make it live.
If you need help with anything or want me to explain further, don’t hesitate to post here in this ticket. I’m happy to answer any questions you have. Or, feel free to post over on our Slack channel.

REQUIRED ISSUES:

  • Remove donation and by ReduxThemes.com links from Theme Info & Support it is not allowed. Only one Upgrade to Pro link is allowed, but since your other links are support links, they can be allowed.
  • Website Color => Website Primary Color option does not works
  • Remove Custom Codes & CSS as now there is core's Additional CSS option
  • This is related to #5 from @poena , there is a lot of content in homepage option. Only minor trivial options are allowed. Although you have explained it, this does not deviate from the fact that a lot of content will be lost when theme switches. Maybe you can add testimonials via plugin(JetPack Testimonials).
    • Best way would be to allow user to select pages rather than let them add content via textarea
  • Add prefix to image names in line 63 and 64 of functions.php
  • Function prefix issue
    • Check function.php lines 237 and 253, you have used redux_ as prefix. Your main prefix is reduxbiz_, use this here as well.
    • No prefix in extras.php ln 109
    • issue in template-tags.php ln 145
  • In footer.php line 18, Use <?php echo esc_attr( date_i18n( __( 'Y', 'theme-slug' ) ) ); ?> instead of <?php echo date("Y"); ?>
  • In comments.php line 31, missing singular placeholder, needed for some languages. See link
    • They have fixed it in twentyseventeen. Check this.
  • You have added support for the html5 search form(functions.php Ln 84), only to overwrite it with another search form in searchform.php. You need to choose only one.
  • Following are unused functions so remove them:
    • function redux_checkbox_sanitize
    • function redux_text_sanitize
    • function redux_radio_select_sanitize
  • No idea why you have flexslider js in the theme. Remove it.
  • Sanitizing Input Issues
    • You have used redux_no_sanitize function to sanitize media images. When working with a setting corresponding with a media control, the sanitize_callback should generally be absint(), since a numerical id is expected. Check https://make.wordpress.org/core/2015/07/16/new-customizer-media-controls-in-4-3-and-4-2/
    • You have used esc_attr as sanitization function in line 232, 306, 356, etc in customizer.php. This function is to be used when escaping output data. Use some appropriate here as sanitize_text_field or something similar
  • Escaping/Sanitizing Output Issues
  • Looks like you have not escaped any output on all the template files in template-parts folder
    • You need to escape all $action... in template-parts/content-panel-actionbar.php before output
      • Like use esc_url for $actionButtonLink on line 42, etc
    • Similar issue as above in content-contact-form.php
    • In contact-panel-form.php same issue but for email, you need to do it as follows:
        <a href="mailto:<?php echo esc_attr( antispambot( $contactinfoEmail ) ); ?>" class="button"><span class="genericon genericon-mail"></span><?php echo esc_attr( antispambot( $contactinfoEmail ) ); ?></a>
      
    • Similar issues in content-panel-hero.php
      • You have also left out a print_r here
    • Similar issues in content-panel-services.php, content-panel-team.php, content-panel-testimonials.php

@poena: I am not sure about the donation link in Dashboard=>Customize=>Reduxbiz page. Can you check and let me know if this is allowed or not? Since I am closing this ticked due to major securities and function prefix issues, it will be helpful for the author when uploading the theme again.

Regards,
Pratik

#9 @pritamhans
8 months ago

@pratikshrestha Thanks for your comprehensive review.

Note: See TracTickets for help on using tickets.