WordPress.org

Make WordPress Themes

Opened 13 months ago

Closed 8 months ago

Last modified 8 months ago

#38078 closed theme (live)

THEME: Concepto Lite – 1.0.5

Reported by: Litonice13 Owned by: WPDevHQ
Priority: new theme Keywords: theme-concepto-lite
Cc: litonice09@…

Description

Concepto Lite - 1.0.0

Concept is a free clean and minimal WordPress blog theme, with an optional minimal layout, perfect to manage your personal, lifestyle, travel, food, recipes or fashion blog. Now is ecommerce ready and is optimized to work with WooCommerce and Contact Form 7 plugins. The blog section has a beautiful masonry grid and you are able to create a pinterest style gallery, adding the image post formats. You can manage the options of Concept Lite from the WordPress Theme Customizer. The theme support all modern browsers like Firefox, Chrome, Safari, Opera and Internet Explorer 8, 9 and 10 and uses the most modern technologies like HTML5 and CSS3.

Theme URL - https://prowptheme.com/products/concepto
Author URL - https://www.prowptheme.com

SVN - https://themes.svn.wordpress.org/concepto-lite/1.0.0
ZIP - https://wordpress.org/themes/download/concepto-lite.1.0.0.zip?nostats=1

History:


https://themes.svn.wordpress.org/concepto-lite/1.0.0/screenshot.png

Change History (30)

#2 follow-up: @Litonice13
12 months ago

Hello @WPDevHQ ,
I want to go through this Ticket. Because another Theme Live on WP Repo name "Concept Lite".
Please Review this Ticket.
Thanks

#3 in reply to: ↑ 2 @WPDevHQ
12 months ago

  • Owner set to WPDevHQ
  • Status changed from new to reviewing

Replying to Litonice13:

Hello @WPDevHQ ,
I want to go through this Ticket. Because another Theme Live on WP Repo name "Concept Lite".
Please Review this Ticket.
Thanks

OK cool.

In the future if you somehow find yourself in the same situation please do make a note on both tickets to the effect. This will help us in dealing with reviews as quickly as possible.

#4 @Litonice13
12 months ago

Hello @WPDevHQ ,
I've faced this kind of problems for the first time. I will follow your suggestions in future.
Thanks

#5 @WPDevHQ
12 months ago

General Check.

  • Themes must declare their copyright.
  • Theme tags - revisit the style.css and make sure all listed tags are actually supported by the theme. You also have "full-width-template" listed twice.
  • In the Documentation file you stated "You can upload an image as logo, for the admin area." - This falls under the plugin territory, please remove it.

License:

  • Choose one license for the PrettyPhoto script. Note that Creative Commons 2.5 license is not GPL compatible.

Code Check.

REQUIRED:

  • All stylesheets and scripts must be enqueued correctly via a function callback hooked to the appropriate action - remove the following from header.php
    <link rel="stylesheet" href="<?php echo get_stylesheet_uri(); ?>" media="screen" />
    <!--[if IE 8]>
        <script src="<?php echo get_template_directory_uri(); ?>/assets/scripts/html5shiv.js" type="text/javascript"></script>
        <script src="<?php echo get_template_directory_uri(); ?>/assets/scripts/selectivizr-min.js" type="text/javascript"></script>
    <![endif]-->
    
  • Use Core functions first where available. The function function concepto_title( $title, $sep ) is no longer allowed - use add_theme_support( 'title-tag' ); instead.
  • Use the correct and core function to enqueue styles and scripts instead of creating your own.
  • Use add_theme_support( 'custom-logo', array() ); for theme logo support instead of creating your own.
  • Translation: textdomain missing for register_nav_menu( 'main-menu', 'Main menu' ); - Note: The theme textdomain should match the theme slug i.e. concepto-lite
  • Translation: All public facing text strings must be translatable which includes the strings in the admin area (if any) - footer.php: ProWPTheme should be translatable.
  • Translation: footer.php - Use <?php echo esc_attr( date_i18n( __( 'Y', 'concepto-lite' ) ) ); ?> instead of <?php echo date("Y"); ?>
  • Pagination: Use core funtionality for paginations instead of creating your own.

Post Installation.

REQUIRED:

  • As mentioned above, theme check returns the following required isses...
    REQUIRED: This theme text domain does not match the theme's slug. The text domain used: conceptThis theme's correct slug and text-domain is concepto-lite.
    REQUIRED: The tag full-width-template is being used more than once, please remove it from your style.css header.
    
  • Customizer: Only 1 unobtrusive link is allowed in the customizer area

Keeping ticket opn on the virtue that you have already waited 5 months for the first review. Please fix all of the items marked as REQUIRED and upload a revised version for further consideration.

If you have any questions regarding any of the issues raised please feel free to ask.

NOTE: You must respond with 7 days of this review otherwise the ticket will be closed as not approved.

#6 @WPDevHQ
12 months ago

Additional Notes: Please fix the theme url. If used it must link to a page/site containing information about the theme. A demo url will only be accepted if it meets this condition - currently the url returns a 404 page not found.

#7 @themetracbot
12 months ago

  • Summary changed from THEME: Concepto Lite – 1.0.0 to THEME: Concepto Lite – 1.0.1

Concepto Lite - 1.0.1

Concepto Lite is a free clean and minimal WordPress blog theme, with an optional minimal layout, perfect to manage your personal, lifestyle, travel, food, recipes or fashion blog. Now is ecommerce ready and is optimized to work with WooCommerce and Contact Form 7 plugins. The blog section has a beautiful masonry grid and you are able to create a pinterest style gallery, adding the image post formats. You can manage the options of Concept Lite from the WordPress Theme Customizer. The theme support all modern browsers like Firefox, Chrome, Safari, Opera and Internet Explorer 8, 9 and 10 and uses the most modern technologies like HTML5 and CSS3.

Theme URL - https://prowptheme.com/products/concepto-lite
Author URL - https://www.prowptheme.com

SVN - https://themes.svn.wordpress.org/concepto-lite/1.0.1
ZIP - https://wordpress.org/themes/download/concepto-lite.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=concepto-lite/1.0.0&new_path=concepto-lite/1.0.1

History:


https://themes.svn.wordpress.org/concepto-lite/1.0.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

#8 @Litonice13
12 months ago

Hello @WPDevHQ,
Thanks for your quick Review. Your cooperation is much appreciated. I was fixing those issues from last couple of days. Sorry for being late.
Fixings are:

  • Themes declared copyright
  • Theme Tags fixed
  • Documentation Updated
  • License: I've used GPL2 on PrettyPhoto.js file. I've checked on PrettyPhoto website for License. They declared as below on "Copyright" section-

'"Copyright prettyPhoto is totally free to use, it is released the GPLv2 (http://www.gnu.org/licenses/gpl-2.0.html) or Creative Commons 2.5 license (http://creativecommons.org/licenses/by/2.5/). Feel free to use the one that suits your needs."'

I know GPL and CC isn't same. But they've given permission to use as GPL so I've used it on GPL License. I hope License is correct now.

  • Stylesheets enqueued correctly
  • Used add_theme_support( 'title-tag' );
  • Used add_theme_support( 'custom-logo', array() ); Function
  • Navigation textdomain issue resolved
  • Footer Translation issue resolved
  • Footer Date issue resolved
  • Text Domain issue fixed on whole Theme
  • Customizer: Only 1 unobtrusive link used on customizer area
  • Theme URL with Demo is fixed.

Hope everything is fine now. Waiting for your nice co-operation.
Thanks

#9 @WPDevHQ
12 months ago

General Check.

REQUIRED:

  • I still don't see theme copyright declaration - should be something like
    == Copyright ==
    
    Twenty Seventeen WordPress Theme, Copyright 2016 WordPress.org
    Twenty Seventeen is distributed under the terms of the GNU GPL
    
  • For the Pretty Photo script licence, remove the words "or Creative Commons 2.5 license" in order to avoid confusion as to which licence is in use.
  • style.css - Change textdoman in header to concepto-lite
  • I don't belive the following on your terms and conditions page is in keeping with the terms of GPL - it also contradicts other sections on the page and will lead to end user confusion
    Ownership
    You may not claim intellectual or exclusive ownership to any of ProWPTheme’s WordPress themes, modified or unmodified. All products are the property of ProWPTheme.com
    

Code Check.

REQUIRED:

  • File main.php @line 494 the $font_url; should be escapped correctly - esc_url_raw( $font_url );
  • header.php - Enqueue: I still see this <link rel="stylesheet" href="<?php echo get_stylesheet_uri(); ?>" media="screen" /> in the header. Please use the correct enqueue method.
  • footer.php - Use single quotes around the strings and textdomain - see lines 27-28. Check all other files.
  • pagination.php - Still building your own pagination here. Please use core functions first.
  • folder: woocommerce - I don't see visual changes to most of the files. Why are these being bundled instead of using the defaults in the plugin?

Post Installation.

  • Custom CSS is now a WordPress core function - please remove this option from the theme.
  • I still see multiple links in the Customizer - either keep the Pro link where it is or move it to the Support tab. Either way please tone the color down and keep it inline with the customizer/admin styling.

I'm wondering if you uploaded the correct version given these issues are from my previous review but you've stated that they are fixed?

#10 @themetracbot
12 months ago

  • Summary changed from THEME: Concepto Lite – 1.0.1 to THEME: Concepto Lite – 1.0.2

Concepto Lite - 1.0.2

Concepto Lite is a free clean and minimal WordPress blog theme, with an optional minimal layout, perfect to manage your personal, lifestyle, travel, food, recipes or fashion blog. Now is ecommerce ready and is optimized to work with WooCommerce and Contact Form 7 plugins. The blog section has a beautiful masonry grid and you are able to create a pinterest style gallery, adding the image post formats. You can manage the options of Concept Lite from the WordPress Theme Customizer. The theme support all modern browsers like Firefox, Chrome, Safari, Opera and Internet Explorer 8, 9 and 10 and uses the most modern technologies like HTML5 and CSS3.

Theme URL - https://prowptheme.com/products/concepto-lite
Author URL - https://www.prowptheme.com

SVN - https://themes.svn.wordpress.org/concepto-lite/1.0.2
ZIP - https://wordpress.org/themes/download/concepto-lite.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=concepto-lite/1.0.1&new_path=concepto-lite/1.0.2

History:


https://themes.svn.wordpress.org/concepto-lite/1.0.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

#11 @Litonice13
12 months ago

Hello @WPDevHQ,
I did few mistakes because few things I didn't understand. Anyway, fixed the most recent issues.
Fixes are:

  • Misunderstood about "Copyright" Declaration. Hope it's fine now.
  • Textdomain fixed on style.css file
  • "Ownership" section changed on ProWPTheme.com Terms and Conditions page.
  • I couldn't find $font_url on main.php file.
  • header.php - Enqueue: I still see this <link rel="stylesheet" href="<?php echo get_stylesheet_uri(); ?>" removed
  • footer.php - single quotes used
  • woocommerce folder removed
  • pagination.php - I don't understand about this. Please give an example about core functions for pagination.
  • Custom CSS removed
  • I want to keep the "Pro Link" on Customizer, please be consider about this. Though there're multiple links on customizer. Those all are relates with Theme Supports.

Thanks for your time.

#12 @WPDevHQ
11 months ago

For pagination you should be using the core function the_posts_pagination() on the blog index/home and the_post_navigation() for single post view.

Will leave the customizer links to the key reviewer to consider once the theme has been approved.

In the readme file remove the following as JQuery is not and should not be included by theme(s).

- Jquery

-- By Jquery - https://jquery.org

--- Licensed under MIT License

You are still using double " where you shouldn't be - like @line 28 in post-info.php. Text strings and the textdomain should be enclosed in single ' quotes. Please check all files for this.

masonry.php @line 51 home_url( '/' ) should be escaped correctly

Could you also explain what is it you are doing with the functions concepto_require and concepto_enqueue_script in main.php with regard to ".DS_Store" check?

Not all post formats declared @line 675 in main.php are being supported - I can only see support for post format standard and image.....did I miss something?

In woocommerce.php template_redirect would be a better hook to target insted of init

There's a mixture of single and double quotes in widgets.php - as mentioned above, check all files.

In theme-style.php - consider using wp_add_inline_style() to output custom styles instead of hooking directly in to wp_head()

In metaboxes.php @line 186 - text string needs to be translatable.

customizer.php line 287 through to 297 - these seem to be text strings. If so they must be translatable.

All of the scripts and styles in general.php are being loaded on every page of the admin dashboard - admin_init is not the appropriate hook for these. You should only loading these where they are required i.e. the Customizer!

Please check every single file and fix these issues - theme reviewers shouldn't have to point them out on every review performed. You the theme author should take care and responsibility to make sure that the theme is ready for the review process.

If you have any questions with respect to any of the raised issues please ask first before resubmitting for further consideration.

Last edited 11 months ago by WPDevHQ (previous) (diff)

#13 @themetracbot
11 months ago

  • Summary changed from THEME: Concepto Lite – 1.0.2 to THEME: Concepto Lite – 1.0.3

Concepto Lite - 1.0.3

Concepto Lite is a free clean and minimal WordPress blog theme, with an optional minimal layout, perfect to manage your personal, lifestyle, travel, food, recipes or fashion blog. Now is ecommerce ready and is optimized to work with WooCommerce and Contact Form 7 plugins. The blog section has a beautiful masonry grid and you are able to create a pinterest style gallery, adding the image post formats. You can manage the options of Concept Lite from the WordPress Theme Customizer. The theme support all modern browsers like Firefox, Chrome, Safari, Opera and Internet Explorer 8, 9 and 10 and uses the most modern technologies like HTML5 and CSS3.

Theme URL - https://prowptheme.com/products/concepto-lite
Author URL - https://www.prowptheme.com

SVN - https://themes.svn.wordpress.org/concepto-lite/1.0.3
ZIP - https://wordpress.org/themes/download/concepto-lite.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=concepto-lite/1.0.2&new_path=concepto-lite/1.0.3

History:


https://themes.svn.wordpress.org/concepto-lite/1.0.3/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

#14 @Litonice13
11 months ago

Hello @WPDevHQ,
Thanks for your details and descriptive instructions. I'm Developing Themes from last few years. Didn't faced problems i'm seeing now. That's why it's taking few times to adopt those things.
Anyway, Always I checked with Theme Check Plugin and use Debug Bar. But I've never seen the textdomain problems with double quotes you've mentioned. Changing over whole theme is painful and it's normal to remains few.
Please let me know your Development Environments and Softwares you're using for latest Theme Checks. It will helpful for me in future specially the Text Domain issue you're mentioning. How you'll detect this thing?

  • Pagination used on your instructions the_posts_pagination() and the_post_navigation() used
  • jQuery removed from readme file
  • masonry.php @line 51 home_url( '/' ) escaped
  • Explaination: I've checked directory for files for wp_enqueue... It may contains junk files like .DS_Store etc.. If scandir fails, don't continue with junk. It ignores non-files (directories) and files starting with a dot (including ., .., .htaccess, etc.)
  • template_redirect used on woocommerce.php
  • On widgets.php file mixtures of single and double quotes fixed
  • add_inline_style() used instead of wp_head()
  • metabox file fixed
  • customizer.php text strings is now translatable
  • On general.php file loading scripts only for customizer

I've tried to check every single issues with the Theme. Sorry for inconveniences you're going through. I'm trying my level best.
Please inform your Development Environments with sofwares.

Thanks

#15 follow-up: @grapplerulrich
11 months ago

@WPDevHQ Using single or double quotes is coding style decision. The WP coding standards says to use single quotes but it is not a requirement.

@Litonice13 The theme check is not enough. There is also a manual review which you can ask a friend to do for you.

#16 in reply to: ↑ 15 @WPDevHQ
11 months ago

Replying to grapplerulrich:

@WPDevHQ Using single or double quotes is coding style decision. The WP coding standards says to use single quotes but it is not a requirement.

Yes I'm aware of it being a coding standard - raised due to the fact the author has a mixture of both. Some files have single and some have double while others contain both.

@Litonice13 - I'll take a look at the latest version in the next 24 hours for you.

#17 @WPDevHQ
11 months ago

  • Status changed from reviewing to approved

Looks good to me.

@Litonice13 - please remove the pagination.php file from the theme in the next iteration.

This ticket was mentioned in Slack in #themereview by litonarefin. View the logs.


10 months ago

#19 @bplv
8 months ago

  • Status changed from approved to reopened

Hello @Litonice13 ,

I'll be doing the final review of your theme.
Please fix the below given issues.

Required

  • Theme author should hold the copy right not wordpress.org. Check theme license declartion on readme.txt
  • Remove the language folder.
  • Make sure excerpt_more filter does not affect admin side. See Twenty Seventeen theme for reference.
  • escaping missing on main.php line 500.
  • After removing language folder please change load_theme_textdomain('concepto-lite', get_template_directory() . '/languages'); to load_theme_textdomain('concepto-lite');
  • No minification of scripts or files unless you provide original files. Check, bootstrap css , fontawesome css.
  • For pagination, use the_posts_pagination() rather than paginate_links()
  • You need to provide link of the images that are bundled with the theme and used on the screenshot.
  • Editor style is not required but if provided it should have proper CSS that will resemble the front-end design on the back-end content editor.
  • concepto_enqueue_style() loads editor-style.css on the front-end too. You don't need that.
Last edited 8 months ago by bplv (previous) (diff)

#20 @rabmalin
8 months ago

  • Status changed from reopened to reviewing

#21 @themetracbot
8 months ago

  • Summary changed from THEME: Concepto Lite – 1.0.3 to THEME: Concepto Lite – 1.0.4

Concepto Lite - 1.0.4

Concepto Lite is a free clean and minimal WordPress blog theme, with an optional minimal layout, perfect to manage your personal, lifestyle, travel, food, recipes or fashion blog. Now is ecommerce ready and is optimized to work with WooCommerce and Contact Form 7 plugins. The blog section has a beautiful masonry grid and you are able to create a pinterest style gallery, adding the image post formats. You can manage the options of Concept Lite from the WordPress Theme Customizer. The theme support all modern browsers like Firefox, Chrome, Safari, Opera and Internet Explorer 8, 9 and 10 and uses the most modern technologies like HTML5 and CSS3.

Theme URL - https://prowptheme.com/products/concepto-lite
Author URL - https://www.prowptheme.com

Trac Browser - https://themes.trac.wordpress.org/browser/concepto-lite/1.0.4

SVN - https://themes.svn.wordpress.org/concepto-lite/1.0.4
ZIP - https://wordpress.org/themes/download/concepto-lite.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=concepto-lite/1.0.3&new_path=concepto-lite/1.0.4

History:


https://themes.svn.wordpress.org/concepto-lite/1.0.4/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#22 @Litonice13
8 months ago

Hello @bplv,
Thanks for getting me back.
I've fixed your given issues.

Updates are

  • Copyright changed to prowptheme.com
  • Language Folder removed
  • excerpt_more fixed followed by Twenty Seventeen theme
  • escaped the url on main.php file line#500
  • load_text_domain() changed
  • Minification files are removed
  • pagination.php file removed. It's not needed file because i'm using the_posts_pagination()
  • No Images bundled with the Theme. All Images used for Demo By Unsplash - https://unsplash.com with Licensed under CC0 License.
  • Editor Style file and code removed.

Hope everything is fine now. Waiting for the final Approval :)
Thanks

#23 @bplv
8 months ago

@Litonice13 ,

You will need to provide a detail link of the images used in screenshot as well.

#24 @Litonice13
8 months ago

Hello @bplv ,
Okay, Do i've to include the urls in this comment box or on readme.txt file ?
Thanks

#25 @bplv
8 months ago

Yes, just add the links to the each individual image on readme.txt . Make sure the image providers are licensed under CC0 or any type of license which is compatible with GPL.

#26 @themetracbot
8 months ago

  • Summary changed from THEME: Concepto Lite – 1.0.4 to THEME: Concepto Lite – 1.0.5

Concepto Lite - 1.0.5

Concepto Lite is a free clean and minimal WordPress blog theme, with an optional minimal layout, perfect to manage your personal, lifestyle, travel, food, recipes or fashion blog. Now is ecommerce ready and is optimized to work with WooCommerce and Contact Form 7 plugins. The blog section has a beautiful masonry grid and you are able to create a pinterest style gallery, adding the image post formats. You can manage the options of Concept Lite from the WordPress Theme Customizer. The theme support all modern browsers like Firefox, Chrome, Safari, Opera and Internet Explorer 8, 9 and 10 and uses the most modern technologies like HTML5 and CSS3.

Theme URL - https://prowptheme.com/products/concepto-lite
Author URL - https://www.prowptheme.com

Trac Browser - https://themes.trac.wordpress.org/browser/concepto-lite/1.0.5

SVN - https://themes.svn.wordpress.org/concepto-lite/1.0.5
ZIP - https://wordpress.org/themes/download/concepto-lite.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=concepto-lite/1.0.4&new_path=concepto-lite/1.0.5

History:


https://themes.svn.wordpress.org/concepto-lite/1.0.5/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#28 follow-up: @bplv
8 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Looks good to me.
Your theme will be live shortly.

Regards.

#29 in reply to: ↑ 28 @alexvtn
8 months ago

Hi @bplv

This theme is a clone of a previous version (2.7.7 i guess) of my SuevaFree theme, available on WordPress.org since 2013

https://wordpress.org/themes/suevafree/

This theme has the same php, css and javascript code, the same files, description, documentation and layout.

Moreover, this theme doesn't work, the following error is displayed after the activation.

Fatal error: Cannot redeclare concepto_hide_excerpt_more() (previously declared in /Volumes/USB/XAMPP/htdocs/wordpress/wp-content/themes/concepto-lite/core/main.php:478) in /Volumes/USB/XAMPP/htdocs/wordpress/wp-content/themes/concepto-lite/core/main.php on line 486

Thank you.

Alex.

Replying to bplv:

Looks good to me.
Your theme will be live shortly.

Regards.

#30 @poena
8 months ago

@Litonice13
Cloning other themes is not acceptable. Your theme has been suspended.

Note: See TracTickets for help on using tickets.