WordPress.org

Make WordPress Themes

Opened 12 months ago

Closed 9 months ago

Last modified 3 months ago

#38219 closed theme (live)

THEME: Lana Blog – 1.0.5

Reported by: lanadesign Owned by: acosmin
Priority: previously reviewed Keywords: theme-lana-blog
Cc: info@…

Change History (10)

#1 @themetracbot
11 months ago

  • Summary changed from THEME: Lana Blog – 1.0.1 to THEME: Lana Blog – 1.0.2

Lana Blog - 1.0.2

Bootstrap based Responsive WordPress Theme

Theme URL - http://wp.lanaprojekt.hu/blog/wordpress-themes/lana-blog/
Author URL - http://wp.lanaprojekt.hu/blog/

SVN - https://themes.svn.wordpress.org/lana-blog/1.0.2
ZIP - https://wordpress.org/themes/download/lana-blog.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=lana-blog/1.0.1&new_path=lana-blog/1.0.2

History:

Ticket Summary Status Resolution Owner
#38124 THEME: Lana Blog – 1.0.0 closed not-approved poena
#38219 THEME: Lana Blog – 1.0.5 closed live acosmin

(this ticket)

#41397 THEME: Lana Blog – 1.0.6 closed live themetracbot
#42035 THEME: Lana Blog – 1.0.7 closed live themetracbot
#42039 THEME: Lana Blog – 1.0.8 closed live themetracbot
#42709 THEME: Lana Blog – 1.0.9 closed live themetracbot
#44316 THEME: Lana Blog – 1.1.0 closed live themetracbot
#46257 THEME: Lana Blog – 1.1.1 closed live themetracbot
#47016 THEME: Lana Blog – 1.1.2 closed live themetracbot


https://themes.svn.wordpress.org/lana-blog/1.0.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

#2 @themetracbot
10 months ago

  • Summary changed from THEME: Lana Blog – 1.0.2 to THEME: Lana Blog – 1.0.3

Lana Blog - 1.0.3

Bootstrap based Responsive WordPress Theme

Theme URL - http://wp.lanaprojekt.hu/blog/wordpress-themes/lana-blog/
Author URL - http://wp.lanaprojekt.hu/blog/

SVN - https://themes.svn.wordpress.org/lana-blog/1.0.3
ZIP - https://wordpress.org/themes/download/lana-blog.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=lana-blog/1.0.2&new_path=lana-blog/1.0.3

History:

Ticket Summary Status Resolution Owner
#38124 THEME: Lana Blog – 1.0.0 closed not-approved poena
#38219 THEME: Lana Blog – 1.0.5 closed live acosmin

(this ticket)

#41397 THEME: Lana Blog – 1.0.6 closed live themetracbot
#42035 THEME: Lana Blog – 1.0.7 closed live themetracbot
#42039 THEME: Lana Blog – 1.0.8 closed live themetracbot
#42709 THEME: Lana Blog – 1.0.9 closed live themetracbot
#44316 THEME: Lana Blog – 1.1.0 closed live themetracbot
#46257 THEME: Lana Blog – 1.1.1 closed live themetracbot
#47016 THEME: Lana Blog – 1.1.2 closed live themetracbot


https://themes.svn.wordpress.org/lana-blog/1.0.3/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

#3 @themetracbot
10 months ago

  • Summary changed from THEME: Lana Blog – 1.0.3 to THEME: Lana Blog – 1.0.4

Lana Blog - 1.0.4

Bootstrap based Responsive WordPress Theme

Theme URL - http://wp.lanaprojekt.hu/blog/wordpress-themes/lana-blog/
Author URL - http://wp.lanaprojekt.hu/blog/

SVN - https://themes.svn.wordpress.org/lana-blog/1.0.4
ZIP - https://wordpress.org/themes/download/lana-blog.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=lana-blog/1.0.3&new_path=lana-blog/1.0.4

History:

Ticket Summary Status Resolution Owner
#38124 THEME: Lana Blog – 1.0.0 closed not-approved poena
#38219 THEME: Lana Blog – 1.0.5 closed live acosmin

(this ticket)

#41397 THEME: Lana Blog – 1.0.6 closed live themetracbot
#42035 THEME: Lana Blog – 1.0.7 closed live themetracbot
#42039 THEME: Lana Blog – 1.0.8 closed live themetracbot
#42709 THEME: Lana Blog – 1.0.9 closed live themetracbot
#44316 THEME: Lana Blog – 1.1.0 closed live themetracbot
#46257 THEME: Lana Blog – 1.1.1 closed live themetracbot
#47016 THEME: Lana Blog – 1.1.2 closed live themetracbot


https://themes.svn.wordpress.org/lana-blog/1.0.4/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

This ticket was mentioned in Slack in #themereview by lanadesign. View the logs.


10 months ago

#5 @acosmin
9 months ago

  • Owner set to acosmin
  • Status changed from new to reviewing

#6 @acosmin
9 months ago

  1. functions.php
    • L43-45 - $content_width needs to be set as a global example
  1. Use core functions:
    • functions\lana-theme.php remove lana_pagination(), change with the_posts_pagination()
  1. functions\lana-theme.php
    • lana_comment_form_fields() - placeholder attributes need to use esc_attr__() for translations
    • L491 - get_permalink() needs to be escaped
  1. lana-theme-customizer.php
    • L163-169 - need to be translatable, __( 'games.png', 'lana-blog' );
  1. searchform.php
    • L4 - esc_attr_e()
  1. footer.php
    • L25, needs to be escaped
    • L32, chage date( 'Y' ) to date_i18n( __( 'Y', 'lana-blog' ) )
  1. readme.txt
    • you need to provide license information for all the assets you are using (files in css, fonts, img, js folders)

You have 7 days to answer/update.

#7 @themetracbot
9 months ago

  • Summary changed from THEME: Lana Blog – 1.0.4 to THEME: Lana Blog – 1.0.5

Lana Blog - 1.0.5

Bootstrap based Responsive WordPress Theme

Theme URL - http://wp.lanaprojekt.hu/blog/wordpress-themes/lana-blog/
Author URL - http://wp.lanaprojekt.hu/blog/

Trac Browser - https://themes.trac.wordpress.org/browser/lana-blog/1.0.5

SVN - https://themes.svn.wordpress.org/lana-blog/1.0.5
ZIP - https://wordpress.org/themes/download/lana-blog.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=lana-blog/1.0.4&new_path=lana-blog/1.0.5

History:

Ticket Summary Status Resolution Owner
#38124 THEME: Lana Blog – 1.0.0 closed not-approved poena
#38219 THEME: Lana Blog – 1.0.5 closed live acosmin

(this ticket)

#41397 THEME: Lana Blog – 1.0.6 closed live themetracbot
#42035 THEME: Lana Blog – 1.0.7 closed live themetracbot
#42039 THEME: Lana Blog – 1.0.8 closed live themetracbot
#42709 THEME: Lana Blog – 1.0.9 closed live themetracbot
#44316 THEME: Lana Blog – 1.1.0 closed live themetracbot
#46257 THEME: Lana Blog – 1.1.1 closed live themetracbot
#47016 THEME: Lana Blog – 1.1.2 closed live themetracbot


https://themes.svn.wordpress.org/lana-blog/1.0.5/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

#8 @acosmin
9 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

@lanadesign Congrats, your theme should be live shortly!

#9 @lanadesign
3 months ago

I would like to modify the author to: @lanacodes

This ticket was mentioned in Slack in #themereview by lanacodes. View the logs.


3 months ago

Note: See TracTickets for help on using tickets.