WordPress.org

Make WordPress Themes

Opened 9 months ago

Closed 5 months ago

#38388 closed theme (live)

THEME: Advocator Lite – 1.0.3

Reported by: rescuethemes Owned by: acosmin
Priority: new theme Keywords: theme-advocator-lite
Cc: hello@…

Description

Advocator Lite - 1.0

A WordPress theme for non-profits, charities, and organizations that do good.

Theme URL - https://rescuethemes.com/wordpress-themes/advocator-lite/
Author URL - https://rescuethemes.com

SVN - https://themes.svn.wordpress.org/advocator-lite/1.0
ZIP - https://wordpress.org/themes/download/advocator-lite.1.0.zip?nostats=1

History:


https://themes.svn.wordpress.org/advocator-lite/1.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

Change History (19)

#1 @joyously
6 months ago

  • There is no menu shown when none are selected. There should be a default/fallback menu, which is the default value for fallback_cb of wp_nav_menu().
  • Ignoring user choice of comment avatar type.
  • Only one link is allowed in the Customizer. Out of 11 sections in the Theme Options, only 4 have actual options. And the Custom CSS option probably should be the new core Additional CSS option.
  • Floats are not being cleared properly. (Edit link wraps)

#2 @rescuethemes
6 months ago

Hello @joyously
Would you help understand or give an example of these two:
Ignoring user choice of comment avatar type.
Floats are not being cleared properly. (Edit link wraps)

Thank you

#3 @joyously
6 months ago

  • Ignoring user choice of comment avatar type.

In my site, I go to Settings > Discussion and at the bottom is Default Avatar. I have chosen Identicon. But when I view my site pages that have comments, I don't see that type of avatar. I see only what the theme chose to show.

  • Floats are not being cleared properly. (Edit link wraps)

In the Theme Unit Tests, which you should be doing, is a page called "Clearing Floats". It has a floated image as the last thing in the page content. The theme should be clearing floats so that whatever comes after is not next to that floated image. This theme did not clear, so the Edit link which comes after the page content ends up next to the image.

#4 @themetracbot
6 months ago

  • Summary changed from THEME: Advocator Lite – 1.0 to THEME: Advocator Lite – 1.0.1

Advocator Lite - 1.0.1

A WordPress theme for non-profits, charities, and organizations that do good.

Theme URL - https://rescuethemes.com/wordpress-themes/advocator-lite/
Author URL - https://rescuethemes.com

Trac Browser - https://themes.trac.wordpress.org/browser/advocator-lite/1.0.1

SVN - https://themes.svn.wordpress.org/advocator-lite/1.0.1
ZIP - https://wordpress.org/themes/download/advocator-lite.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=advocator-lite/1.0&new_path=advocator-lite/1.0.1

History:


https://themes.svn.wordpress.org/advocator-lite/1.0.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#5 @rescuethemes
6 months ago

Thank you @joyously
I have addressed all four issues.

#6 @acosmin
5 months ago

  • Owner set to acosmin
  • Status changed from new to reviewing

You caught me in a good mood. It kinda deserved a not-approved label for more than 5 issues.

You have 7 days to solve them


1.functions.php

  • $content_width needs to be set as a global example
  • L40,41 - handles need to be prefixed
  • L80 is plugin territory
  1. Fancybox is not GPL compatible, anything related to this script needs to be removed
  1. inc\template-tags.php
    • rescue_tribe_event_featured_image()
      • get_the_title() needs to be replaced with the_title_attribute( 'echo=0' )
    • L105
      • replace ... with &hellip
      • get_permalink() needs to be escaped
    • L62, that class needs to be prefixed. Also, why do you have it two times in the theme, functions.php:L197
  1. inc\plugins.php
    • my_theme_register_required_plugins() needs to be prefixed
    • All the plugins need to be hosted on WordPress.org
  1. inc\upgrade - this is not allowed, use something like this
  1. No minification of scripts or files unless you provide original files.
    • check your js folder
  1. content.php
    • L9, same as nr.3, point 1.1
  1. header.php:L123, esc_html() instead of esc_attr()
  1. remove style.css.map
  1. template-home.php
    • L21, 69, 91, 173 - esc_attr() or sanitize_html_class()
    • L98, 159, 184, 236 - esc_html()
    • L110, 196 - absint() or intval()
    • L178 is not allowed, try looking if the class plugin class exists with if( class_exists( 'ClassName' ) ) { }
    • L226 - Custom WP_Query's need to be reset with wp_reset_postdata()
    • L235 - esc_url()
  1. readme.txt
    • You need to declare license information for any assets used in your theme. No license provided for:
      • images in the img folder
      • wow.min.js, modernizr.js
      • images used in screenshot.png
  1. Your theme uri doesn't work.

#7 @acosmin
5 months ago

Also, take a look in the console when you are in the Customizer:
GET http://PATH/advocator-litecustomizercustomizer-library/js/customizer.js?ver=1.0.0 403

And theme mods are showing up in the header after saving in the Customizer

#8 @rescuethemes
5 months ago

I'm sorry @acosmin but I don't understand two things. One why do I have 7 days, two, why am I spoken to in this way?

You caught me in a good mood. It kinda deserved a not-approved label for more than 5 issues. You have 7 days to solve them

#9 @acosmin
5 months ago

@rescuethemes 7 days because with no answer after this period of time I can close the ticket.

Also, you have detailed instructions above on how to solve all the issues, with line numbers and solutions. I don't think it can take more than 1 day to solve them.

I normally close tickets with so many issues, the wording might be a little rough, but I don't think it's rougher than getting a "5 issues, closed ticket" type of message. I apologize if I offended you.

The theme seems unfinished, like it's in development mode.

If you want, I can get you another reviewer.

#10 @rescuethemes
5 months ago

@acosmin I'm not offended by the 7 days. It was the comment "You caught me in a good mood." that takes me back.

I'm sorry if I missed a number of things but I'm learning this process and appreciate the feedback. I don't know if I can get it done because I have a full time job and family to care for. But I'm going to work on these over the next few days as time permits and update on my progress.

Thank you

#11 @themetracbot
5 months ago

  • Summary changed from THEME: Advocator Lite – 1.0.1 to THEME: Advocator Lite – 1.0.2

Advocator Lite - 1.0.2

A WordPress theme for non-profits, charities, and organizations that do good.

Theme URL - https://rescuethemes.com/wordpress-themes/advocator-lite/
Author URL - https://rescuethemes.com

Trac Browser - https://themes.trac.wordpress.org/browser/advocator-lite/1.0.2

SVN - https://themes.svn.wordpress.org/advocator-lite/1.0.2
ZIP - https://wordpress.org/themes/download/advocator-lite.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=advocator-lite/1.0.1&new_path=advocator-lite/1.0.2

History:


https://themes.svn.wordpress.org/advocator-lite/1.0.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#12 @rescuethemes
5 months ago

@acosmin I believe I have addressed everything in your list by removing or fixing. Thank you again for your help and feedback!

#13 @acosmin
5 months ago

You have issues in the Customizer, try changing some colors, they don't work.

Failed to load resource: the server responded with a status of 403 (Forbidden) customizer.js in console.

#14 @rescuethemes
5 months ago

Strange. It is working on my end and I don't receive this 403 error. Which browser are you using? Which color are you changing?

#15 @acosmin
5 months ago

replace:
$path = str_replace( WP_CONTENT_DIR, WP_CONTENT_URL, dirname( dirname( __FILE__ ) ) );

with:
$path = get_template_directory_uri() . '/customizer/customizer-library';

in customizer\customizer-library\extensions\preview.php. It doesn't work on my localhost and it's more than likely it will not work on other hosts. My proposition is more theme based.

#16 @themetracbot
5 months ago

  • Summary changed from THEME: Advocator Lite – 1.0.2 to THEME: Advocator Lite – 1.0.3

Advocator Lite - 1.0.3

A WordPress theme for non-profits, charities, and organizations that do good.

Theme URL - https://rescuethemes.com/wordpress-themes/advocator-lite/
Author URL - https://rescuethemes.com

Trac Browser - https://themes.trac.wordpress.org/browser/advocator-lite/1.0.3

SVN - https://themes.svn.wordpress.org/advocator-lite/1.0.3
ZIP - https://wordpress.org/themes/download/advocator-lite.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=advocator-lite/1.0.2&new_path=advocator-lite/1.0.3

History:


https://themes.svn.wordpress.org/advocator-lite/1.0.3/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#17 @rescuethemes
5 months ago

Thank you for the suggestion @acosmin . I updated in the new upload.

#18 @acosmin
5 months ago

Didn't get an email about this ticket, sorry about the 4 days delay. I'll have an answer for you today.

#19 @acosmin
5 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Can't find the unminified version of modernizr.js. You'll need to add it in the next update.

@rescuethemes Congrats, your theme should be live shortly!

Note: See TracTickets for help on using tickets.