WordPress.org

Make WordPress Themes

Opened 6 months ago

Closed 7 weeks ago

#38393 closed theme (live)

THEME: Dynamic Seventeen – 1.1.3

Reported by: celloexpressions Owned by: rabmalin
Priority: new theme Keywords: theme-dynamic-seventeen child-theme parent-twentyseventeen accessibility-ready
Cc: halseyns@…

Description

Dynamic Seventeen - 1.0

Twenty Seventeen child theme with a dynamic front page and page template. Showcase your content with dynamic multi-part pages integrating all content types in a unified experience. To make a page dynamic, use the “Dynamic Content” page template, then add a menu to the associated menu location to manage its content.

Theme URL - https://github.com/celloexpressions/dynamic-seventeen
Author URL - http://nick.halsey.co/

SVN - https://themes.svn.wordpress.org/dynamic-seventeen/1.0
ZIP - https://wordpress.org/themes/download/dynamic-seventeen.1.0.zip?nostats=1
Parent Theme: https://wordpress.org/themes/twentyseventeen

History:


https://themes.svn.wordpress.org/dynamic-seventeen/1.0/screenshot.png
Theme Check Results:

  • REQUIRED: Could not find wp_footer. See: wp_footer
     <?php wp_footer(); ?>
    
  • REQUIRED: Could not find wp_head. See: wp_head
     <?php wp_head(); ?>
    
  • REQUIRED: Could not find language_attributes. See: language_attributes
    <html <?php language_attributes(); ?>
    
  • REQUIRED: Could not find charset. There must be a charset defined in the Content-Type or the meta charset tag in the head.
  • REQUIRED: Could not find add_theme_support( 'automatic-feed-links' ). See: add_theme_support
     <?php add_theme_support( $feature ); ?>
    
  • REQUIRED: Could not find comments_template. See: comments_template
     <?php comments_template( $file, $separate_comments ); ?>
    
  • REQUIRED: Could not find wp_list_comments. See: wp_list_comments
     <?php wp_list_comments( $args ); ?>
    
  • REQUIRED: Could not find comment_form. See: comment_form
     <?php comment_form(); ?>
    
  • REQUIRED: Could not find body_class call in body tag. See: body_class
     <?php body_class( $class ); ?>
    
  • REQUIRED: Could not find wp_link_pages. See: wp_link_pages
     <?php wp_link_pages( $args ); ?>
    
  • REQUIRED: The theme doesn't have comment pagination code in it. Use paginate_comments_links() or the_comments_navigation or the_comments_pagination or next_comments_link() and previous_comments_link() to add comment pagination.
  • REQUIRED: No content width has been defined. Example:
    if ( ! isset( $content_width ) ) $content_width = 900;
    
  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • WARNING: Could not find the file index.php in the theme.
  • REQUIRED: This theme doesn't seem to support the standard avatar functions. Use get_avatar or wp_list_comments to add this support.
  • REQUIRED: The theme doesn't have post pagination code in it. Use posts_nav_link() or paginate_links() or the_posts_pagination() or the_posts_navigation() or next_posts_link() and previous_posts_link() to add post pagination.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
  • RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( "post-thumbnails" )in the functions.php file.
  • <span class='tc-lead tc-required'>REQUIRED</span>: .sticky css class is needed in your theme css.
  • <span class='tc-lead tc-required'>REQUIRED</span>: .bypostauthor css class is needed in your theme css.
  • <span class='tc-lead tc-required'>REQUIRED</span>: .alignleft css class is needed in your theme css.
  • <span class='tc-lead tc-required'>REQUIRED</span>: .alignright css class is needed in your theme css.
  • <span class='tc-lead tc-required'>REQUIRED</span>: .aligncenter css class is needed in your theme css.
  • <span class='tc-lead tc-required'>REQUIRED</span>: .wp-caption css class is needed in your theme css.
  • <span class='tc-lead tc-required'>REQUIRED</span>: .wp-caption-text css class is needed in your theme css.
  • <span class='tc-lead tc-required'>REQUIRED</span>: .gallery-caption css class is needed in your theme css.
  • <span class='tc-lead tc-required'>REQUIRED</span>: .screen-reader-text css class is needed in your theme css. See See: the Codex for an example implementation.
  • <span class='tc-lead tc-required'>REQUIRED</span>: This theme doesn't seem to display tags. Modify it to display tags in appropriate locations.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs.<br>The domains found are dynamic-seventeen, twentyseventeen
  • REQUIRED: No reference to add_theme_support( "title-tag" ) was found in the theme.
  • REQUIRED: The theme must not used the &lt;title&gt; tags.
  • REQUIRED: The theme must not call to wp_title().
  • <span class='tc-lead tc-recommended'>RECOMMENDED</span>: This theme contains no sidebars/widget areas. See Widgets API

Change History (23)

#1 @celloexpressions
6 months ago

Note: the above theme-check results are invalid because this is a child theme. The results from a local run are:

Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs.
The domains found are twentyseventeen, dynamic-seventeen
RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
INFO: Themes that use the tag accessibility-ready will need to undergo an accessibility review. See https://make.wordpress.org/themes/handbook/review/accessibility/
INFO: icon-functions.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
Line 19: require_once( $svg_icons );
INFO: functions-icons.php The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
Line 20: require_once( $svg_icons );

I'm not sure what the best practice for child theme textdomains is. It seems like there should be language packs for both the theme and the child theme applying at the same time. There are only a couple of strings in the child theme, and they're not particularly important (and admin-only), so it may be better to leave those out entirely or otherwise hack something in? The remaining items all come from Twenty Seventeen itself.

#2 @celloexpressions
6 months ago

As I brought up in the theme review Slack channel last week, I would like this child theme to be considered for an expedited review, for the following reasons:

  • It is a direct extension of Twenty Seventeen, which is now the default theme and will be so for the next twelve months; this child theme would accordingly be most potentially useful over the next twelve months and the current length of the theme queue would likely cut into a significant amount of that time.
  • It proposes an alternative approach for multi-part pages, which are being considered as a core feature in https://core.trac.wordpress.org/ticket/37974. Having a child theme in the repo to expose a potential approach to users is a great way to get feedback for core. This approach is also different from the current direction of the core ticket; having a fully functional example of an alternative could help evaluating what approach ultimately makes the most sense for core. It's harder to get traction and real-world usage/testing there if this isn't in the theme repo yet, and the core project will likely move toward a core commit within the next few months.
  • Related to the above, this child theme is an example of a proposed approach for themes to implement dynamic multi-part pages discussed here: http://celloexpressions.com/blog/building-and-managing-dynamic-multi-part-pages-with-wordpress/. Knowing that it passes the theme review guidelines is an important step for developers to bring this functionality to more themes and more users. This theme has zero commercially-oriented intent/affiliation and is intended as a base for others to build off of.
  • Since it's a child theme with the narrowly-defined scope of changing the multi-part pages functionality and inherits the majority of the traditional "theme" behavior from Twenty Seventeen, the review shouldn't take long or much back-and-forth. The biggest potential issue is evaluating escaping in the custom menu walker, relative to what core (and in one case Twenty Fifteen) does and whether the TRT guidelines prefer anything stricter.

I'd prefer not to even ask about bypassing the queue or suggest that any theme is worthy of bypassing the hundreds already fairly waiting their turn; however, due to the queue's length and the circumstances around this particular theme I want to bring it up. No need to really discuss this further - that could easily take longer than actually reviewing it :) cc @jcastaneda since you had indicated there may be a possibility of doing this.

This ticket was mentioned in Slack in #core-themes by celloexpressions. View the logs.


6 months ago

#4 @joyously
3 months ago

I read your comments here, looked at the code, then tried the theme. I can't seem to get mine to look like your screenshot, even though I know there is a menu involved and Pages.
You need to add more documentation in Customizer to explain what is going on, and/or change your screenshot so it reflects what you get from the theme by default.

#5 @rabmalin
2 months ago

  • Keywords changed from theme-dynamic-seventeen, child-theme, parent-twentyseventeen, accessibility-ready to theme-dynamic-seventeen child-theme parent-twentyseventeen accessibility-ready
  • Owner set to rabmalin
  • Status changed from new to reviewing

#6 @rabmalin
2 months ago

Hello,

Please reupload your theme after fixing issues. https://wordpress.org/themes/upload/

Issues

  • REQUIRED: Remove @import for loading parent theme CSS. Please enqueue it properly.
  • REQUIRED: require_once( 'class-dynamic-seventeen-content-menu-walker.php' ); - Use get_template_directory() to load non-template PHP files.
  • REQUIRED: class-dynamic-seventeen-content-menu-walker.php L146. Use text domain dynamic-seventeen.
  • REQUIRED: readme - Please keep full image URL of that used in the screenshot.

Please respond within 7 days. If there is no response for 7 days, ticket will be closed as not-approved.

#7 @celloexpressions
2 months ago

Thanks @rabmalin and @joyously, I'll work on an update later today.

The image in the screenshot is original, is it necessary to say anything about that in the readme?

#8 @celloexpressions
2 months ago

Can you clarify why get_template_directory() (which would be get_stylesheet_directory() in this case) is required, and where this is documented? The required file is in the same directory that it's being required from, so this isn't necessary.

#9 @rabmalin
2 months ago

Re: image- If image is taken by you then please keep copyright info and declare license for the image.
Yes, "get_stylesheet_directory" should be used. https://wordpress.slack.com/archives/themereview/p1472143987004553

#10 @themetracbot
2 months ago

  • Summary changed from THEME: Dynamic Seventeen – 1.0 to THEME: Dynamic Seventeen – 1.1

Dynamic Seventeen - 1.1

Twenty Seventeen child theme with a dynamic front page and page template. Showcase your content with dynamic multi-part pages integrating all content types in a unified experience. To make a page dynamic, use the &#8220;Dynamic Content&#8221; page template, then add a menu to the associated menu location to manage its content. Any content can be included in a dynamic page, including posts of any type (including pages), taxonomy terms, and even custom links with arbitrary text via menu item descriptions.

Theme URL - https://github.com/celloexpressions/dynamic-seventeen
Author URL - http://nick.halsey.co/

Trac Browser - https://themes.trac.wordpress.org/browser/dynamic-seventeen/1.1

SVN - https://themes.svn.wordpress.org/dynamic-seventeen/1.1
ZIP - https://wordpress.org/themes/download/dynamic-seventeen.1.1.zip?nostats=1
Parent Theme: https://wordpress.org/themes/twentyseventeen

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=dynamic-seventeen/1.0&new_path=dynamic-seventeen/1.1

History:


https://themes.svn.wordpress.org/dynamic-seventeen/1.1/screenshot.png
Theme Check Results:

  • REQUIRED: Could not find wp_footer. See: wp_footer
     &lt;?php wp_footer(); ?&gt;
    
  • REQUIRED: Could not find wp_head. See: wp_head
     &lt;?php wp_head(); ?&gt;
    
  • REQUIRED: Could not find language_attributes. See: language_attributes
    &lt;html &lt;?php language_attributes(); ?&gt;
    
  • REQUIRED: Could not find charset. There must be a charset defined in the Content-Type or the meta charset tag in the head.
  • REQUIRED: Could not find add_theme_support( 'automatic-feed-links' ). See: add_theme_support
     &lt;?php add_theme_support( $feature ); ?&gt;
    
  • REQUIRED: Could not find comments_template. See: comments_template
     &lt;?php comments_template( $file, $separate_comments ); ?&gt;
    
  • REQUIRED: Could not find wp_list_comments. See: wp_list_comments
     &lt;?php wp_list_comments( $args ); ?&gt;
    
  • REQUIRED: Could not find comment_form. See: comment_form
     &lt;?php comment_form(); ?&gt;
    
  • REQUIRED: Could not find body_class call in body tag. See: body_class
     &lt;?php body_class( $class ); ?&gt;
    
  • REQUIRED: Could not find wp_link_pages. See: wp_link_pages
     &lt;?php wp_link_pages( $args ); ?&gt;
    
  • REQUIRED: The theme doesn't have comment pagination code in it. Use paginate_comments_links() or the_comments_navigation or the_comments_pagination or next_comments_link() and previous_comments_link() to add comment pagination.
  • REQUIRED: No content width has been defined. Example:
    if ( ! isset( $content_width ) ) $content_width = 900;
    
  • REQUIRED: Found a Customizer setting that did not have a sanitization callback function. Every call to the add_setting() method needs to have a sanitization callback function passed.
  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • WARNING: Could not find the file index.php in the theme.
  • REQUIRED: This theme doesn't seem to support the standard avatar functions. Use get_avatar or wp_list_comments to add this support.
  • REQUIRED: The theme doesn't have post pagination code in it. Use posts_nav_link() or paginate_links() or the_posts_pagination() or the_posts_navigation() or next_posts_link() and previous_posts_link() to add post pagination.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
  • RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( "post-thumbnails" )in the functions.php file.
  • REQUIRED: .sticky css class is needed in your theme css.
  • REQUIRED: .bypostauthor css class is needed in your theme css.
  • REQUIRED: .alignleft css class is needed in your theme css.
  • REQUIRED: .alignright css class is needed in your theme css.
  • REQUIRED: .aligncenter css class is needed in your theme css.
  • REQUIRED: .wp-caption css class is needed in your theme css.
  • REQUIRED: .wp-caption-text css class is needed in your theme css.
  • REQUIRED: .gallery-caption css class is needed in your theme css.
  • REQUIRED: .screen-reader-text css class is needed in your theme css. See See: the Codex for an example implementation.
  • REQUIRED: This theme doesn't seem to display tags. Modify it to display tags in appropriate locations.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are dynamic-seventeen, twentyseventeen
  • REQUIRED: No reference to add_theme_support( "title-tag" ) was found in the theme.
  • REQUIRED: The theme must not used the &lt;title&gt; tags.
  • REQUIRED: The theme must not call to wp_title().
  • RECOMMENDED: This theme contains no sidebars/widget areas. See Widgets API

#11 @celloexpressions
2 months ago

Sorry, your reply missed my update timing just slightly. I can add an explicit mention of the image in the next update if it really needs to be mentioned, but I would understand that the portion of the image visible in the screenshot is implicitly licensed as GPL along with the theme seeing as it's part of the theme files. I don't think there should be any issue here.

Commits for the update are here: https://github.com/celloexpressions/dynamic-seventeen/commits/master

#12 @rabmalin
2 months ago

Issues

  • REQUIRED: functions.php L111 - Use text domain dynamic-seventeen.
  • REQUIRED: functions.php L8 - Please prefix style handle with theme slug.
  • REQUIRED: functions.php L91 - Found a Customizer setting that did not have a sanitization callback function. Every call to the add_setting() method needs to have a sanitization callback function passed.
  • REQUIRED: If image is taken by you then please keep copyright info and declare license for the image. License should be GPL compatible.

#13 @themetracbot
2 months ago

  • Summary changed from THEME: Dynamic Seventeen – 1.1 to THEME: Dynamic Seventeen – 1.1.1

Dynamic Seventeen - 1.1.1

Twenty Seventeen child theme with a dynamic front page and page template. Showcase your content with dynamic multi-part pages integrating all content types in a unified experience. To make a page dynamic, use the &#8220;Dynamic Content&#8221; page template, then add a menu to the associated menu location to manage its content. Any content can be included in a dynamic page, including posts of any type (including pages), taxonomy terms, and even custom links with arbitrary text via menu item descriptions.

Theme URL - https://github.com/celloexpressions/dynamic-seventeen
Author URL - http://nick.halsey.co/

Trac Browser - https://themes.trac.wordpress.org/browser/dynamic-seventeen/1.1.1

SVN - https://themes.svn.wordpress.org/dynamic-seventeen/1.1.1
ZIP - https://wordpress.org/themes/download/dynamic-seventeen.1.1.1.zip?nostats=1
Parent Theme: https://wordpress.org/themes/twentyseventeen

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=dynamic-seventeen/1.1&new_path=dynamic-seventeen/1.1.1

History:


https://themes.svn.wordpress.org/dynamic-seventeen/1.1.1/screenshot.png
Theme Check Results:

  • REQUIRED: Could not find wp_footer. See: wp_footer
     &lt;?php wp_footer(); ?&gt;
    
  • REQUIRED: Could not find wp_head. See: wp_head
     &lt;?php wp_head(); ?&gt;
    
  • REQUIRED: Could not find language_attributes. See: language_attributes
    &lt;html &lt;?php language_attributes(); ?&gt;
    
  • REQUIRED: Could not find charset. There must be a charset defined in the Content-Type or the meta charset tag in the head.
  • REQUIRED: Could not find add_theme_support( 'automatic-feed-links' ). See: add_theme_support
     &lt;?php add_theme_support( $feature ); ?&gt;
    
  • REQUIRED: Could not find comments_template. See: comments_template
     &lt;?php comments_template( $file, $separate_comments ); ?&gt;
    
  • REQUIRED: Could not find wp_list_comments. See: wp_list_comments
     &lt;?php wp_list_comments( $args ); ?&gt;
    
  • REQUIRED: Could not find comment_form. See: comment_form
     &lt;?php comment_form(); ?&gt;
    
  • REQUIRED: Could not find body_class call in body tag. See: body_class
     &lt;?php body_class( $class ); ?&gt;
    
  • REQUIRED: Could not find wp_link_pages. See: wp_link_pages
     &lt;?php wp_link_pages( $args ); ?&gt;
    
  • REQUIRED: The theme doesn't have comment pagination code in it. Use paginate_comments_links() or the_comments_navigation or the_comments_pagination or next_comments_link() and previous_comments_link() to add comment pagination.
  • REQUIRED: No content width has been defined. Example:
    if ( ! isset( $content_width ) ) $content_width = 900;
    
  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • WARNING: Could not find the file index.php in the theme.
  • REQUIRED: This theme doesn't seem to support the standard avatar functions. Use get_avatar or wp_list_comments to add this support.
  • REQUIRED: The theme doesn't have post pagination code in it. Use posts_nav_link() or paginate_links() or the_posts_pagination() or the_posts_navigation() or next_posts_link() and previous_posts_link() to add post pagination.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
  • RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( "post-thumbnails" )in the functions.php file.
  • REQUIRED: .sticky css class is needed in your theme css.
  • REQUIRED: .bypostauthor css class is needed in your theme css.
  • REQUIRED: .alignleft css class is needed in your theme css.
  • REQUIRED: .alignright css class is needed in your theme css.
  • REQUIRED: .aligncenter css class is needed in your theme css.
  • REQUIRED: .wp-caption css class is needed in your theme css.
  • REQUIRED: .wp-caption-text css class is needed in your theme css.
  • REQUIRED: .gallery-caption css class is needed in your theme css.
  • REQUIRED: .screen-reader-text css class is needed in your theme css. See See: the Codex for an example implementation.
  • REQUIRED: This theme doesn't seem to display tags. Modify it to display tags in appropriate locations.
  • REQUIRED: No reference to add_theme_support( "title-tag" ) was found in the theme.
  • REQUIRED: The theme must not used the &lt;title&gt; tags.
  • REQUIRED: The theme must not call to wp_title().
  • RECOMMENDED: This theme contains no sidebars/widget areas. See Widgets API

#14 @rabmalin
2 months ago

Theme review is completed from my side. Now a11y review will be done by @joedolson
As styling is not much changed, I believe it wont take much time for a11y review. After it is a11y approved, I will set theme live.

#15 @joedolson
2 months ago

On it! Thanks for pinging me.

#16 @joedolson
2 months ago

Just one change I'd like to see. On a page selected for dynamic content, each page gets a heading, but they're all equal at H2, and there's no H1 on the page. I'd like to see the primary page (the one you're actually editing) have an H1, with the dynamic menu pages using H2. It doesn't have to look different, but structurally this would help a lot for the headings architecture.

#17 @celloexpressions
2 months ago

Good catch, thanks @joedolson. Should the recent post titles be changed from h2 to h3 or is it better for them to stay as h2 since they're within article and header tags?

#18 @joedolson
2 months ago

Not sure about the exact context you're referring to. I'm referring to the headings for 'Home', 'Blog', etc., as seen on this demo page: http://dev.josephdolson.com/wp-test/about/page-image-alignment/, where 'Page Image Alignment' is the current page. Page Image Alignment should be an H1, the other headings should be H2.

It doesn't make any difference that they're within article or header tags. That wouldn't have any impact on the heading's hierarchy. You may be referring to the unsupported outline algorithm: https://www.w3.org/TR/html5/sections.html#outlines

#19 @celloexpressions
2 months ago

It looks like that's actually an issue with a template in Twenty Seventeen, so I'll make a core trac ticket for that. When the blog page or any taxonomy is featured, recent post titles are displayed, but they use <h2>, matching the selected object's title, rather than providing another level of hierarchy.

#20 @joedolson
2 months ago

Interesting. If that requires a change to the parent theme, I'll let it through. It's not an issue that causes a massive break in accessibility; it's more a formalist issue than a pragmatic one. Please do raise the issue in Twenty Seventeen, however, so it gets looked at there!

Approved for accessibility-ready!

Best,
Joe

#21 @themetracbot
2 months ago

  • Summary changed from THEME: Dynamic Seventeen – 1.1.1 to THEME: Dynamic Seventeen – 1.1.2

Dynamic Seventeen - 1.1.2

Twenty Seventeen child theme with a dynamic front page and page template. Showcase your content with dynamic multi-part pages integrating all content types in a unified experience. To make a page dynamic, use the &#8220;Dynamic Content&#8221; page template, then add a menu to the associated menu location to manage its content. Any content can be included in a dynamic page, including posts of any type (including pages), taxonomy terms, and even custom links with arbitrary text via menu item descriptions.

Theme URL - https://github.com/celloexpressions/dynamic-seventeen
Author URL - http://nick.halsey.co/

Trac Browser - https://themes.trac.wordpress.org/browser/dynamic-seventeen/1.1.2

SVN - https://themes.svn.wordpress.org/dynamic-seventeen/1.1.2
ZIP - https://wordpress.org/themes/download/dynamic-seventeen.1.1.2.zip?nostats=1
Parent Theme: https://wordpress.org/themes/twentyseventeen

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=dynamic-seventeen/1.1.1&new_path=dynamic-seventeen/1.1.2

History:


https://themes.svn.wordpress.org/dynamic-seventeen/1.1.2/screenshot.png
Theme Check Results:

  • REQUIRED: Could not find wp_footer. See: wp_footer
     &lt;?php wp_footer(); ?&gt;
    
  • REQUIRED: Could not find wp_head. See: wp_head
     &lt;?php wp_head(); ?&gt;
    
  • REQUIRED: Could not find language_attributes. See: language_attributes
    &lt;html &lt;?php language_attributes(); ?&gt;
    
  • REQUIRED: Could not find charset. There must be a charset defined in the Content-Type or the meta charset tag in the head.
  • REQUIRED: Could not find add_theme_support( 'automatic-feed-links' ). See: add_theme_support
     &lt;?php add_theme_support( $feature ); ?&gt;
    
  • REQUIRED: Could not find comments_template. See: comments_template
     &lt;?php comments_template( $file, $separate_comments ); ?&gt;
    
  • REQUIRED: Could not find wp_list_comments. See: wp_list_comments
     &lt;?php wp_list_comments( $args ); ?&gt;
    
  • REQUIRED: Could not find comment_form. See: comment_form
     &lt;?php comment_form(); ?&gt;
    
  • REQUIRED: Could not find body_class call in body tag. See: body_class
     &lt;?php body_class( $class ); ?&gt;
    
  • REQUIRED: Could not find wp_link_pages. See: wp_link_pages
     &lt;?php wp_link_pages( $args ); ?&gt;
    
  • REQUIRED: The theme doesn't have comment pagination code in it. Use paginate_comments_links() or the_comments_navigation or the_comments_pagination or next_comments_link() and previous_comments_link() to add comment pagination.
  • REQUIRED: No content width has been defined. Example:
    if ( ! isset( $content_width ) ) $content_width = 900;
    
  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • WARNING: Could not find the file index.php in the theme.
  • REQUIRED: This theme doesn't seem to support the standard avatar functions. Use get_avatar or wp_list_comments to add this support.
  • REQUIRED: The theme doesn't have post pagination code in it. Use posts_nav_link() or paginate_links() or the_posts_pagination() or the_posts_navigation() or next_posts_link() and previous_posts_link() to add post pagination.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
  • RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( "post-thumbnails" )in the functions.php file.
  • REQUIRED: .sticky css class is needed in your theme css.
  • REQUIRED: .bypostauthor css class is needed in your theme css.
  • REQUIRED: .alignleft css class is needed in your theme css.
  • REQUIRED: .alignright css class is needed in your theme css.
  • REQUIRED: .aligncenter css class is needed in your theme css.
  • REQUIRED: .wp-caption css class is needed in your theme css.
  • REQUIRED: .wp-caption-text css class is needed in your theme css.
  • REQUIRED: .gallery-caption css class is needed in your theme css.
  • REQUIRED: .screen-reader-text css class is needed in your theme css. See See: the Codex for an example implementation.
  • REQUIRED: This theme doesn't seem to display tags. Modify it to display tags in appropriate locations.
  • REQUIRED: No reference to add_theme_support( "title-tag" ) was found in the theme.
  • REQUIRED: The theme must not used the &lt;title&gt; tags.
  • REQUIRED: The theme must not call to wp_title().
  • RECOMMENDED: This theme contains no sidebars/widget areas. See Widgets API

#22 @themetracbot
2 months ago

  • Summary changed from THEME: Dynamic Seventeen – 1.1.2 to THEME: Dynamic Seventeen – 1.1.3

Dynamic Seventeen - 1.1.3

Twenty Seventeen child theme with a dynamic front page and page template. Showcase your content with dynamic multi-part pages integrating all content types in a unified experience. To make a page dynamic, use the &#8220;Dynamic Content&#8221; page template, then add a menu to the associated menu location to manage its content. Any content can be included in a dynamic page, including posts of any type (including pages), taxonomy terms, and even custom links with arbitrary text via menu item descriptions.

Theme URL - https://github.com/celloexpressions/dynamic-seventeen
Author URL - http://nick.halsey.co/

Trac Browser - https://themes.trac.wordpress.org/browser/dynamic-seventeen/1.1.3

SVN - https://themes.svn.wordpress.org/dynamic-seventeen/1.1.3
ZIP - https://wordpress.org/themes/download/dynamic-seventeen.1.1.3.zip?nostats=1
Parent Theme: https://wordpress.org/themes/twentyseventeen

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=dynamic-seventeen/1.1.2&new_path=dynamic-seventeen/1.1.3

History:


https://themes.svn.wordpress.org/dynamic-seventeen/1.1.3/screenshot.png
Theme Check Results:

  • REQUIRED: Could not find wp_footer. See: wp_footer
     &lt;?php wp_footer(); ?&gt;
    
  • REQUIRED: Could not find wp_head. See: wp_head
     &lt;?php wp_head(); ?&gt;
    
  • REQUIRED: Could not find language_attributes. See: language_attributes
    &lt;html &lt;?php language_attributes(); ?&gt;
    
  • REQUIRED: Could not find charset. There must be a charset defined in the Content-Type or the meta charset tag in the head.
  • REQUIRED: Could not find add_theme_support( 'automatic-feed-links' ). See: add_theme_support
     &lt;?php add_theme_support( $feature ); ?&gt;
    
  • REQUIRED: Could not find comments_template. See: comments_template
     &lt;?php comments_template( $file, $separate_comments ); ?&gt;
    
  • REQUIRED: Could not find wp_list_comments. See: wp_list_comments
     &lt;?php wp_list_comments( $args ); ?&gt;
    
  • REQUIRED: Could not find comment_form. See: comment_form
     &lt;?php comment_form(); ?&gt;
    
  • REQUIRED: Could not find body_class call in body tag. See: body_class
     &lt;?php body_class( $class ); ?&gt;
    
  • REQUIRED: Could not find wp_link_pages. See: wp_link_pages
     &lt;?php wp_link_pages( $args ); ?&gt;
    
  • REQUIRED: The theme doesn't have comment pagination code in it. Use paginate_comments_links() or the_comments_navigation or the_comments_pagination or next_comments_link() and previous_comments_link() to add comment pagination.
  • REQUIRED: No content width has been defined. Example:
    if ( ! isset( $content_width ) ) $content_width = 900;
    
  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • WARNING: Could not find the file index.php in the theme.
  • REQUIRED: This theme doesn't seem to support the standard avatar functions. Use get_avatar or wp_list_comments to add this support.
  • REQUIRED: The theme doesn't have post pagination code in it. Use posts_nav_link() or paginate_links() or the_posts_pagination() or the_posts_navigation() or next_posts_link() and previous_posts_link() to add post pagination.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
  • RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( "post-thumbnails" )in the functions.php file.
  • REQUIRED: .sticky css class is needed in your theme css.
  • REQUIRED: .bypostauthor css class is needed in your theme css.
  • REQUIRED: .alignleft css class is needed in your theme css.
  • REQUIRED: .alignright css class is needed in your theme css.
  • REQUIRED: .aligncenter css class is needed in your theme css.
  • REQUIRED: .wp-caption css class is needed in your theme css.
  • REQUIRED: .wp-caption-text css class is needed in your theme css.
  • REQUIRED: .gallery-caption css class is needed in your theme css.
  • REQUIRED: .screen-reader-text css class is needed in your theme css. See See: the Codex for an example implementation.
  • REQUIRED: This theme doesn't seem to display tags. Modify it to display tags in appropriate locations.
  • REQUIRED: No reference to add_theme_support( "title-tag" ) was found in the theme.
  • REQUIRED: The theme must not used the &lt;title&gt; tags.
  • REQUIRED: The theme must not call to wp_title().
  • RECOMMENDED: This theme contains no sidebars/widget areas. See Widgets API

#23 @rabmalin
7 weeks ago

  • Resolution set to live
  • Status changed from reviewing to closed

Approving and setting live. It will take around 1 hour for theme to appear in the directory. Good luck!

Note: See TracTickets for help on using tickets.