WordPress.org

Make WordPress Themes

Opened 8 months ago

Closed 5 months ago

#38651 closed theme (not-approved)

THEME: Jinux Base – 1.0.0

Reported by: jhjinks Owned by: acosmin
Priority: new theme Keywords: theme-jinux-base
Cc: jhjinks61@…

Description

Jinux Base - 1.0.0

Jinux Base is a Personal WordPress Blog Theme

Theme URL -
Author URL - https://profiles.wordpress.org/jinuxweb

SVN - https://themes.svn.wordpress.org/jinux-base/1.0.0
ZIP - https://wordpress.org/themes/download/jinux-base.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#38651 THEME: Jinux Base – 1.0.0 closed not-approved acosmin

(this ticket)


https://themes.svn.wordpress.org/jinux-base/1.0.0/screenshot.png

Change History (3)

#1 @joyously
6 months ago

  • WARNING: wp-includes/class-wp-hook.php:298 - call_user_func_array() expects parameter 1 to be a valid callback, function 'jinuxtheme_header_style' not found or invalid function name
  • The theme is only showing one level of submenu for the main menu. This should be documented.
  • The theme tags 'one-column' and 'right-sidebar' are both listed, but the right sidebar is in its own column.
  • The theme tag 'footer-widgets' is used, but no footer widget area is provided and no widgets are provided.
  • The site tagline is showing with a font size of 7.5px. It is almost unreadable.
  • The > character used to open and close the main menu submenus are okay on desktop, but don't change size on smaller screens. I think they are too small for use with a finger. It's also not intuitive to click those and not the words.
  • On a small screen, the hamburger icon opens the menu. But it can't close the menu because it is covered by the menu item on the same row when hovered. This isn't about mobile which has no hover, but about small screens and using a mouse.
  • It seems inconsistent to show breadcrumbs only on single post, archive, and child pages, but not the 'latest posts' page (it's a top-level Page) or the search results. And those breadcrumbs aren't that useful (mostly Home is linked).

#2 @acosmin
5 months ago

  • Owner set to acosmin
  • Status changed from new to reviewing
  1. No PHP or JS notices.

Warning: call_user_func_array() expects parameter 1 to be a valid callback, function 'jinuxtheme_header_style' not found or invalid function name in PATH\wp-includes\class-wp-hook.php on line 298

  1. Found usage of constant "HEADER_TEXTCOLOR". Use add_theme_support( 'custom-header' ) instead.
  1. functions.php
    • L82 needs a prefix
    • L213-228 - remove, not allowed
  1. inc\jinuxtheme-custom-breadcrumbs.php
    • doesn't work for all cases and you have a lot of escaping issues in it. Try something like this and if you use it, don't forget to prefix it.
    • what is line 105 doing in this file?
  1. Plugin teritorry, please remove:
    • js\embed-youtube.js
    • rem.js - check
  1. footer.php
    • Remove L18,19
    • You can't add your link there, L23
    • Remove 2013 -
    • Change date('Y') with date_i18n( esc_html__( 'Y', 'jinux-base' ) )
    • You are allowed only one link in the footer, and it should be in this format
  1. Update your readme.txt file
    • versions
    • Add license information for any assets used, check your js folder example also the image used in the screenshot.
  1. The Author URL does not exist.
Last edited 5 months ago by acosmin (previous) (diff)

#3 @acosmin
5 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

No answer from the author in 7 days.

Note: See TracTickets for help on using tickets.