WordPress.org

Make WordPress Themes

Opened 10 months ago

Closed 5 months ago

#38774 closed theme (live)

THEME: Eins – 1.04

Reported by: luchino__ Owned by: maneshtimilsina
Priority: new theme Keywords: theme-eins child-theme parent-twentythirteen
Cc: chiharu.nagatomi@…

Description

Eins - 1.0

child theme for the Twenty Thirteen theme.

Theme URL -
Author URL - https://profiles.wordpress.org/luchino_

SVN - https://themes.svn.wordpress.org/eins/1.0
ZIP - https://wordpress.org/themes/download/eins.1.0.zip?nostats=1
Parent Theme: https://wordpress.org/themes/twentythirteen

History:

Ticket Summary Status Resolution Owner
#38774 THEME: Eins – 1.04 closed live maneshtimilsina

(this ticket)

#43536 THEME: Eins – 1.04.1 closed live themetracbot
#44221 THEME: Eins – 1.04.2 closed live themetracbot


https://themes.svn.wordpress.org/eins/1.0/screenshot.png
Theme Check Results:

  • REQUIRED: Could not find wp_footer. See: wp_footer
     <?php wp_footer(); ?>
    
  • REQUIRED: Could not find wp_head. See: wp_head
     <?php wp_head(); ?>
    
  • REQUIRED: Could not find language_attributes. See: language_attributes
    <html <?php language_attributes(); ?>
    
  • REQUIRED: Could not find charset. There must be a charset defined in the Content-Type or the meta charset tag in the head.
  • REQUIRED: Could not find add_theme_support( 'automatic-feed-links' ). See: add_theme_support
     <?php add_theme_support( $feature ); ?>
    
  • REQUIRED: Could not find comments_template. See: comments_template
     <?php comments_template( $file, $separate_comments ); ?>
    
  • REQUIRED: Could not find wp_list_comments. See: wp_list_comments
     <?php wp_list_comments( $args ); ?>
    
  • REQUIRED: Could not find comment_form. See: comment_form
     <?php comment_form(); ?>
    
  • REQUIRED: Could not find body_class call in body tag. See: body_class
     <?php body_class( $class ); ?>
    
  • REQUIRED: Could not find wp_link_pages. See: wp_link_pages
     <?php wp_link_pages( $args ); ?>
    
  • REQUIRED: Could not find post_class. See: post_class
     <div id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
    
  • REQUIRED: The theme doesn't have comment pagination code in it. Use paginate_comments_links() or the_comments_navigation or the_comments_pagination or next_comments_link() and previous_comments_link() to add comment pagination.
  • REQUIRED: No content width has been defined. Example:
    if ( ! isset( $content_width ) ) $content_width = 900;
    
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • WARNING: Could not find the file index.php in the theme.
  • REQUIRED: This theme doesn't seem to support the standard avatar functions. Use get_avatar or wp_list_comments to add this support.
  • RECOMMENDED: No reference to nav_menu's was found in the theme. Note that if your theme has a menu bar, it is required to use the WordPress nav_menu functionality for it.
  • REQUIRED: The theme doesn't have post pagination code in it. Use posts_nav_link() or paginate_links() or the_posts_pagination() or the_posts_navigation() or next_posts_link() and previous_posts_link() to add post pagination.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
  • RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( "post-thumbnails" )in the functions.php file.
  • REQUIRED: Text Domain: is missing from your style.css header.
  • REQUIRED: .sticky css class is needed in your theme css.
  • REQUIRED: .bypostauthor css class is needed in your theme css.
  • REQUIRED: .alignleft css class is needed in your theme css.
  • REQUIRED: .alignright css class is needed in your theme css.
  • REQUIRED: .aligncenter css class is needed in your theme css.
  • REQUIRED: .screen-reader-text css class is needed in your theme css. See See: the Codex for an example implementation.
  • RECOMMENDED: Theme URI: is missing from your style.css header.
  • REQUIRED: This theme doesn't seem to display tags. Modify it to display tags in appropriate locations.
  • REQUIRED: No reference to add_theme_support( "title-tag" ) was found in the theme.
  • REQUIRED: The theme must not used the <title> tags.
  • REQUIRED: The theme must not call to wp_title().
  • RECOMMENDED: This theme contains no sidebars/widget areas. See Widgets API

Change History (22)

#1 @themetracbot
7 months ago

  • Owner set to mikebarlow
  • Status changed from new to reviewing

#2 @mikebarlow
7 months ago

Hi luchino

My name is Mike, and I'll be reviewing your theme.

Required fixes:
Your theme's CSS file is missing the TextDomain identifier
The theme does not contain a License.txt file. You must declare the licenses for any resources used in your theme including fonts and images.

Recommended fixes:
The nav bar seems off-centre - the links could be centered and the search bar opened over the top
Images in the text body that are left or right aligned break out of the container.
The footer can grow to unlimited size - if a large number of date archive links exist, all of them will be shown in a list on the footer.
On mobile screen sizes, the comments form is the full width of the screen with no padding

If you can fix these issues and resubmit, I can take another look.

Mike

#3 @djrmom
7 months ago

  • Keywords changed from theme-eins, child-theme, parent-twentythirteen to theme-eins child-theme parent-twentythirteen

@luchino, you are required to communicate within 7 days of review. Please upload changes or comment to let us know you need more time or this ticket will be closed. Thanks.

#4 @luchino__
7 months ago

I'm sorry I did not notice. I need more time for fix this theme. Please wait for some time.

#5 @djrmom
6 months ago

@luchino , please give an update on your progress to keep the ticket open. Please comment at least every 7 days to let us know you are still working on it. Thanks.

#6 follow-up: @themetracbot
6 months ago

  • Summary changed from THEME: Eins – 1.0 to THEME: Eins – 1.01

Eins - 1.01

child theme for the Twenty Thirteen theme.

Theme URL -
Author URL - https://profiles.wordpress.org/luchino_

Trac Browser - https://themes.trac.wordpress.org/browser/eins/1.01

SVN - https://themes.svn.wordpress.org/eins/1.01
ZIP - https://wordpress.org/themes/download/eins.1.01.zip?nostats=1
Parent Theme: https://wordpress.org/themes/twentythirteen

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=eins/1.0&new_path=eins/1.01

History:

Ticket Summary Status Resolution Owner
#38774 THEME: Eins – 1.04 closed live maneshtimilsina

(this ticket)

#43536 THEME: Eins – 1.04.1 closed live themetracbot
#44221 THEME: Eins – 1.04.2 closed live themetracbot


https://themes.svn.wordpress.org/eins/1.01/screenshot.png
Theme Check Results:

  • REQUIRED: Could not find wp_footer. See: wp_footer
     <?php wp_footer(); ?>
    
  • REQUIRED: Could not find wp_head. See: wp_head
     <?php wp_head(); ?>
    
  • REQUIRED: Could not find language_attributes. See: language_attributes
    <html <?php language_attributes(); ?>
    
  • REQUIRED: Could not find charset. There must be a charset defined in the Content-Type or the meta charset tag in the head.
  • REQUIRED: Could not find add_theme_support( 'automatic-feed-links' ). See: add_theme_support
     <?php add_theme_support( $feature ); ?>
    
  • REQUIRED: Could not find comments_template. See: comments_template
     <?php comments_template( $file, $separate_comments ); ?>
    
  • REQUIRED: Could not find wp_list_comments. See: wp_list_comments
     <?php wp_list_comments( $args ); ?>
    
  • REQUIRED: Could not find comment_form. See: comment_form
     <?php comment_form(); ?>
    
  • REQUIRED: Could not find body_class call in body tag. See: body_class
     <?php body_class( $class ); ?>
    
  • REQUIRED: Could not find wp_link_pages. See: wp_link_pages
     <?php wp_link_pages( $args ); ?>
    
  • REQUIRED: Could not find post_class. See: post_class
     <div id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
    
  • REQUIRED: The theme doesn't have comment pagination code in it. Use paginate_comments_links() or the_comments_navigation or the_comments_pagination or next_comments_link() and previous_comments_link() to add comment pagination.
  • REQUIRED: No content width has been defined. Example:
    if ( ! isset( $content_width ) ) $content_width = 900;
    
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • WARNING: Could not find the file index.php in the theme.
  • REQUIRED: This theme doesn't seem to support the standard avatar functions. Use get_avatar or wp_list_comments to add this support.
  • RECOMMENDED: No reference to nav_menu's was found in the theme. Note that if your theme has a menu bar, it is required to use the WordPress nav_menu functionality for it.
  • REQUIRED: The theme doesn't have post pagination code in it. Use posts_nav_link() or paginate_links() or the_posts_pagination() or the_posts_navigation() or next_posts_link() and previous_posts_link() to add post pagination.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
  • RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( "post-thumbnails" )in the functions.php file.
  • REQUIRED: .sticky css class is needed in your theme css.
  • REQUIRED: .bypostauthor css class is needed in your theme css.
  • REQUIRED: .screen-reader-text css class is needed in your theme css. See See: the Codex for an example implementation.
  • RECOMMENDED: Theme URI: is missing from your style.css header.
  • REQUIRED: This theme doesn't seem to display tags. Modify it to display tags in appropriate locations.
  • REQUIRED: No reference to add_theme_support( "title-tag" ) was found in the theme.
  • REQUIRED: The theme must not used the <title> tags.
  • REQUIRED: The theme must not call to wp_title().
  • RECOMMENDED: This theme contains no sidebars/widget areas. See Widgets API

#7 in reply to: ↑ 6 @luchino__
6 months ago

Thank you for reviewing my theme and sorry for late reply.

I would like to tell you about your recommended fixes.
This is same as parent theme. So I didn't fix .

The nav bar seems off-centre - the links could be centered and the search bar opened over the top
The footer can grow to unlimited size - if a large number of date archive links exist, all of them will be shown in a list on the footer.

Thank you.

#8 @djrmom
6 months ago

  • Owner mikebarlow deleted

I am sorry this review is taking so long. Sometimes people are unable to carry on the review, this may have happened this time. As a result, I am going to add this to the new queue again as a priority. This may mean it still takes time, but will prevent this ticket being held for so long by a reviewer that isn't able to carry on. Thanks for your patience.

If you are the reviewer and able to do this review, please carry on and request you get added back in Slack #themereview or you can take on another review when you have time again.

#9 @themetracbot
6 months ago

  • Owner set to maneshtimilsina

#10 @maneshtimilsina
6 months ago

Hi @luchino

I am reviewing your theme. I will give my feedback within 2 days or so.

#11 @maneshtimilsina
6 months ago

Hi @luchino

I have found following issues in your theme. Please fix them and upload new version.

Issues

  • style.css - Value of Text Domain is not correct.
  • Function prefixing is not correct. eg, theme_enqueue_styles(), twentythirteen_setup_child()
  • In functions.php line 6, style handle parent-style should be prefixed.
  • For loading child theme style, enqueue it like this.
    wp_enqueue_style( 'eins-style', get_stylesheet_uri() );
    
  • In readme.txt file, keep full URL of image header.png and its license information.

#12 @maneshtimilsina
6 months ago

Hi @luchino

Are you working on issues I have listed? Its been 5 days and you are not responding ticket. Note that if you do not respond ticket within 7 days it might get closed. If you are still working let me know.

Thanks.

#13 @luchino__
6 months ago

Sorry. I don't have time on weekdays I will work at the weekend. Please wait for some time.

#14 @themetracbot
6 months ago

  • Summary changed from THEME: Eins – 1.01 to THEME: Eins – 1.02

Eins - 1.02

child theme for the Twenty Thirteen theme.

Theme URL -
Author URL - https://profiles.wordpress.org/luchino_

Trac Browser - https://themes.trac.wordpress.org/browser/eins/1.02

SVN - https://themes.svn.wordpress.org/eins/1.02
ZIP - https://wordpress.org/themes/download/eins.1.02.zip?nostats=1
Parent Theme: https://wordpress.org/themes/twentythirteen

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=eins/1.01&new_path=eins/1.02

History:

Ticket Summary Status Resolution Owner
#38774 THEME: Eins – 1.04 closed live maneshtimilsina

(this ticket)

#43536 THEME: Eins – 1.04.1 closed live themetracbot
#44221 THEME: Eins – 1.04.2 closed live themetracbot


https://themes.svn.wordpress.org/eins/1.02/screenshot.png
Theme Check Results:

  • REQUIRED: Could not find wp_footer. See: wp_footer
     <?php wp_footer(); ?>
    
  • REQUIRED: Could not find wp_head. See: wp_head
     <?php wp_head(); ?>
    
  • REQUIRED: Could not find language_attributes. See: language_attributes
    <html <?php language_attributes(); ?>
    
  • REQUIRED: Could not find charset. There must be a charset defined in the Content-Type or the meta charset tag in the head.
  • REQUIRED: Could not find add_theme_support( 'automatic-feed-links' ). See: add_theme_support
     <?php add_theme_support( $feature ); ?>
    
  • REQUIRED: Could not find comments_template. See: comments_template
     <?php comments_template( $file, $separate_comments ); ?>
    
  • REQUIRED: Could not find wp_list_comments. See: wp_list_comments
     <?php wp_list_comments( $args ); ?>
    
  • REQUIRED: Could not find comment_form. See: comment_form
     <?php comment_form(); ?>
    
  • REQUIRED: Could not find body_class call in body tag. See: body_class
     <?php body_class( $class ); ?>
    
  • REQUIRED: Could not find wp_link_pages. See: wp_link_pages
     <?php wp_link_pages( $args ); ?>
    
  • REQUIRED: Could not find post_class. See: post_class
     <div id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
    
  • REQUIRED: The theme doesn't have comment pagination code in it. Use paginate_comments_links() or the_comments_navigation or the_comments_pagination or next_comments_link() and previous_comments_link() to add comment pagination.
  • REQUIRED: No content width has been defined. Example:
    if ( ! isset( $content_width ) ) $content_width = 900;
    
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • WARNING: .ds_store Hidden Files or Folders found.
  • WARNING: Could not find the file index.php in the theme.
  • REQUIRED: This theme doesn't seem to support the standard avatar functions. Use get_avatar or wp_list_comments to add this support.
  • RECOMMENDED: No reference to nav_menu's was found in the theme. Note that if your theme has a menu bar, it is required to use the WordPress nav_menu functionality for it.
  • REQUIRED: The theme doesn't have post pagination code in it. Use posts_nav_link() or paginate_links() or the_posts_pagination() or the_posts_navigation() or next_posts_link() and previous_posts_link() to add post pagination.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
  • RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( "post-thumbnails" )in the functions.php file.
  • REQUIRED: .sticky css class is needed in your theme css.
  • REQUIRED: .bypostauthor css class is needed in your theme css.
  • REQUIRED: .screen-reader-text css class is needed in your theme css. See See: the Codex for an example implementation.
  • RECOMMENDED: Theme URI: is missing from your style.css header.
  • REQUIRED: This theme doesn't seem to display tags. Modify it to display tags in appropriate locations.
  • REQUIRED: No reference to add_theme_support( "title-tag" ) was found in the theme.
  • REQUIRED: The theme must not used the <title> tags.
  • REQUIRED: The theme must not call to wp_title().
  • RECOMMENDED: This theme contains no sidebars/widget areas. See Widgets API

#15 follow-up: @maneshtimilsina
6 months ago

Hi @luchino

It looks like you have not properly checked issues I have listed. I am listing them again with more description and example. Please fix them and upload new version.

Issues

  • Function prefixing is not correct. theme_enqueue_styles() and twentythirteen_setup_child() should be prefixed with theme slug. Please use eins_theme_enqueue_styles() and eins_twentythirteen_setup_child()
  • In line 6 of functions.php handler should be prefixed. Please use eins-parent-style instead of parent-style
  • In line 7 of functions.php handler should be prefixed. Please use eins-child-style instead of child-style
  • In line 20 of readme.txt change name from Ascendant to Eins
  • In readme.txt file, keep full URL of image header.png and its license information. You can follow this format:

- header.png

License: GPLv2 General Public License
Source - https://pixabay.com/en/imageused


#16 @themetracbot
5 months ago

  • Summary changed from THEME: Eins – 1.02 to THEME: Eins – 1.03

Eins - 1.03

child theme for the Twenty Thirteen theme.

Theme URL -
Author URL - https://profiles.wordpress.org/luchino_

Trac Browser - https://themes.trac.wordpress.org/browser/eins/1.03

SVN - https://themes.svn.wordpress.org/eins/1.03
ZIP - https://wordpress.org/themes/download/eins.1.03.zip?nostats=1
Parent Theme: https://wordpress.org/themes/twentythirteen

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=eins/1.02&new_path=eins/1.03

History:

Ticket Summary Status Resolution Owner
#38774 THEME: Eins – 1.04 closed live maneshtimilsina

(this ticket)

#43536 THEME: Eins – 1.04.1 closed live themetracbot
#44221 THEME: Eins – 1.04.2 closed live themetracbot


https://themes.svn.wordpress.org/eins/1.03/screenshot.png
Theme Check Results:

  • REQUIRED: Could not find wp_footer. See: wp_footer
     <?php wp_footer(); ?>
    
  • REQUIRED: Could not find wp_head. See: wp_head
     <?php wp_head(); ?>
    
  • REQUIRED: Could not find language_attributes. See: language_attributes
    <html <?php language_attributes(); ?>
    
  • REQUIRED: Could not find charset. There must be a charset defined in the Content-Type or the meta charset tag in the head.
  • REQUIRED: Could not find add_theme_support( 'automatic-feed-links' ). See: add_theme_support
     <?php add_theme_support( $feature ); ?>
    
  • REQUIRED: Could not find comments_template. See: comments_template
     <?php comments_template( $file, $separate_comments ); ?>
    
  • REQUIRED: Could not find wp_list_comments. See: wp_list_comments
     <?php wp_list_comments( $args ); ?>
    
  • REQUIRED: Could not find comment_form. See: comment_form
     <?php comment_form(); ?>
    
  • REQUIRED: Could not find body_class call in body tag. See: body_class
     <?php body_class( $class ); ?>
    
  • REQUIRED: Could not find wp_link_pages. See: wp_link_pages
     <?php wp_link_pages( $args ); ?>
    
  • REQUIRED: Could not find post_class. See: post_class
     <div id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
    
  • REQUIRED: The theme doesn't have comment pagination code in it. Use paginate_comments_links() or the_comments_navigation or the_comments_pagination or next_comments_link() and previous_comments_link() to add comment pagination.
  • REQUIRED: No content width has been defined. Example:
    if ( ! isset( $content_width ) ) $content_width = 900;
    
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • WARNING: .ds_store Hidden Files or Folders found.
  • WARNING: Could not find the file index.php in the theme.
  • REQUIRED: This theme doesn't seem to support the standard avatar functions. Use get_avatar or wp_list_comments to add this support.
  • RECOMMENDED: No reference to nav_menu's was found in the theme. Note that if your theme has a menu bar, it is required to use the WordPress nav_menu functionality for it.
  • REQUIRED: The theme doesn't have post pagination code in it. Use posts_nav_link() or paginate_links() or the_posts_pagination() or the_posts_navigation() or next_posts_link() and previous_posts_link() to add post pagination.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
  • RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( "post-thumbnails" )in the functions.php file.
  • REQUIRED: .sticky css class is needed in your theme css.
  • REQUIRED: .bypostauthor css class is needed in your theme css.
  • REQUIRED: .screen-reader-text css class is needed in your theme css. See See: the Codex for an example implementation.
  • RECOMMENDED: Theme URI: is missing from your style.css header.
  • REQUIRED: This theme doesn't seem to display tags. Modify it to display tags in appropriate locations.
  • REQUIRED: No reference to add_theme_support( "title-tag" ) was found in the theme.
  • REQUIRED: The theme must not used the <title> tags.
  • REQUIRED: The theme must not call to wp_title().
  • RECOMMENDED: This theme contains no sidebars/widget areas. See Widgets API

#17 in reply to: ↑ 15 @luchino__
5 months ago

Replying to maneshtimilsina:

Hi @maneshtimilsina

Thank you for reviewing and the detailed explanation.
I have fixed these issues. Check it again please.

#18 @maneshtimilsina
5 months ago

Hi @luchino

You have missed this point:

At line 6 of functions.php you are using eins-parent-style as handler but at line 9 you are using only parent-style. Replace it with eins-parent-style

Please, update new version of theme after fixing this issue.

#19 @themetracbot
5 months ago

  • Summary changed from THEME: Eins – 1.03 to THEME: Eins – 1.04

Eins - 1.04

child theme for the Twenty Thirteen theme.

Theme URL -
Author URL - https://profiles.wordpress.org/luchino_

Trac Browser - https://themes.trac.wordpress.org/browser/eins/1.04

SVN - https://themes.svn.wordpress.org/eins/1.04
ZIP - https://wordpress.org/themes/download/eins.1.04.zip?nostats=1
Parent Theme: https://wordpress.org/themes/twentythirteen

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=eins/1.03&new_path=eins/1.04

History:

Ticket Summary Status Resolution Owner
#38774 THEME: Eins – 1.04 closed live maneshtimilsina

(this ticket)

#43536 THEME: Eins – 1.04.1 closed live themetracbot
#44221 THEME: Eins – 1.04.2 closed live themetracbot


https://themes.svn.wordpress.org/eins/1.04/screenshot.png
Theme Check Results:

  • REQUIRED: Could not find wp_footer. See: wp_footer
     <?php wp_footer(); ?>
    
  • REQUIRED: Could not find wp_head. See: wp_head
     <?php wp_head(); ?>
    
  • REQUIRED: Could not find language_attributes. See: language_attributes
    <html <?php language_attributes(); ?>
    
  • REQUIRED: Could not find charset. There must be a charset defined in the Content-Type or the meta charset tag in the head.
  • REQUIRED: Could not find add_theme_support( 'automatic-feed-links' ). See: add_theme_support
     <?php add_theme_support( $feature ); ?>
    
  • REQUIRED: Could not find comments_template. See: comments_template
     <?php comments_template( $file, $separate_comments ); ?>
    
  • REQUIRED: Could not find wp_list_comments. See: wp_list_comments
     <?php wp_list_comments( $args ); ?>
    
  • REQUIRED: Could not find comment_form. See: comment_form
     <?php comment_form(); ?>
    
  • REQUIRED: Could not find body_class call in body tag. See: body_class
     <?php body_class( $class ); ?>
    
  • REQUIRED: Could not find wp_link_pages. See: wp_link_pages
     <?php wp_link_pages( $args ); ?>
    
  • REQUIRED: Could not find post_class. See: post_class
     <div id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
    
  • REQUIRED: The theme doesn't have comment pagination code in it. Use paginate_comments_links() or the_comments_navigation or the_comments_pagination or next_comments_link() and previous_comments_link() to add comment pagination.
  • REQUIRED: No content width has been defined. Example:
    if ( ! isset( $content_width ) ) $content_width = 900;
    
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • WARNING: .ds_store Hidden Files or Folders found.
  • WARNING: Could not find the file index.php in the theme.
  • REQUIRED: This theme doesn't seem to support the standard avatar functions. Use get_avatar or wp_list_comments to add this support.
  • RECOMMENDED: No reference to nav_menu's was found in the theme. Note that if your theme has a menu bar, it is required to use the WordPress nav_menu functionality for it.
  • REQUIRED: The theme doesn't have post pagination code in it. Use posts_nav_link() or paginate_links() or the_posts_pagination() or the_posts_navigation() or next_posts_link() and previous_posts_link() to add post pagination.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
  • RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( "post-thumbnails" )in the functions.php file.
  • REQUIRED: .sticky css class is needed in your theme css.
  • REQUIRED: .bypostauthor css class is needed in your theme css.
  • REQUIRED: .screen-reader-text css class is needed in your theme css. See See: the Codex for an example implementation.
  • RECOMMENDED: Theme URI: is missing from your style.css header.
  • REQUIRED: This theme doesn't seem to display tags. Modify it to display tags in appropriate locations.
  • REQUIRED: No reference to add_theme_support( "title-tag" ) was found in the theme.
  • REQUIRED: The theme must not used the <title> tags.
  • REQUIRED: The theme must not call to wp_title().
  • RECOMMENDED: This theme contains no sidebars/widget areas. See Widgets API

#20 follow-up: @maneshtimilsina
5 months ago

  • Status changed from reviewing to approved

Hi @luchino

Your theme is approved for final review.

This ticket will now go to 'Final Review: Approved Themes Not Yet Live' queue where Key Reviewer will perform final review before setting it live.

Good Luck. Cheers!!!

#21 in reply to: ↑ 20 @luchino__
5 months ago

Hi @maneshtimilsina
Thank you a lots, thorough reviews.

#22 @poena
5 months ago

  • Resolution set to live
  • Status changed from approved to closed

Hi!
Your theme should be live shortly.

Note: See TracTickets for help on using tickets.