WordPress.org

Make WordPress Themes

Opened 11 months ago

Closed 9 months ago

#39353 closed theme (live)

THEME: Winsome – 1.0.6

Reported by: promenadepro Owned by: rinkuyadav999
Priority: new theme Keywords: theme-winsome
Cc: promenadeproda@…

Description

Winsome - 1.0.0

Winsome is responsive multipurpose theme.

Theme URL -
Author URL - http://promenadepro.com/

SVN - https://themes.svn.wordpress.org/winsome/1.0.0
ZIP - https://wordpress.org/themes/download/winsome.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#39353 THEME: Winsome – 1.0.6 closed live rinkuyadav999

(this ticket)

#41350 THEME: Winsome – 1.0.7 closed live themetracbot
#41785 THEME: Winsome – 1.0.8 closed live themetracbot
#42488 THEME: Winsome – 1.0.9 closed live themetracbot
#43354 THEME: Winsome – 2.0.1 closed live themetracbot
#44424 THEME: Winsome – 2.0.2 closed live themetracbot
#47597 THEME: Winsome – 2.0.3 closed live themetracbot
#47911 THEME: Winsome – 2.0.4 closed live themetracbot
#49293 THEME: Winsome – 2.0.5 closed live themetracbot


https://themes.svn.wordpress.org/winsome/1.0.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

Attachments (1)

Static-Page-as-Home.jpg (90.0 KB) - added by joyously 9 months ago.
This is my home page with static Page. It shows no content! An empty widget area should not show instructions.

Download all attachments as: .zip

Change History (18)

@joyously
9 months ago

This is my home page with static Page. It shows no content! An empty widget area should not show instructions.

#1 @joyously
9 months ago

  • The theme is tagged sticky-post, but the sticky post is not visually different.
  • The "more" tag link is not shown.
  • Menu disappears when on a small screen
  • In Customizer, the Theme Options > Header Options duplicate the core Site Identity option for displaying site title and tagline.

#2 @promenadepro
9 months ago

Hi @joyously

Thanks for review. We will fix these issues and upload new version soon.

Please inform us if you find anything more.

Once again accept our sincere thanks for your time and effort to review our theme.

#3 @themetracbot
9 months ago

  • Summary changed from THEME: Winsome – 1.0.0 to THEME: Winsome – 1.0.1

Winsome - 1.0.1

Winsome is responsive multipurpose one page theme. It has scrolling sections in home page. It is flexible and dynamic enough to use as multi-page or single page site. Winsome can be used for business, corporate, portfolio, digital agency, landing page, product showcase and all informative websites.

Theme URL - https://promenadethemes.com/downloads/winsome/
Author URL - https://promenadethemes.com

Trac Browser - https://themes.trac.wordpress.org/browser/winsome/1.0.1

SVN - https://themes.svn.wordpress.org/winsome/1.0.1
ZIP - https://wordpress.org/themes/download/winsome.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=winsome/1.0.0&new_path=winsome/1.0.1

History:

Ticket Summary Status Resolution Owner
#39353 THEME: Winsome – 1.0.6 closed live rinkuyadav999

(this ticket)

#41350 THEME: Winsome – 1.0.7 closed live themetracbot
#41785 THEME: Winsome – 1.0.8 closed live themetracbot
#42488 THEME: Winsome – 1.0.9 closed live themetracbot
#43354 THEME: Winsome – 2.0.1 closed live themetracbot
#44424 THEME: Winsome – 2.0.2 closed live themetracbot
#47597 THEME: Winsome – 2.0.3 closed live themetracbot
#47911 THEME: Winsome – 2.0.4 closed live themetracbot
#49293 THEME: Winsome – 2.0.5 closed live themetracbot


https://themes.svn.wordpress.org/winsome/1.0.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#4 @themetracbot
9 months ago

  • Summary changed from THEME: Winsome – 1.0.1 to THEME: Winsome – 1.0.2

Winsome - 1.0.2

Winsome is responsive multipurpose one page theme. It has scrolling sections in home page. It is flexible and dynamic enough to use as multi-page or single page site. Winsome can be used for business, corporate, portfolio, digital agency, landing page, product showcase and all informative websites.

Theme URL - https://promenadethemes.com/downloads/winsome/
Author URL - https://promenadethemes.com

Trac Browser - https://themes.trac.wordpress.org/browser/winsome/1.0.2

SVN - https://themes.svn.wordpress.org/winsome/1.0.2
ZIP - https://wordpress.org/themes/download/winsome.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=winsome/1.0.1&new_path=winsome/1.0.2

History:

Ticket Summary Status Resolution Owner
#39353 THEME: Winsome – 1.0.6 closed live rinkuyadav999

(this ticket)

#41350 THEME: Winsome – 1.0.7 closed live themetracbot
#41785 THEME: Winsome – 1.0.8 closed live themetracbot
#42488 THEME: Winsome – 1.0.9 closed live themetracbot
#43354 THEME: Winsome – 2.0.1 closed live themetracbot
#44424 THEME: Winsome – 2.0.2 closed live themetracbot
#47597 THEME: Winsome – 2.0.3 closed live themetracbot
#47911 THEME: Winsome – 2.0.4 closed live themetracbot
#49293 THEME: Winsome – 2.0.5 closed live themetracbot


https://themes.svn.wordpress.org/winsome/1.0.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#5 @themetracbot
9 months ago

  • Summary changed from THEME: Winsome – 1.0.2 to THEME: Winsome – 1.0.3

Winsome - 1.0.3

Winsome is responsive multipurpose one page theme. It has scrolling sections in home page. It is flexible and dynamic enough to use as multi-page or single page site. Winsome can be used for business, corporate, portfolio, digital agency, landing page, product showcase and all informative websites.

Theme URL - https://promenadethemes.com/downloads/winsome/
Author URL - https://promenadethemes.com

Trac Browser - https://themes.trac.wordpress.org/browser/winsome/1.0.3

SVN - https://themes.svn.wordpress.org/winsome/1.0.3
ZIP - https://wordpress.org/themes/download/winsome.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=winsome/1.0.2&new_path=winsome/1.0.3

History:

Ticket Summary Status Resolution Owner
#39353 THEME: Winsome – 1.0.6 closed live rinkuyadav999

(this ticket)

#41350 THEME: Winsome – 1.0.7 closed live themetracbot
#41785 THEME: Winsome – 1.0.8 closed live themetracbot
#42488 THEME: Winsome – 1.0.9 closed live themetracbot
#43354 THEME: Winsome – 2.0.1 closed live themetracbot
#44424 THEME: Winsome – 2.0.2 closed live themetracbot
#47597 THEME: Winsome – 2.0.3 closed live themetracbot
#47911 THEME: Winsome – 2.0.4 closed live themetracbot
#49293 THEME: Winsome – 2.0.5 closed live themetracbot


https://themes.svn.wordpress.org/winsome/1.0.3/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#6 @rinkuyadav999
9 months ago

  • Owner set to rinkuyadav999
  • Status changed from new to reviewing

#7 @rinkuyadav999
9 months ago

HI @promenadepro

I will review your theme and upload issues soon.

Thanks

#8 follow-up: @rinkuyadav999
9 months ago

Hi @promenadepro

I have taken a review and found these issues:

Required:

Subject tags:

is this theme for education or entertainment? Please use correct subject tags. https://make.wordpress.org/themes/handbook/review/required/theme-tags/

License:

There is an image with name "AjaxLoader.gif", is it part of owl.carousel ? If no, please add license in readme.txt

Prefix:

There is a file called "breadcrumbs.php". Please prefix it's functions and classes with theme slug.

Style Handler:

wp_enqueue_style handler, please use 'meanmenu' instead 'jquery-meanmenu', 'font-awesome' instead 'jquery-font-awesome', 'owl-carousel' instead 'jquery-owl-carousel'. you do not need to add 'jquery'. Handler is fine for scripts / wp_enqueue_script.

Plugin territory:

Slider- Slider is a plugin territory because it is creating content. one or two fields may be exception but there are 12 fields for slider. you can add option to select a post category for slider. you can display post title as Headline and content as sub headline. We can not add options to create container content and CTA. footer copyright etc are only exception.

Escaping:

You do not need to escape $single_class variable in content-single.php file. it is a known value (not DB value or translation ready value). also i see same in some other files.

widgets.php L83, Escape $title. also L184, L406 ETC. Please review and check escaping and sanitize.

Translation ready:

You no not need to make comma translation ready here: template-tags.php L18 also no need to escape because it is a known value. Check same in all files.

Recommended:

Plugin territory:

Your theme adds some widgets which create contents. Theme users will lose these content, when they will switch theme. It will better, you developer a plugin and move these widgets in that plugin. Winsome contact (short code will lose), CTA (button text and link will lose), Facts (Icon and text will lose).

Do you want to move these widgets in plugin?

Theme Unit Text Data:

Please install theme unit test data and check all posts. there is a post called "Markup: Image Alignment", it is not displaying properly. content display outside container.

Your theme does not display drop down menu. if this is restriction, you can write in readme.txt

Please review your theme before uploading new version and make sure it follows these requirements : https://make.wordpress.org/themes/handbook/review/required/

If your have comment or question, you can post your comments in this ticket or on our slack channel https://wordpress.slack.com/messages/themereview/.

Note: Please reply within 7 days otherwise this ticket will be set as not-approved.

Thanks

#9 @themetracbot
9 months ago

  • Summary changed from THEME: Winsome – 1.0.3 to THEME: Winsome – 1.0.4

Winsome - 1.0.4

Winsome is responsive multipurpose one page theme. It has scrolling sections in home page. It is flexible and dynamic enough to use as multi-page or single page site. Winsome can be used for business, corporate, portfolio, digital agency, landing page, product showcase and all informative websites.

Theme URL - https://promenadethemes.com/downloads/winsome/
Author URL - https://promenadethemes.com

Trac Browser - https://themes.trac.wordpress.org/browser/winsome/1.0.4

SVN - https://themes.svn.wordpress.org/winsome/1.0.4
ZIP - https://wordpress.org/themes/download/winsome.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=winsome/1.0.3&new_path=winsome/1.0.4

History:

Ticket Summary Status Resolution Owner
#39353 THEME: Winsome – 1.0.6 closed live rinkuyadav999

(this ticket)

#41350 THEME: Winsome – 1.0.7 closed live themetracbot
#41785 THEME: Winsome – 1.0.8 closed live themetracbot
#42488 THEME: Winsome – 1.0.9 closed live themetracbot
#43354 THEME: Winsome – 2.0.1 closed live themetracbot
#44424 THEME: Winsome – 2.0.2 closed live themetracbot
#47597 THEME: Winsome – 2.0.3 closed live themetracbot
#47911 THEME: Winsome – 2.0.4 closed live themetracbot
#49293 THEME: Winsome – 2.0.5 closed live themetracbot


https://themes.svn.wordpress.org/winsome/1.0.4/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#10 in reply to: ↑ 8 @promenadepro
9 months ago

Replying to rinkuyadav999:

Hi @rinkuyadav999

Thanks for detailed review. Please check response of each points you have listed below.

Required:

Subject tags:

is this theme for education or entertainment? Please use correct subject tags. https://make.wordpress.org/themes/handbook/review/required/theme-tags/

Response: education and entertainment subject tags have been removed.

License:

There is an image with name "AjaxLoader.gif", is it part of owl.carousel ? If no, please add license in readme.txt

Response: Yes 'AjaxLoder.gif' is part of owl.carousel. We have added information in readme.txt too.

Prefix:

There is a file called "breadcrumbs.php". Please prefix it's functions and classes with theme slug.

Response: This is third party file so we have not changed core file. We have used if function exists before including it and believe it will not create any problem. Please check code:

if ( ! function_exists( 'breadcrumb_trail' ) ) {
    require_once trailingslashit( get_template_directory() ) . '/assets/vendor/breadcrumbs/breadcrumbs.php';
}

Style Handler:

wp_enqueue_style handler, please use 'meanmenu' instead 'jquery-meanmenu', 'font-awesome' instead 'jquery-font-awesome', 'owl-carousel' instead 'jquery-owl-carousel'. you do not need to add 'jquery'. Handler is fine for scripts / wp_enqueue_script.

Response: We have removed handler from 'font-awesome' and for rest we are following this standard:
https://make.wordpress.org/themes/handbook/review/recommended/#stylesheets-and-scripts

Plugin territory:

Slider- Slider is a plugin territory because it is creating content. one or two fields may be exception but there are 12 fields for slider. you can add option to select a post category for slider. you can display post title as Headline and content as sub headline. We can not add options to create container content and CTA. footer copyright etc are only exception.

Response: We have changed slider functionality. There is option to load slide from pages now. Page title is used as headline and content is used as sub-heading. We have given text field as option to button text and url because primarily this theme is one page theme. So user can input links like '#contact-us' there.

Escaping:

You do not need to escape $single_class variable in content-single.php file. it is a known value (not DB value or translation ready value). also i see same in some other files.

widgets.php L83, Escape $title. also L184, L406 ETC. Please review and check escaping and sanitize.

Response: Unnecessary escape from aforementioned files and other too have been removed.

Translation ready:

You no not need to make comma translation ready here: template-tags.php L18 also no need to escape because it is a known value. Check same in all files.

Response: Translation ready code for comma have been removed.

Recommended:

Plugin territory:

Your theme adds some widgets which create contents. Theme users will lose these content, when they will switch theme. It will better, you developer a plugin and move these widgets in that plugin. Winsome contact (short code will lose), CTA (button text and link will lose), Facts (Icon and text will lose).

Do you want to move these widgets in plugin?

Response: We have not used trivial content. We have used non-trivial content to allow user to input data. We believe non-trivial content can be used in widgets.

Theme Unit Text Data:

Please install theme unit test data and check all posts. there is a post called "Markup: Image Alignment", it is not displaying properly. content display outside container.

Response: We have fixed overflow issue and tested with unit test data.

Your theme does not display drop down menu. if this is restriction, you can write in readme.txt

Response: Dropdown menu issue have been fixed.

Please let us know if there is anything more to update.

Thank you.

Kind Regards,
Promenade Themes

#11 follow-up: @rinkuyadav999
9 months ago

Hi @promenadepro

I was forget to move style and script handler from required to recommended. Actually it is recommended.

Prefix:
Provide a unique prefix for everything the Theme defines in the public namespace, including options, functions, global variables, constants, post meta, etc.

Use a single unique theme slug – as the theme slug appears in style.css. If it uses a framework then no more than 2 unique slugs.

That's why there is prefix issue in file: breadcrumbs.php
It is not a framework.

it will not create any problem. Please check code:

Yes i already read it :)

Thanks

#12 @themetracbot
9 months ago

  • Summary changed from THEME: Winsome – 1.0.4 to THEME: Winsome – 1.0.5

Winsome - 1.0.5

Winsome is responsive multipurpose one page theme. It has scrolling sections in home page. It is flexible and dynamic enough to use as multi-page or single page site. Winsome can be used for business, corporate, portfolio, digital agency, landing page, product showcase and all informative websites.

Theme URL - https://promenadethemes.com/downloads/winsome/
Author URL - https://promenadethemes.com

Trac Browser - https://themes.trac.wordpress.org/browser/winsome/1.0.5

SVN - https://themes.svn.wordpress.org/winsome/1.0.5
ZIP - https://wordpress.org/themes/download/winsome.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=winsome/1.0.4&new_path=winsome/1.0.5

History:

Ticket Summary Status Resolution Owner
#39353 THEME: Winsome – 1.0.6 closed live rinkuyadav999

(this ticket)

#41350 THEME: Winsome – 1.0.7 closed live themetracbot
#41785 THEME: Winsome – 1.0.8 closed live themetracbot
#42488 THEME: Winsome – 1.0.9 closed live themetracbot
#43354 THEME: Winsome – 2.0.1 closed live themetracbot
#44424 THEME: Winsome – 2.0.2 closed live themetracbot
#47597 THEME: Winsome – 2.0.3 closed live themetracbot
#47911 THEME: Winsome – 2.0.4 closed live themetracbot
#49293 THEME: Winsome – 2.0.5 closed live themetracbot


https://themes.svn.wordpress.org/winsome/1.0.5/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#13 in reply to: ↑ 11 @promenadepro
9 months ago

Replying to rinkuyadav999:

Hi @rinkuyadav999

We have updated our theme with changes you have mentioned.

We have added prefix in all class and functions of breadcrumbs.php

Please check it and let us know if there is anything more to do.

Thank you.

#14 follow-up: @rinkuyadav999
9 months ago

Hi @promenadepro

Required:

Sticky post should different than regular post, if you use sticky post tag OR you can remove this tag from style.css file.

Recommended:

I told to prefix function and class not Methods inside class. you can prefix methods or not, depends on you.

Excerpt Length option displays when chosen Archive Layout: Full Post. It is expected to hide for better UI.

NOTE: Please reply within 7 days otherwise we can set this theme as not-approved. Also please take a review before uploading updated version and make sure your theme follow these requirements: https://make.wordpress.org/themes/handbook/review/required/

Thanks

#15 @themetracbot
9 months ago

  • Summary changed from THEME: Winsome – 1.0.5 to THEME: Winsome – 1.0.6

Winsome - 1.0.6

Winsome is responsive multipurpose one page theme. It has scrolling sections in home page. It is flexible and dynamic enough to use as multi-page or single page site. Winsome can be used for business, corporate, portfolio, digital agency, landing page, product showcase and all informative websites.

Theme URL - https://promenadethemes.com/downloads/winsome/
Author URL - https://promenadethemes.com

Trac Browser - https://themes.trac.wordpress.org/browser/winsome/1.0.6

SVN - https://themes.svn.wordpress.org/winsome/1.0.6
ZIP - https://wordpress.org/themes/download/winsome.1.0.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=winsome/1.0.5&new_path=winsome/1.0.6

History:

Ticket Summary Status Resolution Owner
#39353 THEME: Winsome – 1.0.6 closed live rinkuyadav999

(this ticket)

#41350 THEME: Winsome – 1.0.7 closed live themetracbot
#41785 THEME: Winsome – 1.0.8 closed live themetracbot
#42488 THEME: Winsome – 1.0.9 closed live themetracbot
#43354 THEME: Winsome – 2.0.1 closed live themetracbot
#44424 THEME: Winsome – 2.0.2 closed live themetracbot
#47597 THEME: Winsome – 2.0.3 closed live themetracbot
#47911 THEME: Winsome – 2.0.4 closed live themetracbot
#49293 THEME: Winsome – 2.0.5 closed live themetracbot


https://themes.svn.wordpress.org/winsome/1.0.6/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#16 in reply to: ↑ 14 @promenadepro
9 months ago

Replying to rinkuyadav999:

Hi @rinkuyadav999

We have fixed both required and recommended points you have listed and updated our theme.

Please review it and let us know if there is anything more to do.

Thank you

Required:

Sticky post should different than regular post, if you use sticky post tag OR you can remove this tag from style.css file.

Recommended:

I told to prefix function and class not Methods inside class. you can prefix methods or not, depends on you.

Excerpt Length option displays when chosen Archive Layout: Full Post. It is expected to hide for better UI.

NOTE: Please reply within 7 days otherwise we can set this theme as not-approved. Also please take a review before uploading updated version and make sure your theme follow these requirements: https://make.wordpress.org/themes/handbook/review/required/

Thanks

#17 @rinkuyadav999
9 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Hi @promenadepro

I did not find any issue in your theme.

I am setting it live and it will take 1-2 hours to appear in theme directory.

Thanks

Note: See TracTickets for help on using tickets.