WordPress.org

Make WordPress Themes

Opened 10 months ago

Closed 8 months ago

#39404 closed theme (not-approved)

THEME: Blogostrap – 1.1.0

Reported by: nsthemes Owned by: acosmin
Priority: previously reviewed Keywords: theme-blogostrap
Cc: info@…

Description

Blogostrap - 1.1.0

Blogostrap is a simple clean WordPress blog. The horizontal image header with a left sidebar is beauty for website and blog. It has a theme option to customize this theme as you like.

Theme URL -
Author URL - http://www.nsthemes.com/

SVN - https://themes.svn.wordpress.org/blogostrap/1.1.0
ZIP - https://wordpress.org/themes/download/blogostrap.1.1.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=blogostrap/1.0&new_path=blogostrap/1.1.0

History:

Ticket Summary Status Resolution Owner
#36207 THEME: Blogostrap – 1.0 closed not-approved poena
#39404 THEME: Blogostrap – 1.1.0 closed not-approved acosmin

(this ticket)

#41588 THEME: Blogostrap – 1.2.4 closed live poena
#43264 THEME: Blogostrap – 1.2.5 closed live themetracbot
#43716 THEME: Blogostrap – 1.2.6 closed live themetracbot
#44302 THEME: Blogostrap – 1.2.7 closed live themetracbot


https://themes.svn.wordpress.org/blogostrap/1.1.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: Theme URI: is missing from your style.css header.

Change History (2)

#1 @acosmin
8 months ago

  • Owner set to acosmin
  • Status changed from new to reviewing

#2 @acosmin
8 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

I am sorry but because the following 5 or more issues are present in your theme, I decided to close this ticket. Please take your time, read the requirements before you resubmit.


  1. Provide a unique prefix for everything the Theme defines in the public namespace, including options, functions, global variables, constants, post meta, etc.
    • NS_ and ns_ for your constants/functions isn't unique enough, use the theme name.
    • You have unprefixed functions, do a search with regex on for function\s.*\(
  1. No PHP or JS errors:
    • When adding one of your custom widgets for the first time, it trows notices:
      • Notice: Undefined index: ns_button_text in PATH\themes\blogostrap\inc\ns_widget_about.php</b> on line 33
  1. The following functions need to be wrapped in a function and hooked into after_setup_theme:
    • add_theme_support(), add_editor_style()
  1. You can't set your own copyright on a user's website:
    • footer.php:L4
  1. You need to provide license information for any assets used in your theme in this format
    • check your assets folder, also the images used in your screeshot.png file
  1. Use WordPress functionality and features first, if available.:
    • archive.php:L10-22 change with the_archive_title()
  1. All theme text strings are to be translatable.
    • example: single.php:L23,30,37
  1. Validate and/or sanitize untrusted data before entering into the database. All untrusted data should be escaped before output.
    • example:
      • sidebar.php these theme mods need to be escaped
      • ns_widget_about.php:L81 should be sanitized with esc_url_raw()
  1. assets\js\nsblogostrap.js
    • these shouldn't be added in the theme, use it in a plugin.
    • also, the ajax posts need to be nonced

These are just a few of the issues

Note: See TracTickets for help on using tickets.