WordPress.org

Make WordPress Themes

Opened 10 months ago

Closed 8 months ago

Last modified 8 months ago

#39482 closed theme (live)

THEME: Wellington – 1.0.4

Reported by: ThemeZee Owned by: acosmin
Priority: new theme Keywords: theme-wellington
Cc: contact@…

Description

Wellington - 1.0

Wellington is a clean and simple Magazine WordPress theme with beautiful typography and subtle colors. The theme includes two different post layouts, a featured post slider and thoughtful theme settings in the Customizer.

Theme URL - https://themezee.com/themes/wellington/
Author URL - https://themezee.com

SVN - https://themes.svn.wordpress.org/wellington/1.0
ZIP - https://wordpress.org/themes/download/wellington.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#39482 THEME: Wellington – 1.0.4 closed live acosmin

(this ticket)

#41472 THEME: Wellington – 1.0.5 closed live themetracbot
#41858 THEME: Wellington – 1.0.6 closed live themetracbot
#42394 THEME: Wellington – 1.0.7 closed live themetracbot
#42883 THEME: Wellington – 1.0.8 closed live themetracbot
#44518 THEME: Wellington – 1.1 closed live themetracbot
#45541 THEME: Wellington – 1.2 closed live themetracbot
#46147 THEME: Wellington – 1.2.1 closed live themetracbot
#47733 THEME: Wellington – 1.2.2 closed live themetracbot


https://themes.svn.wordpress.org/wellington/1.0/screenshot.jpg

Change History (11)

#1 @joyously
9 months ago

  • Please list the theme tags once only. Several are listed multiple times.
  • Theme is tagged sticky-post, but the sticky post is not visually different.
  • Page links are output in with the content instead of after. This means they can wrap around a float.
  • In Customizer, the Background Color has the wrong default value.
  • In Customizer, Theme Options, General Settings, the Blog title and Blog description is what Site title and Site tagline are. There is no need for these.

#2 @ThemeZee
8 months ago

Hi there,

Thanks so much for taking the time to review my theme and your suggestions to improve it.

I will fix these issues and upload a theme update within the next few days.

Cheers,
Thomas

#3 @acosmin
8 months ago

  • Owner set to acosmin
  • Status changed from new to reviewing
  1. inc\template-tags.php
    • L365, the WordPress href url needs to be translatable and escaped
  1. inc\extras.php
    • wellington_excerpt_length() make sure it doesn't change the excerpt length on the admin sidebar
  1. style.css
    • you have some duplicate Tags:
  1. searchform.php
    • L15 doesn't need escaping
      • same in search.php:L24
  1. readme.txt
    • you forgot license information for html5shiv.js
  1. Theme URL returns 404 status.

#4 @themetracbot
8 months ago

  • Summary changed from THEME: Wellington – 1.0 to THEME: Wellington – 1.0.3

Wellington - 1.0.3

Wellington is a clean and simple Magazine WordPress theme with beautiful typography and subtle colors. The theme includes two different post layouts, a featured post slider and thoughtful theme settings in the Customizer.

Theme URL - https://themezee.com/themes/wellington/
Author URL - https://themezee.com

Trac Browser - https://themes.trac.wordpress.org/browser/wellington/1.0.3

SVN - https://themes.svn.wordpress.org/wellington/1.0.3
ZIP - https://wordpress.org/themes/download/wellington.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=wellington/1.0&new_path=wellington/1.0.3

History:

Ticket Summary Status Resolution Owner
#39482 THEME: Wellington – 1.0.4 closed live acosmin

(this ticket)

#41472 THEME: Wellington – 1.0.5 closed live themetracbot
#41858 THEME: Wellington – 1.0.6 closed live themetracbot
#42394 THEME: Wellington – 1.0.7 closed live themetracbot
#42883 THEME: Wellington – 1.0.8 closed live themetracbot
#44518 THEME: Wellington – 1.1 closed live themetracbot
#45541 THEME: Wellington – 1.2 closed live themetracbot
#46147 THEME: Wellington – 1.2.1 closed live themetracbot
#47733 THEME: Wellington – 1.2.2 closed live themetracbot


https://themes.svn.wordpress.org/wellington/1.0.3/screenshot.jpg

#5 @themetracbot
8 months ago

  • Summary changed from THEME: Wellington – 1.0.3 to THEME: Wellington – 1.0.4

Wellington - 1.0.4

Wellington is a clean and simple Magazine WordPress theme with beautiful typography and subtle colors. The theme includes two different post layouts, a featured post slider and thoughtful theme settings in the Customizer.

Theme URL - https://themezee.com/themes/wellington/
Author URL - https://themezee.com

Trac Browser - https://themes.trac.wordpress.org/browser/wellington/1.0.4

SVN - https://themes.svn.wordpress.org/wellington/1.0.4
ZIP - https://wordpress.org/themes/download/wellington.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=wellington/1.0.3&new_path=wellington/1.0.4

History:

Ticket Summary Status Resolution Owner
#39482 THEME: Wellington – 1.0.4 closed live acosmin

(this ticket)

#41472 THEME: Wellington – 1.0.5 closed live themetracbot
#41858 THEME: Wellington – 1.0.6 closed live themetracbot
#42394 THEME: Wellington – 1.0.7 closed live themetracbot
#42883 THEME: Wellington – 1.0.8 closed live themetracbot
#44518 THEME: Wellington – 1.1 closed live themetracbot
#45541 THEME: Wellington – 1.2 closed live themetracbot
#46147 THEME: Wellington – 1.2.1 closed live themetracbot
#47733 THEME: Wellington – 1.2.2 closed live themetracbot


https://themes.svn.wordpress.org/wellington/1.0.4/screenshot.jpg

#6 @ThemeZee
8 months ago

Hi acosmin,

Thanks so much for reviewing the theme.

I'm so sorry about the huge update. I spent the last weeks on rewriting the Magazine widgets used in all my themes from scratch, and updated the Wellington theme as well.

But I failed/forgot to upload the theme updates on wp.org and thought I have more time. There were 50 tickets before me on the weekend, so it seems the queue has moved pretty fast.

I have now uploaded version 1.0.3 first (sorry again for jumping ahead 3 updates), and then version 1.0.4 which fixes all the things you mentioned in your review.

That way you can view the diff more easily: https://themes.trac.wordpress.org/changeset?old_path=wellington/1.0.3&new_path=wellington/1.0.4

Best,
Thomas

Last edited 8 months ago by ThemeZee (previous) (diff)

#7 @ThemeZee
8 months ago

You can also review the whole theme again if you want, but I don't want to cause you any more work or trouble.

I also create the theme page now.

#8 @acosmin
8 months ago

@ThemeZee I don't see any issues based on diff. The only problem is with your Theme URL, before I set this theme live please make sure it works (not returns a 404 page)

#9 @acosmin
8 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

@ThemeZee I see it working now. Congrats, your theme should be live shortly!

#10 @ThemeZee
8 months ago

Yeah, just created it :)

Thanks so much for making the theme live!

#11 @ThemeZee
8 months ago

And you are pretty fast, no wonder the queue is getting down so quickly :)

Note: See TracTickets for help on using tickets.