WordPress.org

Make WordPress Themes

Opened 9 months ago

Closed 7 months ago

#39696 closed theme (live)

THEME: Best Reloaded – 0.14.0

Reported by: williampatton Owned by: acosmin
Priority: previously reviewed Keywords: theme-best-reloaded
Cc: will@…

Description

Best Reloaded - 0.8.1

A responsive, mobile-first, WordPress theme that uses Bootstrap.

Theme URL - http://www.pattonwebz.com/best-reloaded-bootstrap-theme
Author URL - http://pattonwebz.com/

SVN - https://themes.svn.wordpress.org/best-reloaded/0.8.1
ZIP - https://wordpress.org/themes/download/best-reloaded.0.8.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=best-reloaded/0.6&new_path=best-reloaded/0.8.1

History:

Ticket Summary Status Resolution Owner
#26796 THEME: Best Reloaded – 0.6 closed not-approved WEN Solutions
#39696 THEME: Best Reloaded – 0.14.0 closed live acosmin

(this ticket)

#44536 THEME: Best Reloaded – 1.0.0 closed live themetracbot
#45604 THEME: Best Reloaded – 1.1.0 closed live themetracbot
#46529 THEME: Best Reloaded – 1.4.1 closed live themetracbot
#46530 THEME: Best Reloaded – 1.4.2 closed live themetracbot
#47480 THEME: Best Reloaded – 1.4.3 closed live themetracbot
#47503 THEME: Best Reloaded – 1.5.0 closed live themetracbot


https://themes.svn.wordpress.org/best-reloaded/0.8.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

Change History (23)

#1 @themetracbot
8 months ago

  • Summary changed from THEME: Best Reloaded – 0.8.1 to THEME: Best Reloaded – 0.8.2

Best Reloaded - 0.8.2

A responsive, mobile-first, WordPress theme that uses Bootstrap.

Theme URL - http://www.pattonwebz.com/best-reloaded-bootstrap-theme
Author URL - http://pattonwebz.com/

Trac Browser - https://themes.trac.wordpress.org/browser/best-reloaded/0.8.2

SVN - https://themes.svn.wordpress.org/best-reloaded/0.8.2
ZIP - https://wordpress.org/themes/download/best-reloaded.0.8.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=best-reloaded/0.8.1&new_path=best-reloaded/0.8.2

History:

Ticket Summary Status Resolution Owner
#26796 THEME: Best Reloaded – 0.6 closed not-approved WEN Solutions
#39696 THEME: Best Reloaded – 0.14.0 closed live acosmin

(this ticket)

#44536 THEME: Best Reloaded – 1.0.0 closed live themetracbot
#45604 THEME: Best Reloaded – 1.1.0 closed live themetracbot
#46529 THEME: Best Reloaded – 1.4.1 closed live themetracbot
#46530 THEME: Best Reloaded – 1.4.2 closed live themetracbot
#47480 THEME: Best Reloaded – 1.4.3 closed live themetracbot
#47503 THEME: Best Reloaded – 1.5.0 closed live themetracbot


https://themes.svn.wordpress.org/best-reloaded/0.8.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#2 @themetracbot
8 months ago

  • Summary changed from THEME: Best Reloaded – 0.8.2 to THEME: Best Reloaded – 0.9.1

Best Reloaded - 0.9.1

A responsive, mobile-first, WordPress theme that uses Bootstrap.

Theme URL - http://www.pattonwebz.com/best-reloaded-bootstrap-theme
Author URL - http://pattonwebz.com/

Trac Browser - https://themes.trac.wordpress.org/browser/best-reloaded/0.9.1

SVN - https://themes.svn.wordpress.org/best-reloaded/0.9.1
ZIP - https://wordpress.org/themes/download/best-reloaded.0.9.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=best-reloaded/0.8.2&new_path=best-reloaded/0.9.1

History:

Ticket Summary Status Resolution Owner
#26796 THEME: Best Reloaded – 0.6 closed not-approved WEN Solutions
#39696 THEME: Best Reloaded – 0.14.0 closed live acosmin

(this ticket)

#44536 THEME: Best Reloaded – 1.0.0 closed live themetracbot
#45604 THEME: Best Reloaded – 1.1.0 closed live themetracbot
#46529 THEME: Best Reloaded – 1.4.1 closed live themetracbot
#46530 THEME: Best Reloaded – 1.4.2 closed live themetracbot
#47480 THEME: Best Reloaded – 1.4.3 closed live themetracbot
#47503 THEME: Best Reloaded – 1.5.0 closed live themetracbot


https://themes.svn.wordpress.org/best-reloaded/0.9.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • WARNING: Found a translation function that is missing a text-domain. Function esc_html_e, with the arguments "Sorry, couldn't get any slides."
  • WARNING: Found a translation function that is missing a text-domain. Function , with the arguments 'Toggle on/off the the header slot.'
  • WARNING: Found a translation function that is missing a text-domain. Function , with the arguments 'Enter the text you want to show in the header slot. Accepts some basic html.'

#3 @themetracbot
8 months ago

  • Summary changed from THEME: Best Reloaded – 0.9.1 to THEME: Best Reloaded – 0.9.2

Best Reloaded - 0.9.2

A responsive, mobile-first, WordPress theme that uses Bootstrap.

Theme URL - http://www.pattonwebz.com/best-reloaded-bootstrap-theme
Author URL - http://pattonwebz.com/

Trac Browser - https://themes.trac.wordpress.org/browser/best-reloaded/0.9.2

SVN - https://themes.svn.wordpress.org/best-reloaded/0.9.2
ZIP - https://wordpress.org/themes/download/best-reloaded.0.9.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=best-reloaded/0.9.1&new_path=best-reloaded/0.9.2

History:

Ticket Summary Status Resolution Owner
#26796 THEME: Best Reloaded – 0.6 closed not-approved WEN Solutions
#39696 THEME: Best Reloaded – 0.14.0 closed live acosmin

(this ticket)

#44536 THEME: Best Reloaded – 1.0.0 closed live themetracbot
#45604 THEME: Best Reloaded – 1.1.0 closed live themetracbot
#46529 THEME: Best Reloaded – 1.4.1 closed live themetracbot
#46530 THEME: Best Reloaded – 1.4.2 closed live themetracbot
#47480 THEME: Best Reloaded – 1.4.3 closed live themetracbot
#47503 THEME: Best Reloaded – 1.5.0 closed live themetracbot


https://themes.svn.wordpress.org/best-reloaded/0.9.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#4 @williampatton
8 months ago

Passes all Theme Check tests and NS Theme Check sniffs as of v0.9.2

#5 @rabmalin
7 months ago

Hello,

It is nice that you are updating your theme regularly based on the review guideline. But we should be clear that Theme Check and NS Theme Check are just tools in review process. They only cover a certain part of the review. Theme passing from those plugins wont make sure that your theme is par the guideline.

Here are some issues I found in quick scan. There are easily more than 5+ distinct issues with which can reviewer can close the ticket. So, please check your theme thoroughly and fix accordingly. I see you are reviewing theme also. Theme review is the most efficient method for learning theme development. I am saying this from my experience. Good luck!

Issues

  • REQUIRED: Screenshot dimensions are wrong! Ratio of width to height should be 4:3. Screenshot size should be 1200x900, to account for HiDPI displays. Any 4:3 image size is acceptable, but 1200x900 is preferred.
  • REQUIRED: Remove menu parameter from wp_nav_menu().
  • REQUIRED: require 'inc/theme-setup.php'; - Use get_template_directory() to load non-template PHP files.
  • REQUIRED: wp_bootstrap_navwalker.php - When loading third party PHP library check class_exists before loading to to avoid conflict.
  • REQUIRED: Prefixing: Provide a unique prefix for everything the Theme defines in the public namespace, including options, functions, global variables, constants, post meta, etc. http://themereview.co/prefix-all-the-things/ Your theme slug is best-reloaded. So function name should be best_reloaded_setup() or similar. Please check thoroughly.
  • REQUIRED: Translation Ready: All theme text strings are to be translatable. https://make.wordpress.org/themes/handbook/review/required/#language Lots of strings are still not translatable. Test your theme with Pig Latin plugin.
  • REQUIRED: Remove inline styling and use enqueue approach.
Last edited 7 months ago by rabmalin (previous) (diff)

#6 @williampatton
7 months ago

Hi @rabmalin

Massively appreciate you taking the time to run a preliminary review for me here before I reached the front of the queue.

I know that the checker plugins are only part of what is checked in a review so thank you for directing me towards other issues the sniff are not able to auto check. I'll take care of the items you noted in the next 2 days.

I see now that my screenshot dimensions are backwards, it's 3:4. I can fix easy.

I'll take care of the other issues as well ASAP :)

Regarding this one:

REQUIRED: wp_bootstrap_navwalker.php - When loading third party PHP library check class_exists before loading to to avoid conflict.

As an aspiring reviewer I'm interested in at what point this becomes a requirement. Is that a requirement when loading any classes in? Only if they are 3rd party?

Thanks again!

#7 @rabmalin
7 months ago

If that library is already loaded by some other plugins, then there will be Class already defined PHP fatal error. So, proper check is needed to avoid such fatal error.

#8 @williampatton
7 months ago

So it's required any time a class is loaded?

#9 @rabmalin
7 months ago

Yes, whenever we are using third party PHP library.

#10 @themetracbot
7 months ago

  • Summary changed from THEME: Best Reloaded – 0.9.2 to THEME: Best Reloaded – 0.10.0

Best Reloaded - 0.10.0

A responsive, mobile-first, WordPress theme that uses Bootstrap.

Theme URL - http://www.pattonwebz.com/best-reloaded-bootstrap-theme
Author URL - http://pattonwebz.com/

Trac Browser - https://themes.trac.wordpress.org/browser/best-reloaded/0.10.0

SVN - https://themes.svn.wordpress.org/best-reloaded/0.10.0
ZIP - https://wordpress.org/themes/download/best-reloaded.0.10.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=best-reloaded/0.9.2&new_path=best-reloaded/0.10.0

History:

Ticket Summary Status Resolution Owner
#26796 THEME: Best Reloaded – 0.6 closed not-approved WEN Solutions
#39696 THEME: Best Reloaded – 0.14.0 closed live acosmin

(this ticket)

#44536 THEME: Best Reloaded – 1.0.0 closed live themetracbot
#45604 THEME: Best Reloaded – 1.1.0 closed live themetracbot
#46529 THEME: Best Reloaded – 1.4.1 closed live themetracbot
#46530 THEME: Best Reloaded – 1.4.2 closed live themetracbot
#47480 THEME: Best Reloaded – 1.4.3 closed live themetracbot
#47503 THEME: Best Reloaded – 1.5.0 closed live themetracbot


https://themes.svn.wordpress.org/best-reloaded/0.10.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • WARNING: Found a translation function that is missing a text-domain. Function esc_html_e, with the arguments "Sorry, couldn't get any slides."
  • WARNING: Found a translation function that is missing a text-domain. Function esc_attr_e, with the arguments 'type and hit "enter" to search'
  • WARNING: Found a translation function that is missing a text-domain. Function , with the arguments 'Toggle on/off the the header slot.'
  • WARNING: Found a translation function that is missing a text-domain. Function , with the arguments 'Enter the text you want to show in the header slot. Accepts some basic html.'

#11 @themetracbot
7 months ago

  • Summary changed from THEME: Best Reloaded – 0.10.0 to THEME: Best Reloaded – 0.10.1

Best Reloaded - 0.10.1

A responsive, mobile-first, WordPress theme that uses Bootstrap.

Theme URL - http://www.pattonwebz.com/best-reloaded-bootstrap-theme
Author URL - http://pattonwebz.com/

Trac Browser - https://themes.trac.wordpress.org/browser/best-reloaded/0.10.1

SVN - https://themes.svn.wordpress.org/best-reloaded/0.10.1
ZIP - https://wordpress.org/themes/download/best-reloaded.0.10.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=best-reloaded/0.10.0&new_path=best-reloaded/0.10.1

History:

Ticket Summary Status Resolution Owner
#26796 THEME: Best Reloaded – 0.6 closed not-approved WEN Solutions
#39696 THEME: Best Reloaded – 0.14.0 closed live acosmin

(this ticket)

#44536 THEME: Best Reloaded – 1.0.0 closed live themetracbot
#45604 THEME: Best Reloaded – 1.1.0 closed live themetracbot
#46529 THEME: Best Reloaded – 1.4.1 closed live themetracbot
#46530 THEME: Best Reloaded – 1.4.2 closed live themetracbot
#47480 THEME: Best Reloaded – 1.4.3 closed live themetracbot
#47503 THEME: Best Reloaded – 1.5.0 closed live themetracbot


https://themes.svn.wordpress.org/best-reloaded/0.10.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#12 @themetracbot
7 months ago

  • Summary changed from THEME: Best Reloaded – 0.10.1 to THEME: Best Reloaded – 0.12.0

Best Reloaded - 0.12.0

A responsive, mobile-first, WordPress theme that uses Bootstrap.

Theme URL - http://www.pattonwebz.com/best-reloaded-bootstrap-theme
Author URL - http://pattonwebz.com/

Trac Browser - https://themes.trac.wordpress.org/browser/best-reloaded/0.12.0

SVN - https://themes.svn.wordpress.org/best-reloaded/0.12.0
ZIP - https://wordpress.org/themes/download/best-reloaded.0.12.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=best-reloaded/0.10.1&new_path=best-reloaded/0.12.0

History:

Ticket Summary Status Resolution Owner
#26796 THEME: Best Reloaded – 0.6 closed not-approved WEN Solutions
#39696 THEME: Best Reloaded – 0.14.0 closed live acosmin

(this ticket)

#44536 THEME: Best Reloaded – 1.0.0 closed live themetracbot
#45604 THEME: Best Reloaded – 1.1.0 closed live themetracbot
#46529 THEME: Best Reloaded – 1.4.1 closed live themetracbot
#46530 THEME: Best Reloaded – 1.4.2 closed live themetracbot
#47480 THEME: Best Reloaded – 1.4.3 closed live themetracbot
#47503 THEME: Best Reloaded – 1.5.0 closed live themetracbot


https://themes.svn.wordpress.org/best-reloaded/0.12.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#13 @acosmin
7 months ago

  • Owner set to acosmin
  • Status changed from new to reviewing

#14 @acosmin
7 months ago

  1. remove @package WordPress from all your files.
  1. $content_width needs to be set as a global example
    • it's being added two times, 1st in functions.php:L12 and 2nd in inc\theme-setup.php:L20
  1. inc\theme-setup.php
    • L33,43 make the strings translatable, use esc_attr__() for the title and __() for anchor text
    • L51, handle needs to be prefixed
    • best_reloaded_load_styles() you don't need to register them, just enqueue. Also 3rd party scripts don't need prefixes/suffixes.
      • same thing can be said about best_reloaded_load_scripts()
    • L199, add the $length parameter and in the function add something like if( is_admin() ) { return $length; } before L200, this way it doesn't affect the admin area.
  1. inc\customizer.php
    • you don't need to add 'type' => 'theme_mod' to all your settings, it already defaults to that.
    • prefixing theme mods is not a good idea (unless they conflict with some other Core names), they are added in an option which is already prefixed. If they are prefixed like in your case, they just use space in the database.
    • remove L171,187, they don't do nothing, you need to use apply_filters() for them to do something.
  1. single.php
    • L24-30, just a recommendation, you could use printf() to make it just a line.
    • L32-35, use the_post_navigation() instead, it has some filters if you want to change the output
  1. searchform.php
    • L13, you can't echo esc_attr_e(), it already echos (unless you want to use esc_attr__());
    • L14, use esc_attr_e() or *_x() on the value
  1. loop-slides.php
    • L33 doesn't need escaping
  1. index.php
    • L22, use the_posts_navigation() instead
  1. header.php
    • the aria-label needs to be translatable, esc_attr_e()
  1. footer.php
    • change on L41 the default with:
      • sprintf( __( '© %1$s %2$s' ), date_i18n( __( 'Y', 'best-reloaded' ) ), get_bloginfo( 'name' ) );
        • add the same on L146 in customizer.php
  1. remove the go to post/page -> text from the images in img folder. It needs to be translatable and it can't be :)
  1. readme.txt
    • You need to provide license information for any assets used in your theme in this format (check Bundled Resource Copyright Attribution)
    • missing license info:
      • img\featured-bg-thumb-up.png
Last edited 7 months ago by acosmin (previous) (diff)

#15 @acosmin
7 months ago

Forgot about this, the admin toolbar is overlapping with your sticky menu. Please fix it for all devices.

#16 @williampatton
7 months ago

Hi @acosmin,

Thank you for your initial review, I'll make a start on these issues just now.

Also menu overlap I can fix :)

#17 @themetracbot
7 months ago

  • Summary changed from THEME: Best Reloaded – 0.12.0 to THEME: Best Reloaded – 0.13.0

Best Reloaded - 0.13.0

A responsive, mobile-first, WordPress theme that uses Bootstrap.

Theme URL - http://www.pattonwebz.com/best-reloaded-bootstrap-theme
Author URL - http://pattonwebz.com/

Trac Browser - https://themes.trac.wordpress.org/browser/best-reloaded/0.13.0

SVN - https://themes.svn.wordpress.org/best-reloaded/0.13.0
ZIP - https://wordpress.org/themes/download/best-reloaded.0.13.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=best-reloaded/0.12.0&new_path=best-reloaded/0.13.0

History:

Ticket Summary Status Resolution Owner
#26796 THEME: Best Reloaded – 0.6 closed not-approved WEN Solutions
#39696 THEME: Best Reloaded – 0.14.0 closed live acosmin

(this ticket)

#44536 THEME: Best Reloaded – 1.0.0 closed live themetracbot
#45604 THEME: Best Reloaded – 1.1.0 closed live themetracbot
#46529 THEME: Best Reloaded – 1.4.1 closed live themetracbot
#46530 THEME: Best Reloaded – 1.4.2 closed live themetracbot
#47480 THEME: Best Reloaded – 1.4.3 closed live themetracbot
#47503 THEME: Best Reloaded – 1.5.0 closed live themetracbot


https://themes.svn.wordpress.org/best-reloaded/0.13.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • WARNING: Found a translation function that is missing a text-domain. Function , with the arguments '© %1$s %2$s'

#18 @themetracbot
7 months ago

  • Summary changed from THEME: Best Reloaded – 0.13.0 to THEME: Best Reloaded – 0.13.1

Best Reloaded - 0.13.1

A responsive, mobile-first, WordPress theme that uses Bootstrap.

Theme URL - http://www.pattonwebz.com/best-reloaded-bootstrap-theme
Author URL - http://pattonwebz.com/

Trac Browser - https://themes.trac.wordpress.org/browser/best-reloaded/0.13.1

SVN - https://themes.svn.wordpress.org/best-reloaded/0.13.1
ZIP - https://wordpress.org/themes/download/best-reloaded.0.13.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=best-reloaded/0.13.0&new_path=best-reloaded/0.13.1

History:

Ticket Summary Status Resolution Owner
#26796 THEME: Best Reloaded – 0.6 closed not-approved WEN Solutions
#39696 THEME: Best Reloaded – 0.14.0 closed live acosmin

(this ticket)

#44536 THEME: Best Reloaded – 1.0.0 closed live themetracbot
#45604 THEME: Best Reloaded – 1.1.0 closed live themetracbot
#46529 THEME: Best Reloaded – 1.4.1 closed live themetracbot
#46530 THEME: Best Reloaded – 1.4.2 closed live themetracbot
#47480 THEME: Best Reloaded – 1.4.3 closed live themetracbot
#47503 THEME: Best Reloaded – 1.5.0 closed live themetracbot


https://themes.svn.wordpress.org/best-reloaded/0.13.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#19 @acosmin
7 months ago

Almost there...

Point 3, issue 1, you also need to make the title attribute translatable, using esc_attr__()
Point 3, issue 2, not fixed, when using add_image_size() you need to prefix the handle
Point 4, issue 3, not fixed
Point 9, issue 1, esc_attr_e(), not _html

#20 @williampatton
7 months ago

Hey, getting on these now :)

Regarding Point 4, issue 3.

Those are the sanitization functions I use with the customizer settings. I understand that the filter I added was unnecessary and I can remove that but if I remove the functions completely my sanitization will fail. Do you think I should using core functions for sanitization instead here? They are for sanitizing text areas and checkboxes.

#21 @acosmin
7 months ago

just remove these 2 lines:

  • add_filter( 'best_reloaded_sanitize_textarea', 'best_reloaded_sanitize_textarea' );
  • add_filter( 'best_reloaded_sanitize_checkbox', 'best_reloaded_sanitize_checkbox' );

and leave the functions.

There is no need for those filters, the sanitize part of add_setting calls the functions, not filters.

#22 @themetracbot
7 months ago

  • Summary changed from THEME: Best Reloaded – 0.13.1 to THEME: Best Reloaded – 0.14.0

Best Reloaded - 0.14.0

A responsive, mobile-first, WordPress theme that uses Bootstrap.

Theme URL - http://www.pattonwebz.com/best-reloaded-bootstrap-theme
Author URL - http://pattonwebz.com/

Trac Browser - https://themes.trac.wordpress.org/browser/best-reloaded/0.14.0

SVN - https://themes.svn.wordpress.org/best-reloaded/0.14.0
ZIP - https://wordpress.org/themes/download/best-reloaded.0.14.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=best-reloaded/0.13.1&new_path=best-reloaded/0.14.0

History:

Ticket Summary Status Resolution Owner
#26796 THEME: Best Reloaded – 0.6 closed not-approved WEN Solutions
#39696 THEME: Best Reloaded – 0.14.0 closed live acosmin

(this ticket)

#44536 THEME: Best Reloaded – 1.0.0 closed live themetracbot
#45604 THEME: Best Reloaded – 1.1.0 closed live themetracbot
#46529 THEME: Best Reloaded – 1.4.1 closed live themetracbot
#46530 THEME: Best Reloaded – 1.4.2 closed live themetracbot
#47480 THEME: Best Reloaded – 1.4.3 closed live themetracbot
#47503 THEME: Best Reloaded – 1.5.0 closed live themetracbot


https://themes.svn.wordpress.org/best-reloaded/0.14.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#23 @acosmin
7 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

@williampatton Congrats, your theme should be live shortly!

Note: See TracTickets for help on using tickets.