WordPress.org

Make WordPress Themes

Opened 8 months ago

Closed 5 months ago

Last modified 5 months ago

#40011 closed theme (live)

THEME: Checathlon – 1.1.4

Reported by: sami.keijonen Owned by: acosmin
Priority: previously reviewed Keywords: theme-checathlon accessibility-ready
Cc: sami.keijonen@…

Description

Checathlon - 1.1.1

Checathlon is the perfect theme for your next business site. Or selling your digital products using Easy Digital Downloads Plugin. You can also showcase your services, portfolios, testimonials, and team members. There are multiple widget areas to set content in many ways. What more you need for your business or e-commerce site!

Theme URL - https://foxland.fi/downloads/checathlon/
Author URL - https://foxland.fi/

SVN - https://themes.svn.wordpress.org/checathlon/1.1.1
ZIP - https://wordpress.org/themes/download/checathlon.1.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=checathlon/1.0.0&new_path=checathlon/1.1.1

History:

Ticket Summary Status Resolution Owner
#38379 THEME: Checathlon – 1.0.0 closed not-approved rabmalin
#40011 THEME: Checathlon – 1.1.4 closed live acosmin

(this ticket)

#42532 THEME: Checathlon – 1.2.0 closed live themetracbot
#44348 THEME: Checathlon – 1.2.1 closed live themetracbot
#44350 THEME: Checathlon – 1.2.2 closed live themetracbot


https://themes.svn.wordpress.org/checathlon/1.1.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: Could not find the file readme.txt in the theme. Please see Theme_Documentation for more information.

Change History (16)

#1 @acosmin
6 months ago

  • Keywords changed from theme-checathlon, accessibility-ready to theme-checathlon accessibility-ready
  • Owner set to acosmin
  • Status changed from new to reviewing

#2 @sami.keijonen
6 months ago

Hi @acosmin. I noticed that I don't have the latest version here. For example image license shown in screenshot is not mentioned in the readme file.

Do you want me to upload a new version at this point? Or wait for your review and fix other issues in the same time if there are any:)

#3 @acosmin
6 months ago

  • functions.php
    • Shouldn't the checathlon_google_fonts filter be put somewhere after L324. This way you can also get the already registered fonts and manipulate them.
  • menu-primary.php, menu-social.php
    • the aria-label attribute should use esc_attr_e()
  • README.md
    • you forgot the license information for images used in the screenshot.
    • also theme licence, something like this

@sami.keijonen You were faster than me :D anyway, you can upload an update and after that you need an accessibility review.

#4 @sami.keijonen
6 months ago

Thanks @acosmin for review. I push the updates soon.

#5 @sami.keijonen
6 months ago

Before I update the theme is theme license OK to say as there is already with link to GPL site?

https://github.com/samikeijonen/checathlon#copyright-and-license

All other resources and theme elements are licensed under the GNU GPL, version 2 or later.

#6 @acosmin
6 months ago

Yes, that's ok :)

#7 @themetracbot
6 months ago

  • Summary changed from THEME: Checathlon – 1.1.1 to THEME: Checathlon – 1.1.3

Checathlon - 1.1.3

Checathlon is the perfect theme for your next business site. Or selling your digital products using Easy Digital Downloads Plugin. You can also showcase your services, portfolios, testimonials, and team members. There are multiple widget areas to set content in many ways. What more you need for your business or e-commerce site!

Theme URL - https://foxland.fi/downloads/checathlon/
Author URL - https://foxland.fi/

Trac Browser - https://themes.trac.wordpress.org/browser/checathlon/1.1.3

SVN - https://themes.svn.wordpress.org/checathlon/1.1.3
ZIP - https://wordpress.org/themes/download/checathlon.1.1.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=checathlon/1.1.1&new_path=checathlon/1.1.3

History:

Ticket Summary Status Resolution Owner
#38379 THEME: Checathlon – 1.0.0 closed not-approved rabmalin
#40011 THEME: Checathlon – 1.1.4 closed live acosmin

(this ticket)

#42532 THEME: Checathlon – 1.2.0 closed live themetracbot
#44348 THEME: Checathlon – 1.2.1 closed live themetracbot
#44350 THEME: Checathlon – 1.2.2 closed live themetracbot


https://themes.svn.wordpress.org/checathlon/1.1.3/screenshot.png
Theme Check Results:

  • RECOMMENDED: Could not find the file readme.txt in the theme. Please see Theme_Documentation for more information.

#8 @acosmin
6 months ago

@sami.keijonen everything looks ok based on diff, pinging @joedolson for the accessibility review.

#9 @joedolson
6 months ago

On my list!

#10 @jcastaneda
6 months ago

Hey @joedolson wanted to see if you are able to take a look over this in the next couple of days?

#11 @joedolson
6 months ago

Hi, @sami - Sorry about the extreme delay! There are a couple of issues to address:

1) Keyboard Navigation - Pass

2) Controls - Pass

3) Skip Links - Pass

4) Forms - Pass

5) Headings - Pass

6) ARIA Landmark Roles - Fail

  • Inside .footer-widgets-wrapper, there's an instance of the site title and description that is orphaned, not contained inside any landmark role. I think I'd recommend placing the entire widgets-wrapper inside a complementary role and removing the <aside> elements on the individual widget regions inside that section.

7) Link Text - Pass

8) Contrasts - Fail

  • #ff1654 has a contrast of 3.82:1 on white - this is fine in headings, but is below contrast requirements in links (Read more, main nav, etc.)

9) Images - Pass

10) Media - None identified; default pass.

11) Not Allowed - Pass

Theme Accessibility Guidelines & Tips:
https://make.wordpress.org/themes/handbook/review/accessibility/required/

#12 @themetracbot
5 months ago

  • Summary changed from THEME: Checathlon – 1.1.3 to THEME: Checathlon – 1.1.4

Checathlon - 1.1.4

Checathlon is the perfect theme for your next business site. Or selling your digital products using Easy Digital Downloads Plugin. You can also showcase your services, portfolios, testimonials, and team members. There are multiple widget areas to set content in many ways. What more you need for your business or e-commerce site!

Theme URL - https://foxland.fi/downloads/checathlon/
Author URL - https://foxland.fi/

Trac Browser - https://themes.trac.wordpress.org/browser/checathlon/1.1.4

SVN - https://themes.svn.wordpress.org/checathlon/1.1.4
ZIP - https://wordpress.org/themes/download/checathlon.1.1.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=checathlon/1.1.3&new_path=checathlon/1.1.4

History:

Ticket Summary Status Resolution Owner
#38379 THEME: Checathlon – 1.0.0 closed not-approved rabmalin
#40011 THEME: Checathlon – 1.1.4 closed live acosmin

(this ticket)

#42532 THEME: Checathlon – 1.2.0 closed live themetracbot
#44348 THEME: Checathlon – 1.2.1 closed live themetracbot
#44350 THEME: Checathlon – 1.2.2 closed live themetracbot


https://themes.svn.wordpress.org/checathlon/1.1.4/screenshot.png
Theme Check Results:

  • RECOMMENDED: Could not find the file readme.txt in the theme. Please see Theme_Documentation for more information.

#13 @sami.keijonen
5 months ago

Thanks @joedolson for review! Here is updated version.

#14 @joedolson
5 months ago

Looks great! Approved for #accessibility-ready based on diff.

#15 @acosmin
5 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

@sami.keijonen Congrats, your theme should be live shortly!

#16 @sami.keijonen
5 months ago

Thanks @acosmin and @joedolson!

Note: See TracTickets for help on using tickets.