WordPress.org

Make WordPress Themes

Opened 9 months ago

Closed 6 months ago

Last modified 6 months ago

#40027 closed theme (not-approved)

THEME: BootstrapFast – 1.0.1

Reported by: carl-alberto Owned by: juhise
Priority: new theme Keywords: theme-bootstrapfast
Cc: cralberto11@…

Description

BootstrapFast - 1.0.0

Fast lightweight theme based from Underscores and Bootstrap Responsive grid

Theme URL - https://carl.alber2.com/theme/bootstrapfast
Author URL - https://carl.alber2.com

SVN - https://themes.svn.wordpress.org/bootstrapfast/1.0.0
ZIP - https://wordpress.org/themes/download/bootstrapfast.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#40027 THEME: BootstrapFast – 1.0.1 closed not-approved juhise

(this ticket)

#42772 THEME: BootstrapFast – 1.0.2 closed live ShinichiN
#47164 THEME: BootstrapFast – 1.0.3 closed live themetracbot


https://themes.svn.wordpress.org/bootstrapfast/1.0.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.

Change History (20)

#1 @joyously
7 months ago

  • Theme link in footer links to #.
  • Menu background is transparent, so submenus can't be read on top of other text.
  • My static home Page did not show its featured image. Actually, none of my featured images show. (Theme is tagged featured-images.)
  • Comments show the ordered list number, which is confusing for paged or nested comments. Try using CSS for hiding it or making it more logical (CSS counters).
  • Styling: nothing to distinguish blockquote

#2 @juhise
7 months ago

  • Owner set to juhise
  • Status changed from new to reviewing

#3 @juhise
7 months ago

Hello @carl-alberto

I am reviewing your theme, here is my findings. Please fix below and upload within 7 days, if need more days then please comment on the ticket.

Thanks @joyously for the initial review @carl-alberto please take care of above too.

REQUIRED

  • Remove readme.md file
  • Either remove the tag featured-image or display featured image the_post_thumbnail()
  • You don’t need to manually add the jquery, remove L32 assetloader.php. jQuery is automatically loaded when there is a dependency.
  • Add the code to display custom header image.
  • Update readme.txt and also gives the license information of third party styles/scripts etc.

THEME UNIT TEST

  • Custom menu widget with more than 3 level looks broken

Best Regards,
Juhi

#4 @juhise
7 months ago

Hey @carl-alberto

Kind reminder: Please upload your updated theme or if you need more time please drop a comment. The rule is to close the theme if don't get any activity from author within 7 days.

Best Regards,
Juhi

#5 @juhise
7 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hey @carl-alberto

I am closing this theme due to inactivity.

Best Regards,
Juhi

#6 @carl-alberto
7 months ago

Hi @juhise & @joyously,

Sorry I didn't get notified that my theme has already been started to be reviewed, please give me a week to action the above items and please re-open my ticket I have been waiting for this review for a few months already :)

Thank You & Kind Regards,
Carl A

Last edited 7 months ago by carl-alberto (previous) (diff)

#7 @juhise
7 months ago

  • Resolution not-approved deleted
  • Status changed from closed to reopened

#8 @rabmalin
7 months ago

  • Status changed from reopened to reviewing

#9 @carl-alberto
6 months ago

Hi @rabmalin & @juhise,

May I request for another week of extension for review, my hands got full for the past days.

Thanks!

#10 @juhise
6 months ago

Hey @carl-alberto

No problem, just keep me updated :) .

Best Regards,
Juhi

#11 @themetracbot
6 months ago

  • Summary changed from THEME: BootstrapFast – 1.0.0 to THEME: BootstrapFast – 1.0.1

BootstrapFast - 1.0.1

Fast lightweight theme based from Underscores utilizing Bootstrap Responsive grid

Theme URL - https://carl.alber2.com/theme/bootstrapfast
Author URL - https://carl.alber2.com

Trac Browser - https://themes.trac.wordpress.org/browser/bootstrapfast/1.0.1

SVN - https://themes.svn.wordpress.org/bootstrapfast/1.0.1
ZIP - https://wordpress.org/themes/download/bootstrapfast.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=bootstrapfast/1.0.0&new_path=bootstrapfast/1.0.1

History:

Ticket Summary Status Resolution Owner
#40027 THEME: BootstrapFast – 1.0.1 closed not-approved juhise

(this ticket)

#42772 THEME: BootstrapFast – 1.0.2 closed live ShinichiN
#47164 THEME: BootstrapFast – 1.0.3 closed live themetracbot


https://themes.svn.wordpress.org/bootstrapfast/1.0.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#12 @carl-alberto
6 months ago

Hi @juhise,

Thanks for having time to review my theme, here are my response:

  • Remove readme.md file > done
  • Either remove the tag featured-image or display featured image the_post_thumbnail() > done
  • Add the code to display custom header image. > done
  • You don’t need to manually add the jquery, remove L32 assetloader.php. jQuery is automatically loaded when there is a dependency. > removed jquery since it is already included in core
  • Modifying/ Removing non presentational hooks not allowed. L26-33 security.php Refer https://make.wordpress.org/themes/handbook/review/required/explanations-and-examples/ > removed
  • Add the required tags from the list https://make.wordpress.org/themes/handbook/review/required/theme-tags/ > added all relevant tags
  • Update readme.txt and also gives the license information of third party styles/scripts etc. > updated licensing and attribution in readme.txt and in style.css
  • Custom menu widget with more than 3 level looks broken > fixed
  • Theme link in footer links to #. > fixed
  • Menu background is transparent, so submenus can't be read on top of other text. > fixed
  • My static home Page did not show its featured image. Actually, none of my featured images show. (Theme is tagged featured-images.) > featured images now implemented in the single blog template
  • Comments show the ordered list number, which is confusing for paged or nested comments. Try using CSS for hiding it or making it more logical (CSS counters). > fixed
  • See Proper Copyright/License Attribution for Themes > updated licensing and attribution in readme.txt and in style.css
  • Styling: nothing to distinguish blockquote > fixed

Thanks you!

Last edited 6 months ago by carl-alberto (previous) (diff)

This ticket was mentioned in Slack in #themereview by juhise. View the logs.


6 months ago

#14 @meissudeep
6 months ago

@carl-alberto
I am continuing this review will be back soon :)
@poena assign this ticket to me.

#15 @carl-alberto
6 months ago

Hi @meissudeep,

Thanks! hope you will be easy on me, this is my first theme and learned a lot about the theme review and theme development along the process :)

#16 @meissudeep
6 months ago

Hello @carl-alberto

Here is my initial review

Issues

  • You are suppose to use wp_enqueue_scripts not wp_footer while enqueing the scripts.
  • Provide a unique prefix for everything the Theme defines in the public namespace, including options, functions, global variables, constants, post meta, etc. http://themereview.co/prefix-all-the-things/ see functions such as asset_dir(), stylesuffix(), theme_prefix_setup() etc.
  • Update your POT file according to your theme. Or you can remove whole languages folder if you want to take advantage of WordPress Language Pack.
  • You cann't use 'sanitize_callback' => 'esc_textarea', for select 'type' => 'select', you can create custom one see other themes as example.
  • why are you using after_setup_theme for multiple times simply copy the code related to logo in you bootstrapfast_setup() function.
  • You can remove .map files, I don't see any of that being used.
  • Remove all commented codes and unwanted files such as assets/index.php, check others as well.

#17 @carl-alberto
6 months ago

Hi @meissudeep,

Thanks for the review, please give me another week to resolve all of this.

Kind Regards,
Carl A

#18 @meissudeep
6 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hello @carl-alberto

It has been 8 extra days, so I am marking this ticket as not-approved.

#19 @carl-alberto
6 months ago

Hi @meissudeep,

May I request for another week extension? Got my hands full from the past days sorry.

Thank you very much and kind regards,
Carl A

#20 @carl-alberto
6 months ago

Hi @meissudeep & @juhise ,

  • You are suppose to use wp_enqueue_scripts not wp_footer while enqueing the scripts. > I have put all styles and JS using the wp_enqueue_scripts. Initially I thought it would be better to hook it in the footer to make the theme load lighter.
  • Provide a unique prefix for everything the Theme defines in the public namespace, including options, functions, global variables, constants, post meta, etc. http://themereview.co/prefix-all-the-things/ see functions such as asset_dir(), stylesuffix(), theme_prefix_setup() etc. > added theme prefix that I can find
  • Update your POT file according to your theme. Or you can remove whole languages folder if you want to take advantage of WordPress Language Pack. > Removed the languages folder
  • You cann't use 'sanitize_callback' => 'esc_textarea', for select 'type' => 'select', you can create custom one see other themes as example. > removed unused callbacks
  • why are you using after_setup_theme for multiple times simply copy the code related to logo in you bootstrapfast_setup() function. > minimized the use of after_setup_theme()
  • You can remove .map files, I don't see any of that being used. > removed all unneeded map files
  • Remove all commented codes and unwanted files such as assets/index.php, check others as well., > removed
  • Added sanitation callback every time add_setting() is used

Thank you and kind regards,
Carl A

Note: See TracTickets for help on using tickets.