WordPress.org

Make WordPress Themes

Opened 8 months ago

Closed 5 months ago

Last modified 5 months ago

#40211 closed theme (live)

THEME: Frindle – 10.2.5

Reported by: zipal Owned by: bplv
Priority: previously reviewed Keywords: theme-frindle
Cc: zipal96@…

Description

Frindle - 10.1.1

Frindle is a mobile friendly WordPress theme for blogs, magazines and business websites. It’s been designed to beautifully display pictures and text content, and engineered to be easy to use and fast. The Frindle theme helps you attract and retain more visitors.

Theme URL - http://frindle.phoenixwebsolutions.net/
Author URL - http://fancyfrindle.com/

Trac Browser - https://themes.trac.wordpress.org/browser/frindle/10.1.1

SVN - https://themes.svn.wordpress.org/frindle/10.1.1
ZIP - https://wordpress.org/themes/download/frindle.10.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=frindle/10.1.0&new_path=frindle/10.1.1

History:

Ticket Summary Status Resolution Owner
#36198 THEME: Frindle – 10.1.0 closed not-approved ponvendhan
#40211 THEME: Frindle – 10.2.5 closed live bplv

(this ticket)

#43950 THEME: Frindle – 10.2.6 closed live themetracbot


https://themes.svn.wordpress.org/frindle/10.1.1/screenshot.png

Change History (41)

#1 @themetracbot
7 months ago

  • Summary changed from THEME: Frindle – 10.1.1 to THEME: Frindle – 10.1.2

Frindle - 10.1.2

Frindle is a mobile friendly WordPress theme for blogs, magazines and business websites. It’s been designed to beautifully display pictures and text content, and engineered to be easy to use and fast. The Frindle theme helps you attract and retain more visitors.

Theme URL - http://frindle.phoenixwebsolutions.net/
Author URL - http://fancyfrindle.com/

Trac Browser - https://themes.trac.wordpress.org/browser/frindle/10.1.2

SVN - https://themes.svn.wordpress.org/frindle/10.1.2
ZIP - https://wordpress.org/themes/download/frindle.10.1.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=frindle/10.1.1&new_path=frindle/10.1.2

History:

Ticket Summary Status Resolution Owner
#36198 THEME: Frindle – 10.1.0 closed not-approved ponvendhan
#40211 THEME: Frindle – 10.2.5 closed live bplv

(this ticket)

#43950 THEME: Frindle – 10.2.6 closed live themetracbot


https://themes.svn.wordpress.org/frindle/10.1.2/screenshot.png

#2 @ponvendhan
7 months ago

Hi @zipal
This is not an official review. Consider it as a suggestion.

styles and scripts handler.
functions.php line 5 - frindle-icons should be font-awesome

why do you set add_image_size as variable?
you can set add_image_size('frindle-small-thumbnail', 300, 195, true); as usual
and can output by simply calling the_post_thumbnail('frindle-small-thumbnail');

All theme text strings are to be translatable.
functions.php line 164: Read More &raquo
searchform.php line 2: Search for
searchform.php line 3: "Search . . ." & don't forget to use … instead of ...
searchform.php line 4: Search
archive.php line 106, 107
comments.php line 58
content-audio.php line 18: by
please look all files

Escapes missing
content-audio.php get_author_posts_url should be escaped with esc_url()
content-page.php get_the_permalink should be escaped with esc_url()
content-page.php get_the_title should be escaped with esc_html()
check all files

$content_width should be defined as global and hooked by after_setup_theme
refer twentyseventeen

I think add_meta_box are not allowed. You can confirm in slack (theme review channel)

Remove frindle_profile_fields(), save_frindle_profile_fields()
Not allowed because when user change theme, these fields will vanished.

Provide copy right info like this in readme.txt
frindle WordPress theme, Copyright 2017 zipal
frindle is distributed under the terms of the GNU GPL

Update readme file to keep credits and license info of all third party resources. Eg, fonts, images, scripts, etc.
unable to find license info for pictures in images folder
unable to find license info for images used in screenshot - (you have used 16 images in screenshot.png)

Remove unused files
font-awesome.min.css, jquery-1.11.0.min

Remove add_theme_support('html5', array('search-form')); as you are manually defining your search form
searchform.php remove action="<?php get_stylesheet_directory_uri(); ?>/"> which is causing error. use action="<?php echo home_url( '/' ); ?>"> instead.

php errors
Notice: Undefined variable: facebook in C:\wamp\www\ammu\wp-content\themes\frindle\inc\widget\social-links.php on line 38
Notice: Undefined variable: twitter in C:\wamp\www\ammu\wp-content\themes\frindle\inc\widget\social-links.php on line 43
Notice: Undefined variable: google in C:\wamp\www\ammu\wp-content\themes\frindle\inc\widget\social-links.php on line 48
Notice: Undefined variable: linkedin in C:\wamp\www\ammu\wp-content\themes\frindle\inc\widget\social-links.php on line 53
Notice: Undefined index: widget_title in C:\wamp\www\ammu\wp-content\themes\frindle\inc\widget\flickr.php on line 55
Notice: Undefined index: id in C:\wamp\www\ammu\wp-content\themes\frindle\inc\widget\flickr.php on line 56
Notice: Undefined index: number in C:\wamp\www\ammu\wp-content\themes\frindle\inc\widget\flickr.php on line 57

Most of the included plugins are plugin territory. I recommend to remove all plugins.

Recommend
Consider to add descriptions on sidebar (register_sidebar) so user can understand how to use it.
archive.php: can use the_archive_description instead of category_description
found few inline css here and there. Try to remove those. Eg. archive.php

Note: Please self review your all files once again. fix all issues. Also keep in mind that a review may close this ticket if 5 distinct issues found.

Regard,
Ponvendhan

This ticket was mentioned in Slack in #themereview by ivorysoda. View the logs.


7 months ago

#4 @themetracbot
7 months ago

  • Summary changed from THEME: Frindle – 10.1.2 to THEME: Frindle – 10.1.3

Frindle - 10.1.3

Frindle is a mobile friendly WordPress theme for blogs, magazines and business websites. It’s been designed to beautifully display pictures and text content, and engineered to be easy to use and fast. The Frindle theme helps you attract and retain more visitors.

Theme URL - http://frindle.phoenixwebsolutions.net/
Author URL - http://fancyfrindle.com/

Trac Browser - https://themes.trac.wordpress.org/browser/frindle/10.1.3

SVN - https://themes.svn.wordpress.org/frindle/10.1.3
ZIP - https://wordpress.org/themes/download/frindle.10.1.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=frindle/10.1.2&new_path=frindle/10.1.3

History:

Ticket Summary Status Resolution Owner
#36198 THEME: Frindle – 10.1.0 closed not-approved ponvendhan
#40211 THEME: Frindle – 10.2.5 closed live bplv

(this ticket)

#43950 THEME: Frindle – 10.2.6 closed live themetracbot


https://themes.svn.wordpress.org/frindle/10.1.3/screenshot.png
Theme Check Results:

  • WARNING: Found a translation function that is missing a text-domain. Function esc_html, with the arguments '

This ticket was mentioned in Slack in #themereview by ivorysoda. View the logs.


7 months ago

#6 @themetracbot
7 months ago

  • Summary changed from THEME: Frindle – 10.1.3 to THEME: Frindle – 10.1.4

Frindle - 10.1.4

Frindle is a mobile friendly WordPress theme for blogs, magazines and business websites. It’s been designed to beautifully display pictures and text content, and engineered to be easy to use and fast. The Frindle theme helps you attract and retain more visitors.

Theme URL - http://frindle.phoenixwebsolutions.net/
Author URL - http://fancyfrindle.com/

Trac Browser - https://themes.trac.wordpress.org/browser/frindle/10.1.4

SVN - https://themes.svn.wordpress.org/frindle/10.1.4
ZIP - https://wordpress.org/themes/download/frindle.10.1.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=frindle/10.1.3&new_path=frindle/10.1.4

History:

Ticket Summary Status Resolution Owner
#36198 THEME: Frindle – 10.1.0 closed not-approved ponvendhan
#40211 THEME: Frindle – 10.2.5 closed live bplv

(this ticket)

#43950 THEME: Frindle – 10.2.6 closed live themetracbot


https://themes.svn.wordpress.org/frindle/10.1.4/screenshot.png

#7 @themetracbot
7 months ago

  • Summary changed from THEME: Frindle – 10.1.4 to THEME: Frindle – 10.1.5

Frindle - 10.1.5

Frindle is a mobile friendly WordPress theme for blogs, magazines and business websites. It’s been designed to beautifully display pictures and text content, and engineered to be easy to use and fast. The Frindle theme helps you attract and retain more visitors.

Theme URL - http://frindle.phoenixwebsolutions.net/
Author URL - http://fancyfrindle.com/

Trac Browser - https://themes.trac.wordpress.org/browser/frindle/10.1.5

SVN - https://themes.svn.wordpress.org/frindle/10.1.5
ZIP - https://wordpress.org/themes/download/frindle.10.1.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=frindle/10.1.4&new_path=frindle/10.1.5

History:

Ticket Summary Status Resolution Owner
#36198 THEME: Frindle – 10.1.0 closed not-approved ponvendhan
#40211 THEME: Frindle – 10.2.5 closed live bplv

(this ticket)

#43950 THEME: Frindle – 10.2.6 closed live themetracbot


https://themes.svn.wordpress.org/frindle/10.1.5/screenshot.png

#8 follow-up: @bplv
7 months ago

Hello @djrmom ,

Please assign me this ticket :)

Regards.

#9 in reply to: ↑ 8 @zipal
7 months ago

@bplv Thank you for the enthusiasm in reviewing my theme. I am really excited about the review.

Replying to bplv:

Hello @djrmom ,

Please assign me this ticket :)

Regards.

#10 @djrmom
7 months ago

  • Owner set to bplv
  • Status changed from new to reviewing

#11 @zipal
7 months ago

Hello @bplv I am updating the theme. So please review the theme after an update.
Thank you!

#12 @themetracbot
6 months ago

  • Summary changed from THEME: Frindle – 10.1.5 to THEME: Frindle – 10.1.6

Frindle - 10.1.6

Frindle is a mobile friendly WordPress theme for blogs, magazines and business websites. It’s been designed to beautifully display pictures and text content, and engineered to be easy to use and fast. The Frindle theme helps you attract and retain more visitors.

Theme URL - http://frindle.phoenixwebsolutions.net/
Author URL - http://fancyfrindle.com/

Trac Browser - https://themes.trac.wordpress.org/browser/frindle/10.1.6

SVN - https://themes.svn.wordpress.org/frindle/10.1.6
ZIP - https://wordpress.org/themes/download/frindle.10.1.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=frindle/10.1.5&new_path=frindle/10.1.6

History:

Ticket Summary Status Resolution Owner
#36198 THEME: Frindle – 10.1.0 closed not-approved ponvendhan
#40211 THEME: Frindle – 10.2.5 closed live bplv

(this ticket)

#43950 THEME: Frindle – 10.2.6 closed live themetracbot


https://themes.svn.wordpress.org/frindle/10.1.6/screenshot.png

#13 @bplv
6 months ago

Hello @zipal ,

I have reviewed your theme and found some issues that needs to be fixed before your theme is approved. Please fix the below given issues on or before 7 days or else your ticket will be closed (due to inactivity). If you need more time to resolve the issues you can always comment on the this ticket. If you do not understand any of the below given points you can always comment on the ticket or if you do not agree with any of the below given points (issues) we can always discuss it with a mentor or a key reviewer.

Required

  • You have used image from twitter, pinterest and some other blogs. Are you sure those images are licensed under GPL license ?
  • Use add_editor_style() function to use editor style
  • wp_link_pages() is required after the use of the_content() function.
  • Escaping missing functions.php line 171. , header.php line 88
  • Check escaping on each conte-...php files. All your content files have escaping missing.
  • No significant change on post formats design output. theme supports post formats and has distinct designs for post formats.
  • frindle_sanitize_checkbox() use a sanitization function like absint or something like that. Currently you are just checking the input values.
  • Use get_option("time_format") for proper time formatting on the_time() function.
  • Use get_template_directory(); instead of get_stylesheet_directory_uri(); to display the default-featured-image.png, as it can cause problems in child theme.
  • When you want to echo in normal context the_title() is used but in attribute context the_title_attribute() should be used.

Theme Check

FILE: /srv/www/wordpress-develop/public_html/src/wp-content/themes/frindle/archive.php
--------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------
 32 | ERROR | Only variables can be passed to empty() prior to PHP 5.5.
--------------------------------------------------------------------------------------


FILE: /srv/www/wordpress-develop/public_html/src/wp-content/themes/frindle/comments.php
--------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
 19 | ERROR | Missing singular placeholder, needed for some languages. See
    |       | https://codex.wordpress.org/I18n_for_WordPress_Developers#Plurals
--------------------------------------------------------------------------------------------------------------
Last edited 6 months ago by bplv (previous) (diff)

#14 @zipal
6 months ago

Hello @bplv

Thanks for the review. I am working on an update and will resolve the issues with 24 hours.

Cheers :)

#15 @themetracbot
6 months ago

  • Summary changed from THEME: Frindle – 10.1.6 to THEME: Frindle – 10.1.7

Frindle - 10.1.7

Frindle is a mobile friendly WordPress theme for blogs, magazines and business websites. It’s been designed to beautifully display pictures and text content, and engineered to be easy to use and fast. The Frindle theme helps you attract and retain more visitors.

Theme URL - http://frindle.phoenixwebsolutions.net/
Author URL - http://fancyfrindle.com/

Trac Browser - https://themes.trac.wordpress.org/browser/frindle/10.1.7

SVN - https://themes.svn.wordpress.org/frindle/10.1.7
ZIP - https://wordpress.org/themes/download/frindle.10.1.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=frindle/10.1.6&new_path=frindle/10.1.7

History:

Ticket Summary Status Resolution Owner
#36198 THEME: Frindle – 10.1.0 closed not-approved ponvendhan
#40211 THEME: Frindle – 10.2.5 closed live bplv

(this ticket)

#43950 THEME: Frindle – 10.2.6 closed live themetracbot


https://themes.svn.wordpress.org/frindle/10.1.7/screenshot.png

#16 @themetracbot
6 months ago

  • Summary changed from THEME: Frindle – 10.1.7 to THEME: Frindle – 10.1.8

Frindle - 10.1.8

Frindle is a mobile friendly WordPress theme for blogs, magazines and business websites. It’s been designed to beautifully display pictures and text content, and engineered to be easy to use and fast. The Frindle theme helps you attract and retain more visitors.

Theme URL - http://frindle.phoenixwebsolutions.net/
Author URL - http://fancyfrindle.com/

Trac Browser - https://themes.trac.wordpress.org/browser/frindle/10.1.8

SVN - https://themes.svn.wordpress.org/frindle/10.1.8
ZIP - https://wordpress.org/themes/download/frindle.10.1.8.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=frindle/10.1.7&new_path=frindle/10.1.8

History:

Ticket Summary Status Resolution Owner
#36198 THEME: Frindle – 10.1.0 closed not-approved ponvendhan
#40211 THEME: Frindle – 10.2.5 closed live bplv

(this ticket)

#43950 THEME: Frindle – 10.2.6 closed live themetracbot


https://themes.svn.wordpress.org/frindle/10.1.8/screenshot.png

#17 @bplv
6 months ago

Hello,

Here are some more issues that needs fixing.

Required

  • Escaping missing on searchform.php line 1, page-layout1.php line 22, page-layout4.php line 18, header.php line 21, content.php line 25, post-info.php line 18., functions.php 173.
  • Check all the the files under /widget/ folder. They have escaping missing in many places. check: popular-post.php 107-121 and other files too.
  • wp_link_pages() is required after the use of the_content() function.
  • Use esc_url for escaping urls, you have used esc_attr everywhere. Use proper function for proper escaping.
  • Make sure excerpt_length filter does not affect admin side. See Twenty Seventeen theme for reference.
  • Use the_excerpt() function rather than echo get_the_excerpt()
  • Theme URI is optional. If used, it must be about the theme we’re hosting on WordPress.org. If the URI is a demo site, the content must be about the theme itself and not test data. Currently there are test data.
  • You are only allowed to add one - three subject tags. Four found.

#18 @themetracbot
6 months ago

  • Summary changed from THEME: Frindle – 10.1.8 to THEME: Frindle – 10.1.9

Frindle - 10.1.9

Frindle is a mobile friendly WordPress theme for blogs, magazines and business websites. It’s been designed to beautifully display pictures and text content, and engineered to be easy to use and fast. The Frindle theme helps you attract and retain more visitors.

Theme URL -
Author URL - http://fancyfrindle.com/

Trac Browser - https://themes.trac.wordpress.org/browser/frindle/10.1.9

SVN - https://themes.svn.wordpress.org/frindle/10.1.9
ZIP - https://wordpress.org/themes/download/frindle.10.1.9.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=frindle/10.1.8&new_path=frindle/10.1.9

History:

Ticket Summary Status Resolution Owner
#36198 THEME: Frindle – 10.1.0 closed not-approved ponvendhan
#40211 THEME: Frindle – 10.2.5 closed live bplv

(this ticket)

#43950 THEME: Frindle – 10.2.6 closed live themetracbot


https://themes.svn.wordpress.org/frindle/10.1.9/screenshot.png
Theme Check Results:

  • RECOMMENDED: Theme URI: is missing from your style.css header.

#19 @themetracbot
6 months ago

  • Summary changed from THEME: Frindle – 10.1.9 to THEME: Frindle – 10.2.0

Frindle - 10.2.0

Frindle is a mobile friendly WordPress theme for blogs, magazines and business websites. It’s been designed to beautifully display pictures and text content, and engineered to be easy to use and fast. The Frindle theme helps you attract and retain more visitors.

Theme URL -
Author URL - http://fancyfrindle.com/

Trac Browser - https://themes.trac.wordpress.org/browser/frindle/10.2.0

SVN - https://themes.svn.wordpress.org/frindle/10.2.0
ZIP - https://wordpress.org/themes/download/frindle.10.2.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=frindle/10.1.9&new_path=frindle/10.2.0

History:

Ticket Summary Status Resolution Owner
#36198 THEME: Frindle – 10.1.0 closed not-approved ponvendhan
#40211 THEME: Frindle – 10.2.5 closed live bplv

(this ticket)

#43950 THEME: Frindle – 10.2.6 closed live themetracbot


https://themes.svn.wordpress.org/frindle/10.2.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: Theme URI: is missing from your style.css header.

#20 @bplv
6 months ago

  • Status changed from reviewing to approved

Approving your theme :)

#21 @zipal
6 months ago

@bplv Thank you so much for reviewing and approving theme. Just a quick question where do I find the admin queue.?

Thanks
Zipal Patel

#22 @bplv
6 months ago

Hello @zipal ,

You can find it here https://themes.trac.wordpress.org/report/24

Regards.

#23 @juhise
5 months ago

  • Status changed from approved to reopened

#24 @themetracbot
5 months ago

  • Summary changed from THEME: Frindle – 10.2.0 to THEME: Frindle – 10.2.1

Frindle - 10.2.1

Frindle is a mobile friendly WordPress theme for blogs, magazines and business websites. It’s been designed to beautifully display pictures and text content, and engineered to be easy to use and fast. The Frindle theme helps you attract and retain more visitors.

Theme URL - http://phoenixwebsolutions.net/themes/frindle/index.html
Author URL - http://fancyfrindle.com/

Trac Browser - https://themes.trac.wordpress.org/browser/frindle/10.2.1

SVN - https://themes.svn.wordpress.org/frindle/10.2.1
ZIP - https://wordpress.org/themes/download/frindle.10.2.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=frindle/10.2.0&new_path=frindle/10.2.1

History:

Ticket Summary Status Resolution Owner
#36198 THEME: Frindle – 10.1.0 closed not-approved ponvendhan
#40211 THEME: Frindle – 10.2.5 closed live bplv

(this ticket)

#43950 THEME: Frindle – 10.2.6 closed live themetracbot


https://themes.svn.wordpress.org/frindle/10.2.1/screenshot.png

#25 @juhise
5 months ago

  • Status changed from reopened to reviewing

Hey @zipal

I am doing the final review, I found below issues. Please fix and reupload the theme.

REQUIRED

  • Use wp_reset_postdata() to reset custom query rather than wp_reset_query().
  • Translation strings in HTML attribute needs escaping also. Please check thoroughly. Eg check searchform.php line 3
  • Do not prefix page template file name with page-. Use tpl- or template- or similar.
  • In widgets, field value is not sanitized properly when saving widget options. Please sanitize those with appropriate function.
  • There are inline styles in several files. Please use CSS file and enqueue those with appropriate hooks.
  • Escape home_url() with esc_url().
  • Escape get_permalink() with esc_url().
  • Escape L85 Header.php
  • Escape Translated string L3, L4, L5 in searchform.php
  • Escape Translated String L57, L147 single.php
  • Escape get_theme_mode L557,L565 and so many other places in customizer.php
  • Escape L76 in frindle-posts.php
  • Escape L43 L48, L53 etc in social-links.php
  • Make hardcoded string translatable L158-170 in frindle-posts.php, check at other places too

Question

I can't see images mentioned in read me, used anywhere. Can you please tell me where it's used?

Please check your theme against these https://make.wordpress.org/themes/handbook/.

Best Regards,
Juhi

#26 @zipal
5 months ago

Hello @juhise
Thanks for the detailed review!

But, I need your help to resolve the couple of issues you mentioned. Specially this one: "In widgets, field value is not sanitized properly when saving widget options. Please sanitize those with appropriate function."

I referred other theme widgets too, but couldn't figure it out. And another help with the escaping get_theme_mode.

esc_attr(get_theme_mod( 'quick_notify' ) == 1 ))

Is this proper way to do that? Furthermore, single.php L147

Looking forward for the help.
Cheers :)
Zipal Patel

Last edited 5 months ago by zipal (previous) (diff)

#27 follow-up: @juhise
5 months ago

Hey,

  1. You need to escape only when you are rendering. esc_attr(get_theme_mod( 'quick_notify' ) == 1 )) here you don't need to escape here.
  1. Regarding "In widgets, field value is not sanitized properly when saving widget options. Please sanitize those with appropriate function" $instance['facebook'] = (!empty($new_instance['facebook']) ) ? strip_tags($new_instance['facebook']) : ' use esc_url_raw() for url field and sanitize_text_field() should be used for for text field .
  1. single.php L147 I agree there is no need to escape, sorry about that.

Best Regards,
Juhi

#28 in reply to: ↑ 27 @zipal
5 months ago

Replying to juhise:

Done!

  1. You need to escape only when you are rendering. esc_attr(get_theme_mod( 'quick_notify' ) == 1 )) here you don't need to escape here.

Still need more specific answer. Could you write a rough function snippet for me?

  1. Regarding "In widgets, field value is not sanitized properly when saving widget options. Please sanitize those with appropriate function" $instance['facebook'] = (!empty($new_instance['facebook']) ) ? strip_tags($new_instance['facebook']) : ' use esc_url_raw() for url field and sanitize_text_field() should be used for for text field .

No problem!

  1. single.php L147 I agree there is no need to escape, sorry about that.

#29 @themetracbot
5 months ago

  • Summary changed from THEME: Frindle – 10.2.1 to THEME: Frindle – 10.2.2

Frindle - 10.2.2

Frindle is a mobile friendly WordPress theme for blogs, magazines and business websites. It’s been designed to beautifully display pictures and text content, and engineered to be easy to use and fast. The Frindle theme helps you attract and retain more visitors.

Theme URL - http://phoenixwebsolutions.net/themes/frindle/index.html
Author URL - http://fancyfrindle.com/

Trac Browser - https://themes.trac.wordpress.org/browser/frindle/10.2.2

SVN - https://themes.svn.wordpress.org/frindle/10.2.2
ZIP - https://wordpress.org/themes/download/frindle.10.2.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=frindle/10.2.1&new_path=frindle/10.2.2

History:

Ticket Summary Status Resolution Owner
#36198 THEME: Frindle – 10.1.0 closed not-approved ponvendhan
#40211 THEME: Frindle – 10.2.5 closed live bplv

(this ticket)

#43950 THEME: Frindle – 10.2.6 closed live themetracbot


https://themes.svn.wordpress.org/frindle/10.2.2/screenshot.png
Theme Check Results:

  • WARNING: Found a translation function that is missing a text-domain. Function esc_attr_x, with the arguments 'Search &hellip;', 'frindle'
  • WARNING: Found a translation function that is missing a text-domain. Function esc_attr_x, with the arguments 'Search', 'frindle'

#30 @themetracbot
5 months ago

  • Summary changed from THEME: Frindle – 10.2.2 to THEME: Frindle – 10.2.3

Frindle - 10.2.3

Frindle is a mobile friendly WordPress theme for blogs, magazines and business websites. It’s been designed to beautifully display pictures and text content, and engineered to be easy to use and fast. The Frindle theme helps you attract and retain more visitors.

Theme URL - http://phoenixwebsolutions.net/themes/frindle/index.html
Author URL - http://fancyfrindle.com/

Trac Browser - https://themes.trac.wordpress.org/browser/frindle/10.2.3

SVN - https://themes.svn.wordpress.org/frindle/10.2.3
ZIP - https://wordpress.org/themes/download/frindle.10.2.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=frindle/10.2.2&new_path=frindle/10.2.3

History:

Ticket Summary Status Resolution Owner
#36198 THEME: Frindle – 10.1.0 closed not-approved ponvendhan
#40211 THEME: Frindle – 10.2.5 closed live bplv

(this ticket)

#43950 THEME: Frindle – 10.2.6 closed live themetracbot


https://themes.svn.wordpress.org/frindle/10.2.3/screenshot.png

#31 @zipal
5 months ago

Hello @juhise

The latest version (v10.2.3 made a silly mistake with v10.2.2) of theme eliminate every issues you mentioned and also the theme URI page is also working properly. I am still updating it though.

The question you asked about those images, Those are in the screenshot of theme. :) So they need proper license info. Additionally that "widget field update..." problem also resolved.

Looking forward for your favorable reply.

Thanks
Zipal Patel

#32 @juhise
5 months ago

Hey @zipal

Thanks for fixing the issues, though theme has still escaping issues. It would be tedious to mark each and every line number which need escaping. You can use this plugin https://github.com/WPTRT/ns-theme-check and fix the issues.

Best Regards,
Juhi

#33 @zipal
5 months ago

Hello @juhise

Actually the problem is I am on windows 10 and as far as I know "rm -rf" script does not launch on windows, so I can not have the NS Theme Check plugin. That means I can't test theme with that plugin. And I believe that I almost take care of every escaping in latest version.

Thank you!
Zipal

#35 @themetracbot
5 months ago

  • Summary changed from THEME: Frindle – 10.2.3 to THEME: Frindle – 10.2.4

Frindle - 10.2.4

Frindle is a mobile friendly WordPress theme for blogs, magazines and business websites. It’s been designed to beautifully display pictures and text content, and engineered to be easy to use and fast. The Frindle theme helps you attract and retain more visitors.

Theme URL - http://phoenixwebsolutions.net/themes/frindle/index.html
Author URL - http://fancyfrindle.com/

Trac Browser - https://themes.trac.wordpress.org/browser/frindle/10.2.4

SVN - https://themes.svn.wordpress.org/frindle/10.2.4
ZIP - https://wordpress.org/themes/download/frindle.10.2.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=frindle/10.2.3&new_path=frindle/10.2.4

History:

Ticket Summary Status Resolution Owner
#36198 THEME: Frindle – 10.1.0 closed not-approved ponvendhan
#40211 THEME: Frindle – 10.2.5 closed live bplv

(this ticket)

#43950 THEME: Frindle – 10.2.6 closed live themetracbot


https://themes.svn.wordpress.org/frindle/10.2.4/screenshot.png

#36 @zipal
5 months ago

Hello @juhise

Please proceed the review further.

Thanks
Zipal Patel

#37 follow-ups: @juhise
5 months ago

Hey @zipal,

Please check below issues:

  • Escape $logo_width L640 customizer.php
  • Escape as late as possible L25,L28 index.php
  • Escape L85, L86, L87, L88 in social-links.php
  • Escape as late as possible L60,L73, L86 post-format.php

Best Regards,
Juhi

#38 @themetracbot
5 months ago

  • Summary changed from THEME: Frindle – 10.2.4 to THEME: Frindle – 10.2.5

Frindle - 10.2.5

Frindle is a mobile friendly WordPress theme for blogs, magazines and business websites. It’s been designed to beautifully display pictures and text content, and engineered to be easy to use and fast. The Frindle theme helps you attract and retain more visitors.

Theme URL - http://phoenixwebsolutions.net/themes/frindle/index.html
Author URL - http://fancyfrindle.com/

Trac Browser - https://themes.trac.wordpress.org/browser/frindle/10.2.5

SVN - https://themes.svn.wordpress.org/frindle/10.2.5
ZIP - https://wordpress.org/themes/download/frindle.10.2.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=frindle/10.2.4&new_path=frindle/10.2.5

History:

Ticket Summary Status Resolution Owner
#36198 THEME: Frindle – 10.1.0 closed not-approved ponvendhan
#40211 THEME: Frindle – 10.2.5 closed live bplv

(this ticket)

#43950 THEME: Frindle – 10.2.6 closed live themetracbot


https://themes.svn.wordpress.org/frindle/10.2.5/screenshot.png

#39 in reply to: ↑ 37 @zipal
5 months ago

Replying to juhise:

Can't escape them earlier. And escaping them late will print the html code instead of embedded code or function respective o/p. So, that work out.

  • Escape as late as possible L60,L73, L86 post-format.php

And taken care of other escaping.

Regards
Zipal

#40 @juhise
5 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Hey @zipal

Thanks for the quick fixes.

Looks good to me.

Setting your theme live. Congratulations.

It may take while to show up in the directory.

Best Regards,
Juhi

#41 in reply to: ↑ 37 @zipal
5 months ago

Oh hey @juhise

Thank you so much to setting theme live right on time.
Really appreciated your efforts.

Thank you so much!
Zipal Patel ♥

Note: See TracTickets for help on using tickets.