WordPress.org

Make WordPress Themes

Opened 9 months ago

Closed 7 months ago

Last modified 7 months ago

#40336 closed theme (live)

THEME: StoreOne – 1.0.6

Reported by: ThemeFarmer Owned by: rabmalin
Priority: new theme Keywords: theme-storeone
Cc: kapildevsharma12@…

Description

StoreOne - 1.0.0

StoreOne is Powerful multipurpose WooCommerce WordPress Theme. StoreOne is the perfect free theme for shop. StoreOne is responsive mobile optimized and using bootstrap framework. to show awesome icons on site it’s using FontAwesome icons. StoreOne is Search Engine Optimized (SEO) friendly. Theme is developed to be used for any business, corporate, companies, or freelancers to create an awesome online presence. Theme includes customizable homepage, awesome slider, social links, latest products, latest blog section and other Advance section. Theme Provide 2 page Template (Full Width, Left Sidebar) to select layout. StoreOne is perfect suitable for clothing, electronics, mobile and almost any type of store. StoreOne is good for eCommerce solution and compatible with contact form 7, JetPack, WPML. Documentation available at https://www.themefarmer.com/documentation/documentation-storeone/ and check the Demo at http://demo.themefarmer.com/storeone/

Theme URL -
Author URL - https://www.themefarmer.com

Trac Browser - https://themes.trac.wordpress.org/browser/storeone/1.0.0

SVN - https://themes.svn.wordpress.org/storeone/1.0.0
ZIP - https://wordpress.org/themes/download/storeone.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#40336 THEME: StoreOne – 1.0.6 closed live rabmalin

(this ticket)

#42573 THEME: StoreOne – 1.1 closed live themetracbot
#43249 THEME: StoreOne – 1.2 closed live themetracbot
#44452 THEME: StoreOne – 1.3 closed live themetracbot
#46929 THEME: StoreOne – 1.4 closed live themetracbot
#47686 THEME: StoreOne – 1.5 closed live themetracbot


https://themes.svn.wordpress.org/storeone/1.0.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.

Attachments (1)

search-title-covered.jpg (64.1 KB) - added by joyously 8 months ago.
On the search page, the title is covered by the default images.

Download all attachments as: .zip

Change History (18)

#1 @themetracbot
8 months ago

  • Summary changed from THEME: StoreOne – 1.0.0 to THEME: StoreOne – 1.0.1

StoreOne - 1.0.1

StoreOne is Powerful multipurpose WooCommerce WordPress Theme. StoreOne is the perfect free theme for shop. StoreOne is responsive mobile optimized and using bootstrap framework. to show awesome icons on site it’s using FontAwesome icons. StoreOne is Search Engine Optimized (SEO) friendly. Theme is developed to be used for any business, corporate, companies, or freelancers to create an awesome online presence. Theme includes customizable homepage, awesome slider, social links, latest products, latest blog section and other Advance section. Theme Provide 2 page Template (Full Width, Left Sidebar) to select layout. StoreOne is perfect suitable for clothing, electronics, mobile and almost any type of store. StoreOne is good for eCommerce solution and compatible with contact form 7, JetPack, WPML. Documentation available at https://www.themefarmer.com/documentation/documentation-storeone/ and check the Demo at http://demo.themefarmer.com/storeone/

Theme URL - https://www.themefarmer.com/free-themes/storeone-e-commerce-wordpress-theme/
Author URL - https://www.themefarmer.com

Trac Browser - https://themes.trac.wordpress.org/browser/storeone/1.0.1

SVN - https://themes.svn.wordpress.org/storeone/1.0.1
ZIP - https://wordpress.org/themes/download/storeone.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=storeone/1.0.0&new_path=storeone/1.0.1

History:

Ticket Summary Status Resolution Owner
#40336 THEME: StoreOne – 1.0.6 closed live rabmalin

(this ticket)

#42573 THEME: StoreOne – 1.1 closed live themetracbot
#43249 THEME: StoreOne – 1.2 closed live themetracbot
#44452 THEME: StoreOne – 1.3 closed live themetracbot
#46929 THEME: StoreOne – 1.4 closed live themetracbot
#47686 THEME: StoreOne – 1.5 closed live themetracbot


https://themes.svn.wordpress.org/storeone/1.0.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

@joyously
8 months ago

On the search page, the title is covered by the default images.

#2 follow-up: @joyously
8 months ago

  • Showing "Add/Edit Social Links in Customizer" (twice!) -- installation instructions should not be visible to visitors. This is actually better handled as a menu, so the user doesn't have to enter the same thing for each theme.
  • For a gallery, the image is on the left and the caption is centered. The theme should support the gallery default of 3 columns.
  • On archive pages, the post pagination is output last yet it is covered by the top of the first posts.
  • The search results should not show the date of static Pages.
  • Page links (generated by <!--nextpage-->) are being output as part of the content instead of after it.
  • Floats are not being cleared properly after the content area. Try putting Additional CSS in the Customizer on the Clearing Floats page like .entry-content {background:yellow} and see if the image sticks out the bottom.
  • The defaults for the Blog Slider section don't match what is shown to visitors. The theme should not provide default images. Remove them.
  • On small screens, the menu has a horizontal scrollbar. It seems that the menu would be unusable on touch screens since the submenus are shown on hover, which does not exist, and clicking on the menu arrow navigates to the top level page instead of opening the submenu.

#3 @themetracbot
8 months ago

  • Summary changed from THEME: StoreOne – 1.0.1 to THEME: StoreOne – 1.0.2

StoreOne - 1.0.2

StoreOne is Powerful multipurpose WooCommerce WordPress Theme. StoreOne is the perfect free theme for e-commerce shop. StoreOne is responsive mobile optimized and using bootstrap framework. to show awesome icons on site it&#8217;s using FontAwesome icons. StoreOne is Search Engine Optimized (SEO) friendly. Theme is developed to be used for any business, corporate, companies, or freelancers to create an awesome online presence. Theme includes customizable homepage, awesome slider, social links, latest products, latest blog section and other Advance section. Theme Provide 3 page Template (Home Page , Full Width, Left Sidebar) to select layout. StoreOne is perfect suitable for clothing, electronics, mobile and almost any type of store. StoreOne is good for eCommerce solution and compatible with contact form 7, JetPack, WPML. Documentation available at https://www.themefarmer.com/documentation/documentation-storeone/ and check the Demo at http://demo.themefarmer.com/storeone/

Theme URL - https://www.themefarmer.com/free-themes/storeone-e-commerce-wordpress-theme/
Author URL - https://www.themefarmer.com

Trac Browser - https://themes.trac.wordpress.org/browser/storeone/1.0.2

SVN - https://themes.svn.wordpress.org/storeone/1.0.2
ZIP - https://wordpress.org/themes/download/storeone.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=storeone/1.0.1&new_path=storeone/1.0.2

History:

Ticket Summary Status Resolution Owner
#40336 THEME: StoreOne – 1.0.6 closed live rabmalin

(this ticket)

#42573 THEME: StoreOne – 1.1 closed live themetracbot
#43249 THEME: StoreOne – 1.2 closed live themetracbot
#44452 THEME: StoreOne – 1.3 closed live themetracbot
#46929 THEME: StoreOne – 1.4 closed live themetracbot
#47686 THEME: StoreOne – 1.5 closed live themetracbot


https://themes.svn.wordpress.org/storeone/1.0.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#4 in reply to: ↑ 2 @ThemeFarmer
8 months ago

Replying to joyously:
hello @joyously
Thank you very much for pointing issue.

  • Showing "Add/Edit Social Links in Customizer" (twice!) -- installation instructions should not be visible to visitors. This is actually better handled as a menu, so the user doesn't have to enter the same thing for each theme.

-> installation instructions are not be visible to visitors only to current_user_can('edit_theme_options')).
-> no need to add twice only need to add once and it will show twice on topbar and footer.

  • For a gallery, the image is on the left and the caption is centered. The theme should support the gallery default of 3 columns.

-> Fixed

  • On archive pages, the post pagination is output last yet it is covered by the top of the first posts.

-> Fixed

  • The search results should not show the date of static Pages.

-> Fixed

  • Page links (generated by <!--nextpage-->) are being output as part of the content instead of after it.

-> not understanding how it should show but showing same as twenty seventeen. please give us reference we will fix it quick.


  • Floats are not being cleared properly after the content area. Try putting Additional CSS in the Customizer on the Clearing Floats page like .entry-content {background:yellow} and see if the image sticks out the bottom.

-> possibly Fixed

  • The defaults for the Blog Slider section don't match what is shown to visitors. The theme should not provide default images. Remove them.

-> updated according to guideline. showing recent posts slider if slider not set. showing placeholder image if no featured image in post/page.

  • On small screens, the menu has a horizontal scrollbar. It seems that the menu would be unusable on touch screens since the submenus are shown on hover, which does not exist, and clicking on the menu arrow navigates to the top level page instead of opening the submenu.

-> Fixed

Regards

#5 @joyously
8 months ago

installation instructions are not be visible to visitors only to current_user_can('edit_theme_options')).
no need to add twice only need to add once and it will show twice on topbar and footer.

I'm sorry, I don't log out to check the front end. I think that is obnoxious, actually, that I would have to log out in order to see the site the same way as the user sees it. I thought the guideline mentioned it should only be in Customizer, but I can't find that.
I didn't say you had to add the social links twice, I said it's best if it's a menu so you only add it once and it works for all themes, instead of having to add it to each theme that you switch to.

Gallery...

Fixed

Well, it's better, but still has problems. Here is what I see on my normal window sized ~1070px (and everything smaller).
https://s21.postimg.org/bg21olo47/gallery-1070px.jpg

Page links...

not understanding how it should show but showing same as twenty seventeen. please give us reference we will fix it quick.

Floats...

possibly Fixed

Suppose the user wants to style just his content, so he adds a CSS rule in the Customizer under Additional CSS that says .entry-content {background:yellow}. The way it is currently, there are two problems: 1) the float is not cleared and 2) the page links are part of the content.
https://s2.postimg.org/o55a8u0fd/float-not-clear-page-links-in-content.jpg

Here is how it would look with a clearing div at the end of the content and the page links outside the content div.
https://s15.postimg.org/8pidtismj/cleared-floats-page-links-after.png

Slider...

updated according to guideline. showing recent posts slider if slider not set. showing placeholder image if no featured image in post/page.

No, the guidelines say that the theme cannot create/supply content. So you need to remove the slider images. The defaults still do not match what is showing. The slider options are for Pages. Since none are selected, nothing should show. So the default for enable/disable should be disabled. And showing Pages on the page that the user chose to show Latest Posts is not right either.

#6 @themetracbot
8 months ago

  • Summary changed from THEME: StoreOne – 1.0.2 to THEME: StoreOne – 1.0.3

StoreOne - 1.0.3

StoreOne is Powerful multipurpose WooCommerce WordPress Theme. StoreOne is the perfect free theme for e-commerce shop. StoreOne is responsive mobile optimized and using bootstrap framework. to show awesome icons on site it&#8217;s using FontAwesome icons. StoreOne is Search Engine Optimized (SEO) friendly. Theme is developed to be used for any business, corporate, companies, or freelancers to create an awesome online presence. Theme includes customizable homepage, awesome slider, social links, latest products, latest blog section and other Advance section. Theme Provide 3 page Template (Home Page , Full Width, Left Sidebar) to select layout. StoreOne is perfect suitable for clothing, electronics, mobile and almost any type of store. StoreOne is good for eCommerce solution and compatible with contact form 7, JetPack, WPML. Documentation available at https://www.themefarmer.com/documentation/documentation-storeone/ and check the Demo at http://demo.themefarmer.com/storeone/

Theme URL - https://www.themefarmer.com/free-themes/storeone-e-commerce-wordpress-theme/
Author URL - https://www.themefarmer.com

Trac Browser - https://themes.trac.wordpress.org/browser/storeone/1.0.3

SVN - https://themes.svn.wordpress.org/storeone/1.0.3
ZIP - https://wordpress.org/themes/download/storeone.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=storeone/1.0.2&new_path=storeone/1.0.3

History:

Ticket Summary Status Resolution Owner
#40336 THEME: StoreOne – 1.0.6 closed live rabmalin

(this ticket)

#42573 THEME: StoreOne – 1.1 closed live themetracbot
#43249 THEME: StoreOne – 1.2 closed live themetracbot
#44452 THEME: StoreOne – 1.3 closed live themetracbot
#46929 THEME: StoreOne – 1.4 closed live themetracbot
#47686 THEME: StoreOne – 1.5 closed live themetracbot


https://themes.svn.wordpress.org/storeone/1.0.3/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#7 @rabmalin
8 months ago

  • Owner set to rabmalin
  • Status changed from new to reviewing

#8 @rabmalin
8 months ago

Hello,

Please check following issues.

Please respond within 7 days. If there is no response for 7 days, ticket will be closed as not-approved.

Issues

  • REQUIRED: Change date('Y') to date_i18n(__('Y','textdomain'))
  • REQUIRED: Core-bundled scripts: Required to use core-bundled scripts rather than including their own version of that script. For example jQuery, masonry
  • REQUIRED: Rate this theme - Change http://wordpress.org/support/view/theme-reviews/storeone?filter=5 to http://wordpress.org/support/view/theme-reviews/storeone.
  • REQUIRED: Remove StoreOne_Page_Dropdown_Control - Dropdown page control is already available in core.
  • REQUIRED: Make sure excerpt_more filter does not affect admin side. See Twenty Seventeen theme for reference.
  • REQUIRED: Do not use wp_reset_query().
  • REQUIRED: Never use 'posts_per_page' => -1 in custom query. If limit is not fixed, you can add some reasonable limit in the query.

Theme Check Sniffs

Note: Errors need to be fixed and Warnings are things that need to be checked manually.

FILE: /var/www/review.dev/public_html/wp-content/themes/storeone/header.php
---------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------
 74 | ERROR | Only variables can be passed to empty() prior to PHP 5.5.
 79 | ERROR | Only variables can be passed to empty() prior to PHP 5.5.
---------------------------------------------------------------------------

#9 @ThemeFarmer
8 months ago

hello @rabmalin

If wp_reset_query() removed main query not working after custom query. any suggestion on this will be great help.

Thanks

#10 @themetracbot
7 months ago

  • Summary changed from THEME: StoreOne – 1.0.3 to THEME: StoreOne – 1.0.4

StoreOne - 1.0.4

StoreOne is Powerful multipurpose WooCommerce WordPress Theme. StoreOne is the perfect free theme for e-commerce shop. StoreOne is responsive mobile optimized and using bootstrap framework. to show awesome icons on site it&#8217;s using FontAwesome icons. StoreOne is Search Engine Optimized (SEO) friendly. Theme is developed to be used for any business, corporate, companies, or freelancers to create an awesome online presence. Theme includes customizable homepage, awesome slider, social links, latest products, latest blog section and other Advance section. Theme Provide 3 page Template (Home Page , Full Width, Left Sidebar) to select layout. StoreOne is perfect suitable for clothing, electronics, mobile and almost any type of store. StoreOne is good for eCommerce solution and compatible with contact form 7, JetPack, WPML. Documentation available at https://www.themefarmer.com/documentation/documentation-storeone/ and check the Demo at http://demo.themefarmer.com/storeone/

Theme URL - https://www.themefarmer.com/free-themes/storeone-e-commerce-wordpress-theme/
Author URL - https://www.themefarmer.com

Trac Browser - https://themes.trac.wordpress.org/browser/storeone/1.0.4

SVN - https://themes.svn.wordpress.org/storeone/1.0.4
ZIP - https://wordpress.org/themes/download/storeone.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=storeone/1.0.3&new_path=storeone/1.0.4

History:

Ticket Summary Status Resolution Owner
#40336 THEME: StoreOne – 1.0.6 closed live rabmalin

(this ticket)

#42573 THEME: StoreOne – 1.1 closed live themetracbot
#43249 THEME: StoreOne – 1.2 closed live themetracbot
#44452 THEME: StoreOne – 1.3 closed live themetracbot
#46929 THEME: StoreOne – 1.4 closed live themetracbot
#47686 THEME: StoreOne – 1.5 closed live themetracbot


https://themes.svn.wordpress.org/storeone/1.0.4/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#11 @ThemeFarmer
7 months ago

Hello @rabmalin
have fixed all issues
Thanks

#12 @rabmalin
7 months ago

Issues

  • REQUIRED: Remove search-form from add_theme_support( 'html5' as you are customizing it yourself.
  • REQUIRED: Remove comment-list from add_theme_support( 'html5' as you are customizing it yourself.
  • REQUIRED: Remove comment-form from add_theme_support( 'html5' as you are customizing it yourself.
  • REQUIRED: Use sanitize_email() to sanitize email field. You already have function for that. Check storeone_sanitize_email().
  • REQUIRED: Translation issue - /wp-content/themes/storeone/inc/functions.php line 106, 111

#13 @themetracbot
7 months ago

  • Summary changed from THEME: StoreOne – 1.0.4 to THEME: StoreOne – 1.0.5

StoreOne - 1.0.5

StoreOne is Powerful multipurpose WooCommerce WordPress Theme. StoreOne is the perfect free theme for e-commerce shop. StoreOne is responsive mobile optimized and using bootstrap framework. to show awesome icons on site it&#8217;s using FontAwesome icons. StoreOne is Search Engine Optimized (SEO) friendly. Theme is developed to be used for any business, corporate, companies, or freelancers to create an awesome online presence. Theme includes customizable homepage, awesome slider, social links, latest products, latest blog section and other Advance section. Theme Provide 3 page Template (Home Page , Full Width, Left Sidebar) to select layout. StoreOne is perfect suitable for clothing, electronics, mobile and almost any type of store. StoreOne is good for eCommerce solution and compatible with contact form 7, JetPack, WPML. Documentation available at https://www.themefarmer.com/documentation/documentation-storeone/ and check the Demo at http://demo.themefarmer.com/storeone/

Theme URL - https://www.themefarmer.com/free-themes/storeone-e-commerce-wordpress-theme/
Author URL - https://www.themefarmer.com

Trac Browser - https://themes.trac.wordpress.org/browser/storeone/1.0.5

SVN - https://themes.svn.wordpress.org/storeone/1.0.5
ZIP - https://wordpress.org/themes/download/storeone.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=storeone/1.0.4&new_path=storeone/1.0.5

History:

Ticket Summary Status Resolution Owner
#40336 THEME: StoreOne – 1.0.6 closed live rabmalin

(this ticket)

#42573 THEME: StoreOne – 1.1 closed live themetracbot
#43249 THEME: StoreOne – 1.2 closed live themetracbot
#44452 THEME: StoreOne – 1.3 closed live themetracbot
#46929 THEME: StoreOne – 1.4 closed live themetracbot
#47686 THEME: StoreOne – 1.5 closed live themetracbot


https://themes.svn.wordpress.org/storeone/1.0.5/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#14 @rabmalin
7 months ago

One final issue. Please fix this and I will set your theme live.

  • REQUIRED: In Theme Info page, there is file not found error in console. May be screenshot URL is not correct.

#15 @themetracbot
7 months ago

  • Summary changed from THEME: StoreOne – 1.0.5 to THEME: StoreOne – 1.0.6

StoreOne - 1.0.6

StoreOne is Powerful multipurpose WooCommerce WordPress Theme. StoreOne is the perfect free theme for e-commerce shop. StoreOne is responsive mobile optimized and using bootstrap framework. to show awesome icons on site it&#8217;s using FontAwesome icons. StoreOne is Search Engine Optimized (SEO) friendly. Theme is developed to be used for any business, corporate, companies, or freelancers to create an awesome online presence. Theme includes customizable homepage, awesome slider, social links, latest products, latest blog section and other Advance section. Theme Provide 3 page Template (Home Page , Full Width, Left Sidebar) to select layout. StoreOne is perfect suitable for clothing, electronics, mobile and almost any type of store. StoreOne is good for eCommerce solution and compatible with contact form 7, JetPack, WPML. Documentation available at https://www.themefarmer.com/documentation/documentation-storeone/ and check the Demo at http://demo.themefarmer.com/storeone/

Theme URL - https://www.themefarmer.com/free-themes/storeone-e-commerce-wordpress-theme/
Author URL - https://www.themefarmer.com

Trac Browser - https://themes.trac.wordpress.org/browser/storeone/1.0.6

SVN - https://themes.svn.wordpress.org/storeone/1.0.6
ZIP - https://wordpress.org/themes/download/storeone.1.0.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=storeone/1.0.5&new_path=storeone/1.0.6

History:

Ticket Summary Status Resolution Owner
#40336 THEME: StoreOne – 1.0.6 closed live rabmalin

(this ticket)

#42573 THEME: StoreOne – 1.1 closed live themetracbot
#43249 THEME: StoreOne – 1.2 closed live themetracbot
#44452 THEME: StoreOne – 1.3 closed live themetracbot
#46929 THEME: StoreOne – 1.4 closed live themetracbot
#47686 THEME: StoreOne – 1.5 closed live themetracbot


https://themes.svn.wordpress.org/storeone/1.0.6/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#16 @rabmalin
7 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Looks good. Approving and setting live. It will take around 1 hour for theme to appear in the directory. Good luck!

#17 @ThemeFarmer
7 months ago

@rabmalin Thank You for awesome review and setting theme live.

Note: See TracTickets for help on using tickets.