WordPress.org

Make WordPress Themes

Opened 8 months ago

Closed 6 months ago

#40437 closed theme (live)

THEME: Responsive Kubrick – 1.4.0

Reported by: glamink Owned by: pratikshrestha
Priority: new theme Keywords: theme-responsive-kubrick
Cc: admin@…

Description

Responsive Kubrick - 1.0

A modern remake of the famous Kubrick theme. Customizable header gradient, lightweight CSS3 build and modern standards compliant. Fun to remember the old days. Enjoy!

Theme URL -
Author URL - https://glam.ink/

Trac Browser - https://themes.trac.wordpress.org/browser/responsive-kubrick/1.0

SVN - https://themes.svn.wordpress.org/responsive-kubrick/1.0
ZIP - https://wordpress.org/themes/download/responsive-kubrick.1.0.zip?nostats=1

History:


https://themes.svn.wordpress.org/responsive-kubrick/1.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to nav_menu's was found in the theme. Note that if your theme has a menu bar, it is required to use the WordPress nav_menu functionality for it.

Change History (18)

#1 @themetracbot
8 months ago

  • Summary changed from THEME: Responsive Kubrick – 1.0 to THEME: Responsive Kubrick – 1.1

Responsive Kubrick - 1.1

A modern remake of the famous Kubrick theme. Customizable header gradient, lightweight CSS3 build and modern standards compliant. Fun to remember the old days. Enjoy!

Theme URL -
Author URL - https://glam.ink/

Trac Browser - https://themes.trac.wordpress.org/browser/responsive-kubrick/1.1

SVN - https://themes.svn.wordpress.org/responsive-kubrick/1.1
ZIP - https://wordpress.org/themes/download/responsive-kubrick.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=responsive-kubrick/1.0&new_path=responsive-kubrick/1.1

History:


https://themes.svn.wordpress.org/responsive-kubrick/1.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to nav_menu's was found in the theme. Note that if your theme has a menu bar, it is required to use the WordPress nav_menu functionality for it.

#2 @glamink
8 months ago

Changelog

1.1 - February 20 2016

Last edited 8 months ago by glamink (previous) (diff)

#3 @themetracbot
8 months ago

  • Summary changed from THEME: Responsive Kubrick – 1.1 to THEME: Responsive Kubrick – 1.2.1

Responsive Kubrick - 1.2.1

A modern remake of the famous Kubrick theme. Customizable header gradient, lightweight CSS3 build and modern standards compliant. Fun to remember the old days. Enjoy!

Theme URL -
Author URL - https://glam.ink/

Trac Browser - https://themes.trac.wordpress.org/browser/responsive-kubrick/1.2.1

SVN - https://themes.svn.wordpress.org/responsive-kubrick/1.2.1
ZIP - https://wordpress.org/themes/download/responsive-kubrick.1.2.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=responsive-kubrick/1.1&new_path=responsive-kubrick/1.2.1

History:


https://themes.svn.wordpress.org/responsive-kubrick/1.2.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to nav_menu's was found in the theme. Note that if your theme has a menu bar, it is required to use the WordPress nav_menu functionality for it.

#4 @glamink
8 months ago

Changelog

1.2.1 - February 21 2016

  • Mobile - fixed pagination margin
  • Mobile - fixed sidebar padding
  • Mobile - fixed blog name font size
  • Deleted some unused styles

#5 follow-up: @joyously
7 months ago

  • Consider supporting a menu. It's not very modern without it.
  • Theme is not showing user choice of date format.
  • <q> tag is unstyled (default removed)
  • Theme is tagged sticky-post, but sticky post is not visually different.
  • Theme is tagged custom-menu, but does not support one.
  • Pingback <link> should be conditional (singular and pings_open)

#6 @pratikshrestha
7 months ago

  • Owner set to pratikshrestha
  • Status changed from new to reviewing

#7 follow-up: @pratikshrestha
7 months ago

Hello @glamink,

Thanks for uploading theme, please fix the issue mentioned by @joyously.

Further Issues:


Note: Please reply in ticket within 7days otherwise theme will be resolved as not-approved.

#8 @glamink
6 months ago

Thanks @joyously @pratikshrestha

Sorry for my late reply, I'll start working on the modifications asap.

#9 @themetracbot
6 months ago

  • Summary changed from THEME: Responsive Kubrick – 1.2.1 to THEME: Responsive Kubrick – 1.3.0

Responsive Kubrick - 1.3.0

A modern remake of the famous Kubrick theme. Customizable header gradient, lightweight CSS3 build and modern standards compliant. Fun to remember the old days. Enjoy!

Theme URL -
Author URL - https://glam.ink/

Trac Browser - https://themes.trac.wordpress.org/browser/responsive-kubrick/1.3.0

SVN - https://themes.svn.wordpress.org/responsive-kubrick/1.3.0
ZIP - https://wordpress.org/themes/download/responsive-kubrick.1.3.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=responsive-kubrick/1.2.1&new_path=responsive-kubrick/1.3.0

History:


https://themes.svn.wordpress.org/responsive-kubrick/1.3.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

#10 in reply to: ↑ 5 @glamink
6 months ago

Replying to joyously:

  • Consider supporting a menu. It's not very modern without it.
  • Theme is tagged custom-menu, but does not support one.

Added menu

  • Theme is not showing user choice of date format.

Change post data to display in user's format

  • <q> tag is unstyled (default removed)

Added <q> css style

  • Theme is tagged sticky-post, but sticky post is not visually different.

Styled sticky post

Set licensing and copyright properly

  • Pingback <link> should be conditional (singular and pings_open)

Fixed

#11 in reply to: ↑ 7 @glamink
6 months ago

Replying to pratikshrestha:

Fixed

Added licensing (GPL) on my website

#12 follow-up: @pratikshrestha
6 months ago

hi @glamink,

I am busy for the weekend, so will br able to look at the update most probably on monday.

#13 in reply to: ↑ 12 @glamink
6 months ago

Replying to pratikshrestha:

hi @glamink,

I am busy for the weekend, so will br able to look at the update most probably on monday.

No problem, thanks for letting me know. Have a great weekend!

#14 @pratikshrestha
6 months ago

Hi @glamink,

Thanks for update i will post review in a while.

#15 follow-up: @pratikshrestha
6 months ago

Just a few issues left, fix these and I will mark the theme as live.

  • Use sanitize_hex_color function to sanitize_hex_color values rather than sanitize_text_field in customizer.php lines 30 and 51
  • You can either use theme shop name or theme slug(recommended) as handle prefixes. In customizer.php lines 75 and 80, you have used both. For consistency, since you have used glamink_ everywhere, use same in line 80
  • In functions.php line133, use glamink_ as prefix here as well
  • In responsive-kubrick/js/customizer-controls.js, you have added api for datepicker,. I cannot find it being used anywhere, check it and remove it if unnecessary.
  • In footer.php line 21, internationalize date() by replacing <?php echo date( 'Y' ); ?> with <?php echo esc_attr( date_i18n( __( 'Y', 'theme-slug' ) ) ); ?>
Last edited 6 months ago by pratikshrestha (previous) (diff)

#16 @themetracbot
6 months ago

  • Summary changed from THEME: Responsive Kubrick – 1.3.0 to THEME: Responsive Kubrick – 1.4.0

Responsive Kubrick - 1.4.0

A modern remake of the famous Kubrick theme. Customizable header gradient, lightweight CSS3 build and modern standards compliant. Fun to remember the old days. Enjoy!

Theme URL -
Author URL - https://glam.ink/

Trac Browser - https://themes.trac.wordpress.org/browser/responsive-kubrick/1.4.0

SVN - https://themes.svn.wordpress.org/responsive-kubrick/1.4.0
ZIP - https://wordpress.org/themes/download/responsive-kubrick.1.4.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=responsive-kubrick/1.3.0&new_path=responsive-kubrick/1.4.0

History:


https://themes.svn.wordpress.org/responsive-kubrick/1.4.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.

#17 in reply to: ↑ 15 @glamink
6 months ago

Replying to pratikshrestha:

  • Use sanitize_hex_color function to sanitize_hex_color values rather than sanitize_text_field in customizer.php lines 30 and 51

Done

  • You can either use theme shop name or theme slug(recommended) as handle prefixes. In customizer.php lines 75 and 80, you have used both. For consistency, since you have used glamink_ everywhere, use same in line 80
  • In functions.php line133, use glamink_ as prefix here as well

Fixed - changed prefix

  • In responsive-kubrick/js/customizer-controls.js, you have added api for datepicker,. I cannot find it being used anywhere, check it and remove it if unnecessary.

Fixed - I deleted the unused file

  • In footer.php line 21, internationalize date() by replacing <?php echo date( 'Y' ); ?> with <?php echo esc_attr( date_i18n( __( 'Y', 'theme-slug' ) ) ); ?>

Done

#18 @pratikshrestha
6 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Everything looks good. Marking theme as live.

Note: See TracTickets for help on using tickets.