WordPress.org

Make WordPress Themes

Opened 8 months ago

Closed 8 months ago

#40498 closed theme (closed-newer-version-uploaded)

THEME: Activation – 1.1.0

Reported by: Godaddy Owned by: meissudeep
Priority: previously reviewed Keywords: theme-activation child-theme parent-primer
Cc: plugins@…

Description

Activation - 1.1.0

Activation is a Primer child theme with a colorful, fitness-focused design.

Theme URL - https://github.com/godaddy/wp-activation-theme
Author URL - https://www.godaddy.com/

Trac Browser - https://themes.trac.wordpress.org/browser/activation/1.1.0

SVN - https://themes.svn.wordpress.org/activation/1.1.0
ZIP - https://wordpress.org/themes/download/activation.1.1.0.zip?nostats=1
Parent Theme: https://wordpress.org/themes/primer

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=activation/0.9.2&new_path=activation/1.1.0

History:

Ticket Summary Status Resolution Owner
#37074 THEME: Activation – 0.9.2 closed closed-newer-version-uploaded meissudeep
#40498 THEME: Activation – 1.1.0 closed closed-newer-version-uploaded meissudeep

(this ticket)

#40805 THEME: Activation – 1.1.2 closed live meissudeep


https://themes.svn.wordpress.org/activation/1.1.0/screenshot.png
Theme Check Results:

  • REQUIRED: Could not find wp_footer. See: wp_footer
     <?php wp_footer(); ?>
    
  • REQUIRED: Could not find wp_head. See: wp_head
     <?php wp_head(); ?>
    
  • REQUIRED: Could not find language_attributes. See: language_attributes
    <html <?php language_attributes(); ?>
    
  • REQUIRED: Could not find charset. There must be a charset defined in the Content-Type or the meta charset tag in the head.
  • REQUIRED: Could not find add_theme_support( 'automatic-feed-links' ). See: add_theme_support
     <?php add_theme_support( $feature ); ?>
    
  • REQUIRED: Could not find comments_template. See: comments_template
     <?php comments_template( $file, $separate_comments ); ?>
    
  • REQUIRED: Could not find wp_list_comments. See: wp_list_comments
     <?php wp_list_comments( $args ); ?>
    
  • REQUIRED: Could not find comment_form. See: comment_form
     <?php comment_form(); ?>
    
  • REQUIRED: Could not find body_class call in body tag. See: body_class
     <?php body_class( $class ); ?>
    
  • REQUIRED: Could not find wp_link_pages. See: wp_link_pages
     <?php wp_link_pages( $args ); ?>
    
  • REQUIRED: Could not find post_class. See: post_class
     <div id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
    
  • REQUIRED: The theme doesn't have comment pagination code in it. Use paginate_comments_links() or the_comments_navigation or the_comments_pagination or next_comments_link() and previous_comments_link() to add comment pagination.
  • REQUIRED: No content width has been defined. Example:
    if ( ! isset( $content_width ) ) $content_width = 900;
    
  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • WARNING: Could not find the file index.php in the theme.
  • REQUIRED: This theme doesn't seem to support the standard avatar functions. Use get_avatar or wp_list_comments to add this support.
  • RECOMMENDED: No reference to nav_menu's was found in the theme. Note that if your theme has a menu bar, it is required to use the WordPress nav_menu functionality for it.
  • REQUIRED: The theme doesn't have post pagination code in it. Use posts_nav_link() or paginate_links() or the_posts_pagination() or the_posts_navigation() or next_posts_link() and previous_posts_link() to add post pagination.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
  • RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( "post-thumbnails" )in the functions.php file.
  • REQUIRED: This theme doesn't seem to display tags. Modify it to display tags in appropriate locations.
  • REQUIRED: No reference to add_theme_support( "title-tag" ) was found in the theme.
  • REQUIRED: The theme must not used the <title> tags.
  • REQUIRED: The theme must not call to wp_title().
  • RECOMMENDED: This theme contains no sidebars/widget areas. See Widgets API
  • WARNING: "Activation" currently has 4,000+ active installations. Please check for name collisions outside of WordPress.org before approval.

Change History (16)

#1 @grapplerulrich
8 months ago

  • Keywords changed from theme-activation, child-theme, parent-primer to theme-activation child-theme parent-primer
  • Owner set to meissudeep
  • Status changed from new to reviewing

#2 @fjarrett
8 months ago

@meissudeep FYI I just updated Primer to 1.5.1 because there was a small bug.

https://themes.trac.wordpress.org/ticket/40500

#3 @meissudeep
8 months ago

  • Status changed from reviewing to approved

All good form my site.

#4 @WPDevHQ
8 months ago

Theme: Primer

  • index.php/archive.php - still using primer_paging_nav(); - you'll need to switch to the_posts_pagination()
  • template-tags.php: the function primer_paging_nav() needs removing!

@meissudeep - you need to be checking the code for the raised isseues before approving tickets!

@fjarrett - Not going to hold this theme back for those issues but do bare in mind if they are not resolved in the next update of Primer they will be blockers for your future child themes from being approved!

@grapplerulrich - you may need to confirm and set live if satisfied :)

Last edited 8 months ago by WPDevHQ (previous) (diff)

#5 @fjarrett
8 months ago

Thanks @WPDevHQ.

But we did change primer_paging_nav() so that it no longer uses a custom implementation, it uses the_posts_pagination(). Are wrappers not allowed? And if so, why not?

https://github.com/godaddy/wp-primer-theme/blob/6fdd12399a4ff90db645a9add9816664cc3b456a/inc/template-tags.php#L183

#6 @WPDevHQ
8 months ago

That doesn't seem to have been pushed to WordPress.org version.

Current version 1.5.1 in template-tags I see this

function primer_paging_nav() {

	global $wp_query;

	if ( ! isset( $wp_query->max_num_pages ) || $wp_query->max_num_pages < 2 ) {

		return;

	}

	?>
	<nav class="navigation paging-navigation">

		<h2 class="screen-reader-text"><?php esc_html_e( 'Posts navigation', 'primer' ); ?></h2>

		<div class="nav-links">

		<?php if ( get_next_posts_link() ) : ?>

			<div class="nav-previous"><?php next_posts_link( __( '<span class="meta-nav">&larr;</span> Older posts', 'primer' ) ); ?></div>

		<?php endif; ?>

		<?php if ( get_previous_posts_link() ) : ?>

			<div class="nav-next"><?php previous_posts_link( __( 'Newer posts <span class="meta-nav">&rarr;</span>', 'primer' ) ); ?></div>

		<?php endif; ?>

		</div><!-- .nav-links -->

	</nav><!-- .navigation -->
	<?php

}

Not the same as GitHub version

#7 @fjarrett
8 months ago

What the heck. OK I will look into this then! Thanks for the heads up.

#8 @fjarrett
8 months ago

@WPDevHQ Hmmm, well everything looks fine on SVN...

https://themes.svn.wordpress.org/primer/1.5.1/inc/template-tags.php

/**
 * Display navigation to next/previous post, when applicable.
 *
 * @link  https://developer.wordpress.org/reference/functions/get_the_post_navigation/
 * @since 1.0.0
 * @uses  the_post_navigation
 *
 * @param array $args (optional) Post navigation arguments.
 */
function primer_post_nav( $args = array() ) {

	/**
	 * Filter the default post navigation args.
	 *
	 * @since 1.5.0
	 *
	 * @var array
	 */
	$defaults = (array) apply_filters( 'primer_post_nav_default_args', array(
		'prev_text' => '&larr; %title',
		'next_text' => '%title &rarr;',
	) );

	$args = wp_parse_args( $args, $defaults );

	the_post_navigation( $args );

}

#9 @fjarrett
8 months ago

@WPDevHQ Just noticed we are talking about two different functions primer_paging_nav() and primer_post_nav(). Easy change, we can have it out tomorrow.

#10 @fjarrett
8 months ago

@WPDevHQ I have a PR issued now for the above https://github.com/godaddy/wp-primer-theme/pull/164

@meissudeep Any idea on when Activation will be live on WordPress.org?

https://wordpress.org/themes/activation/

#11 @WPDevHQ
8 months ago

As soon as the version of Primer on WordPress.org is updated to reflect those changes we can get Activation set to live.

#12 @fjarrett
8 months ago

Alright, we just got the pagination fixed in Primer 1.6.0: https://themes.trac.wordpress.org/ticket/40701

I will be updating Activation here tonight with the proper styles to support them.

#13 @fjarrett
8 months ago

Styles for core pagination support added to v1.1.1: https://themes.trac.wordpress.org/ticket/40805

#14 @meissudeep
8 months ago

hello @grapplerulrich

close this ticket and assign https://themes.trac.wordpress.org/ticket/40805 this to me.

#15 @grapplerulrich
8 months ago

  • Status changed from approved to reopened

#16 @grapplerulrich
8 months ago

  • Resolution set to closed-newer-version-uploaded
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.