WordPress.org

Make WordPress Themes

Opened 8 months ago

Closed 5 months ago

Last modified 5 months ago

#40643 closed theme (not-approved)

THEME: RabbitYel – 1.02

Reported by: aleksandrposs Owned by: timph
Priority: new theme Keywords: theme-rabbityel
Cc: chu753chu@…

Description

RabbitYel - 1.0

simple theme for create doorways

Theme URL -
Author URL - https://wordpress.org/aleksandrposs

Trac Browser - https://themes.trac.wordpress.org/browser/rabbityel/1.0

SVN - https://themes.svn.wordpress.org/rabbityel/1.0
ZIP - https://wordpress.org/themes/download/rabbityel.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#40643 THEME: RabbitYel – 1.02 closed not-approved timph

(this ticket)

#42916 THEME: RabbitYel – 1.09 closed live ponvendhan


https://themes.svn.wordpress.org/rabbityel/1.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

Attachments (4)

rabbityel.zip (679.6 KB) - added by aleksandrposs 8 months ago.
update file single.php
rabbityel.2.zip (238.7 KB) - added by aleksandrposs 7 months ago.
fix errors 05.04.2017
rabbityel.dev.3.zip (237.4 KB) - added by aleksandrposs 6 months ago.
testing file dev version 3 for verify on wordpress.org
screeen.jpg (58.8 KB) - added by aleksandrposs 6 months ago.
design last version

Download all attachments as: .zip

Change History (24)

#1 @aleksandrposs
8 months ago

This is my first wordpress theme. Please, say me if I do errors, then say me how can I fix it..Please, say fully details about how can I fix errors in my FIRST theme.

At future time I want create and develop more themes for wordpress.

#2 @themetracbot
8 months ago

  • Summary changed from THEME: RabbitYel – 1.0 to THEME: RabbitYel – 1.01

RabbitYel - 1.01

simple theme for create doorways

Theme URL -
Author URL - https://profiles.wordpress.org/aleksandrposs

Trac Browser - https://themes.trac.wordpress.org/browser/rabbityel/1.01

SVN - https://themes.svn.wordpress.org/rabbityel/1.01
ZIP - https://wordpress.org/themes/download/rabbityel.1.01.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=rabbityel/1.0&new_path=rabbityel/1.01

History:

Ticket Summary Status Resolution Owner
#40643 THEME: RabbitYel – 1.02 closed not-approved timph

(this ticket)

#42916 THEME: RabbitYel – 1.09 closed live ponvendhan


https://themes.svn.wordpress.org/rabbityel/1.01/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

@aleksandrposs
8 months ago

update file single.php

#3 @joyously
7 months ago

All updates should be from the upload page, not as attachments to the ticket.

  • Remove all @package WordPress comments. This is not part of WordPress.
  • readme.txt:
    • You can't just copy the readme from another theme. Not much of it applies to this theme. Make your own readme.txt file and delete this one.
  • header.php:
    • wp_head() should be the last thing before </head>
    • wp_enqueue_style() should be in a function hooked to the after_theme_setup action, so that child themes can override. Same for setting the content_width.
  • single.php:
    • Why is this in there twice? <main id="main" class="site-main" role="main"> (closed once)
    • Use WordPress functionality first, because it's got filters and action hooks. Instead of echo $post->post_title, use the_title(). Instead of echo $post->post_content, use the_content().
    • need to do something to clear floats after the content.
  • search.php:
    • Why is this in there twice? <main id="main" class="site-main" role="main"> (closed once)
    • The page title is only output if there are posts.
    • The post titles should not be h1.
    • The search does not return password protected posts unless you have already entered the password. So you don't need to check for password before the post_thumbnail.
    • Search results work much better as excerpts, so the user can see where the matches are instead of a flood of mostly non-matching content.
  • page.php:
    • Remove the echo from the_title() and the_content(). These functions echo by default.
    • need to do something to clear floats after the_content().
  • index.php:
    • The post titles should not be h1.
    • Remove the echo from the_title() and the_content() and the_tags(). These functions echo by default.
    • Remove get_template_part( 'content', get_post_format() ) since you don't have any template parts.
    • need to do something to clear floats after the_content().
    • you call get_template_part( 'content', 'none' ), but you don't have that template part so nothing is output.
  • image.php:
    • This is obviously copied from TwentySixteen. You can't just clone it. Make your own.
    • calling undefined functions: rabbityel_excerpt() and rabbityel_entry_meta()
  • footer.php, archive.php, 404.php, functions.php:
    • Also obviously copied.
  • Archive, Search, Index should all link the post titles to the post page.

There is no way you tested this without finding all these problems.

Please read the guidelines and use the theme test data as described here. Review tickets can be closed for having 5 or more required fix issues.

#4 @jcastaneda
7 months ago

Hi @aleksandrposs

This was brought to my attention and I wanted to share a few things with you. First, I love, love that you are wanting to share your theme with people. Second, and I don't want it to come off harsh and while design is not a requirement, the overall design is lacking. I am not sure if you have had the chance to look over any of the recommended items listed under design: https://make.wordpress.org/themes/handbook/review/recommended/#design

One thing I want to encourage you to do is to focus on creating a less general purpose theme as this currently appears to be one.

Consider designing niche themes.

This is what will set this apart from the others as well.

Another thing I wanted to pass on was that I love your enthusiasm, I do. I love that you are wanting to learn. The thing to remember is that not all reviewers have the time needed to keep educating on a single theme. I can tell you there are several resources available that can teach you how to develop WordPress themes. A few that I've come across over the years:

Yes, some of those are actual-paid courses but they are very worth it if you really want to pursue this.

#5 @aleksandrposs
7 months ago

Hello!

Nice to meet you. Sorry, my native langauge is non-english I fully understand you @joyously and @jcastaneda .

I fixed all errors in my template "RabbitYel" for wordpress. At future time I want upgrade my this theme to more header colors and add support header's image and social buttons for post.

Now, I can saying - my template fully ready for upload to wordpress.org/plugis. But, if you can search errors this is will be true.

I added, new version of template to this page.

@aleksandrposs
7 months ago

fix errors 05.04.2017

#6 @themetracbot
6 months ago

  • Owner set to jcb121
  • Status changed from new to reviewing

#7 @aleksandrposs
6 months ago

Sorry, my PC was be attacked. I don't changed owner of this theme.

I'm fully author of this theme.

And why i can't copy parts of other thems? GPL license allowing copy source codes of themes.

Please set OWNER to ME @aleksandrposs .

Last edited 6 months ago by aleksandrposs (previous) (diff)

#8 @jcastaneda
6 months ago

@aleksandrposs you are still the owner of the theme. It is referring to the owner of this ticket.

@jcb121, if you are able to post a review please do so, otherwise, I can place it back in the queue.


@joyously if you can, please make sure that you are differentiating as to what is required and what you are recommending. The review team requirements are listed here: https://make.wordpress.org/themes/handbook/review/required/

What you linked to are the developer documentation pages.

#9 @djrmom
6 months ago

  • Owner jcb121 deleted

I am sorry this review is taking so long. Sometimes people are unable to carry on the review, this may have happened this time. As a result, I am going to add this to the new queue again as a priority. This may mean it still takes time, but will prevent this ticket being held for so long by a reviewer that isn't able to carry on. Thanks for your patience.

If you are the reviewer and able to do this review, please carry on and request you get added back in Slack #themereview or you can take on another review when you have time again.

#10 @themetracbot
6 months ago

  • Owner set to albanb

#11 @albanb
6 months ago

  1. Data Validation issues have been found in your theme. All dynamic data must be correctly escaped for the context where it is rendered. - All dynamic data must be escaped with esc_attr() before rendered in an html attribute. - Whenever you are rendering a url to the screen its value must be passed through esc_url() first. - If dynamic data is rendered inside an attribute that triggers a JavaScript event, it must be escaped with esc_js().

https://codex.wordpress.org/I18n_for_WordPress_Developers

  1. Add class in the once and close it correctly
  2. <main> tag specifies the main content of a document and open once.

Example:
https://i.imgur.com/lTGx7lO.png

  1. Strings translation file should be delivered as .POT file
  1. Please remove comment template from search.php

Example:https://i.imgur.com/WruiYBa.png

#12 @aleksandrposs
6 months ago

  1. esc_url added to footer, where I added link to author profile's page.

My theme doesn't have javascript (this is simple theme), therefore I don't using esc_js().
I don't have html dynamic attributes, therefore I don't using esc_attr().

2.My theme doesn't have classes in finction.php file and other files. This is very simple theme.

3.<main> tag closes NOW in my theme.

4.String translation don't need use in this simple theme. And I verified....my theme normal working with russian langauge. Therefore my theme will be working with other langauges.

5.Yeah..I removed this from comments.php

@aleksandrposs
6 months ago

testing file dev version 3 for verify on wordpress.org

#13 @albanb
6 months ago

  1. Polish design and make typography looks much better.

@aleksandrposs
6 months ago

design last version

#14 @aleksandrposs
6 months ago

I think on themeforest and wordpress.org/themes more templates for wordpress has beautyfull designs. My design is simple. Important for me, that my this SIMPLE template with green colors will be accepted on wordpress.org/themes.

If my template doesn't has errors in source code, please approve my template.

After, this I want create templates with beautyfull designs.

Last edited 6 months ago by aleksandrposs (previous) (diff)

#15 @jcastaneda
6 months ago

@aleksandrposs you need to use the upload form you first used to upload the theme ( https://wordpress.org/themes/upload/ ) otherwise the system will not recognize the newest version.

#16 @themetracbot
6 months ago

  • Summary changed from THEME: RabbitYel – 1.01 to THEME: RabbitYel – 1.02

RabbitYel - 1.02

simple theme for create doorways

Theme URL -
Author URL - https://profiles.wordpress.org/aleksandrposs

Trac Browser - https://themes.trac.wordpress.org/browser/rabbityel/1.02

SVN - https://themes.svn.wordpress.org/rabbityel/1.02
ZIP - https://wordpress.org/themes/download/rabbityel.1.02.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=rabbityel/1.01&new_path=rabbityel/1.02

History:

Ticket Summary Status Resolution Owner
#40643 THEME: RabbitYel – 1.02 closed not-approved timph

(this ticket)

#42916 THEME: RabbitYel – 1.09 closed live ponvendhan


https://themes.svn.wordpress.org/rabbityel/1.02/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#17 @djrmom
6 months ago

@albanb, are you still reviewing this theme? If not, please let me know, I can reassign. Thanks.

#18 @djrmom
6 months ago

  • Owner albanb deleted

I am sorry this review is taking so long. Sometimes people are unable to carry on the review, this may have happened this time. As a result, I am going to add this to the new queue again as a priority. This may mean it still takes time, but will prevent this ticket being held for so long by a reviewer that isn't able to carry on. Thanks for your patience.

If you are the reviewer and able to do this review, please carry on and request you get added back in Slack #themereview or you can take on another review when you have time again.

#19 @themetracbot
5 months ago

  • Owner set to timph

#20 @timph
5 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hey there @aleksandrposs

First of all - thanks so much for your theme submission!

I have taken an initial look at your theme, and have a couple of suggestions in order for the theme to be accepted. Some of the things I noticed are things that have been previously mentioned whether or not part of an official or unofficial review, so I would recommend rereading some of those responses as they are all targeted to help you succeed!

As part of our theme review process, theme submissions that have 5 or more required changes to make will have their tickets closed until you are able to address the changes and resubmit them for review. This doesn't mean you aren't on the right track - we want you to still resubmit the theme after you have reviewed the requested changes. We do ask that you spend a little bit of time reviewing the requirements for themes, which are available here: https://make.wordpress.org/themes/handbook/review/required/.

Required:

  1. In header.php L10 you have:
    <html <?php language_attributes(); ?>
    

You need to make sure you are closing tags on any and all HTML elements to help prevent buggy behaviors. You might consider using a text editor like Atom or Sublime (or a variety of others), which can help you with syntax highlighting and making sure you line things up nicely.

  1. In footer.php L15 you have:
    esc_url('https://profiles.wordpress.org/aleksandrposs/');
    

There's not any reason to escape this static content.

the URL to https://wordpress.org/ does not need to be piped through translation methods as it's just a URL.

  1. Either remove or update readme.txt as it has nothing to do with your theme.
  1. Use template tags appropriately. In index.php L39 you have:
get_template_part( 'content', get_post_format() );

Your theme does not include any post formats, so you should remove this as it's unnecessary overhead when rendering your templates.

  1. When looking at the rendered HTML by viewing the source outputted, I see that you have two closing div tags that don't have any openers. WordPress itself tries to help users who may not format their HTML correctly with things like autop or force_balance_tags when rendering user content, but as a theme developer you need to ensure that your theme is properly finishing what it starts!
  1. In footer.php L15 you have:
                                    Author <a href="<?php echo esc_url('https://profiles.wordpress.org/aleksandrposs/'); ?>">Chugaev Aleksandr Aleksandrovich</a>
    
    

Make sure any text strings you are adding to the theme are going through translate.
https://make.wordpress.org/themes/handbook/review/required/#language

Other things to consider:

  1. Extra wide 1200px images don't fit on the page.
  1. Create or use some sort of navigation that is easily accessible. This theme provides a pretty poor user experience, especially for a site that has content.
  1. The theme isn't really responsive, and this is something that can go a long way for a user in terms of appearance. Giving more thought to this would help ensure that your theme is more successful and provide users with a much better experience.
  1. Your sticky posts should have some level of visual differentiation from a standard post.
  1. You should really consider making the link to your wordpress.org author profile and WordPress.org attribution customizer options, so that users can easily remove and enable the links in their footer. A lot of people don't like using a theme that doesn't provide this flexibility, and it only takes a few minutes to implement.
  1. Since the theme is not focused on being accessibility ready, adding roles to aside, main, and navigation don't serve much of a purpose and pretty much are recommended for IE11 and lower to assist with screenreaders. Instead of removing them, I would encourage you to focus on accessibility more in your theme - as it helps site's that use the theme reach a wider audience.
  1. Your code uses a mix of tabs and spaces and this makes it incredibly difficult to read over quickly. I would recommend using the WordPress coding standards as a good readable format for developing your theme's code out of preference : https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/. Regardless of the formatting you choose, keeping your formatting consistent in your code helps improve your workflow and the workflow of others who might work with your code.

Don't be discouraged with this review, as we want to see you be successful. I do think that you should put some additional focus on the design, and make the theme something that people are inclined to use by following the suggestions of the others that were provided to you. @jcastaneda gave you some excellent resources to help you get deeper into things. Once you have a theme out there, it does become a much more complex process to ensure backwards compatibility of your existing users if you have plans to completely change this simple theme to something more elegant - so you should always submit what you're ready to provide to other people who will be relying on your work! No one wants to have a theme that looks a certain way, then it all of the sudden it is an entirely different thing or gets broken when they update it. Accounting for a lot of the stuff in the theme unit test data will help you cover situations that you might not have focused on or thought about initially. Users may use your theme in various different ways that you might not predict, so providing a base set of styles to cover those use cases, and elements goes a long way in making an okay theme really great.

Thanks again for you submission, and we look forward to seeing your changes!

Last edited 5 months ago by timph (previous) (diff)
Note: See TracTickets for help on using tickets.