WordPress.org

Make WordPress Themes

Opened 6 months ago

Closed 5 months ago

Last modified 5 months ago

#40803 closed theme (not-approved)

THEME: Stride lite – 1.2.2

Reported by: orahmax Owned by: rabmalin
Priority: new theme Keywords: theme-stride-lite
Cc: mohitchawla127@…

Description

Stride lite - 1.0.0

stride is a clean, modern and fully responsive WordPress Personal Blog theme built using Bootstrap 3 which makes it optimized for tablets and mobile. It comes with Related posts and popular posts widget with deatured posts slider on front page.

Theme URL -
Author URL - https://www.tidyhive.com

Trac Browser - https://themes.trac.wordpress.org/browser/stride-lite/1.0.0

SVN - https://themes.svn.wordpress.org/stride-lite/1.0.0
ZIP - https://wordpress.org/themes/download/stride-lite.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#40803 THEME: Stride lite – 1.2.2 closed not-approved rabmalin

(this ticket)

#41260 THEME: Stride lite – 1.3.1 closed live rushijagani


https://themes.svn.wordpress.org/stride-lite/1.0.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.

Change History (6)

#1 @themetracbot
6 months ago

  • Summary changed from THEME: Stride lite – 1.0.0 to THEME: Stride lite – 1.2.0

Stride lite - 1.2.0

stride is a clean, modern and fully responsive WordPress Personal Blog theme built using Bootstrap 3 which makes it optimized for tablets and mobile. It comes with Related posts and popular posts widget with deatured posts slider on front page.

Theme URL -
Author URL - https://www.tidyhive.com

Trac Browser - https://themes.trac.wordpress.org/browser/stride-lite/1.2.0

SVN - https://themes.svn.wordpress.org/stride-lite/1.2.0
ZIP - https://wordpress.org/themes/download/stride-lite.1.2.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=stride-lite/1.0.0&new_path=stride-lite/1.2.0

History:

Ticket Summary Status Resolution Owner
#40803 THEME: Stride lite – 1.2.2 closed not-approved rabmalin

(this ticket)

#41260 THEME: Stride lite – 1.3.1 closed live rushijagani


https://themes.svn.wordpress.org/stride-lite/1.2.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.

#2 @themetracbot
5 months ago

  • Summary changed from THEME: Stride lite – 1.2.0 to THEME: Stride lite – 1.2.2

Stride lite - 1.2.2

Stride lite is a clean, modern and fully responsive WordPress Personal Blog theme built using Bootstrap 3 which makes it optimized for tablets and mobile.

Theme URL -
Author URL - https://www.tidyhive.com

Trac Browser - https://themes.trac.wordpress.org/browser/stride-lite/1.2.2

SVN - https://themes.svn.wordpress.org/stride-lite/1.2.2
ZIP - https://wordpress.org/themes/download/stride-lite.1.2.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=stride-lite/1.2.0&new_path=stride-lite/1.2.2

History:

Ticket Summary Status Resolution Owner
#40803 THEME: Stride lite – 1.2.2 closed not-approved rabmalin

(this ticket)

#41260 THEME: Stride lite – 1.3.1 closed live rushijagani


https://themes.svn.wordpress.org/stride-lite/1.2.2/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Theme URI: is missing from your style.css header.

#3 @rabmalin
5 months ago

  • Owner set to rabmalin
  • Status changed from new to reviewing

#4 @rabmalin
5 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hello,

Your theme has been partially reviewed against this Theme Review Guideline.

As part of the new theme directory guidelines, reviewers may now close tickets if a theme has 5 or more issues. This is part of our long term goals to improve the theme quality and shorten the queues. You can read more about this change here: https://make.wordpress.org/themes.

Please do not get discouraged by the ticket being closed. We want you to resubmit your theme, but we do ask that you spend more time making sure that your theme meets all the requirements. You can upload your updated theme here: https://wordpress.org/themes/upload/

Because of the large number of themes waiting for review, we might not be able to follow up immediately. We will review your update when your theme reaches the top of the review queue.

Issues

Theme Check Sniffs

Note: Errors need to be fixed and Warnings are things that need to be checked manually.

FILE: /var/www/review.dev/public_html/wp-content/themes/stride-lite/inc/custom-comments.php
-------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------
 44 | ERROR | Overriding WordPress globals is prohibited
-------------------------------------------------------------------------------------------


FILE: /var/www/review.dev/public_html/wp-content/themes/stride-lite/inc/custom-header.php
------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------
 50 | ERROR | Found usage of constant "HEADER_TEXTCOLOR". Use add_theme_support( 'custom-header' ) instead.
------------------------------------------------------------------------------------------------------------


FILE: /var/www/review.dev/public_html/wp-content/themes/stride-lite/inc/template-tags.php
-----------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------
 30 | ERROR | Strings should have translatable content
 35 | ERROR | Strings should have translatable content
 70 | ERROR | Strings should have translatable content
-----------------------------------------------------------------------------------------


FILE: /var/www/review.dev/public_html/wp-content/themes/stride-lite/footer.php
--------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------
 34 | ERROR | [x] Multiple placeholders should be ordered. Expected '%1$s, %2$s', but got %s, %s.
--------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------


FILE: /var/www/review.dev/public_html/wp-content/themes/stride-lite/comments.php
--------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
 31 | ERROR | Missing singular placeholder, needed for some languages. See
    |       | https://codex.wordpress.org/I18n_for_WordPress_Developers#Plurals
--------------------------------------------------------------------------------------------------------------

#5 @orahmax
5 months ago

You have listed the issues but did not specify the file/code where the problem exists. It seems you were in a hurry to close my theme.

If you can be more specific with the issues you mentioned, I can make corrections and re-submit the theme.

  • Where do you see untranslatable text?
  • I am using _s starter theme and it comes with proper prefixing. Please specify unprefixed part.
  • Not clear where is the problem with prefixing, sanitation and escaping?

#6 @rabmalin
5 months ago

Hello,

You have listed the issues but did not specify the file/code where the problem exists. It seems you were in a hurry to close my theme.

Nope, I did not close ticket in hurry. Reviewers are allowed to close if ticket if theme has 5+ distinct issues. This theme has lot more than that. So, I closed the ticket.

Another thing, do not expect reviewer do the QA and testing of theme. It is theme author's responsibilty to make their theme par the standard. Reviewers are here for facilitating the theme author for making good theme.

I am using _s starter theme and it comes with proper prefixing.

We should be very clear that _s theme should be just taken as reference. Yes, it is good starter theme, but it is based on WordPress.com standard. We review theme here in WordPress.org standard. Copying code from _s wont make sure that it will be fully compatible with theme review guidelines here.

Prefixing issues

  • bloggedin_excerpt_length(), new_excerpt_more(), copyright_flag_sanitize()
  • Google font handle is not prefixed

Translation Issues

  • customizer.php L27
  • Check stride_plugin_notice()

Escaping Issues

  • footer.php - Value of copyright_textbox not escaped before displaying

Sanitization Issues

  • Check this code. esc_html() is not sanitizing function.
    function copyright_text_sanitize( $input ){
        return esc_html( $input );
    }
    

At final, please check Theme Review Guideline very thoroughly and fix your theme accordingly. I am sure you would not want your theme be closed due to 5+ issues waiting 3 months in the queue.

Good luck.

Note: See TracTickets for help on using tickets.