WordPress.org

Make WordPress Themes

Opened 8 months ago

Closed 6 months ago

#40805 closed theme (live)

THEME: Activation – 1.1.2

Reported by: Godaddy Owned by: meissudeep
Priority: previously reviewed Keywords: theme-activation child-theme parent-primer
Cc: plugins@…

Description

Activation - 1.1.1

Activation is a Primer child theme with a colorful, fitness-focused design.

Theme URL - https://github.com/godaddy/wp-activation-theme
Author URL - https://www.godaddy.com/

Trac Browser - https://themes.trac.wordpress.org/browser/activation/1.1.1

SVN - https://themes.svn.wordpress.org/activation/1.1.1
ZIP - https://wordpress.org/themes/download/activation.1.1.1.zip?nostats=1
Parent Theme: https://wordpress.org/themes/primer

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=activation/1.1.0&new_path=activation/1.1.1

History:

Ticket Summary Status Resolution Owner
#37074 THEME: Activation – 0.9.2 closed closed-newer-version-uploaded meissudeep
#40498 THEME: Activation – 1.1.0 closed closed-newer-version-uploaded meissudeep
#40805 THEME: Activation – 1.1.2 closed live meissudeep

(this ticket)


https://themes.svn.wordpress.org/activation/1.1.1/screenshot.png
Theme Check Results:

  • REQUIRED: Could not find wp_footer. See: wp_footer
     <?php wp_footer(); ?>
    
  • REQUIRED: Could not find wp_head. See: wp_head
     <?php wp_head(); ?>
    
  • REQUIRED: Could not find language_attributes. See: language_attributes
    <html <?php language_attributes(); ?>
    
  • REQUIRED: Could not find charset. There must be a charset defined in the Content-Type or the meta charset tag in the head.
  • REQUIRED: Could not find add_theme_support( 'automatic-feed-links' ). See: add_theme_support
     <?php add_theme_support( $feature ); ?>
    
  • REQUIRED: Could not find comments_template. See: comments_template
     <?php comments_template( $file, $separate_comments ); ?>
    
  • REQUIRED: Could not find wp_list_comments. See: wp_list_comments
     <?php wp_list_comments( $args ); ?>
    
  • REQUIRED: Could not find comment_form. See: comment_form
     <?php comment_form(); ?>
    
  • REQUIRED: Could not find body_class call in body tag. See: body_class
     <?php body_class( $class ); ?>
    
  • REQUIRED: Could not find wp_link_pages. See: wp_link_pages
     <?php wp_link_pages( $args ); ?>
    
  • REQUIRED: Could not find post_class. See: post_class
     <div id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
    
  • REQUIRED: The theme doesn't have comment pagination code in it. Use paginate_comments_links() or the_comments_navigation or the_comments_pagination or next_comments_link() and previous_comments_link() to add comment pagination.
  • REQUIRED: No content width has been defined. Example:
    if ( ! isset( $content_width ) ) $content_width = 900;
    
  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • WARNING: Could not find the file index.php in the theme.
  • REQUIRED: This theme doesn't seem to support the standard avatar functions. Use get_avatar or wp_list_comments to add this support.
  • RECOMMENDED: No reference to nav_menu's was found in the theme. Note that if your theme has a menu bar, it is required to use the WordPress nav_menu functionality for it.
  • REQUIRED: The theme doesn't have post pagination code in it. Use posts_nav_link() or paginate_links() or the_posts_pagination() or the_posts_navigation() or next_posts_link() and previous_posts_link() to add post pagination.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
  • RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( "post-thumbnails" )in the functions.php file.
  • REQUIRED: This theme doesn't seem to display tags. Modify it to display tags in appropriate locations.
  • REQUIRED: No reference to add_theme_support( "title-tag" ) was found in the theme.
  • REQUIRED: The theme must not used the <title> tags.
  • REQUIRED: The theme must not call to wp_title().
  • RECOMMENDED: This theme contains no sidebars/widget areas. See Widgets API
  • WARNING: "Activation" currently has 5,000+ active installations. Please check for name collisions outside of WordPress.org before approval.

Change History (11)

#1 @fjarrett
8 months ago

@WPDevHQ / @meissudeep,

We have addressed the core pagination issue raised with the Primer parent theme in v1.6.0, and have updated the styles in Activation here accordingly.

Note: The previous pagination function still remains in Primer for backward compatibility with other/older child themes, but has been marked as deprecated.

Thank you both for your thorough and thoughtful advice!

Last edited 8 months ago by fjarrett (previous) (diff)

#2 @grapplerulrich
8 months ago

  • Keywords changed from theme-activation, child-theme, parent-primer to theme-activation child-theme parent-primer
  • Owner set to meissudeep
  • Status changed from new to reviewing

#3 @meissudeep
8 months ago

  • Status changed from reviewing to approved

Hello @fjarrett

Only seen the style and version get modified so marking this theme as approved

#4 @fjarrett
7 months ago

Thanks @meissudeep! So when will this go live?

#5 @rabmalin
6 months ago

I am doing final review.

@fjarrett Please avoid commenting in the ticket after ticket is approved. It may distort your theme position in the final queue.

#6 @rabmalin
6 months ago

  • Status changed from approved to reopened

Hello

Only few issues found. Please fix following issues are re-upload your theme.

Issues

  • REQUIRED: readme.txt - Please keep FULL URL of images used in the screenshot and the theme. 4 images are used in the screenshot but only 1 URL is kept in the readme file.

Please respond within 7 days. If there is no response for 7 days, ticket will be closed as not-approved.

#7 @rabmalin
6 months ago

  • Status changed from reopened to reviewing

#8 @rabmalin
6 months ago

@fjarrett Reminder - Please respond within 7 days. If there is no response for 7 days, ticket will be closed as not-approved.

#9 @themetracbot
6 months ago

  • Summary changed from THEME: Activation – 1.1.1 to THEME: Activation – 1.1.2

Activation - 1.1.2

Activation is a Primer child theme with a colorful, fitness-focused design.

Theme URL - https://github.com/godaddy/wp-activation-theme
Author URL - https://www.godaddy.com/

Trac Browser - https://themes.trac.wordpress.org/browser/activation/1.1.2

SVN - https://themes.svn.wordpress.org/activation/1.1.2
ZIP - https://wordpress.org/themes/download/activation.1.1.2.zip?nostats=1
Parent Theme: https://wordpress.org/themes/primer

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=activation/1.1.1&new_path=activation/1.1.2

History:

Ticket Summary Status Resolution Owner
#37074 THEME: Activation – 0.9.2 closed closed-newer-version-uploaded meissudeep
#40498 THEME: Activation – 1.1.0 closed closed-newer-version-uploaded meissudeep
#40805 THEME: Activation – 1.1.2 closed live meissudeep

(this ticket)


https://themes.svn.wordpress.org/activation/1.1.2/screenshot.png
Theme Check Results:

  • REQUIRED: Could not find wp_footer. See: wp_footer
     <?php wp_footer(); ?>
    
  • REQUIRED: Could not find wp_head. See: wp_head
     <?php wp_head(); ?>
    
  • REQUIRED: Could not find language_attributes. See: language_attributes
    <html <?php language_attributes(); ?>
    
  • REQUIRED: Could not find charset. There must be a charset defined in the Content-Type or the meta charset tag in the head.
  • REQUIRED: Could not find add_theme_support( 'automatic-feed-links' ). See: add_theme_support
     <?php add_theme_support( $feature ); ?>
    
  • REQUIRED: Could not find comments_template. See: comments_template
     <?php comments_template( $file, $separate_comments ); ?>
    
  • REQUIRED: Could not find wp_list_comments. See: wp_list_comments
     <?php wp_list_comments( $args ); ?>
    
  • REQUIRED: Could not find comment_form. See: comment_form
     <?php comment_form(); ?>
    
  • REQUIRED: Could not find body_class call in body tag. See: body_class
     <?php body_class( $class ); ?>
    
  • REQUIRED: Could not find wp_link_pages. See: wp_link_pages
     <?php wp_link_pages( $args ); ?>
    
  • REQUIRED: Could not find post_class. See: post_class
     <div id="post-<?php the_ID(); ?>" <?php post_class(); ?>>
    
  • REQUIRED: The theme doesn't have comment pagination code in it. Use paginate_comments_links() or the_comments_navigation or the_comments_pagination or next_comments_link() and previous_comments_link() to add comment pagination.
  • REQUIRED: No content width has been defined. Example:
    if ( ! isset( $content_width ) ) $content_width = 900;
    
  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • WARNING: Could not find the file index.php in the theme.
  • REQUIRED: This theme doesn't seem to support the standard avatar functions. Use get_avatar or wp_list_comments to add this support.
  • RECOMMENDED: No reference to nav_menu's was found in the theme. Note that if your theme has a menu bar, it is required to use the WordPress nav_menu functionality for it.
  • REQUIRED: The theme doesn't have post pagination code in it. Use posts_nav_link() or paginate_links() or the_posts_pagination() or the_posts_navigation() or next_posts_link() and previous_posts_link() to add post pagination.
  • RECOMMENDED: No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
  • RECOMMENDED: No reference to post-thumbnails was found in the theme. If the theme has a thumbnail like functionality, it should be implemented with add_theme_support( "post-thumbnails" )in the functions.php file.
  • REQUIRED: This theme doesn't seem to display tags. Modify it to display tags in appropriate locations.
  • REQUIRED: No reference to add_theme_support( "title-tag" ) was found in the theme.
  • REQUIRED: The theme must not used the <title> tags.
  • REQUIRED: The theme must not call to wp_title().
  • RECOMMENDED: This theme contains no sidebars/widget areas. See Widgets API
  • WARNING: "Activation" currently has 6,000+ active installations. Please check for name collisions outside of WordPress.org before approval.

#10 @fjarrett
6 months ago

@rabmalin OK I've updated the screenshot and removed those images.

https://themes.trac.wordpress.org/ticket/40805

#11 @rabmalin
6 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

Approving and setting live.

Note: See TracTickets for help on using tickets.