WordPress.org

Make WordPress Themes

Opened 10 months ago

Closed 6 months ago

Last modified 6 months ago

#40841 closed theme (not-approved)

THEME: Buzzo – 1.0.3

Reported by: awethemes Owned by: Rohittm
Priority: new theme Keywords: theme-buzzo accessibility-ready
Cc: support@…

Description

Buzzo - 1.0.0

Buzzo is a simple, responsive, gorgeous theme that will put your content without distraction. The theme does offer visual appeal by including large enticing featured images and bold headlines, which make it easy for your readers to browse lots of material.

Theme URL - http://awethemes.com/docs/buzzo
Author URL - http://awethemes.com

Trac Browser - https://themes.trac.wordpress.org/browser/buzzo/1.0.0

SVN - https://themes.svn.wordpress.org/buzzo/1.0.0
ZIP - https://wordpress.org/themes/download/buzzo.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#40841 THEME: Buzzo – 1.0.3 closed not-approved Rohittm

(this ticket)

#44239 THEME: Buzzo – 1.0.9 closed live codexdemon
#49170 THEME: Buzzo – 1.0.10 closed live themetracbot


https://themes.svn.wordpress.org/buzzo/1.0.0/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

Attachments (2)

buzzo.zip (1.2 MB) - added by awethemes 8 months ago.
Resubmit: Buzzo WordPress Theme
buzzo.2.zip (1.8 MB) - added by awethemes 6 months ago.

Change History (37)

#1 @joyously
8 months ago

  • Hardcoded date in copyright
  • Read this about why not to name a page template home.php.
  • Remove the sass folder.
  • Static Pages should show comments.
  • Formatting:
    • There is a CSS rule for code, kbd, tt, var {font-size: 0.05859rem;} that makes these tags incredibly small (less than 1px), totally unreadable.
    • There is a separate rule for pre with the same tiny font-size.
    • <q> tag is unstyled (default removed)
    • Page links (generated by <!--nextpage-->) are being output in the same div as the content instead of after it.
    • The text that goes on top of color blocks could use a little text-shadow to make it more readable.
  • Remove the hardcoded theme-added content after posts. "Good luck my friend. hopefully this article will be useful to you."
  • Search results should not show the date of static Pages.
  • Search results work much better as excerpts, so the user can see where the matches are instead of a flood of mostly non-matching content.
  • Nested comments are showing the ordered list number, which is confusing for paged and nested comments. Try using CSS to hide the number or CSS counters to make it more logical.
  • The 404 page has a title of "Archives".
  • Customizer:
    • Clicking the option to "Display Site title and Tagline" does nothing.
    • Changing the Header Text color does nothing.
    • Remove the Social Sharing option. (plugin territory)
    • For Home Page section, please make it clear how to get this home page (page template, static Page ?).

Please read the guidelines and use the theme test data as described here. Review tickets can be closed for having 5 or more required fix issues.

#2 @themetracbot
8 months ago

  • Owner set to ketuchetan
  • Status changed from new to reviewing

#3 @ketuchetan
8 months ago

Hi @awethemes,

Thanks for the submitting this good theme :)

Can you please fix all the above changes which mentioned by @joyously?

After then your above fixes I will start the theme review again.

Thanks,

#4 @awethemes
8 months ago

Hi @joyously , @ketuchetan.

Thank for this review. We're going to fix all issues as soon as possible.

Best,
AweThemes

@awethemes
8 months ago

Resubmit: Buzzo WordPress Theme

#5 @awethemes
8 months ago

Hi Reviewer Team,

We're ready to resubmit theme. It was fixed above changes which mentioned by @joyously.

Looking forward to hear from you guys.

Best
AweThemes.

#6 @joyously
8 months ago

You need to use the same upload page that you originally did. The upload page runs it through Theme Check. The attachment to this ticket is not used since it is not run through Theme Check.
Be sure to increment the version number.

#7 @themetracbot
8 months ago

  • Keywords changed from theme-buzzo, accessibility-ready to theme-buzzo accessibility-ready
  • Summary changed from THEME: Buzzo – 1.0.0 to THEME: Buzzo – 1.0.1

Buzzo - 1.0.1

Buzzo is a simple, responsive, gorgeous theme that will put your content without distraction. The theme does offer visual appeal by including large enticing featured images and bold headlines, which make it easy for your readers to browse lots of material.

Theme URL - http://awethemes.com/docs/buzzo
Author URL - http://awethemes.com

Trac Browser - https://themes.trac.wordpress.org/browser/buzzo/1.0.1

SVN - https://themes.svn.wordpress.org/buzzo/1.0.1
ZIP - https://wordpress.org/themes/download/buzzo.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=buzzo/1.0.0&new_path=buzzo/1.0.1

History:

Ticket Summary Status Resolution Owner
#40841 THEME: Buzzo – 1.0.3 closed not-approved Rohittm

(this ticket)

#44239 THEME: Buzzo – 1.0.9 closed live codexdemon
#49170 THEME: Buzzo – 1.0.10 closed live themetracbot


https://themes.svn.wordpress.org/buzzo/1.0.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

#8 @poena
8 months ago

@ketuchetan Hi! Will you be able to continue the review?

#9 @ketuchetan
8 months ago

Hi @awethemes,

Thanks for the correction.

Still, I have few changes which you have to do in your theme.

  • No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • Possible hard-coded links were found in the file footer.php
    • Line 23: $copyright = get_theme_mod( 'buzzo_copyright', '&copy; [year]. Made with love by <a href='http://awethemes.com'>Awethemes</a>' );
  • Only one text-domain is being used in this theme. Make sure it matches the theme's slug correctly so that the theme will be compatible with WordPress.org language packs.

The domain found is buzzo

Thanks,

#10 @awethemes
8 months ago

Hi @ketuchetan.

Thank for this review. We're going to fix all issues as soon as possible.

Best,
AweThemes

#11 @themetracbot
8 months ago

  • Summary changed from THEME: Buzzo – 1.0.1 to THEME: Buzzo – 1.0.2

Buzzo - 1.0.2

Buzzo is a simple, responsive, gorgeous theme that will put your content without distraction. The theme does offer visual appeal by including large enticing featured images and bold headlines, which make it easy for your readers to browse lots of material.

Theme URL - http://awethemes.com/docs/buzzo
Author URL - http://awethemes.com

Trac Browser - https://themes.trac.wordpress.org/browser/buzzo/1.0.2

SVN - https://themes.svn.wordpress.org/buzzo/1.0.2
ZIP - https://wordpress.org/themes/download/buzzo.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=buzzo/1.0.1&new_path=buzzo/1.0.2

History:

Ticket Summary Status Resolution Owner
#40841 THEME: Buzzo – 1.0.3 closed not-approved Rohittm

(this ticket)

#44239 THEME: Buzzo – 1.0.9 closed live codexdemon
#49170 THEME: Buzzo – 1.0.10 closed live themetracbot


https://themes.svn.wordpress.org/buzzo/1.0.2/screenshot.png

#12 @awethemes
8 months ago

Hi Reviewer Team,

We're ready to resubmit theme. It was fixed above changes which mentioned by @ketuchetan.
Looking forward to hear from you guys.

Best
AweThemes.

#13 @poena
8 months ago

Hi
@ketuchetan The issues mentioned in #9 are not requirements. The requirements are listed here: https://make.wordpress.org/themes/handbook/review/required/

Please message me on the theme review slack channel (https://make.wordpress.org/chat/) so that I can give you an introduction on how to do a full review.

#14 @ketuchetan
8 months ago

Hi @poena,

I am reviewing the theme again as per the guideline of https://make.wordpress.org/themes/handbook/review/required/

#15 @ketuchetan
8 months ago

Hi @awethemes,

I found some more issue into your theme. Plese, correct below the changes.

  • FILE: buzzo\inc\extras.php
    • Line: 329 ERROR Overriding WordPress globals is prohibited
  • several empty files please remove below file which are not used into the theme.
    • wp-content/themes/buzzo/inc/meta-boxes
      • class-buzzo-page-meta-box.php
      • class-buzzo-post-meta-box.php
      • class-buzzo-sidebar-meta-box.php
      • meta-boxes.php
  • FILE inc/customizer.php
    • required to use the WordPress functions for the custom logo instead of $wp_customize->add_control( new WP_Customize_Image_Control( $wp_customize, 'buzzo_logo', array(
  • We are not allowed the twitter functionality on the theme
    • /awe-recent-tweets-widget/tweet.php
  • inc/extras.php
    • function buzzo_awe_user_social_fields( $fields ) this is plugin territory and not allowed in themes

Thanks,

#16 @awethemes
8 months ago

Hi @ketuchetan

Thank for this review. We're going to fix all issues as soon as possible.

Best,
AweThemes

#17 @djrmom
7 months ago

@awethemes,

Our requirement is "If you are a theme shop you should be selling under GPL to be in the WordPress.org repo" https://make.wordpress.org/themes/handbook/review/required/#selling-credits-and-links, also see https://make.wordpress.org/themes/2015/08/15/themes-should-be-100-gpl/ for a more detailed explanation.

You are promoting your split licensed Themeforest products on your website, you need to be selling under the 100% GPL compatible license option in order to be approved.

Thanks.

#18 @awethemes
7 months ago

Hi @djrmom,

Thanks, we will update again and re-submit soon.

Thanks.

#19 @themetracbot
7 months ago

  • Summary changed from THEME: Buzzo – 1.0.2 to THEME: Buzzo – 1.0.3

Buzzo - 1.0.3

Buzzo is a simple, responsive, gorgeous theme that will put your content without distraction. The theme does offer visual appeal by including large enticing featured images and bold headlines, which make it easy for your readers to browse lots of material.

Theme URL - http://awethemes.com/docs/buzzo
Author URL - http://awethemes.com

Trac Browser - https://themes.trac.wordpress.org/browser/buzzo/1.0.3

SVN - https://themes.svn.wordpress.org/buzzo/1.0.3
ZIP - https://wordpress.org/themes/download/buzzo.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=buzzo/1.0.2&new_path=buzzo/1.0.3

History:

Ticket Summary Status Resolution Owner
#40841 THEME: Buzzo – 1.0.3 closed not-approved Rohittm

(this ticket)

#44239 THEME: Buzzo – 1.0.9 closed live codexdemon
#49170 THEME: Buzzo – 1.0.10 closed live themetracbot


https://themes.svn.wordpress.org/buzzo/1.0.3/screenshot.png

#20 @awethemes
7 months ago

Hi Reviewer Team,

We're ready to resubmit theme. It was fixed above changes which mentioned by @ketuchetan @djrmom
Looking forward to hear from you guys.

Best
AweThemes.

#21 @rabmalin
7 months ago

@ketuchetan Have you checked the update?

#22 @djrmom
7 months ago

@awethemes, I am still seeing your themeforest themes being sold under the split license not 100% GPL.

#23 @awethemes
7 months ago

Hi @djrmom,

Could you please explain more about "the split license not 100% GPL" ? Absolutely i don't fully understand about that.

Thanks

#24 @awethemes
7 months ago

Hi @djrmom

Can we remove all themeforest URL on our website http://awethemes.com/ to solve this problem?

Thanks.

#25 @djrmom
7 months ago

@awethemes if you separate your website from your themeforest business so that you are not directly or indirectly promoting those themes or your profile, that is acceptable. Thanks.

#26 @joedolson
7 months ago

Just noting that this theme is marked as accessibility-ready; please don't approve the theme until I've had a chance to audit it for accessibility. Thanks!

#27 @awethemes
7 months ago

Hi @djrmom, @joedolson

We removed all themeforest URL on our website. Please check again Buzzo 1.0.3 version.

Thanks.

#28 @djrmom
7 months ago

Thanks @awethemes.

@ketuchetan, please review the latest version. Thanks.

#29 @djrmom
6 months ago

  • Owner ketuchetan deleted

I am sorry this review is taking so long. I am going to add this to the new queue again as a priority. Thanks for your patience.

If you are the reviewer and able to do this review, please carry on and request you get added back in Slack #themereview or you can take on another review when you have time again.

#30 @themetracbot
6 months ago

  • Owner set to Rohittm

#31 @Rohittm
6 months ago

@awethemes ,

Hi I will be reviewing the themes and will give the detailed review within couple of days.

Thank you :)

#32 @Rohittm
6 months ago

Hey @awethemes ,

Till now, I have reviewed the theme and would like to tell these changes to be done:

Required:

  1. Don’t comment the code. Either give an option to enable/disable, or just remove it. User isn’t supposed to touch the code. in

i)functions.php line: 215,217 ,
ii)social.php line: 46-63

  1. Use a text-domain. in footer.php line: 23
  1. Found usage of constant "HEADER_TEXTCOLOR". Use add_theme_support( 'custom-header' ) instead. in buzzo/inc/custom-header.php line: 61
  1. If you have added support for post format, each format should look different.
  1. Your $GLOBALS/['content_width'/] should match the content area size being 616px fixed in theme’s post. in functions.php line: 115

Recommended:

  1. Don’t need to register scripts/styles. Enqueue directly.
  1. Move buzzo_custom_header_setup to functions.php
  1. Instead of using customizer control for social icon, use Social Menu.
  1. Use ellipses instead of ‘…’ in template-tags.php line: 228
  1. It is not recommended to use custom widgets but post widgets can be used. Seems fine.

I'll be posting more of it. Thank you

Last edited 6 months ago by Rohittm (previous) (diff)

#33 @Rohittm
6 months ago

@sanyog @rabmalin Please check if its alright?

#34 @Rohittm
6 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

It has been a more than a week, so as per the TRT guidelines, I am closing the ticket. You can re-submit the theme whenever you want.

@awethemes
6 months ago

#35 @awethemes
6 months ago

Hi @Rohittm, I just re-submit theme, pls check the new ticket at:
https://themes.trac.wordpress.org/ticket/44239

Note: See TracTickets for help on using tickets.