WordPress.org

Make WordPress Themes

Opened 2 months ago

Closed 5 weeks ago

#40977 closed theme (not-approved)

THEME: wpmyshop – 1.0.4

Reported by: milindpd Owned by: rinkuyadav999
Priority: previously reviewed Keywords: theme-wpmyshop
Cc: milind.p.deshpande@…

Description

wpmyshop - 1.0.3

Simple Word Press Theme for Small Business.

Theme URL -
Author URL -

Trac Browser - https://themes.trac.wordpress.org/browser/wpmyshop/1.0.3

SVN - https://themes.svn.wordpress.org/wpmyshop/1.0.3
ZIP - https://wordpress.org/themes/download/wpmyshop.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=wpmyshop/1.0.1&new_path=wpmyshop/1.0.3

History:

Ticket Summary Status Resolution Owner
#40340 THEME: wpmyshop – 1.0.1 closed not-approved acosmin
#40977 THEME: wpmyshop – 1.0.4 closed not-approved rinkuyadav999

(this ticket)


https://themes.svn.wordpress.org/wpmyshop/1.0.3/screenshot.png
Theme Check Results:

  • RECOMMENDED: Theme URI: is missing from your style.css header.
  • RECOMMENDED: Author URI: is missing from your style.css header.

Change History (5)

#1 @themetracbot
2 months ago

  • Summary changed from THEME: wpmyshop – 1.0.3 to THEME: wpmyshop – 1.0.4

wpmyshop - 1.0.4

Simple Word Press Theme for Small Business.

Theme URL -
Author URL -

Trac Browser - https://themes.trac.wordpress.org/browser/wpmyshop/1.0.4

SVN - https://themes.svn.wordpress.org/wpmyshop/1.0.4
ZIP - https://wordpress.org/themes/download/wpmyshop.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=wpmyshop/1.0.3&new_path=wpmyshop/1.0.4

History:

Ticket Summary Status Resolution Owner
#40340 THEME: wpmyshop – 1.0.1 closed not-approved acosmin
#40977 THEME: wpmyshop – 1.0.4 closed not-approved rinkuyadav999

(this ticket)


https://themes.svn.wordpress.org/wpmyshop/1.0.4/screenshot.png
Theme Check Results:

  • RECOMMENDED: Theme URI: is missing from your style.css header.
  • RECOMMENDED: Author URI: is missing from your style.css header.

#2 @joyously
6 weeks ago

  • The menu needs to have a fallback for when no menu is selected. Remove the if statement around it.
  • The submenus do not have a background color, so it is difficult to read text overlapping other text.
  • On a desktop screen, the submenu of the first menu item (left) is cut off. I know TwentySixteen had this issue and I fixed it for TwentySeventeen, but I don't remember right now how the fix works. You can look at the GitHub repository for it if you can't figure it out.
  • The special character on the menu (arrows?) do not display correctly. Also for pagination links.
  • The post meta is narrow (21%) and the font size is larger than the post's, so the words are broken to fit, making it difficult to read and taking a lot of vertical space.
  • There are quite a few things that are way too small (comment meta, comment Reply link, Paged comments link, author bio, image captions, page links, Previous/Next Image links).
  • Formatting:
    • list markers are further left than any other text (actually outside the <article> container)
    • <q> tag is unstyled (default removed)
  • If you put theme tags in readme.txt, make sure they match the real ones in style.css.
  • It looks like the code for the footer sidebar was copied and then not called.
  • Required to use core-bundled scripts rather than including their own version of that script, for example jQuery.
  • In Customizer, the colors don't have default values. The Header Text color option does not work.
  • I don't think I can make this theme look like the screenshot.
  • I think the theme description was copied from somewhere else, because it does not match this theme.

#3 @kevinhaig
5 weeks ago

Note to Author

  1. The above preview by @joyously is not an official review. You must still wait to get to the top of the review queue before an official review will begin.
  1. Many of the concerns above relate to results from Theme Unit Test and you should always test your theme with that package. However please note that many of the comments are considered recommended. Recommended comments DO NOT have to be addressed for theme approval. In many cases it is good advice, but the decision to address those issues is yours.
  1. There may be some comment items that are required. Requires items must be addressed or the theme will not be approved. Please visit https://make.wordpress.org/themes/handbook/review/required/ to double check required items. Note that when an official review starts your theme may be closed if 5 or more distinct requirements are not met.
  1. If you are in doubt of a comment, or do not want to address something please ask for a confirmation in the ticket, or on the open Slack channel.

#4 @rinkuyadav999
5 weeks ago

  • Owner set to rinkuyadav999
  • Status changed from new to reviewing

Hi @milindpd

I will review your theme.

Thanks

#5 @rinkuyadav999
5 weeks ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hi

Your theme have more than 4 required issues so i am setting as not-approved.

Required

WordPress Spelling
Please write 'WordPress' instead 'Word Press' in theme description.
Spell 'WordPress' correctly in all public facing text: all one word, with both an uppercase W and P. No Space.

Theme Tags
Your theme does not support flexible-header so please remove this tag from style.css or make sure your theme support it.
Your theme does not display content in one-column so remove this tag. as i can see your theme display content in two column so you can replace one-column with two-column.

License
Please declare license properly in readme file. you can take help of core WordPress themes like 'twentysixteen'.

Also add license of all files. you did not add license for 'small-business.css', 'img3.jpg' ETC.

Also do not add license if you did not bundle files like 'Font Awesome'. I did not find Font Awesome files but you added license for it.

Also remove file 'LICENSE' because you pointed link of license file in style.css http://www.gnu.org/licenses/gpl-2.0.html

Enqueue Script / Style
wp_enqueue_style handler should be name of third party file like 'bootstrap' instead 'wpmyshop'.
wp_enqueue_style handler should be different for different css files.
You do not need to enqueue both minified and non-minified version.
You can not add and enqueue jquery file instead use from core WordPress.
Handler of html5.js will be 'html5' instead 'wpmyshop-html5'.

Prefix
Please use Theme Slug / Unique String to prefix functions. Function 'category_id_class' did not prefixed.

Theme Options
Setting 'Display Site Title and Tagline', 'Header Text Color' do not work.

You can use esc_url_e function instead

echo esc_url( __(.....

in footer.php

Icons do not display in menu, footer ETC.

add_theme_support 'post-formats' declared two times in functions.php.

Where you used template-parts/footer/footer-widgets.php file. Also it called 'sidebar-3' but did not registered. If you have not used this file, you can delete it. Also delete all not used and extra files like 'LICENSE', 'README.md'

Please fix all require issues and upload theme again. Make sure your theme follow theme requirements https://make.wordpress.org/themes/handbook/review/required/ .

Thanks

Note: See TracTickets for help on using tickets.