WordPress.org

Make WordPress Themes

Opened 4 months ago

Closed 3 months ago

#40989 closed theme (not-approved)

THEME: Molecule – 2.0

Reported by: batgeek Owned by: poena
Priority: new theme Keywords: theme-molecule accessibility-ready
Cc: jasondaledavis@…

Description

Molecule - 2.0

Molecule is a diverse theme for whatever you imagine. Molecule is fully compatible with popular plugins like WooCommerce, Gravity Forms, Contact Form 7, Jetpack, and others. The content area powers the entire sites main page area, so make it look how you want. the header and footer are customizable from the WordPress customizer for backgrounds and color options. There are 4 widget areas in the footer, and a separate page and blog sidebar. Sidebars are only activate once a widget is dragged in place and page and blog sidebar is only on the right side column. A page builder is recommended like SiteOrigin or Visual Composer to create a beautiful layout like the demo.

Theme URL - https://molecule.element502.com
Author URL - https://nerdbrand.me

Trac Browser - https://themes.trac.wordpress.org/browser/molecule/2.0

SVN - https://themes.svn.wordpress.org/molecule/2.0
ZIP - https://wordpress.org/themes/download/molecule.2.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#40989 THEME: Molecule – 2.0 closed not-approved poena

(this ticket)


https://themes.svn.wordpress.org/molecule/2.0/screenshot.png

Change History (2)

#1 @poena
3 months ago

  • Keywords changed from theme-molecule, accessibility-ready to theme-molecule accessibility-ready
  • Owner set to poena
  • Status changed from new to reviewing

#2 @poena
3 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hi
Thank you for submitting your theme.
Your theme has been partially reviewed against these requirements:
https://make.wordpress.org/themes/handbook/review/required/

As part of the new theme directory guidelines, reviewers may now close tickets if a theme has 5 or more issues.
This is part of our long term goals to improve the theme quality and shorten the queues.
You can read more about this change here: https://make.wordpress.org/themes.

Please do not get discouraged by the ticket being closed. A closed ticket is not the end.
-We want you to resubmit your theme, but we do ask that you spend more time making sure that your theme meets all the requirements.
https://make.wordpress.org/themes/handbook/review/required/
You can upload your update here: https://wordpress.org/themes/upload/
-Because of the large number of themes waiting for review, we might not be able to follow up immediately.

If you have questions you can ask them here or in the #themereview channel on Slack
channel.

Required:

Theme URI is a 404.

No minification of scripts or files unless you provide original files.

All untrusted data should be escaped before output
All instances of home_url() needs to be escaped with esc_url().

License and attribution
Missing attribution for Twenty Sixteen.
Missing license information for images used in screenshot.png.

add_image_size names need to be prefixed.

All theme text strings are to be translatable.
There is text in the theme that is missing translation functions, like the sidebar names.

In customizer.php, it says:

 //=============================================================
 // Remove Colors, Background image, and Static front page 
 // option from theme customizer     
 //=============================================================
 $wp_customize->remove_section("colors");

This is not correct, -and themes shouldn't add support for features only to remove them...

In template-tags.php, please do not overwrite user settings by changing the alt attribute.
the_post_thumbnail( 'post-thumbnail', array( 'alt' => the_title_attribute( 'echo=0' ) ) );

Meta boxes may only be used for design related options, not to add content, because this content is lost when the user switches themes.

I could not get the theme to look like the screenshot, for example, there are no instructions or options that helps me set up the "subscribe" and "service" sections showing on the screenshot?

Please remove any and all files that are not used by the theme like .ai, .psd, and the favicon.

The theme also does not pass the accessibility-ready review. Please increase the color contrast.

Recommended:
Is the theme specifically designed to use "duplicate post" plugin? svg support?
I would suggest only recommending plugins that the theme will use, since some users might
not understand that these are entirely optional and that the theme does not depend on them.


Recommended reading:

https://wordpress.tv/2015/03/13/tammie-lister-theme-dont-be-my-everything/

https://make.wordpress.org/themes/handbook/review/required/
https://make.wordpress.org/themes/handbook/review/resources/
https://developer.wordpress.org/themes/

https://developer.wordpress.org/themes/functionality/internationalization/
https://codex.wordpress.org/Validating_Sanitizing_and_Escaping_User_Data
https://make.wordpress.org/themes/2014/07/08/proper-copyrightlicense-attribution-for-themes/

The coding standards are not required to pass the review, but they can be helpful when developing your theme.
https://make.wordpress.org/core/handbook/best-practices/coding-standards/

The code reference library is very useful when you want to know more about WordPress functions, classes, hooks and methods.
It can help you determine if a function needs to be escaped or not, or if a function you have planned to write is already available.
https://developer.wordpress.org/reference/

Note: See TracTickets for help on using tickets.