WordPress.org

Make WordPress Themes

Opened 7 months ago

Closed 5 months ago

Last modified 5 months ago

#41026 closed theme (live)

THEME: Juliet – 1.2.1

Reported by: lyrathemes Owned by: benlumia007
Priority: previously reviewed Keywords: theme-juliet
Cc: webmaster@…

Description

Juliet - 1.1

Juliet is a simple, elegant, feminine lifestyle blogging WordPress theme.

Theme URL - https://www.lyrathemes.com/juliet/
Author URL - https://www.lyrathemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/juliet/1.1

SVN - https://themes.svn.wordpress.org/juliet/1.1
ZIP - https://wordpress.org/themes/download/juliet.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=juliet/1.0&new_path=juliet/1.1

History:

Ticket Summary Status Resolution Owner
#35507 THEME: Juliet – 1.0 closed not-approved acosmin
#41026 THEME: Juliet – 1.2.1 closed live benlumia007

(this ticket)

#42852 THEME: Juliet – 1.2.2 closed live themetracbot
#42987 THEME: Juliet – 1.2.3 closed live themetracbot
#43008 THEME: Juliet – 1.2.4 closed live themetracbot
#43305 THEME: Juliet – 1.3 closed live themetracbot
#43653 THEME: Juliet – 1.3.1 closed live themetracbot


https://themes.svn.wordpress.org/juliet/1.1/screenshot.png
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are juliet, kirki
  • WARNING: "Juliet" currently has 1,000+ active installations. Please check for name collisions outside of WordPress.org before approval.

Change History (19)

#1 @joyously
6 months ago

  • zip file is 4.7Meg! That's half of WordPress. Reduce this by removing the images used for posts that don't have images. Themes cannot supply content.
  • Theme or author name/brand should not be output on front end except as allowed in a single credit link.
  • Use the user's site title, not the theme name.
  • Any copyright statements on the front end should display the user's copyright, not the theme author's copyright.
  • Remove theme name overlay from sticky post.
  • So much tiny text. Is it feminine to squint? 8px for image captions. Really? My eyes are tired just looking at this.
  • The fallback menu is not styled like a custom menu.
  • Page links (generated by <!--nextpage-->) are not being output on Posts or Pages.
  • Search results should not show the author and date of static Pages.
  • Tables look all smashed together. (see calendar widget also)
  • Floats are not being cleared properly after the content area.
  • Pingbacks and trackbacks should be shown.
  • Comments should be shown even if comments are closed.
  • The 404 page is not at all helpful.

#2 @benlumia007
6 months ago

Note to Author

  1. The above preview by @joyously is not an official review. It is best to wait for theme ticket to get to the top of the review queue before an official review will begin.
  1. Many of the concerns above relate to results from Theme Unit Test and you should always test your theme with that package. However please note that many of the comments are considered recommended.
  1. Recommended comments DO NOT have to be addressed for theme approval. In many cases it is good advice, but the decision to address those issues is yours.
  1. There may be some comment items that are required. Requires items must be addressed or the theme will not be approved. Please visit https://make.wordpress.org/themes/handbook/review/required/ to double check required items. Note that when an official review starts your theme may be closed if 5 or more distinct requirements are not met.
  1. If you are in doubt of a comment, or do not want to address something please ask for a confirmation in the ticket, or on the open Slack channel.

#3 @lyrathemes
6 months ago

@benlumia007 Thanks so much for dropping in :) I have made note of joyously's comments and will be making an update soon.

#4 @benlumia007
6 months ago

  • Owner set to benlumia007
  • Status changed from new to reviewing

#5 @benlumia007
6 months ago

@lyrathemes
I will wait till Monday so that you have at least couple of days to finalize your theme and I will review on Tuesday.

@benlumia007

#6 @lyrathemes
6 months ago

@benlumia007 Thanks so much! I'll be in touch.

#7 @themetracbot
6 months ago

  • Summary changed from THEME: Juliet – 1.1 to THEME: Juliet – 1.2

Juliet - 1.2

Juliet is a simple, elegant, lifestyle blogging WordPress theme. It includes two skins: a classic feminine look, and a more contemporary minimalist look. Juliet comes with basic WooCommerce integration and a special front page layout with a banner and featured posts. Multiple widget areas allow you set up your website your way! It also comes with built-in menus for displaying your social media presence, multiple blog feed layouts, text and image logo options, banner color overlay options, and much more! Beautifully designed and extremely clean and light weight, Juliet is backed by world class, one-on-one support, and a super active team of developers and designers ready to help!

Theme URL - https://www.lyrathemes.com/juliet/
Author URL - https://www.lyrathemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/juliet/1.2

SVN - https://themes.svn.wordpress.org/juliet/1.2
ZIP - https://wordpress.org/themes/download/juliet.1.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=juliet/1.1&new_path=juliet/1.2

History:

Ticket Summary Status Resolution Owner
#35507 THEME: Juliet – 1.0 closed not-approved acosmin
#41026 THEME: Juliet – 1.2.1 closed live benlumia007

(this ticket)

#42852 THEME: Juliet – 1.2.2 closed live themetracbot
#42987 THEME: Juliet – 1.2.3 closed live themetracbot
#43008 THEME: Juliet – 1.2.4 closed live themetracbot
#43305 THEME: Juliet – 1.3 closed live themetracbot
#43653 THEME: Juliet – 1.3.1 closed live themetracbot


https://themes.svn.wordpress.org/juliet/1.2/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Tags: is either empty or missing in style.css header.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are juliet, kirki

#8 @lyrathemes
6 months ago

@benlumia007 Hope you had a great weekend. I have uploaded the latest version here just now. Looking forward to hearing from you soon :) Thanks for your time.

#9 @benlumia007
6 months ago

@lyrathemes
I'm going to finished up a theme review before yours. So I will get yours tomorrow.

Thanks
@benlumia007

#10 @benlumia007
6 months ago

@lyrathemes
Finally got internet at home so I'll be doing the actual review today or tomorrow. Sorry about that.

@benlumia007

#11 @benlumia007
6 months ago

404.php
<h1 class="entry-title">404</h1> needs to be translated

functions.php
removing core settings is not allowed.
$wp_customize->remove_control('header_textcolor');

Note: Errors need to be fixed and Warnings are things that need to be checked manually.

FILE: /srv/www/themereview/public_html/wp-content/themes/juliet/parts/entry.php
--------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
 60 | ERROR | Missing singular placeholder, needed for some languages. See
    |       | https://codex.wordpress.org/I18n_for_WordPress_Developers#Plurals
--------------------------------------------------------------------------------------------------------------


FILE: /srv/www/themereview/public_html/wp-content/themes/juliet/parts/frontpage-featured.php
--------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------------------------
 26 | ERROR | Overriding WordPress globals is prohibited
 38 | ERROR | Overriding WordPress globals is prohibited
 50 | ERROR | Overriding WordPress globals is prohibited
 62 | ERROR | Overriding WordPress globals is prohibited
--------------------------------------------------------------------------------------------

Time: 24894473 mins, 36.4 secs; Memory: 226.01Mb

#12 @benlumia007
5 months ago

@lyrathemes
I will keep this ticket open for the next 7 days. Please fixed all issues before submitting a new version of the theme.

Thanks
@benlumia007

#13 @lyrathemes
5 months ago

Thanks @benlumia007 I will try to get an update to you by tonight. Sorry for the delay on this!!

#14 @themetracbot
5 months ago

  • Summary changed from THEME: Juliet – 1.2 to THEME: Juliet – 1.2.1

Juliet - 1.2.1

Juliet is a simple, elegant, lifestyle blogging WordPress theme. It includes two skins: a classic feminine look, and a more contemporary minimalist look. Juliet comes with basic WooCommerce integration and a special front page layout with a banner and featured posts. Multiple widget areas allow you set up your website your way! It also comes with built-in menus for displaying your social media presence, multiple blog feed layouts, text and image logo options, banner color overlay options, and much more! Beautifully designed and extremely clean and light weight, Juliet is backed by world class, one-on-one support, and a super active team of developers and designers ready to help!

Theme URL - https://www.lyrathemes.com/juliet/
Author URL - https://www.lyrathemes.com/

Trac Browser - https://themes.trac.wordpress.org/browser/juliet/1.2.1

SVN - https://themes.svn.wordpress.org/juliet/1.2.1
ZIP - https://wordpress.org/themes/download/juliet.1.2.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=juliet/1.2&new_path=juliet/1.2.1

History:

Ticket Summary Status Resolution Owner
#35507 THEME: Juliet – 1.0 closed not-approved acosmin
#41026 THEME: Juliet – 1.2.1 closed live benlumia007

(this ticket)

#42852 THEME: Juliet – 1.2.2 closed live themetracbot
#42987 THEME: Juliet – 1.2.3 closed live themetracbot
#43008 THEME: Juliet – 1.2.4 closed live themetracbot
#43305 THEME: Juliet – 1.3 closed live themetracbot
#43653 THEME: Juliet – 1.3.1 closed live themetracbot


https://themes.svn.wordpress.org/juliet/1.2.1/screenshot.jpg
Theme Check Results:

  • RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • RECOMMENDED: Tags: is either empty or missing in style.css header.
  • Warning: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are juliet, kirki

#15 @lyrathemes
5 months ago

I am unsure about this one - can you please point out what needs to change here?

Missing singular placeholder, needed for some languages. See https://codex.wordpress.org/I18n_for_WordPress_Developers#Plurals

I've made the rest of the changes.

Thanks for your time, much appreciated!

#16 @benlumia007
5 months ago

@lyrathemes

Sorry, just became very busy this week due a major project, I will continue the review on Friday, is that ok with you.

Thanks
@benlumia007

#17 @lyrathemes
5 months ago

No worries Ben, I'll wait for your feedback :)

#18 @benlumia007
5 months ago

  • Resolution set to live
  • Status changed from reviewing to closed

@lyrathemes

I have not found any issues so I'm marking theme live as of today!

Thanks
@benlumia007

#19 @lyrathemes
5 months ago

Woohoo thanks so much for your time on this :D

Note: See TracTickets for help on using tickets.